Re: WMM vs QoS

2016-03-29 Thread Steven Pease
As a test, I attempted to hardcode mac80211 to hardcode a priority of 6 or 7. I tried several places, but the most correct seemed to be cfg80211_classify8021d. Despite this I noticed no change in behavior. I also looked for a place in the ath9k driver, but it looked like it pretty much just handed

Re: [PATCH 1/9] ath10k: speedup htt rx descriptor processing for tx completion

2016-03-29 Thread Valo, Kalle
"Manoharan, Rajkumar" writes: >>> @@ -1712,7 +1710,20 @@ static void ath10k_htt_rx_frm_tx_compl(struct ath10k >>> *ar, >>> for (i = 0; i < resp->data_tx_completion.num_msdus; i++) { >>> msdu_id = resp->data_tx_completion.msdus[i]; >>> tx_done.msdu_id = __le16_to

Re: [RFC] ath10k: implement dql for htt tx

2016-03-29 Thread Michal Kazior
On 26 March 2016 at 17:44, Dave Taht wrote: > Dear Michal: [...] > I am running behind on this patch set, but a couple quick comments. [...] >> - no rrul tests, sorry Dave! :) > > rrul would be a good baseline to have, but no need to waste your time > on running it every time as yet. It stresses

Re: [PATCH] mac80211: allow same PN for AMSDU sub-frames

2016-03-29 Thread Johannes Berg
On Wed, 2016-03-09 at 11:29 +0200, Emmanuel Grumbach wrote: > From: Sara Sharon > > Some hardware (iwlwifi an example) de-aggregate AMSDUs and > copy the IV as is to the generated MPDUs, so the same PN > appears in multiple packets without being a replay attack. > Do not increment the PN until al

Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

2016-03-29 Thread Kalle Valo
Wei-Ning Huang writes: > "single skb allocation failure" happens when system is under heavy > memory pressure. Add __GFP_REPEAT to skb allocation call so kernel > attempts to reclaim pages and retry the allocation. > > Signed-off-by: Wei-Ning Huang Is this really a proper way to fix the issue?

Re: [V11,2/2] brcmfmac: add support for nl80211 BSS_SELECT feature

2016-03-29 Thread Arend Van Spriel
+ linux-wireless, Johannes On 26-3-2016 11:28, Kalle Valo wrote: > Arend van Spriel writes: > >> This brcmfmac patch [1] is set to "Awaiting Upstream" as it relies on >> nl80211 patch. However, that patch was already in linux-next before the >> merge window so are you waiting for 4.6-rc1 or did

[PATCH v3 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-03-29 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Enable support for 'drv_sta_statistics' callback. Export rx_duration support if available to cfg80211/nl80211 This can also act as a placeholder for any new per STA stats support Signed-off-by: Mohammed Shafi Shajakhan --- [v3] removed conditions for ath10k state

[PATCH v3 2/2] ath10k: Remove debugfs support for Per STA total rx duration

2016-03-29 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan cfg80211/nl80211 interface changes for per STA total rx-duration and very basic 'ath10k_sta_statistics' mac80211 callback is implemented to extend support for per station statistics from the driver. Also provision in 'iw dev wlan#N station dump' to parse rx-durati

Re: [PATCH v3 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-03-29 Thread kbuild test robot
Hi Mohammed, [auto build test ERROR on ath6kl/ath-next] [also build test ERROR on v4.6-rc1 next-20160329] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Mohammed-Shafi-Shajakhan/ath10k-Add

Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

2016-03-29 Thread Wei-Ning Huang
Adding some chromium devs to the thread. In, http://lxr.free-electrons.com/source/mm/page_alloc.c#L3152 The default mm retry allocation when 'order <= PAGE_ALLOC_COSTLY_ORDER' of gfp_mask contains __GFP_REPEAT. PAGE_ALLOC_COSTLY_ORDER is defined to be 3. On systems with page size = 4K, this means

[PATCHv3 RESEND 11/11] cfg80211: allow to tie the NAN instance to the owner

2016-03-29 Thread Emmanuel Grumbach
Allow the user space application that starts NAN to forbid any other socket to add or remove functions. Notifications will be sent to the socket that started the NAN interface only. By default, keep the current behavior: events are sent in multicast and any application can add / remove functions.

[PATCHv3 RESEND 04/11] cfg80211: allow the user space to change current NAN configuration

2016-03-29 Thread Emmanuel Grumbach
Some NAN configuration paramaters may change during the operation of the NaN device. For example, a user may want to update master preference value when the device gets plugged/unplugged to the power. Add API that allows to do so. Signed-off-by: Andrei Otcheretianski Signed-off-by: Emmanuel Grumb

[PATCHv3 RESEND 05/11] cfg80211: provide a function to report a match for NAN

2016-03-29 Thread Emmanuel Grumbach
Provide a function the driver can call to report a match. This will send the event to the user space. Signed-off-by: Andrei Otcheretianski Signed-off-by: Emmanuel Grumbach --- include/net/cfg80211.h | 37 ++ include/uapi/linux/nl80211.h | 38 +++

[PATCHv3 RESEND 03/11] cfg80211: add add_nan_func / rm_nan_func

2016-03-29 Thread Emmanuel Grumbach
A NAN function can be either publish, subscribe or follow up. Make all the necessary verifications and just pass the request to the driver. Signed-off-by: Andrei Otcheretianski Signed-off-by: Emmanuel Grumbach --- include/net/cfg80211.h | 79 +++ include/uapi/linux/nl80211.h | 15

[PATCHv3 RESEND 02/11] mac80211: add boilerplate code for start / stop NAN

2016-03-29 Thread Emmanuel Grumbach
This codes doens't do much besides allowing to start and stop the vif. Signed-off-by: Andrei Otcheretianski Signed-off-by: Emmanuel Grumbach --- include/net/mac80211.h| 9 + net/mac80211/cfg.c| 35 + net/mac80211/chan.c | 3 +++ net/ma

[PATCHv3 RESEND 01/11] cfg80211: add start / stop NAN commands

2016-03-29 Thread Emmanuel Grumbach
This allows user space to start/stop NAN interface. A NAN interface is like P2P device in a few aspects: it doesn't have a netdev associated to it. Add the new interface type and prevent operations that can't be executed on NAN interface like scan. Define several attributes that may be configured b

[PATCHv3 RESEND 07/11] cfg80211: add utility functions to clone and free nan_func

2016-03-29 Thread Emmanuel Grumbach
From: Andrei Otcheretianski Add cfg80211_free_nan_func and cfg80211_clone_nan_func. These helper functions will be used by mac80211 in the next patch. Signed-off-by: Andrei Otcheretianski Signed-off-by: Emmanuel Grumbach --- include/net/cfg80211.h | 21 ++ net/wireless/util.c| 11

[PATCHv3 RESEND 06/11] cfg80211: Provide an API to report NAN function termination

2016-03-29 Thread Emmanuel Grumbach
From: Andrei Otcheretianski Provide a function that reports NAN DE function termination. The function may be terminated due to one of the following reasons: user request, ttl expiration or failure. Signed-off-by: Andrei Otcheretianski Signed-off-by: Emmanuel Grumbach --- include/net/cfg80211.

[PATCHv3 RESEND 09/11] mac80211: Implement add_nan_func and rm_nan_func

2016-03-29 Thread Emmanuel Grumbach
From: Andrei Otcheretianski Implement add/rm_nan_func functions and handle nan function termination notifications. Handle instance_id allocation for nan functions and implement the reconfig flow. Signed-off-by: Andrei Otcheretianski Signed-off-by: Emmanuel Grumbach --- include/net/mac80211.h

[PATCHv3 RESEND 08/11] mac80211: implement nan_change_conf

2016-03-29 Thread Emmanuel Grumbach
From: Andrei Otcheretianski Implement nan_change_conf callback which allows to change current nan configuration (master preference and dual band operation). Store the current nan configuration in sdata, so it can be used both to provide the driver the updated configuration with changes and also i

[PATCHv3 RESEND 10/11] mac80211: Add API to report nan function match

2016-03-29 Thread Emmanuel Grumbach
From: Andrei Otcheretianski Provide an API to report nan function match. Mac80211 will lookup the corresponding cookie and report the match to cfg80211. Signed-off-by: Andrei Otcheretianski Signed-off-by: Emmanuel Grumbach --- include/net/mac80211.h | 14 ++ net/mac80211/cfg.c

RE: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

2016-03-29 Thread Amitkumar Karwar
> From: Wei-Ning Huang [mailto:wnhu...@google.com] > Sent: Tuesday, March 29, 2016 2:57 PM > To: Kalle Valo > Cc: Linux Wireless; LKML; Amitkumar Karwar; Nishant Sarmukadam; Sameer > Nanda; net...@vger.kernel.org; Sonny Rao; Douglas Anderson > Subject: Re: [PATCH] mwifiex: add __GFP_REPEAT to skb a

[PATCH 2/2] cfg80211: Allow reassociation to be requested with internal SME

2016-03-29 Thread Jouni Malinen
If the user space issues a NL80211_CMD_CONNECT with NL80211_ATTR_PREV_BSSID when there is already a connection, allow this to proceed as a reassociation instead of rejecting the new connect command with EALREADY. Signed-off-by: Jouni Malinen --- net/wireless/nl80211.c | 3 ++- net/wireless/sme.

[PATCH 1/2] cfg80211: Add option to specify previous BSSID for Connect command

2016-03-29 Thread Jouni Malinen
This extends NL80211_CMD_CONNECT to allow the NL80211_ATTR_PREV_BSSID attribute to be used similarly to way this was already allowed with NL80211_CMD_ASSOCIATE. This allows user space to request reassociation (instead of association) when already connected to an AP. This provides an option to reass

Re: [PATCH] mwifiex: advertise low priority scan feature

2016-03-29 Thread Wei-Ning Huang
I've resent the patch here: https://patchwork.kernel.org/patch/8637861/ Thanks! Wei-Ning On Tue, Mar 22, 2016 at 12:12 PM, Wei-Ning Huang wrote: > Hi Kalle, > > Thanks for the review. I accidentally removed the s-o-b line from > akarwar in this version. > The original patch can be found at: > ht

Wireless Encryption

2016-03-29 Thread Aswin Paranji
Hi, I'm trying to encrypt the 802.11 data with my own encryption instead of WEP or WPA. Can anybody guide me on how to do that and where I need to change. I'm trying to do this with Raspberry PI 3 device. Appreciate if you can guide me. Regards, Aswin -- To unsubscribe from this list: send the li

Re: Wireless Encryption

2016-03-29 Thread Arend Van Spriel
On 29-3-2016 13:09, Aswin Paranji wrote: > Hi, > I'm trying to encrypt the 802.11 data with my own encryption instead > of WEP or WPA. Can anybody guide me on how to do that and where I need > to change. I'm trying to do this with Raspberry PI 3 device. Umm. You mean you want to do it with the int

Re: Wireless Encryption

2016-03-29 Thread Aswin Paranji
Arend, Thanks for the response. What I'm trying to accomplish is to encrypt the 802.11 data packet that is sent to mac80211 as data frames and mac80211 sends it to the wifi driver. I took a look at this blog "https://www.linux.com/community/blogs/133-general-linux/816721-linux-wireless-networking-

Re: [PATCH 15/16] wcn36xx: don't pad beacons for mesh

2016-03-29 Thread Sergei Shtylyov
Hello. On 3/29/2016 9:06 AM, Bjorn Andersson wrote: From: Jason Mobarak Patch "wcn36xx: Pad TIM PVM if needed" has caused a regression in mesh scripts/checkpatch.pl now enforces the specific commit citing format, i.e. <12-digit SHA1> (""). beaconing. The field tim_off is always 0 fo

Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

2016-03-29 Thread Eric Dumazet
On Tue, 2016-03-29 at 17:27 +0800, Wei-Ning Huang wrote: > Adding some chromium devs to the thread. > > In, http://lxr.free-electrons.com/source/mm/page_alloc.c#L3152 > > The default mm retry allocation when 'order <= > PAGE_ALLOC_COSTLY_ORDER' of gfp_mask contains __GFP_REPEAT. > PAGE_ALLOC_COST

[PATCH] mmc: add API for data write using scatter gather DMA

2016-03-29 Thread Amitkumar Karwar
From: Bing Zhao This patch adds new API for SDIO scatter gather. Existing mmc_io_rw_extended() API expects caller to pass single contiguous buffer. It will be split if it exceeds segment size, SG table is prepared and used it for reading/writing the data. Our intention for defining new API here

Re: [PATCH] Staging: rtl8723au: Remove function rtw_enqueue_{recvbuf23a/recvbuf23a_to_head}

2016-03-29 Thread Jes Sorensen
Bhumika Goyal writes: > The functions rtw_enqueue_recvbuf23a and rtw_enqueue_recvbuf23a_to_head > are never used anywhere in the kernel. So, remove their definition and > prototype. > Grepped to find occurences. > > Signed-off-by: Bhumika Goyal > --- > drivers/staging/rtl8723au/core/rtw_recv.c

Re: [PATCH] Staging: rtl8723au: Remove unused functions

2016-03-29 Thread Jes Sorensen
Bhumika Goyal writes: > The functions rtw_get_oper_bw23a and rtw_get_oper_ch23aoffset are never > used anywhere in the kernel. So, remove their definition and prototype. > Grepped to find occurences. > > Signed-off-by: Bhumika Goyal > --- > drivers/staging/rtl8723au/core/rtw_wlan_util.c | 10 -

Re: [RFC] ath10k: implement dql for htt tx

2016-03-29 Thread Ben Greear
On 03/29/2016 12:49 AM, Michal Kazior wrote: if you are getting a pure codel result of 160ms, that means the implementation is broken. But I think (after having read your description twice), the baseline result today of 160ms of queuing was with a fq_codel *qdisc* doing the work on top of huge b

Re: Question on rhashtable in worst-case scenario.

2016-03-29 Thread Ben Greear
Looks like rhashtable has too much policy in it to properly deal with cases where there are too many hash collisions, so I am going to work on reverting it's use in mac80211. Thanks, Ben On 03/28/2016 01:29 PM, Ben Greear wrote: Hello! I have a use case for mac80211 where I create multiple sta

[PATCH] rtl8xxxu: fix uninitialized return value in ret

2016-03-29 Thread Colin King
From: Colin Ian King several functions are not initializing a return status in ret resulting in garbage to be returned instead of 0 for success. Currently, the calls to these functions are not checking the return, however, it seems prudent to return the correct status in case they are to be check

Re: [PATCH] rtl8xxxu: fix uninitialized return value in ret

2016-03-29 Thread Jes Sorensen
Colin King writes: > From: Colin Ian King > > several functions are not initializing a return status in ret > resulting in garbage to be returned instead of 0 for success. > Currently, the calls to these functions are not checking the > return, however, it seems prudent to return the correct stat

Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

2016-03-29 Thread kbuild test robot
Hi Pontus, [auto build test ERROR on wireless-drivers/master] [also build test ERROR on v4.6-rc1 next-20160329] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Bjorn-Andersson/Misc-wcn36xx

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-03-29 Thread Lukas Wunner
Dear bcma maintainers, I'm moving BCMA_CORE_SIZE from drivers/bcma/bcma_private.h to include/linux/bcma/bcma.h in the patch included below to be able to use it in drivers/pci/quirks.c. If you are okay with this change and have no other objections then please kindly ack the patch for merging via t

[PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-03-29 Thread Lukas Wunner
Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ storm on boot until they are reset, causing spurious interrupts if the IRQ is shared. Apparently the EFI bootloader enables the device and does not disable it before passing control to the OS. The bootloader contains a driver for the

Re: Bonjour mDNS broacast can be lost during BT-WLAN coexistence schemes?

2016-03-29 Thread Adrian Chadd
On 28 March 2016 at 21:22, sandeep suresh wrote: > Hello Adrian, > Thanks for your response. Currently with 2-wire coexistence, BT has > higher priority when compared to WiFi. You had shared the following > different bitfields that can be configured with different weights: > > WLAN:- > wait_

Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

2016-03-29 Thread Bjorn Andersson
On Tue 29 Mar 10:01 PDT 2016, kbuild test robot wrote: > Hi Pontus, > > [auto build test ERROR on wireless-drivers/master] > [also build test ERROR on v4.6-rc1 next-20160329] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving th

[RESEND PATCH 15/16] wcn36xx: don't pad beacons for mesh

2016-03-29 Thread Bjorn Andersson
From: Jason Mobarak Patch "wcn36xx: Pad TIM PVM if needed" has caused a regression in mesh beaconing. The field tim_off is always 0 for mesh mode, and thus pvm_len (referring to the TIM length field) and pad are both incorrectly calculated. Thus, msg_body.beacon_length is incorrectly calculated

Re: [RESEND PATCH 15/16] wcn36xx: don't pad beacons for mesh

2016-03-29 Thread Bjorn Andersson
On Tue 29 Mar 14:41 PDT 2016, Bjorn Andersson wrote: > From: Jason Mobarak > > Patch "wcn36xx: Pad TIM PVM if needed" has caused a regression in mesh > beaconing. The field tim_off is always 0 for mesh mode, and thus > pvm_len (referring to the TIM length field) and pad are both incorrectly > c

[RESEND] nfc: Drop owner assignment from i2c_driver

2016-03-29 Thread Krzysztof Kozlowski
i2c_driver does not need to set an owner because i2c_register_driver() will set it. Signed-off-by: Krzysztof Kozlowski --- The coccinelle script which generated the patch was sent here: http://www.spinics.net/lists/kernel/msg2029903.html --- drivers/nfc/nxp-nci/i2c.c | 1 - drivers/nfc/pn544/

Re: [RFC] ath10k: implement dql for htt tx

2016-03-29 Thread Dave Taht
As a side note of wifi ideas complementary to codel, please see: http://blog.cerowrt.org/post/selective_unprotect/ On Tue, Mar 29, 2016 at 12:49 AM, Michal Kazior wrote: > On 26 March 2016 at 17:44, Dave Taht wrote: >> Dear Michal: > [...] >> I am running behind on this patch set, but a couple

Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

2016-03-29 Thread Kalle Valo
Bjorn Andersson writes: >> All error/warnings (new ones prefixed by >>): >> >>drivers/net/wireless/ath/wcn36xx/main.c: In function 'wcn36xx_set_key': >> >> drivers/net/wireless/ath/wcn36xx/main.c:389:9: error: implicit >> >> declaration of function 'wcn36xx_sta_to_priv' >> >> [-Werror=impl