On Wed, Apr 26, 2017 at 12:54 PM, James Hughes
wrote:
> On 26 April 2017 at 19:03, Arend Van Spriel
> wrote:
>>
>>
>> On 26-4-2017 17:44, Steve deRosier wrote:
>>> On Wed, Apr 26, 2017 at 1:53 AM, Kalle Valo wrote:
Arend Van Spriel wrote:
> An issue was found brcmfmac driver in which a
On Wed, Apr 26, 2017 at 09:41:48PM -0400, Geoff Lansberry wrote:
Hi Geoff.
> In prior commits the selected clock frequency does not propagate
> correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL
> register.
>
> Signed-off-by: Geoff Lansberry
> ---
> drivers/nfc/trf7970a.c | 7
In prior commits the selected clock frequency does not propagate
correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL
register.
Signed-off-by: Geoff Lansberry
---
drivers/nfc/trf7970a.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/nfc/trf7970a.c b/drivers/nf
On Fri, Apr 07, 2017 at 11:43:04PM +0200, Arend Van Spriel wrote:
> On 6-4-2017 14:14, Hans de Goede wrote:
> > Luis, do you think it would be a good idea to add
> > .optional_postfix member to driver_data_req_params
> > for this? I believe other sdio based wifi devices
> > may want to do the same,
On Tue, Apr 11, 2017 at 10:53:57AM +0200, Hans de Goede wrote:
> Hi,
>
> On 10-04-17 23:50, Arend Van Spriel wrote:
> > On 8-4-2017 11:53, Hans de Goede wrote:
> > > Hi,
> > >
> > > On 07-04-17 23:43, Arend Van Spriel wrote:
> > > >
> > > >
> > > > On 6-4-2017 14:14, Hans de Goede wrote:
> > >
Hi Johan,
On Thu, Mar 30, 2017 at 12:15:34PM +0200, Johan Hovold wrote:
> This started out with the observation that the nfcmrvl_uart driver
> unconditionally dereferenced the tty class device despite the fact that
> not every tty has an associated struct device (Unix98 ptys). Some
> further chang
Hi Mark,
On Tue, Apr 25, 2017 at 03:43:47PM -0700, Mark Greer wrote:
> These trf7970a driver patches do the following things:
> - add Mark Greer as the maintainer of the trf7970a driver
> - some minor fixups
> - remove support for 'vin-voltage-override' DT property
> - change the DTS example t
The TX status trigger of the wlan interface is named phy0tx, so this
updates the default-trigger for the WLAN LED to use that instead.
Signed-off-by: Bjorn Andersson
---
Note that without patch 1/2 this trigger does not fire - but there's also no
harm in picking the two patches through separate
As the tx skbs are collected they should be passed to
ieee80211_tx_status() rather than ieee80211_free_txskb(), as the prior
will take care of monitoring and LED triggers while the latter will
consider the skb dropped.
Signed-off-by: Bjorn Andersson
---
drivers/net/wireless/ath/wcn36xx/dxe.c | 2
On 26 April 2017 at 19:03, Arend Van Spriel
wrote:
>
>
> On 26-4-2017 17:44, Steve deRosier wrote:
>> On Wed, Apr 26, 2017 at 1:53 AM, Kalle Valo wrote:
>>> Arend Van Spriel wrote:
An issue was found brcmfmac driver in which a skbuff in .start_xmit()
callback was actually cloned. So in
On Wed, 2017-04-26 at 20:18 +0200, Arend Van Spriel wrote:
>
> I guess it is in you repo as I did not see anything related on the
> mailing list.
Yeah. But that should be up-to-date.
> So regarding this rework, do you want me to send the
> series again or just this patch?
Just this single patc
On 26-4-2017 9:20, Johannes Berg wrote:
> On Tue, 2017-04-25 at 20:56 +0200, Arend Van Spriel wrote:
>>
>> You might, but not about this ;-) The other approach I had in mind is
>> to only pass the flag for drivers with 4-way-hs support. In that case
>> wpa_supp also has to check that to determine w
+ Jouni
On 26-4-2017 12:05, Arend van Spriel wrote:
> Almost overlooked this one. Thanks for the hint, Johannes.
>
> On 4/26/2017 9:58 AM, Luca Coelho wrote:
>> From: Avraham Stern
>>
>> Drivers that initiate roaming while being connected to a network that
>> uses 802.1X authentication need to i
On 26-4-2017 9:16, Johannes Berg wrote:
> On Fri, 2017-04-21 at 13:05 +0100, Arend van Spriel wrote:
>> Have proper request id filled in the SCHED_SCAN_RESULTS and
>> SCHED_SCAN_STOPPED notifications toward user-space by having the
>> driver provide it through the api.
>>
>> Reviewed-by: Hante Meul
Hi Steve,
Here the email which hopefully provides enough context.
Regards,
Arend
Forwarded Message
Subject:Question on drivers using skb_unclone
Date: Fri, 14 Apr 2017 10:03:01 +0100
From: James Hughes
To: net...@vger.kernel.org
CC: unglinuxdri...@microchip
On 26-4-2017 17:44, Steve deRosier wrote:
> On Wed, Apr 26, 2017 at 1:53 AM, Kalle Valo wrote:
>> Arend Van Spriel wrote:
>>> An issue was found brcmfmac driver in which a skbuff in .start_xmit()
>>> callback was actually cloned. So instead of checking for sufficient
>>> headroom it should also
On Wed, Apr 26, 2017 at 09:48:33AM -0400, Geoff Lansberry wrote:
> In prior commits the selected clock frequency does not propagate
> correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL
> register.
> Also fixes a bug that causes the device tree property check to always
> pass.
>
>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git
master
head: 3e451b15ec3c6560b81875cb85b19f807258f8d7
commit: 3a565a1318a18fd2b7554b6e0b9846cc3fb68c67 [3/12] cfg80211: simplify
netlink socket owner interface deletion
reproduce: make htmldocs
All warnings (new on
On Wed, Apr 26, 2017 at 1:53 AM, Kalle Valo wrote:
> Arend Van Spriel wrote:
>> An issue was found brcmfmac driver in which a skbuff in .start_xmit()
>> callback was actually cloned. So instead of checking for sufficient
>> headroom it should also be writable. Hence use skb_cow_head() to
>> check
On 2017-04-26 16:41, Venkateswara Rao Naralasetty wrote:
> Channel active/busy time are showing incorrect
> (less than previous or sometimes zero) for
> successive survey dump command.
>
> example:
> Survey data from wlan0
> frequency: 5180 MHz [in use]
> chann
Rename .tx_status_noskb to .tx_status_ext and pass a new on-stack
struct ieee80211_tx_status instead of struct ieee80211_tx_info.
This struct can be used to pass extra information, e.g. for dynamic tx
power control
Signed-off-by: Felix Fietkau
---
include/net/mac80211.h | 20 +++
From: Thomas Huehn
To use the per rate information about which txpower level was
used for a successful or unsuccessful transmission, this new
tx power per multi-rate retry rate annotation in the tx status
path is needed.
Signed-off-by: Thomas Huehn
---
include/net/mac80211.h | 2 ++
1 file cha
This allows the driver to pass in struct ieee80211_tx_status directly.
Make ieee80211_tx_status_noskb a wrapper around it.
As with ieee80211_tx_status_noskb, there is no _ni variant of this call,
because it probably won't be needed.
Even if the driver won't provide any extra status info other tha
Makes further cleanups more readable
Signed-off-by: Felix Fietkau
---
net/mac80211/status.c | 116 +-
1 file changed, 58 insertions(+), 58 deletions(-)
diff --git a/net/mac80211/status.c b/net/mac80211/status.c
index e655b3abb84a..2b3f02f56db3 100
This will be used to allow rate control to control per-packet tx power.
Since cb space is tight and minstrel/minstrel_ht uses
info->control.rates only for the sampling rate, the tx power field in
info->control refers to the first rate attempt entry only.
Transmit power for the selected best rate s
Channel active/busy time are showing incorrect
(less than previous or sometimes zero) for
successive survey dump command.
example:
Survey data from wlan0
frequency: 5180 MHz [in use]
channel active time:54995 ms
channel busy time:
Am 26.04.2017 15:48, schrieb Geoff Lansberry:
> In prior commits the selected clock frequency does not propagate
> correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL
> register.
> Also fixes a bug that causes the device tree property check to always
> pass.
>
> Signed-off-by: G
In prior commits the selected clock frequency does not propagate
correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL
register.
Also fixes a bug that causes the device tree property check to always
pass.
Signed-off-by: Geoff Lansberry
---
drivers/nfc/trf7970a.c | 9 -
1 f
Luca Coelho writes:
> Here's another pull-request intended for v4.12. This is generic
> development work, nothing really stands out. More details in the tag
> description.
>
> I have sent this out before, and kbuildbot reported success.
>
> Please let me know if there are any issues.
>
> Cheers
Michael Mera writes:
> Kalle Valo writes:
>> I fixed a checkpatch warning in the pending branch:
>>
>> drivers/net/wireless/ath/ath10k/debug.c:636: spaces preferred around
>> that '-' (ctx:VxV)
>
> Hum... but then you will have a line longer than 80 characters (81), so
> another warning.
I have
On Wed, Apr 19, 2017 at 01:24:31AM +0200, Samuel Ortiz wrote:
> On Tue, Apr 18, 2017 at 12:09:16PM +0200, Johan Hovold wrote:
> > On Thu, Mar 30, 2017 at 12:15:34PM +0200, Johan Hovold wrote:
> > > This started out with the observation that the nfcmrvl_uart driver
> > > unconditionally dereference
From: Xinming Hu
P2p client act as a station, data will be queued by DA instead
of RA. This patch pass the sanity check, so that p2p client share
the same data path with infrastruction station mode.
Signed-off-by: Xinming Hu
Signed-off-by: Cathy Luo
---
drivers/net/wireless/marvell/mwifiex/ma
Kalle Valo writes:
> I fixed a checkpatch warning in the pending branch:
>
> drivers/net/wireless/ath/ath10k/debug.c:636: spaces preferred around that '-'
> (ctx:VxV)
Hum... but then you will have a line longer than 80 characters (81), so
another warning.
I prefered this version since I feel tha
On 4/26/2017 11:08 AM, Johannes Berg wrote:
On Wed, 2017-04-26 at 11:05 +0200, Arend van Spriel wrote:
I guess it could be done, but I'm tending towards doing that less
again, I have no strong preference in this case. If it was
something
that seems likely to get abused, perhaps, but here...
Almost overlooked this one. Thanks for the hint, Johannes.
On 4/26/2017 9:58 AM, Luca Coelho wrote:
From: Avraham Stern
Drivers that initiate roaming while being connected to a network that
uses 802.1X authentication need to inform user space if 802.1X
authentication is further required after
Michael Mera wrote:
> During write to debugfs file simulate_fw_crash, fixed-size local buffer
> 'buf' is accessed and modified at index 'count-1', where 'count' is the
> size of the write (so potentially out of bounds).
> This patch fixes this problem.
>
> Signed-off-by: Michael Mera
I fixed a
Pan Bian wrote:
> Function alloc_skb() will return a NULL pointer if there is no enough
> memory. However, in function mt7601u_mcu_msg_alloc(), its return value
> is not validated before it is used. This patch fixes it.
>
> Signed-off-by: Pan Bian
> Acked-by: Jakub Kicinski
Patch applied to wi
On 4/26/2017 10:49 AM, Johannes Berg wrote:
FWIW:
https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git/commit/?id=978812b3f43dda86e20588cfe0a4a244c4fab141
On Wed, 2017-04-26 at 10:46 +0200, Arend van Spriel wrote:
Sure. In the worker we are already iterating so I guess w
On Wed, 2017-04-26 at 11:05 +0200, Arend van Spriel wrote:
> I guess it could be done, but I'm tending towards doing that less
> > again, I have no strong preference in this case. If it was
> > something
> > that seems likely to get abused, perhaps, but here...
>
> Ok. As long as drivers don't thi
James Hughes wrote:
> The incoming skb header may be resized if header space is
> insufficient, which might change the data adddress in the skb.
> Ensure that a cached pointer to that data is correctly set by
> moving assignment to after any possible changes.
>
> Signed-off-by: James Hughes
>
>
James Hughes wrote:
> The driver was making changes to the skb_header without
> ensuring it was writable (i.e. uncloned).
> This patch also removes some boiler plate header size
> checking/adjustment code as that is also handled by the
> skb_cow_header function used to make header writable.
>
> S
Pan Bian wrote:
> From: Pan Bian
>
> Function create_singlethread_workqueue() will return a NULL pointer if
> there is no enough memory, and its return value should be validated
> before using. However, in function rndis_wlan_bind(), its return value
> is not checked. This may cause NULL derefer
Pan Bian wrote:
> From: Pan Bian
>
> Function alloc_workqueue() will return a NULL pointer if there is no
> enough memory, and its return value should be validated before using.
> However, in function if_spi_probe(), its return value is not checked.
> This may result in a NULL dereference bug. T
Maksim Salau wrote:
> Allocate buffer on HEAP instead of STACK for a local variable
> that is to be sent using usb_control_msg().
>
> Signed-off-by: Maksim Salau
Patch applied to wireless-drivers-next.git, thanks.
2f6ae79cb04b orinoco_usb: Fix buffer on stack
--
https://patchwork.kernel.org/
Larry Finger wrote:
> Current channel switch implementation sets 8812ae RFE reg value assuming
> that device always has type 2.
>
> Extend possible RFE types set and write corresponding reg values.
>
> Source for new code is
> http://dlcdnet.asus.com/pub/ASUS/wireless/PCE-AC51/DR_PCE_AC51_202328
On 4/26/2017 10:53 AM, Kalle Valo wrote:
Arend Van Spriel wrote:
An issue was found brcmfmac driver in which a skbuff in .start_xmit()
callback was actually cloned. So instead of checking for sufficient
headroom it should also be writable. Hence use skb_cow_head() to
check and expand the headro
Colin Ian King wrote:
> From: Colin Ian King
>
> trivial fix to spelling mistake in dbg_dbg message
>
> Signed-off-by: Colin Ian King
Patch applied to wireless-drivers-next.git, thanks.
bea35f90dbb1 orinoco: fix spelling mistake: "Registerred" -> "Registered"
--
https://patchwork.kernel.or
On 4/26/2017 9:58 AM, Luca Coelho wrote:
From: Avraham Stern
cfg80211_roamed() and cfg80211_roamed_bss() take the same arguments
except that cfg80211_roamed() requires the BSSID and
cfg80211_roamed_bss() requires the bss entry.
Unify the two functions by using a struct for driver initiated
roa
Arend Van Spriel wrote:
> An issue was found brcmfmac driver in which a skbuff in .start_xmit()
> callback was actually cloned. So instead of checking for sufficient
> headroom it should also be writable. Hence use skb_cow_head() to
> check and expand the headroom appropriately.
>
> Signed-off-by
FWIW:
https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git/commit/?id=978812b3f43dda86e20588cfe0a4a244c4fab141
On Wed, 2017-04-26 at 10:46 +0200, Arend van Spriel wrote:
> Sure. In the worker we are already iterating so I guess we could.
> The number of internal fields in str
On 4/25/2017 9:49 PM, Johannes Berg wrote:
if (schedule_destroy_work) {
- struct cfg80211_iface_destroy *destroy;
+ struct cfg80211_nlport_release *destroy;
destroy = kzalloc(sizeof(*destroy),
GFP_ATOMIC);
I was never really
On Wed, 2017-04-26 at 11:11 +0300, Luca Coelho wrote:
> On Wed, 2017-04-26 at 10:08 +0200, Johannes Berg wrote:
> > > Avraham Stern (3):
> > > mac80211: Add support for BSS max idle period element
> > > cfg80211: unify cfg80211_roamed() and cfg80211_roamed_bss()
> > > cfg80211/nl80211: add au
This seems nice, yes.
regards,
dan carpenter
Hi Kalle,
Here's another pull-request intended for v4.12. This is generic
development work, nothing really stands out. More details in the tag
description.
I have sent this out before, and kbuildbot reported success.
Please let me know if there are any issues.
Cheers,
Luca.
The following ch
> Avraham Stern (3):
> mac80211: Add support for BSS max idle period element
> cfg80211: unify cfg80211_roamed() and cfg80211_roamed_bss()
> cfg80211/nl80211: add authorized flag to roaming event
I'm going to let these get a bit more time on the list.
Arend, it'd be nice if you could take a
On Wed, 2017-04-26 at 10:08 +0200, Johannes Berg wrote:
> > Avraham Stern (3):
> > mac80211: Add support for BSS max idle period element
> > cfg80211: unify cfg80211_roamed() and cfg80211_roamed_bss()
> > cfg80211/nl80211: add authorized flag to roaming event
>
> I'm going to let these get a
From: Johannes Berg
Some of the enum definitions are unnamed but there's still
an attempt at documenting them - that doesn't work. Name
them to make that work.
Signed-off-by: Johannes Berg
---
include/linux/ieee80211.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --
From: Luca Coelho
The multicast variable in the ieee80211_accept_frame() function is
treated as a boolean, but defined as int. Fix that.
Signed-off-by: Luca Coelho
---
net/mac80211/rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
i
From: Johannes Berg
At least on iwlwifi, sometimes lockdep complains that we can
lock
chanctx_mtx -> mvm.mutex -> iflist_mtx
(due to iterate_interfaces)
and
iflist_mtx -> chanctx_mtx
Remove the latter dependency in mac80211 by using the RTNL
that we already hold in one case, and can relativel
From: Avraham Stern
Drivers that initiate roaming while being connected to a network that
uses 802.1X authentication need to inform user space if 802.1X
authentication is further required after roaming.
For example, when using the Fast transition protocol, roaming within
the mobility domain does
From: Avraham Stern
Parse the BSS max idle period element and set the BSS configuration
accordingly so the driver can use this information to configure the
max idle period and to use protected management frames for keep alive
when required.
The BSS max idle period element is defined in IEEE802.1
From: Avraham Stern
cfg80211_roamed() and cfg80211_roamed_bss() take the same arguments
except that cfg80211_roamed() requires the BSSID and
cfg80211_roamed_bss() requires the bss entry.
Unify the two functions by using a struct for driver initiated
roaming information so that either the BSSID o
From: Luca Coelho
Add the definitions for SUITE_B and SUITE_B_192 AKM selectors as
defined in IEEE802.11REVmc_D5.0, table 9-132.
Signed-off-by: Luca Coelho
---
include/linux/ieee80211.h | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/include/lin
From: Luca Coelho
Add the definition for FT-8021.1X AKM selector as defined in
IEEE Std 802.11-2016, table 9-133.
Signed-off-by: Luca Coelho
---
include/linux/ieee80211.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
index c916ba4a22d
From: Emmanuel Grumbach
ieee80211_frame_acked is called when a frame is acked by
the peer. In case this is a management frame, we check
if this an SMPS frame, in which case we can update our
antenna configuration.
When we parse the management frame we look at the category
in case it is an action
From: Luca Coelho
Hi,
Here are some mac80211 and cfg80211 patches from our internal tree.
* New AKM suite selectors in the ieee80211 header;
* Some improvements in the roaming API in cfg80211;
* Support for max BSS idle period in mac80211;
* Some cleanups and an optimization;
Please revie
On Tue, 2017-04-25 at 20:56 +0200, Arend Van Spriel wrote:
>
> You might, but not about this ;-) The other approach I had in mind is
> to only pass the flag for drivers with 4-way-hs support. In that case
> wpa_supp also has to check that to determine whether the flag should
> be taken into accoun
On Fri, 2017-04-21 at 13:05 +0100, Arend van Spriel wrote:
> Have proper request id filled in the SCHED_SCAN_RESULTS and
> SCHED_SCAN_STOPPED notifications toward user-space by having the
> driver provide it through the api.
>
> Reviewed-by: Hante Meuleman
> Reviewed-by: Pieter-Paul Giesberts m>
> nl80211: allow multiple active scheduled scan requests
> nl80211: add support for BSSIDs in scheduled scan matchsets
> cfg80211: add request id parameter to .sched_scan_stop() signature
I applied these.
> cfg80211: add request id to cfg80211_sched_scan_*() api
Will comment here separa
69 matches
Mail list logo
