[PATCH net-next] rsi: remove unused including

2017-10-27 Thread Wei Yongjun
Remove including that don't need it. Signed-off-by: Wei Yongjun --- drivers/net/wireless/rsi/rsi_91x_ps.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_ps.c b/drivers/net/wireless/rsi/rsi_91x_ps.c index 523f532..410c55f 100644 --- a/drivers/net/wireless/rs

Re: RTL usb adapter question

2017-10-27 Thread James Cameron
On Fri, Oct 27, 2017 at 10:23:54PM -0500, David Ashley wrote: > On 10/26/17, James Cameron wrote: > > Interesting, thanks. It should be a QFN 46 pin chip; you may have > > counted 15 instead of 14 pins on the long edge. Send me a photograph > > of the inside, off-list? > > I uploaded a couple o

Re: RTL usb adapter question

2017-10-27 Thread David Ashley
On 10/26/17, James Cameron wrote: > Interesting, thanks. It should be a QFN 46 pin chip; you may have > counted 15 instead of 14 pins on the long edge. Send me a photograph > of the inside, off-list? I uploaded a couple of pictures here: http://www.linuxmotors.com/RTL8188CUS/ You're right, I m

Re: rtlwifi oops

2017-10-27 Thread James Cameron
On Sat, Oct 28, 2017 at 12:02:30AM +0300, nirinA raseliarison wrote: > On 10/27/2017 07:57 AM, James Cameron wrote: > >On Fri, Oct 27, 2017 at 04:08:48AM +0300, nirinA raseliarison wrote: > >>hi all, > >>i applied the patch against 4.13.8. i still got some trouble, dmesg > >>is below. > > > >As thi

[PATCH 1/1] ocb: Use common freqchan helper for setting the operating channel

2017-10-27 Thread Peter Große
Simplify code by using the helper which has been introduced earlier. Signed-off-by: Peter Große --- ocb.c | 50 -- 1 file changed, 8 insertions(+), 42 deletions(-) diff --git a/ocb.c b/ocb.c index bcf0474..dfdaf59 100644 --- a/ocb.c +++ b/ocb.c @@

Re: rtlwifi oops

2017-10-27 Thread nirinA raseliarison
On 10/27/2017 07:57 AM, James Cameron wrote: On Fri, Oct 27, 2017 at 04:08:48AM +0300, nirinA raseliarison wrote: hi all, i applied the patch against 4.13.8. i still got some trouble, dmesg is below. As this new event does not have "disabled by hub (EMI?)", it is a different problem to your 19

Re: Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"

2017-10-27 Thread Ben Greear
On 10/27/2017 01:15 PM, Johannes Berg wrote: On Wed, 2017-10-25 at 09:13 -0700, Ben Greear wrote: Well it resulted in a WARN_ON because if the AP didn't have those rates, we'd not find any usable rates while trying to transmit a frame, and then ended up warning and falling down to the lowest po

Re: Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"

2017-10-27 Thread Johannes Berg
On Wed, 2017-10-25 at 09:13 -0700, Ben Greear wrote: > > Well it resulted in a WARN_ON because if the AP didn't have those > > rates, we'd not find any usable rates while trying to transmit a frame, > > and then ended up warning and falling down to the lowest possible rate. > > > > I don't think

Re: Commit 0711d638 breaks mwifiex

2017-10-27 Thread Johannes Berg
Hi, > IIUC, mwifiex hasn't told the firmware to do anything at this point -- > the -EALREADY check is practically the first thing it does within > connect(). So it just quits the connect() request and tries to carry on > as usual. It will only do something different if the upper layers tell > it t

Re: ath10k-regression due to "ath10k: fix napi_poll budget overflow" c9353bf483d3

2017-10-27 Thread Ryan Hsu
On 10/27/2017 02:40 AM, Kalle Valo wrote: > + linux-wireless > > Sorry, I have not been able to follow this discussion very closely but > was the conclusion? Should we should revert c9353bf483d3 for 4.14 or > what? I should still have time to do that, but not much. Kalle, I don't think I have eno

Re: RTL usb adapter question

2017-10-27 Thread Larry Finger
On 10/26/2017 05:00 PM, James Cameron wrote: Base on your evidence, I'd say the device is different to others and has firmware included. That would seem to be the case. The firmware has been updated since that device was released, and I suggest that you provide the file requested, namely /lib

wcn36xx: connection monitoring issue

2017-10-27 Thread Damien Riegel
Hi, I'm working on a board derived from the DragonBoard-410c (apq8016 + wcn3620) and noticed an issue with WiFi connection monitoring. When I get out of the range of the access point, the device stays associated, no matter how far I go or how long I wait. The chip on this board is the WCN3620, a

Re: [v3] ath10k: rebuild crypto header in rx data frames

2017-10-27 Thread Kalle Valo
Kalle Valo wrote: > Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and > HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done > on host (mac80211) rather than firmware. Rebuild cipher header > in every received data frames (that are notified through those > HTT interfaces) from th

[PATCH v2 3/3] ath9k: Switch to mac80211 airtime API

2017-10-27 Thread Toke Høiland-Jørgensen
This removes the in-driver airtime fairness scheduling from ath9k and switches the driver to use the API introduced in mac80211 in the previous commit. Signed-off-by: Toke Høiland-Jørgensen --- Changes since v1: - Split out ath9k changes into separate patch drivers/net/wireless/ath/ath9k/ath9k.

[PATCH v2 2/3] mac80211: Add airtime account and scheduling to TXQs

2017-10-27 Thread Toke Høiland-Jørgensen
This adds airtime accounting and scheduling to the mac80211 TXQ scheduler. A new hardware flag, AIRTIME_ACCOUNTING, is added that drivers can set if they support reporting airtime usage of transmissions. When this flag is set, mac80211 will expect the actual airtime usage to be reported in the tx_t

[PATCH v2 1/3] mac80211: Add TXQ scheduling API

2017-10-27 Thread Toke Høiland-Jørgensen
This adds an API to mac80211 to handle scheduling of TXQs and changes the interface between driver and mac80211 for TXQ handling as follows: - The wake_tx_queue callback interface no longer includes the TXQ. Instead, the driver is expected to retrieve that from ieee80211_next_txq() - Two new ma

Re: wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed

2017-10-27 Thread Kalle Valo
Jia-Ju Bai wrote: > No rcu_read_lock is called, but rcu_read_unlock is still called. > Thus rcu_read_unlock should be removed. > > Signed-off-by: Jia-Ju Bai > Acked-by: Bjorn Andersson > Signed-off-by: Kalle Valo Patch applied to ath-current branch of ath.git, thanks. c0d5adc35c0b wcn36xx:

Re: drivers/wireless: ath: Convert timers to use timer_setup()

2017-10-27 Thread Kalle Valo
Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo > Cc: linux-wireless@vger.kernel.org > Cc: net...@vger.kernel.o

Re: wil6210: remove SSID debugfs

2017-10-27 Thread Kalle Valo
Johannes Berg wrote: > This driver shouldn't be using wdev->ssid to start with, as > it's more or less an internal field in cfg80211 used for > various purposes. Reading it is possible through nl80211, > even if that's not really what we should be doing there > for anything but AP type interfaces

Re: wil6210: remove wil6210_uapi.h from MAINTAINERS

2017-10-27 Thread Kalle Valo
Johannes Berg wrote: > This file doesn't exist. > > Signed-off-by: Johannes Berg > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 6bac0d2cda71 wil6210: remove wil6210_uapi.h from MAINTAINERS -- https://patchwork.kernel.org/patch/10012773/ https://wireless.w

Re: ath9k: debug: Remove redundant check

2017-10-27 Thread Kalle Valo
Christos Gkekas wrote: > Variable val is unsigned, so checking whether it is less than zero is > redundant. > > Signed-off-by: Christos Gkekas > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 9d414949a306 ath9k: debug: Remove redundant check -- https://patch

Re: ath10k: spectral: Remove redundant check

2017-10-27 Thread Kalle Valo
Christos Gkekas wrote: > Variable val is unsigned, so checking whether it is less than zero is > redundant. > > Signed-off-by: Christos Gkekas > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. d83c0d3293bb ath10k: spectral: remove redundant check in write_file

Re: ath10k: fix sending wmi cmd during the tdls teardown

2017-10-27 Thread Kalle Valo
ako...@qti.qualcomm.com wrote: > The current firmware 10.4-3.5.1-00035 on QCA9888 supports > TDLS explicit mode, it expects WMI_TDLS_ENABLE_PASSIVE > for tdls setup and WMI_TDLS_DISABLE for tdls teardown. > > Signed-off-by: Anilkumar Kolli > Signed-off-by: Kalle Valo Patch applied to ath-next

Re: [1/2] ath10k: move ath10k_mac_tdls_vif*() functions

2017-10-27 Thread Kalle Valo
ako...@qti.qualcomm.com wrote: > To be able to use ath10k_mac_tdls_vif_stations_count() in > ath10k_hw_scan() in the following patch, move the functions > earlier in the file. > > This commit is pure code move, no functional changes. > > Signed-off-by: Anilkumar Kolli > Signed-off-by: Kalle Val

Re: wil6210: disallow changing RSN in beacon change

2017-10-27 Thread Johannes Berg
On Fri, 2017-10-27 at 15:42 +0200, Kalle Valo wrote: > Johannes Berg wrote: > > > This is a code path that will never really get hit anyway, since > > it's nonsense to change the beacon of an existing BSS to suddenly > > include or no longer include the RSN IE. Reject this instead of > > having t

Re: ath10k: fix build errors with !CONFIG_PM

2017-10-27 Thread Kalle Valo
Brian Norris wrote: > Build errors have been reported with CONFIG_PM=n: > > drivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit > declaration of function 'ath10k_pci_suspend' > [-Werror=implicit-function-declaration] > > drivers/net/wireless/ath/ath10k/pci.c:3428:8: error: implicit >

Re: wil6210: disallow changing RSN in beacon change

2017-10-27 Thread Kalle Valo
Johannes Berg wrote: > This is a code path that will never really get hit anyway, since > it's nonsense to change the beacon of an existing BSS to suddenly > include or no longer include the RSN IE. Reject this instead of > having the dead code, and get rid of accessing wdev->ssid/_len by > way o

Re: [01/12] wil6210: run-time PM when interface down

2017-10-27 Thread Kalle Valo
Maya Erez wrote: > Allow run-time suspend when interface is down, keep card alive when > interface is up. > If driver is in wmi only or debug_fw mode run-time PM won't suspend. > > Signed-off-by: Lazar Alexei > pcie_bus.c > Signed-off-by: Maya Erez > Signed-off-by: Kalle Valo Kbuild bo

Submit patches for v4.15 now

2017-10-27 Thread Kalle Valo
Hi, merge window is getting closer, most like it will open in 1-2 weeks. If there's anything you want to have in v4.15 submit them now so that there's enough time to get everything ready. -- Kalle Valo

[v3 3/3] rsi: sdio: Add WOWLAN support for S5 shutdown state

2017-10-27 Thread Amitkumar Karwar
From: Karun Eagalapati Unlike other power states, WoWLAN configuration does not come from mac80211 for shutdown. Hence configuring the WoWLAN from shut down callback it self. Remaining steps of disabling SDIO interrupts, setting 'MMC_PM_KEEP_POWER' flag are same as other power states. Signed-off

[v3 2/3] rsi: sdio: Add WOWLAN support for S4 hibernate state

2017-10-27 Thread Amitkumar Karwar
From: Karun Eagalapati We are disabling of interrupts from firmware in freeze handler. Also setting power management capability KEEP_MMC_POWER to make device wakeup for WoWLAN trigger. At restore, we observed a device reset on some platforms. Hence reloading of firmware and device initialization

[v3 1/3] rsi: sdio: add WOWLAN support for S3 suspend state

2017-10-27 Thread Amitkumar Karwar
From: Karun Eagalapati WoWLAN is supported in RS9113 device through GPIO pin2. wowlan config frame is internally sent to firmware in mac80211 suspend handler. Also beacon miss threshold and keep-alive time values are increased to avoid un-necessary disconnection with AP. Signed-off-by: Karun Eag

[v3 0/3] rsi: WOWLAN support

2017-10-27 Thread Amitkumar Karwar
From: Amitkumar Karwar This patch series adds WOWLAN support for system's S3, S4 and S5 power states. wakeup through magic packet has been verified in these power states. Changes since v2: Rebased the patch series to the latest code. Recently below patch got accepted which causes some confli

[PATCH] mwifiex: do not transmit in 11N rates when connected in TKIP security

2017-10-27 Thread Ganapathi Bhat
Driver is transmitting in 11N rates, when connected to an AP in TKIP security mode. Add a check to disable_11n to fix the issue. Signed-off-by: Ganapathi Bhat --- drivers/net/wireless/marvell/mwifiex/fw.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/

Re: ath10k-regression due to "ath10k: fix napi_poll budget overflow" c9353bf483d3

2017-10-27 Thread Kalle Valo
+ linux-wireless Thorsten Leemhuis writes: > Lo! On 03.10.2017 01:40, Ryan Hsu wrote: >> On 10/01/2017 01:59 AM, Thorsten Leemhuis wrote: >>> Lo! The wifi connection of my Dell XPS13 (9360) with its QCA6174 >>> sometimes suddenly stops working since I switched to 4.14-rc2+. Every >>> time it hap

Re: [PATCH 2/2] ath10k: search DT for qcom, ath10k-calibration-variant

2017-10-27 Thread Kalle Valo
Sven Eckelmann writes: > On Freitag, 10. März 2017 19:20:54 CEST Christian Lamparter wrote: > [...] >> @Aeolus Yang / Kalle / QCA: Would it be possible to assign a variant string >> to >> the Asus RT-AC58U? >> >> I've attached the necessary bmi-board-id=16 and bmi-board-id=17 board >> files to

Re: drivers/wireless: ath: Convert timers to use timer_setup()

2017-10-27 Thread Kees Cook
On Fri, Oct 27, 2017 at 11:18 AM, Kalle Valo wrote: > Kees Cook wrote: > >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to pass the timer pointer explicitly. >> >> Cc: Kalle Valo >>

Re: [v7,2/5] ath10k: Enable TDLS peer buffer STA feature

2017-10-27 Thread Kalle Valo
yint...@qti.qualcomm.com wrote: > From: Yingying Tang > > Enable TDLS peer buffer STA feature. > QCA6174 firmware(version: WLAN.RM.4.4) support TDLS peer buffer STA, > it reports this capability through wmi service map in wmi service ready > event. Set related parameter in TDLS WMI command to en

Re: drivers/wireless: ath: Convert timers to use timer_setup()

2017-10-27 Thread Kalle Valo
Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo > Cc: linux-wireless@vger.kernel.org > Cc: net...@vger.kernel.o

Re: [1/5] qtnfmac: modify full Tx queue error reporting

2017-10-27 Thread Kalle Valo
Sergey Matyukevich wrote: > Under heavy load it is normal that h/w Tx queue is almost full all the time > and reclaim should be done before transmitting next packet. Warning still > should be reported as well as s/w Tx queues should be stopped in the > case when reclaim failed. > > Signed-off-by

Re: rtlwifi: Remove seq_number from rtl_tid_data

2017-10-27 Thread Kalle Valo
Ping-Ke Shih wrote: > From: Ping-Ke Shih > > Since mac80211 maintains the sequence number for each STA/TID, > driver doesn't need to maintain a copy. > > Signed-off-by: Ping-Ke Shih Patch applied to wireless-drivers-next.git, thanks. 1d1aa8f1ea24 rtlwifi: Remove seq_number from rtl_tid_data

Re: rtlwifi: rtl8821ae: Fix typo in variable name

2017-10-27 Thread Kalle Valo
Nik Nyby wrote: > In _rtl8821ae_dbi_write(), wrtie_addr should be write_addr. > > Signed-off-by: Nik Nyby Patch applied to wireless-drivers-next.git, thanks. 62689167261d rtlwifi: rtl8821ae: Fix typo in variable name -- https://patchwork.kernel.org/patch/10023407/ https://wireless.wiki.ker

Re: [V2] bcma: Use bcma_debug and not pr_cont in MIPS driver

2017-10-27 Thread Kalle Valo
Joe Perches wrote: > Commit 66cc04424960 ("bcma: use bcma_debug and pr_cont in MIPS driver") > converted a printk(KERN_DEBUG to bcma_debug. > > bcma_debug is guarded by a #define DEBUG via pr_debug. > > This means that the bcma_debug will generally not be emitted > but any pr_cont following the

Re: [v4,2/9] brcmsmac: split up wlc_phy_workarounds_nphy

2017-10-27 Thread Kalle Valo
Arnd Bergmann wrote: > The stack consumption in this driver is still relatively high, with one > remaining warning if the warning level is lowered to 1536 bytes: > > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:17135:1: error: > the frame size of 1880 bytes is larger than 1536 b

Re: libertas: Convert timers to use timer_setup()

2017-10-27 Thread Kalle Valo
Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo > Cc: Arvind Yadav > Cc: Ingo Molnar > Cc: Johannes Berg > C

Re: mwifiex: Convert timers to use timer_setup()

2017-10-27 Thread Kalle Valo
Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo > Cc: Amitkumar Karwar > Cc: Nishant Sarmukadam > Cc: Ganapat

Re: drivers/wireless: rsi: Convert timers to use timer_setup()

2017-10-27 Thread Kalle Valo
Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo > Cc: Amitkumar Karwar > Cc: Prameela Rani Garnepudi > Cc: Pa

Re: cw1200: Convert timers to use timer_setup()

2017-10-27 Thread Kalle Valo
Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Solomon Peachy > Cc: Kalle Valo > Cc: linux-wireless@vger.kernel.org > Cc

Re: atmel: Convert timers to use timer_setup()

2017-10-27 Thread Kalle Valo
Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Simon Kelley > Cc: Kalle Valo > Cc: linux-wireless@vger.kernel.org > Cc:

Re: iwlegacy: Convert timers to use timer_setup()

2017-10-27 Thread Kalle Valo
Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo > Cc: Stanislaw Gruszka > Cc: linux-wireless@vger.kernel.org >

Re: qtnfmac: Convert timers to use timer_setup()

2017-10-27 Thread Kalle Valo
Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo > Cc: Igor Mitsyanko > Cc: Avinash Patil > Cc: Sergey Matyuke

Re: rtlwifi: Convert timers to use timer_setup()

2017-10-27 Thread Kalle Valo
Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo > Cc: Larry Finger > Cc: Chaoming Li > Cc: Ping-Ke Shih > Cc

Re: [08/58] net/wireless/ray_cs: Convert timers to use timer_setup()

2017-10-27 Thread Kalle Valo
Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo > Cc: linux-wireless@vger.kernel.org > Cc: net...@vger.kernel.o

[RFC PATCH v10 3/7] mwifiex: Disable wakeup irq handling for pcie

2017-10-27 Thread Jeffy Chen
We are going to handle the wakeup irq in the pci core. Signed-off-by: Jeffy Chen --- Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v3: None Changes in v2: None drivers/net/wireless/marvell/mwifiex/main.c | 4

[RFC PATCH v10 0/7] PCI: rockchip: Move PCIe WAKE# handling into pci core

2017-10-27 Thread Jeffy Chen
Currently we are handling wake irq in mrvl wifi driver. Move it into pci core. Tested on my chromebook bob(with cros 4.4 kernel and mrvl wifi). Changes in v10: Use device_set_wakeup_capable() instead of device_set_wakeup_enable(), since dedicated wakeirq will be lost in device_set_wakeup_enable

[RFC PATCH v9 3/7] mwifiex: Disable wakeup irq handling for pcie

2017-10-27 Thread Jeffy Chen
We are going to handle the wakeup irq in the pci core. Signed-off-by: Jeffy Chen --- Changes in v9: None Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v3: None Changes in v2: None drivers/net/wireless/marvell/mwifiex/main.c | 4 1 file changed,

[RFC PATCH v9 0/7] PCI: rockchip: Move PCIe WAKE# handling into pci core

2017-10-27 Thread Jeffy Chen
Currently we are handling wake irq in mrvl wifi driver. Move it into pci core. Tested on my chromebook bob(with cros 4.4 kernel and mrvl wifi). Changes in v9: Add section for PCI devices and rewrite the commit message. Rewrite the commit message. Fix check error in .cleanup(). Move dedicated wa