Re: [PATCH 1/3] ath9k: remove stray backslash in Makefile

2017-11-27 Thread Jakub Kicinski
On Mon, 27 Nov 2017 18:56:21 +0100, Matthias Schiffer wrote: > Signed-off-by: Matthias Schiffer > --- > drivers/net/wireless/ath/ath9k/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath9k/Makefile >

[PATCH v2] drivers: bcma: driver_pcie2.c: Comment format correction & moving trailing */ to a separate line as per checkpatch

2017-11-27 Thread Ashish Kalra
This patch fixes the checkpatch.pl warning: WARNING: Block comments use * on subsequent lines + /* TODO: + si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */ WARNING: Block comments use a trailing */ on a separate line + si_core_wrapperreg(pcie2, 3, 0x60,

Re: [PATCH v1] brcmfmac: Avoid build error with make W=1

2017-11-27 Thread Arend van Spriel
On 23-11-17 16:57, Andy Shevchenko wrote: When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for the first run, all next ones are okay. CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot

Re: [PATCH] ath6kl: remove redundant variable ies_len

2017-11-27 Thread Steve deRosier
On Sat, Nov 25, 2017 at 9:38 PM, Kenneth Lu wrote: > To get rid of W=1 warning: variable ‘ies_len’ set but not used. > Variable ies_len is being assigned but never read. > > Signed-off-by: Kenneth Lu > --- >

RE: [RFC] cfg80211: Implement Multiple BSSID capability in scanning

2017-11-27 Thread Peng Xu
> Is a new version of this patch hinging only on this? We'd love to have a > fixed- > up one :-) The new version covers the use cases mentioned by Jouni as the OUIs of the vendor commands has the format of OUI + type + subtype. For other format of vendor commands, they will be treated as

[PATCH 1/3] ath9k: remove stray backslash in Makefile

2017-11-27 Thread Matthias Schiffer
Signed-off-by: Matthias Schiffer --- drivers/net/wireless/ath/ath9k/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/Makefile b/drivers/net/wireless/ath/ath9k/Makefile index 36a40ffdce15..90e4a341076c

[PATCH 3/3] ath10k: move spectral scan support under a separate config symbol

2017-11-27 Thread Matthias Schiffer
At the moment, spectral scan support, and with it RELAY, is always enabled with ATH10K_DEBUGFS. Spectral scan support is currently the only user of RELAY in ath10k, and it unconditionally reserves a relay channel. Having debugfs support in ath10k is often useful even on very small embedded

[PATCH 2/3] ath9k: move spectral scan support under a separate config symbol

2017-11-27 Thread Matthias Schiffer
At the moment, spectral scan support, and with it RELAY, is always enabled with ATH9K[_HTC]_DEBUGFS. Spectral scan support is currently the only user of RELAY in ath9k, and it unconditionally reserves a relay channel. Having debugfs support in ath9k is often useful even on very small embedded

Re: [PATCH for-4.15] brcmfmac: change driver unbind order of the sdio function devices

2017-11-27 Thread Kalle Valo
Arend van Spriel writes: > In the function brcmf_sdio_firmware_callback() the driver is > unbound from the sdio function devices in the error path. > However, the order in which it is done resulted in a use-after-free > issue (see brcmf_ops_sdio_remove() in

Re: pull-request: mac80211 2017-11-27

2017-11-27 Thread David Miller
From: Johannes Berg Date: Mon, 27 Nov 2017 11:32:56 +0100 > Here are a few more fixes, one of which fixes the crash Florian > reported which I think is the same that zero-day reported. > > Please pull and let me know if there's any problem. Pulled, thanks Johannes.

Re: Setting TX power on a monitoring interface

2017-11-27 Thread Peter Große
On Mon, 27 Nov 2017 12:43:13 +0100 Johannes Berg wrote: > > What would be the correct way of fixing it? Maybe I can provide a patch. > > That's a really good question :-) > > I think if the driver has WANT_MONITOR_VIF, then we can pass that >

Re: Build regressions/improvements in v4.15-rc1

2017-11-27 Thread Kalle Valo
Geert Uytterhoeven writes: > On Mon, Nov 27, 2017 at 11:01 AM, Geert Uytterhoeven > wrote: >> Below is the list of build error/warning regressions/improvements in >> v4.15-rc1[1] compared to v4.14[2]. >> >> Summarized: >> - build errors: +2/-5 > >>

Re: [RFC] cfg80211: Implement Multiple BSSID capability in scanning

2017-11-27 Thread Johannes Berg
Hi, > As you pointed out the use cases for having vendor elements in MBSSID > subelements, what is > your suggestion to identify and process the vendor elements? Is a new version of this patch hinging only on this? We'd love to have a fixed-up one :-) johannes

Re: [RFC PATCH 2/2] nl80211: implement beacon change notifier

2017-11-27 Thread Johannes Berg
On Wed, 2017-11-15 at 18:35 +0300, Sergey Matyukevich wrote: > In our case, we are experimenting with applications running along with > hostapd and enabling band steering and client roaming functionality. > As I mentioned, various approaches are being examined, including > both pure nl80211-based

Re: What would it take to get WDS working with channel contexts?

2017-11-27 Thread Johannes Berg
On Fri, 2017-11-17 at 08:46 -0800, Ben Greear wrote: > It looks like my options are to hack the mac80211 stack to be minimally > functional with WDS and channel-contexts, or to hack ath10k driver to > disable chan-tx in order to try to fix the ath10k firmware WDS issues. > > I'd guess the former

[PATCH] ath10k: use 64-bit crash dump timestamps

2017-11-27 Thread Arnd Bergmann
The dump format uses 64-bit timestamps already, but calling getnstimeofday() only returns a 32-bit number on 32-bit architectures, so that will overflow in y2038. This changes it to use ktime_get_real_ts64() instead. Signed-off-by: Arnd Bergmann ---

[PATCH] wlcore: use boottime for fw time sync

2017-11-27 Thread Arnd Bergmann
Using getnstimeofday()/timespec_to_ns() causes an overflow on 32-bit architectures in 2038, and may suffer from time jumps due to settimeofday() or leap seconds. I don't see a reason why this needs to be UTC, so either monotonic or boot time would be better here. Assuming that the fw time keeps

Re: Setting TX power on a monitoring interface

2017-11-27 Thread Johannes Berg
On Mon, 2017-11-20 at 17:34 +0100, Peter Große wrote: > Hi everyone. > > The iw tool allows to set TX power settings on network interfaces. > > If I try to set the TX power level on a _monitor_ interface, I get > a kernel warning: > > [ cut here ] > WARNING: CPU: 0

pull-request: mac80211 2017-11-27

2017-11-27 Thread Johannes Berg
Hi Dave, Here are a few more fixes, one of which fixes the crash Florian reported which I think is the same that zero-day reported. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit a13e8d418f3cb9d0b4efa6e744b8b23c0e3cdfe8: Merge tag

Re: Build regressions/improvements in v4.15-rc1

2017-11-27 Thread Geert Uytterhoeven
On Mon, Nov 27, 2017 at 11:01 AM, Geert Uytterhoeven wrote: > Below is the list of build error/warning regressions/improvements in > v4.15-rc1[1] compared to v4.14[2]. > > Summarized: > - build errors: +2/-5 > [1] >