Re: [PATCH 0/2] enable 802.11w in mt7601u driver

2018-07-09 Thread Jakub Kicinski
On Mon, 9 Jul 2018 12:20:25 +0200, Lorenzo Bianconi wrote: > Lorenzo Bianconi (1): > mt7601u: use sw encryption for hw unsupported ciphers > > Davide Caratti (1): > mt7601u: expose 802.11w support > > drivers/net/wireless/mediatek/mt7601u/init.c | 1 + >

Re: [PATCH v2 11/24] mtd: rawnand: sunxi: Make sure ret is initialized in sunxi_nfc_read_byte()

2018-07-09 Thread Boris Brezillon
On Mon, 9 Jul 2018 22:35:56 +0200 Arnd Bergmann wrote: > On Mon, Jul 9, 2018 at 10:09 PM, Boris Brezillon > wrote: > > Fixes the following smatch warning: > > > > drivers/mtd/nand/raw/sunxi_nand.c:551 sunxi_nfc_read_byte() error: > > uninitialized symbol 'ret'. > > > > Signed-off-by: Boris

Re: [PATCH v2 00/24] mtd: rawnand: Improve compile-test coverage

2018-07-09 Thread Arnd Bergmann
On Mon, Jul 9, 2018 at 10:09 PM, Boris Brezillon wrote: > Hello, > > This is an attempt at adding "depends || COMPILE_TEST" to all NAND > drivers that have no compile-time dependencies on arch > features/headers. > > This will hopefully help us (NAND/MTD maintainers) in detecting build > issues

Re: [PATCH v2 11/24] mtd: rawnand: sunxi: Make sure ret is initialized in sunxi_nfc_read_byte()

2018-07-09 Thread Arnd Bergmann
On Mon, Jul 9, 2018 at 10:09 PM, Boris Brezillon wrote: > Fixes the following smatch warning: > > drivers/mtd/nand/raw/sunxi_nand.c:551 sunxi_nfc_read_byte() error: > uninitialized symbol 'ret'. > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/raw/sunxi_nand.c | 2 +- > 1 file

[PATCH v2 02/24] mtd: rawnand: atmel: Add an __iomem cast on gen_pool_dma_alloc() call

2018-07-09 Thread Boris Brezillon
gen_pool_dma_alloc() return type is void *, while internally, the memory region exposed by the sram driver has been mapped with ioremap(). Add a void * to void __iomem * cast to make sparse happy. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/atmel/nand-controller.c | 6 +++--- 1

[PATCH v2 03/24] mtd: rawnand: atmel: Allow selection of this driver when COMPILE_TEST=y

2018-07-09 Thread Boris Brezillon
It just makes NAND maintainers' life easier by allowing them to compile-test this driver without having ARCH_AT91 enabled. We also need to add a dependency on HAS_IOMEM to make sure the driver compiles correctly. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/Kconfig | 3 ++- 1 file

[PATCH v2 00/24] mtd: rawnand: Improve compile-test coverage

2018-07-09 Thread Boris Brezillon
Hello, This is an attempt at adding "depends || COMPILE_TEST" to all NAND drivers that have no compile-time dependencies on arch features/headers. This will hopefully help us (NAND/MTD maintainers) in detecting build issues earlier. Unfortunately we still have a few drivers that can't easily be

[PATCH v2 01/24] mtd: rawnand: atmel: Use uintptr_t casts instead of unsigned int

2018-07-09 Thread Boris Brezillon
When casting a pointer to an unsigned in, uintptr_t should be used to cope with the pointer size differences between 32-bit and 64-bit architectures. This is needed if we want to allow compilation of this driver when COMPILE_TEST=y. Reported-by: Stephen Rothwell Signed-off-by: Boris Brezillon

[PATCH v2 18/24] mtd: rawnand: fsl_ifc: Allow selection of this driver when COMPILE_TEST=y

2018-07-09 Thread Boris Brezillon
It just makes maintainers' life easier by allowing them to compile-test this driver without having FSL_SOC, ARCH_LAYERSCAPE or SOC_LS1021A enabled. We also need to add a dependency on HAS_IOMEM to make sure the driver compiles correctly. Signed-off-by: Boris Brezillon ---

[PATCH v2 06/24] mtd: rawnand: orion: Allow selection of this driver when COMPILE_TEST=y

2018-07-09 Thread Boris Brezillon
It just makes NAND maintainers' life easier by allowing them to compile-test this driver without having PLAT_ORION enabled. We add a dependency on HAS_IOMEM to make sure the driver compiles correctly, and a dependency on !IA64 because the {read,write}s{bwl}() accessors are not defined for this

[PATCH v2 15/24] mtd: rawnand: fsmc: Allow selection of this driver when COMPILE_TEST=y

2018-07-09 Thread Boris Brezillon
It just makes NAND maintainers' life easier by allowing them to compile-test this driver without having PLAT_SPEAR, ARCH_NOMADIK, ARCH_U8500 or MACH_U300 enabled. We also need to add a dependency on HAS_IOMEM to make sure the driver compiles correctly. Signed-off-by: Boris Brezillon ---

[PATCH v2 05/24] mtd: rawnand: orion: Avoid direct inclusion of asm headers

2018-07-09 Thread Boris Brezillon
Include linux/sizes.h instead of asm/sizes.h to make code completely arch independent. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/orion_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/orion_nand.c b/drivers/mtd/nand/raw/orion_nand.c

[PATCH v2 20/24] mtd: rawnand: txx9ndfmc: Allow selection of this driver when COMPILE_TEST=y

2018-07-09 Thread Boris Brezillon
It just makes NAND maintainers' life easier by allowing them to compile-test this driver without having SOC_TX4938 or SOC_TX4939 enabled. We also need to add a dependency on HAS_IOMEM to make sure the driver compiles correctly. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/Kconfig |

[PATCH v2 16/24] memory: fsl_ifc: Allow selection of this driver when COMPILE_TEST=y

2018-07-09 Thread Boris Brezillon
It just makes maintainers' life easier by allowing them to compile-test this driver without having FSL_SOC, ARCH_LAYERSCAPE or SOC_LS1021A enabled. We also need to add a dependency on HAS_IOMEM to make sure the driver compiles correctly. Signed-off-by: Boris Brezillon ---

[PATCH v2 22/24] mtd: rawnand: jz4740: Allow selection of this driver when COMPILE_TEST=y

2018-07-09 Thread Boris Brezillon
It just makes NAND maintainers' life easier by allowing them to compile-test this driver without having MACH_JZ4740 enabled. We also need to add a dependency on HAS_IOMEM to make sure the driver compiles correctly. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/Kconfig | 3 ++- 1 file

[PATCH v2 21/24] MIPS: jz4740: Move jz4740_nand.h header to include/linux/platform_data/jz4740

2018-07-09 Thread Boris Brezillon
This way we will be able to compile the jz4740_nand driver when COMPILE_TEST=y. Signed-off-by: Boris Brezillon --- arch/mips/jz4740/board-qi_lb60.c | 3 ++- drivers/mtd/nand/raw/jz4740_nand.c| 2 +- .../mach-jz4740 =>

[PATCH v2 17/24] mtd: rawnand: fsl_ifc: Add an __iomem specifier on eccstat_regs

2018-07-09 Thread Boris Brezillon
The local eccstat_regs variable in fsl_ifc_run_command() is missing an __iomem specifier, and sparce complains about that. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/fsl_ifc_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 23/24] mtd: rawnand: jz4780: Drop the dependency on MACH_JZ4780

2018-07-09 Thread Boris Brezillon
This MACH_JZ4780 dependency is taken care of by JZ4780_NEMC, no need to repeat it here. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig index

[PATCH v2 12/24] mtd: rawnand: sunxi: Allow selection of this driver when COMPILE_TEST=y

2018-07-09 Thread Boris Brezillon
It just makes NAND maintainers' life easier by allowing them to compile-test this driver without having ARCH_SUNXI enabled. We also need to add a dependency on HAS_IOMEM to make sure the driver compiles correctly. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/Kconfig | 3 ++- 1 file

[PATCH v2 19/24] MIPS: txx9: Move the ndfc.h header to include/linux/platform_data/txx9

2018-07-09 Thread Boris Brezillon
This way we will be able to compile the ndfmc driver when COMPILE_TEST=y. Signed-off-by: Boris Brezillon --- arch/mips/txx9/generic/setup.c | 2 +- arch/mips/txx9/generic/setup_tx4938.c | 2 +-

[PATCH v2 10/24] mtd: rawnand: sunxi: Add an U suffix to NFC_PAGE_OP definition

2018-07-09 Thread Boris Brezillon
Fixes the "warning: large integer implicitly truncated to unsigned type [-Woverflow]" warning when compiled for x86. This is needed in order to allow compiling this driver when COMPILE_TEST=y. Reported-by: Stephen Rothwell Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/sunxi_nand.c |

[PATCH v2 13/24] mtd: rawnand: fscm: Avoid collision on PC def when compiling for MIPS

2018-07-09 Thread Boris Brezillon
We want to allow this driver to be selected when COMPILE_TEST=y, this means the driver can be compiled for any arch, including MIPS. When compiling this driver for MIPS, we end up with a collision on the 'PC' macro definition (also defined in arch/mips/include/asm/ptrace.h). Prefix the fsmc one

[PATCH v2 14/24] mtd: rawnand: fsmc: Use uintptr_t casts instead of unsigned ones

2018-07-09 Thread Boris Brezillon
uintptr_t should be used when casting a pointer to an unsigned int so that the code compiles without warnings even on 64-bit architectures. This is needed if we want to allow selection of this driver when COMPILE_TEST=y. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/fsmc_nand.c | 4

[PATCH v2 08/24] mtd: rawnand: davinci: Use uintptr_t casts instead of unsigned ones

2018-07-09 Thread Boris Brezillon
uintptr_t should be used when casting a pointer to an unsigned int so that the code compiles without warnings even on 64-bit architectures. This is needed if we want to allow selection of this driver when COMPILE_TEST=y. Reported-by: Stephen Rothwell Signed-off-by: Boris Brezillon ---

[PATCH v2 09/24] mtd: rawnand: davinci: Allow selection of this driver when COMPILE_TEST=y

2018-07-09 Thread Boris Brezillon
It just makes NAND maintainers' life easier by allowing them to compile-test this driver without having ARCH_DAVINCI or ARCH_KEYSTONE enabled. We also need to add a dependency on HAS_IOMEM to make sure the driver compiles correctly. Signed-off-by: Boris Brezillon ---

[PATCH v2 04/24] mtd: rawnand: s3c2410: Allow selection of this driver when COMPILE_TEST=y

2018-07-09 Thread Boris Brezillon
It just makes NAND maintainers' life easier by allowing them to compile-test this driver without having ARCH_S3C24XX or ARCH_S3C64XX enabled. We add a dependency on HAS_IOMEM to make sure the driver compiles correctly, and a dependency on !IA64 because the {read,write}s{bwl}() accessors are not

[PATCH v2 07/24] mtd: rawnand: davinci: Stop doing iomem pointer <-> u32 conversions

2018-07-09 Thread Boris Brezillon
There is no point in doing this sort of conversion since pointers can we can replace |= by += operations which are perfectly valid on pointers. This is done in preparation of COMPILE_TEST addition to the NAND_DAVINCI Kconfig entry, since building for x86 generates a several warnings because of

[PATCH v2 11/24] mtd: rawnand: sunxi: Make sure ret is initialized in sunxi_nfc_read_byte()

2018-07-09 Thread Boris Brezillon
Fixes the following smatch warning: drivers/mtd/nand/raw/sunxi_nand.c:551 sunxi_nfc_read_byte() error: uninitialized symbol 'ret'. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/raw/sunxi_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[RFC v2 4/4] ath9k: Switch to mac80211 TXQ scheduling and airtime APIs

2018-07-09 Thread Toke Høiland-Jørgensen
This moves the ath9k driver to use the mac80211 TXQ scheduling and airtime accounting APIs, removing the corresponding state tracking inside the driver. Signed-off-by: Toke Høiland-Jørgensen --- drivers/net/wireless/ath/ath9k/ath9k.h | 14 -- drivers/net/wireless/ath/ath9k/debug.c |

[RFC v2 2/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-07-09 Thread Toke Høiland-Jørgensen
This adds airtime accounting and scheduling to the mac80211 TXQ scheduler. A new callback, ieee80211_sta_register_airtime(), is added that drivers can call to report airtime usage for stations, and an extended feature flag is added that drivers can use to opt into airtime fairness scheduling.

[RFC v2 3/4] cfg80211: Add airtime statistics and settings

2018-07-09 Thread Toke Høiland-Jørgensen
This adds airtime statistics to the cfg80211 station dump, and also adds a new parameter to set the airtime weight of each station. The latter allows userspace to implement policies for different stations by varying their weights. Signed-off-by: Toke Høiland-Jørgensen --- include/net/cfg80211.h

[RFC v2 1/4] mac80211: Add TXQ scheduling API

2018-07-09 Thread Toke Høiland-Jørgensen
This adds an API to mac80211 to handle scheduling of TXQs. The API consists of two new functions: ieee80211_next_txq() and ieee80211_schedule_txq(). The former returns the next TXQ that should be scheduled, and is how the driver gets a queue to pull packets from. The latter is called internally by

[RFC v2 0/4] Move TXQ scheduling into mac80211

2018-07-09 Thread Toke Høiland-Jørgensen
This is an updated version of my previous patch series to move TXQ scheduling into mac80211, allowing more drivers to take advantage of airtime fairness scheduling. This version keeps compatibility with the old wake_tx_queue API, so drivers can be ported to the new API one at a time. For now, only

[PATCH 2/2] mt7601u: expose 802.11w support

2018-07-09 Thread Lorenzo Bianconi
From: Davide Caratti Set MFP_CAPABLE bit in hw flag capabilities exported by the driver Signed-off-by: Davide Caratti Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt7601u/init.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 1/2] mt7601u: use sw encryption for hw unsupported ciphers

2018-07-09 Thread Lorenzo Bianconi
Fall back to software encryption for hw unsupported ciphers in order to enable 802.11w Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt7601u/main.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt7601u/main.c

[PATCH 0/2] enable 802.11w in mt7601u driver

2018-07-09 Thread Lorenzo Bianconi
Lorenzo Bianconi (1): mt7601u: use sw encryption for hw unsupported ciphers Davide Caratti (1): mt7601u: expose 802.11w support drivers/net/wireless/mediatek/mt7601u/init.c | 1 + drivers/net/wireless/mediatek/mt7601u/main.c | 11 +++ 2 files changed, 12 insertions(+) -- 2.17.1

Re: [PATCH] mac80211: restrict delayed tailroom needed decrement

2018-07-09 Thread Johannes Berg
On Mon, 2018-07-09 at 15:07 +0530, Manikanta Pubbisetty wrote: > > I think you should do > > > > ieee80211_key_destroy(..., type == STATION); > > Even this would boil down to the same behavior, no? Yes, but I think it's easier to understand than thinking "ok this will delay" when you pass the

Re: [PATCH] mac80211: restrict delayed tailroom needed decrement

2018-07-09 Thread Manikanta Pubbisetty
On 7/9/2018 2:56 PM, Johannes Berg wrote: On Mon, 2018-07-09 at 14:54 +0530, Manikanta Pubbisetty wrote: This describes a scenario where there's *unnecessary* work done, but not really one where we have something that's *incorrect*? To me at least doing unnecessary things is incorrect

Re: [PATCH] mac80211: restrict delayed tailroom needed decrement

2018-07-09 Thread Johannes Berg
On Mon, 2018-07-09 at 14:54 +0530, Manikanta Pubbisetty wrote: > > This describes a scenario where there's *unnecessary* work done, but not > > really one where we have something that's *incorrect*? > > > > To me at least doing unnecessary things is incorrect :-D, may be we can > change the

Re: [PATCH] mac80211: restrict delayed tailroom needed decrement

2018-07-09 Thread Manikanta Pubbisetty
For example, let's consider the case of a 4-addr client connecting to an AP for which AP_VLAN interface is also created, let the initial value for tailroom_needed on the AP be 1. * 4-addr client connects to the AP (AP: tailroom_needed = 1) * AP will clear old keys, delay decrement of

Re: [PATCH] mac80211: restrict delayed tailroom needed decrement

2018-07-09 Thread Johannes Berg
On Mon, 2018-07-09 at 14:28 +0530, Manikanta Pubbisetty wrote: > As explained in ieee80211_delayed_tailroom_dec(), during roam, > keys of the old AP will be destroyed and new keys will be > installed. Deletion of the old key causes > crypto_tx_tailroom_needed_cnt to go from 1 to 0 and the new key

[PATCH] mac80211: restrict delayed tailroom needed decrement

2018-07-09 Thread Manikanta Pubbisetty
As explained in ieee80211_delayed_tailroom_dec(), during roam, keys of the old AP will be destroyed and new keys will be installed. Deletion of the old key causes crypto_tx_tailroom_needed_cnt to go from 1 to 0 and the new key installation causes a transition from 0 to 1. Whenever

Re: [PATCH v2] mac80211: Fix wlan freezes under load at rekey

2018-07-09 Thread Johannes Berg
Hi, > I'll try that, but will probably take another week. My main main work > station got severe file system corruption, forcing me to reinstall it > from scratch. I suspect it was something in the wireless testing kernel > 4.18-rc1 (944ae08d4e71) related to either btrfs or the ssd disk but >