Re: [RFC v4 08/13] rtw88: debug files

2018-10-13 Thread Joe Perches
On Sat, 2018-10-13 at 18:23 +0300, Kalle Valo wrote: > Joe Perches writes: > > > On Sat, 2018-10-13 at 17:00 +0800, yhchu...@realtek.com wrote: > > > From: Yan-Hsuan Chuang > > [] > > > diff --git a/drivers/net/wireless/realtek/rtw88/debug.c > > > b/drivers/net/wireless/realtek/rtw88/debug.c > >

Re: [PATCH] ath10k: htt_rx: Fix signedness bug in ath10k_update_per_peer_tx_stats

2018-10-13 Thread Gustavo A. R. Silva
On 10/13/18 7:23 PM, Kalle Valo wrote: > > Patch applied to ath-next branch of ath.git, thanks. > > 9d9cdbf3f9ed ath10k: htt_rx: fix signedness bug in > ath10k_update_per_peer_tx_stats > Thank you, Kalle. -- Gustavo

Re: [RFC v3 01/12] rtw88: main files

2018-10-13 Thread Kalle Valo
Tony Chuang writes: >> > +static void rtw_watch_dog_work(struct work_struct *work) >> > +{ >> > + struct rtw_dev *rtwdev = container_of(work, struct rtw_dev, >> > +watch_dog_work.work); >> > + struct rtw_vif *rtwvif; >> > + >> > + if (!rtw_flag_check(rtw

Re: [PATCH v5 1/6] ath10k: Add qmi service helpers for wcn3990 qmi client

2018-10-13 Thread Kalle Valo
Govind Singh wrote: > WLAN qmi server running in Q6 exposes host to target > cold boot qmi handshakes. Add WLAN QMI service helpers > for ath10k wcn3990 qmi client. > > Signed-off-by: Govind Singh > Reviewed-by: Bjorn Andersson > Acked-by: Niklas Cassel > Reviewed-by: Brian Norris > Signed-o

Re: [PATCH] wil6210: fix debugfs_simple_attr.cocci warnings

2018-10-13 Thread Kalle Valo
YueHaibing wrote: > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_fi

Re: [PATCH] ath9k: fix RX_STAT_INC() etc macros

2018-10-13 Thread Kalle Valo
Arnd Bergmann wrote: > A couple of macros that deal with statistics in ath9k rely on the > declaration of the 'sc' variable, which they dereference. > > However, when the statistics are disabled, the new instance in > ath_cmn_process_fft() causes a warning for an unused variable: > > drivers/ne

Re: [PATCH] ath10k: htt: remove some dead code

2018-10-13 Thread Kalle Valo
Dan Carpenter wrote: > We added an unnecessary condition here in commit a904417fc876 ("ath10k: > add extended per sta tx statistics support"). "legacy_rate_idx" is a u8 > so it can't be negative. The caller doesn't pass negatives either. I > have deleted this code. > > Signed-off-by: Dan Carp

Re: [PATCH V3] ath10k: allocate small size dma memory in ath10k_pci_diag_write_mem

2018-10-13 Thread Kalle Valo
Carl Huang wrote: > ath10k_pci_diag_write_mem may allocate big size of the dma memory > based on the parameter nbytes. Take firmware diag download as > example, the biggest size is about 500K. In some systems, the > allocation is likely to fail because it can't acquire such a large > contiguous d

Re: [PATCH] ath10k: Add peer flush in ath10k_flush for STATION

2018-10-13 Thread Kalle Valo
Wen Gong wrote: > In the noisy environment, if there are packets in the queue and can't > send out, the suspend timing will be more than 5 seconds due to the wait, > flush the queue to optimize the suspend timing, and let the upper layer to > retry the packets after resume. > > Tested with QCA61

Re: [PATCH] ath10k: remove unnecessary comparison of unsigned integer with < 0

2018-10-13 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > There is no need to compare *ps_state_enable* with < 0 because > such variable is of type u8 (8 bits, unsigned), making it > impossible to hold a negative value. > > Fix this by removing such comparison. > > Addresses-Coverity-ID: 1473921 ("Unsigned compared again

Re: [PATCH] ath10k: htt_rx: Fix signedness bug in ath10k_update_per_peer_tx_stats

2018-10-13 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Currently, the error handling for the call to function > ath10k_get_legacy_rate_idx() doesn't work because > *rate_idx* is of type u8 (8 bits, unsigned), which > makes it impossible for it to hold a value less > than 0. > > Fix this by changing the type of variable

Re: [PATCH v3] ath10k: management tx ack rssi capability check

2018-10-13 Thread Kalle Valo
Balaji Pothunoori wrote: > Adding WMI service check for management tx ack rssi support; this is > done to maintain common avg ack signal in user level for both data > and management tx ack packet. > > Tested on QCA4019(fw version-10.4-3.2.1-00063). > > Signed-off-by: Balaji Pothunoori > Signed

Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2018-10-13 Thread Kalle Valo
Wen Gong wrote: > For WoWLAN support it is expected to support wake up based on discovery of > one or more known SSIDs. This is the WIPHY_WOWLAN_NET_DETECT feature, > which shows up as an NL80211 feature flag. > > This shows up in 'iw phy' as: > > WoWLAN support: > * wake up on network detectio

Re: [PATCH] ath10k: Set probe request oui during driver start

2018-10-13 Thread Kalle Valo
Rakesh Pillai wrote: > Currently the wmi command for setting probe request > oui, needed for mac randomization, is sent during > the mac register. At this time, during the driver > init the wmi has already been detached. This can > cause unexpected behavior since the firmware is > already down an

Re: [PATCH] ath10k: Fix possible out of bound access of ath10k_rates array

2018-10-13 Thread Kalle Valo
Sriram R wrote: > While using 'ath10k_mac_get_rate_hw_value()' to obtain the hw value > from the passed bitrate, there is a chance of out of bound array access > when wrong bitrate is passed. This is fixed by comparing the bitrates > within the correct size of the ath10k_rates array. > > Fixes c

Re: [PATCH] rtl8xxxu: Remove set but not used variables 'usedesc40' and 'seq_number'

2018-10-13 Thread Kalle Valo
YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function > 'rtl8xxxu_tx': > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4925:7: warning: > variable 'usedesc40' set but not used [-Wunused-but-set-variable

Re: [PATCH 1/5] qtnfmac: use 'help' in Kconfig

2018-10-13 Thread Kalle Valo
Sergey Matyukevich wrote: > Fix checkpatch warning: use preferred 'help' option in Kconfig. > > Signed-off-by: Sergey Matyukevich 3 patches applied to wireless-drivers-next.git, thanks. db62abe51853 qtnfmac: use 'help' in Kconfig b458a033ca2f qtnfmac: use SPDX identifier for pcie bus layer fi

Re: [PATCH v2] libertas: return errno from lbs_add_card()

2018-10-13 Thread Kalle Valo
Lubomir Rintel wrote: > This makes the error handling somewhat cleaner -- lbs_add_card() does no > logner throw away the errno and lets its callers propagate it. > > Signed-off-by: Lubomir Rintel Patch applied to wireless-drivers-next.git, thanks. bbc2a101f06b libertas: return errno from lbs_

Re: [PATCH] libertas: don't set URB_ZERO_PACKET on IN USB transfer

2018-10-13 Thread Kalle Valo
Lubomir Rintel wrote: > The USB core gets rightfully upset: > > usb 1-1: BOGUS urb flags, 240 --> 200 > WARNING: CPU: 0 PID: 60 at drivers/usb/core/urb.c:503 > usb_submit_urb+0x2f8/0x3ed > Modules linked in: > CPU: 0 PID: 60 Comm: kworker/0:3 Not tainted 4.19.0-rc6-00319-g5206d00a45c7

Re: [PATCH] iwlegacy: Add a lock assertion in il4965_send_rxon_assoc()

2018-10-13 Thread Kalle Valo
Jia-Ju Bai wrote: > The variables il->staging.filter_flags, rxon1->filter_flags and > rxon2->filter_flags need to be protected by the mutex lock il->mutex. > This patch adds a lock assertion of il->mutex to check whether > this lock is held. > > Signed-off-by: Jia-Ju Bai > Acked-by: Stanislaw

Re: [PATCH v4] brcmsmac: AP mode: update beacon when TIM changes

2018-10-13 Thread Kalle Valo
Ali MJ Al-Nasrawy wrote: > Beacons are not updated to reflect TIM changes. This is not compliant with > power-saving client stations as the beacons do not have valid TIM and can > cause the network to stall at random occasions and to have highly variable > latencies. > Fix it by updating beacon t

pull request: mt76 2018-10-13 v2

2018-10-13 Thread Felix Fietkau
Hi Kalle, Here's another large batch of mt76 code cleanup / deduplication / fixes v2: add missing S-o-b. - Felix The following changes since commit c894696188d5c2af1e636e458190e80c53fb893d: rtlwifi: rtl8821ae: replace _rtl8821ae_mrate_idx_to_arfr_id with generic version (2018-10-13 15:00:37

Re: pull request: mt76 2018-10-13

2018-10-13 Thread Kalle Valo
Felix Fietkau writes: > Hi Kalle, > > Here's another batch of mt76 code cleanup / deduplication / fixes > > - Felix > > The following changes since commit c894696188d5c2af1e636e458190e80c53fb893d: > > rtlwifi: rtl8821ae: replace _rtl8821ae_mrate_idx_to_arfr_id with generic > version (2018-10-1

[PATCH] rsi: fix spelling mistake "Initialzing" -> "Initializing"

2018-10-13 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in rsi_dbg debug message Signed-off-by: Colin Ian King --- drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio_ops.c b/drivers/net/wireles

Re: [RFC v4 08/13] rtw88: debug files

2018-10-13 Thread Kalle Valo
Joe Perches writes: > On Sat, 2018-10-13 at 17:00 +0800, yhchu...@realtek.com wrote: >> From: Yan-Hsuan Chuang > [] >> diff --git a/drivers/net/wireless/realtek/rtw88/debug.c >> b/drivers/net/wireless/realtek/rtw88/debug.c > [] >> +#ifdef CONFIG_RTW88_DEBUG >> + >> +void __rtw_dbg(struct rtw_dev

pull request: mt76 2018-10-13

2018-10-13 Thread Felix Fietkau
Hi Kalle, Here's another batch of mt76 code cleanup / deduplication / fixes - Felix The following changes since commit c894696188d5c2af1e636e458190e80c53fb893d: rtlwifi: rtl8821ae: replace _rtl8821ae_mrate_idx_to_arfr_id with generic version (2018-10-13 15:00:37 +0300) are available in the

Re: [RFC v4 08/13] rtw88: debug files

2018-10-13 Thread Joe Perches
On Sat, 2018-10-13 at 17:00 +0800, yhchu...@realtek.com wrote: > From: Yan-Hsuan Chuang [] > diff --git a/drivers/net/wireless/realtek/rtw88/debug.c > b/drivers/net/wireless/realtek/rtw88/debug.c [] > +#ifdef CONFIG_RTW88_DEBUG > + > +void __rtw_dbg(struct rtw_dev *rtwdev, const char *fmt, ...) >

Re: [PATCH 5/5] qtnfmac: add support for Topaz chipsets

2018-10-13 Thread Kalle Valo
Sergey Matyukevich writes: > This patch adds support for QSR1000/QSR2000 family of chipsets > to qtnfmac_pcie platform driver. > > QSR1000/QSR2000 (aka Topaz) is a family of 80MHz, 11ac Wave2, > 4x4/2x4/2x2 chips, including single and dual band devices. > Depending on specific chip model and firm

Re: [PATCH] rtlwifi: rtl8821ae: replace _rtl8821ae_mrate_idx_to_arfr_id with generic version

2018-10-13 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > Function _rtl8821ae_mrate_idx_to_arfr_id is functionally identical to > the generic version rtl_mrate_idx_to_arfr_id, so remove > _rtl8821ae_mrate_idx_to_arfr_id and use the generic one instead. > > This also fixes a missing break statement found b

Re: [PATCH] rtlwifi: rtl8821ae: add in a missing break in switch statement

2018-10-13 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > The switch case RATR_INX_WIRELESS_MC has a missing break, this seems > to be unintentional as the setting of variable ret gets overwritten > when the case falls through to the following RATR_INX_WIRELESS_AC_5N > case. Fix this by adding in the missi

Re: [PATCH] iwlwifi: mvm: check return value of rs_rate_from_ucode_rate()

2018-10-13 Thread Kalle Valo
Luca Coelho wrote: > From: Luca Coelho > > The rs_rate_from_ucode_rate() function may return -EINVAL if the rate > is invalid, but none of the callsites check for the error, potentially > making us access arrays with index IWL_RATE_INVALID, which is larger > than the arrays, causing an out-of-b

Re: pull-request: iwlwifi-next 2018-10-12

2018-10-13 Thread Kalle Valo
Luca Coelho writes: > Hi Kalle, > > This is the fourth batch of patches intended for v4.20. This includes > only the last patchset I sent. Usual development work, mostly queue > handling cleanups. More details about the contents in the tag > description. > > I have sent this out before and kbu

Re: [RFC v3] cfg80211: add peer measurement with FTM API

2018-10-13 Thread Kalle Valo
Johannes Berg writes: > From: Johannes Berg > > Add a new "peer measurement" API, that can be used to measure > certain things related to a peer. Right now, only implement > FTM (flight time measurement) over it, but the idea is that > it'll be extensible to also support measuring the necessary

Re: [PATCH v4 4/8] rt2800: fix registers init for MT7620

2018-10-13 Thread Kalle Valo
Stanislaw Gruszka writes: > There is duplicated 'if (rt2x00_rt(rt2x00dev, RT6352))' entry that > causes we do not perform register initialization for RT6352 (MT7620 > SOCs) in correct branch. Fix this and disable registers initialization > that is specific to particular MT7620 revision. > > Signe

[PATCH] linux-firmware: add firmware for mt7610e

2018-10-13 Thread Lorenzo Bianconi
Add binary firmware for mt7610e based devices Signed-off-by: Lorenzo Bianconi --- WHENCE | 3 ++- mediatek/mt7610e.bin | Bin 0 -> 80680 bytes 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 mediatek/mt7610e.bin diff --git a/WHENCE b/WHENCE index b480062..b49

[RFC v4 13/13] rtw88: add support for Realtek 802.11ac wireless chips

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang Signed-off-by: Yan-Hsuan Chuang --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9ad052a..138515b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12546,6 +12546,14 @@ T: git git://git.kernel.org/pub/scm/linux/

[RFC v4 05/13] rtw88: mac files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang mac files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/mac.c | 1045 ++ drivers/net/wireless/realtek/rtw88/mac.h | 35 + 2 files changed, 1080 insertions(+) create mode 1

[RFC v4 06/13] rtw88: fw and efuse files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang fw and efuse files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/efuse.c | 150 +++ drivers/net/wireless/realtek/rtw88/efuse.h | 53 +++ drivers/net/wireless/realtek/rtw88/fw.c| 655 +++

[RFC v4 01/13] rtw88: main files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang main files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/mac80211.c | 478 ++ drivers/net/wireless/realtek/rtw88/main.c | 1168 + drivers/net/wireless/realtek/rtw88/

[RFC v4 03/13] rtw88: hci files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang hci files for Realtek 802.11ac wireless network chips For now there is only PCI bus supported by rtwlan, in the future it will also have USB/SDIO Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/hci.h | 211 ++ drivers/net/wireless/realtek/rtw

[RFC v4 08/13] rtw88: debug files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang debug files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/debug.c | 652 + drivers/net/wireless/realtek/rtw88/debug.h | 43 ++ 2 files changed, 695 insertions(+) create mod

[RFC v4 11/13] rtw88: 8822C init table

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang 8822C init table for chip files Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- .../net/wireless/realtek/rtw88/rtw8822c_table.c| 4150 1 file changed, 4150 insertions(+) create mode 100644 drivers/net/wireless/realtek

[RFC v4 07/13] rtw88: phy files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang phy files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/phy.c | 1679 ++ drivers/net/wireless/realtek/rtw88/phy.h | 125 +++ 2 files changed, 1804 insertions(+) create mode

[RFC v4 00/13] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang This is a new mac80211 driver for Realtek 802.11ac wireless network chips. rtw88 supports 8822BE and 8822CE chips, and will be able to support multi-vif combinations in run-time. For now, only PCI bus is supported, but rtw88 was originally designed to optionally support th

[RFC v4 09/13] rtw88: chip files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang chip files Realtek 802.11ac wireless network chips 8822B & 8822C series files Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/rtw8822b.c | 1588 drivers/net/wireless/realtek/rtw88/rtw8822b.h | 155 ++ .../net/wireles

[RFC v4 04/13] rtw88: trx files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang trx files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/rx.c | 153 ++ drivers/net/wireless/realtek/rtw88/rx.h | 41 + drivers/net/wireless/realtek/rtw88/tx.c | 273

[RFC v4 12/13] rtw88: Kconfig & Makefile

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang Kconfig & Makefile for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/Kconfig| 1 + drivers/net/wireless/realtek/Makefile | 1 + drivers/net/wireless/realtek/rtw88/Kconfig | 55 +++

[RFC v4 02/13] rtw88: core files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang core files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/ps.c | 168 +++ drivers/net/wireless/realtek/rtw88/ps.h | 20 ++ drivers/net/wireless/realtek/rtw88/regd.c | 328 +++

Re: [Make-wifi-fast] [PATCH RFC v5 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-10-13 Thread Dave Taht
On Fri, Oct 12, 2018 at 12:38 AM Rajkumar Manoharan wrote: > > On 2018-10-11 03:38, Toke Høiland-Jørgensen wrote: > > Rajkumar Manoharan writes: > > > >> Hmm... mine is bit different. txqs are refilled only once for all > >> txqs. > >> It will give more opportunity for non-served txqs. drv_wake_t