Re: [PATCH 5.4 regression fix] brcmfmac: Fix brcmf_cfg80211_get_channel returning uninitialized fields

are added to the struct. Guess this warrants a Fixes: tag and ... Acked-by: Arend van Spriel Signed-off-by: Hans de Goede --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211

Re: [PATCH V3 0/8] nl80211: add 6GHz band support

+ linux-wireless On September 19, 2019 8:25:57 PM Jeff Johnson wrote: On 2019-08-02 04:30, Arend van Spriel wrote: Changing to formal patch series instead of RFC. In 802.11ax D4.0 a new band has been proposed. This series contains changes to cfg80211 for supporting this band. With 2GHz

Re: [PATCH 04/11] wil6210: fix PTK re-key race

On 9/12/2019 11:04 PM, Alexander Wetzel wrote: Hi Denis, I don't know anything about the driver here but in mac80211 the idea to avoid the race is to simply flush the queues prior deleting the outgoing key. Maybe a silly question, but what does flushing the queue mean in this context?  I

Re: [PATCH 04/11] wil6210: fix PTK re-key race

On 9/10/2019 3:23 PM, Kalle Valo wrote: Maya Erez wrote: Fix a race between cfg80211 add_key call and transmitting of 4/4 EAP packet. In case the transmit is delayed until after the add key takes place, message 4/4 will be encrypted with the new key, and the receiver side (AP) will drop it

Re: [PATCH 3/3] brcmfmac: don't realloc wiphy during PCIe reset

reliable. Acked-by: Arend van Spriel Signed-off-by: Rafał Miłecki --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [PATCH 2/3] brcmfmac: split brcmf_attach() and brcmf_detach() functions

On 9/3/2019 6:29 AM, Rafał Miłecki wrote: From: Rafał Miłecki Move code allocating/freeing wiphy out of above functions. This will allow reinitializing the driver (e.g. on some error) without allocating a new wiphy. Acked-by: Arend van Spriel Signed-off-by: Rafał Miłecki

Re: [PATCH 1/3] brcmfmac: move "cfg80211_ops" pointer to another struct

On 9/3/2019 6:29 AM, Rafał Miłecki wrote: From: Rafał Miłecki This moves "ops" pointer from "struct brcmf_cfg80211_info" to the "struct brcmf_pub". This movement makes it possible to allocate wiphy without attaching cfg80211 (brcmf_cfg80211_attach()). It's required for later separation of wiphy

Re: [PATCH 0/3] brcmfmac: keep wiphy during PCIe driver lifetime

On 9/3/2019 6:29 AM, Rafał Miłecki wrote: From: Rafał Miłecki Driver's main init/attach function brcmf_attach() was handling both: wiphy allocation and driver initialization. It meant getting a new wiphy on every init (initial, resume, error recovery). For supplicants/authenticators and Lin

[PATCH] cfg80211: fix boundary value in ieee80211_frequency_to_channel()

The boundary value used for the 6G band was incorrect as it would result in invalid 6G channel number for certain frequencies. Reported-by: Amar Singhal Signed-off-by: Arend van Spriel --- net/wireless/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless

Re: [PATCH] cfg80211: Add new helper function for channels

On 8/30/2019 12:41 PM, Johannes Berg wrote: On Fri, 2019-08-30 at 12:40 +0200, Arend Van Spriel wrote: +EXPORT_SYMBOL(ieee80211_channel_op_class_to_frequency); The function ieee80211_operating_class_to_band() uses ranges within switch statement, eg.: case 128 ... 130

Re: [PATCH] cfg80211: Convert 6 GHz channel frequency to channel number

On 8/30/2019 12:32 PM, Johannes Berg wrote: On Thu, 2019-08-29 at 15:21 -0700, Amar Singhal wrote: Enhance function ieee80211_frequency_to_channel by adding 6 GHz channels. Wait, this is already supported, no? Just implemented slightly differently? It is Johannes, but I was unaware as well.

Re: [PATCH] cfg80211: Convert 6 GHz channel frequency to channel number

On 8/30/2019 12:21 AM, Amar Singhal wrote: Enhance function ieee80211_frequency_to_channel by adding 6 GHz channels. This look very similar to what I submitted earlier: https://patchwork.kernel.org/patch/11073197/ Regards, Arend

Re: [PATCH] cfg80211: Add new helper function for channels

On 8/29/2019 11:49 PM, Amar Singhal wrote: Add new helper function to convert (chan_number, oper_class) pair to frequency. Call this function ieee80211_channel_op_class_to_frequency. This function would be very useful in the context of 6 GHz channels, where channel number is not unique. That 'u

Re: [PATCH] brcmfmac: replace strncpy() by strscpy()

/brcm80211/brcmfmac/cfg80211.c:4227:2: warning: 'strncpy' output truncated before terminating nul copying 3 bytes from a string of the same length [-Wstringop-truncation] strncpy(iebuf, add_del_cmd, VNDR_IE_CMD_LEN - 1); ^~~~ Acked-

Re: [PATCH v7 2/2] nl support for dmtool

On 8/18/2019 4:15 PM, Alexei Avshalom Lazar wrote: Signed-off-by: Alexei Avshalom Lazar --- drivers/net/wireless/ath/wil6210/Kconfig | 11 ++ drivers/net/wireless/ath/wil6210/Makefile | 1 + drivers/net/wireless/ath/wil6210/ioctl.c | 245 + drivers/net/wi

Re: [PATCH v2 2/2] rtw88: RTL8822C: add WoW firmware v7.3

On 8/7/2019 11:53 AM, Tony Chuang wrote: From: Arend Van Spriel [mailto:arend.vanspr...@broadcom.com] On 8/7/2019 10:48 AM, yhchu...@realtek.com wrote: From: Yan-Hsuan Chuang Add WoW firmware to support entering Wake on WirelessLAN mode Signed-off-by: Yan-Hsuan Chuang --- v1 ->

Re: [PATCH v2 2/2] rtw88: RTL8822C: add WoW firmware v7.3

On 8/7/2019 10:48 AM, yhchu...@realtek.com wrote: From: Yan-Hsuan Chuang Add WoW firmware to support entering Wake on WirelessLAN mode Signed-off-by: Yan-Hsuan Chuang --- v1 -> v2 * update WHENCE file for new added firmware WHENCE| 1 + rtw88/rtw8822c_wow_fw.

[PATCH V3 5/8] cfg80211: add 6GHz in code handling array with NUM_NL80211_BANDS entries

-by: Arend van Spriel --- net/wireless/nl80211.c | 1 + net/wireless/trace.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 1a107f2..d28d745 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -677,6

[PATCH V3 6/8] cfg80211: use same IR permissive rules for 6GHz band

The function cfg80211_ir_permissive_chan() is applicable for 6GHz band as well so make sure it is handled. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/chan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH V3 1/8] nl80211: add 6GHz band definition to enum nl80211_band

In the 802.11ax specification a new band is introduced, which is also proposed by FCC for unlicensed use. This band is referred to as 6GHz spanning frequency range from 5925 to 7125 MHz. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- changes

[PATCH V3 3/8] cfg80211: util: add 6GHz channel to freq conversion and vice versa

Extend the functions ieee80211_channel_to_frequency() and ieee80211_frequency_to_channel() to support 6GHz band according specification in 802.11ax D4.1 27.3.22.2. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/util.c | 10

[PATCH V3 8/8] cfg80211: apply same mandatory rate flags for 5GHz and 6GHz

For the new 6GHz band the same rules apply for mandatory rates so add it to set_mandatory_flags_band() function. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/wireless

[PATCH V3 0/8] nl80211: add 6GHz band support

. The only place I could find an issue with this is in cfg80211_wext_freq(). Not sure how to deal with that so it is not part of this series. The series applies to the master branch of the mac80211-next repository. Arend van Spriel (8): nl80211: add 6GHz band definition to enum nl80211_band

[PATCH V3 2/8] cfg80211: add 6GHz UNII band definitions

For the new 6GHz there are new UNII band definitions as listed in the FCC notice [1]. [1] https://docs.fcc.gov/public/attachments/FCC-18-147A1_Rcd.pdf Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/reg.c | 21

[PATCH V3 7/8] cfg80211: ibss: use 11a mandatory rates for 6GHz band operation

The default mandatory rates, ie. when not specified by user-space, is determined by the band. Select 11a rateset for 6GHz band. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/ibss.c | 16 +++- 1 file changed, 11

[PATCH V3 4/8] cfg80211: extend ieee80211_operating_class_to_band() for 6GHz

Add 6GHz operating class range as defined in 802.11ax D4.1 Annex E. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/wireless/util.c b/net/wireless/util.c index

Re: [RFC V2 0/8] nl80211: add 6GHz band support

On July 24, 2019 11:35:14 AM Johannes Berg wrote: Hi Arend, After all the discussion, I think we want this? I think so yes. Even if it is just informational for user-space it seems to make sense for kernel side. Care to resend? Will do. I think I want it at least because we should

Re: [PATCH] brcmfmac: don't net_ratelimit() CONSOLE messages on firmware crash

sible after a crash. Acked-by: Arend van Spriel Signed-off-by: Rafał Miłecki --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH] brcmfmac: change the order of things in brcmf_detach()

On July 20, 2019 6:26:30 PM Rafał Miłecki wrote: On 30.04.2019 12:10, Arend Van Spriel wrote: On 4/30/2019 10:11 AM, Piotr Figiel wrote: Hi Arend, On Mon, Apr 29, 2019 at 12:09:21PM +0200, Arend van Spriel wrote: When brcmf_detach() from the bus layer upon rmmod we can no longer

Re: [PATCH v3 2/3] nl80211: Limit certain commands to interface owner

On 7/1/2019 5:33 PM, Denis Kenzior wrote: If the wdev object has been created (via NEW_INTERFACE) with SOCKET_OWNER attribute set, then limit certain commands only to the process that created that wdev. This can be used to make sure no other process on the system interferes by sending unwanted s

Re: [RFC 0/8] nl80211: add 6GHz band support

On 7/12/2019 11:30 AM, Johannes Berg wrote: On Thu, 2019-07-11 at 13:30 +0200, Arend Van Spriel wrote: I assume user-space does not necessarily need the band, but hostapd needs to be aware that it is operating in 6GHz to setup the correct (information) elements in the beacon. Obviously the

Re: [RFC 0/8] nl80211: add 6GHz band support

On 6/28/2019 3:04 PM, Johannes Berg wrote: Hi Arend, all, Sorry. No, my thoughts aren't really more concrete, but Tova is starting to work on this now. This came up in discussion with my colleagues today and I would say from mac80211 perspective there is more to it than just scanning. In short

[PATCH 2/7] brcmfmac: change the order of things in brcmf_detach()

warning if there are still network devices linked to the wiphy instance. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- .../wireless/broadcom/brcm80211/brcmfmac/core.c| 27 +++--- 1 file changed, 14

[PATCH 7/7] brcmfmac: remove unnecessary strlcpy() upon obtaining "ver" iovar

Recently a strcpy() was replaced by strlcpy(). However, the strcpy() was not needed in the first place. So removing that line of code. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom

[PATCH 6/7] brcmfmac: simply remove flowring if bus is down

When the bus is down, eg. due to rmmod, there is no need to attempt to inform firmware about it. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c | 7 +++ 1

[PATCH 5/7] brcmfmac: avoid firmware commands when bus is down

Upon rmmod a few attempts are made to inform firmware, but there is no point as the bus is down and these will fail. Avoid them to keep the logs clean. Reported-by: Stefan Wahren Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van

[PATCH 0/7] brcmfmac: rework probe/attach sequence

nch of the wireless-drivers-next repository. Arend van Spriel (7): Revert "brcmfmac: fix NULL pointer derefence during USB disconnect" brcmfmac: change the order of things in brcmf_detach() brcmfmac: avoid firmware command in brcmf_netdev_open() when bus is down brcmf

[PATCH 3/7] brcmfmac: avoid firmware command in brcmf_netdev_open() when bus is down

No point in sending a firmware command when bus is down so make it conditional checking the state. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 3 ++- 1

[PATCH 4/7] brcmfmac: clear events in brcmf_fweh_detach() will always fail

Clearing firmware events in brcmf_fweh_detach() is always failing because it is called only upon driver remove and communication with firmware is no longer possible. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel

[PATCH 1/7] Revert "brcmfmac: fix NULL pointer derefence during USB disconnect"

This reverts commit 5cdb0ef6144f47440850553579aa923c20a63f23. Subsequent changes make rework the driver code fixing the issue differently. Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcdc.c | 11 ++- drivers/net/wireless/broadcom/brcm80211

[PATCH 1/3] brcmfmac: add 160MHz in chandef_to_chanspec()

van Spriel --- .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index b6d0df3

[PATCH 3/3] brcmfmac: allow 160MHz in custom regulatory rules

device actually supports. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

[PATCH 0/3] brcmfmac: 160MHz fixes and DFS offload

applies to the master branch of the wireless-drivers-next repository. Arend van Spriel (3): brcmfmac: add 160MHz in chandef_to_chanspec() brcmfmac: enable DFS_OFFLOAD extended feature if supported brcmfmac: allow 160MHz in custom regulatory rules .../broadcom/brcm80211/brcmfmac/cfg80211.c

[PATCH 2/3] brcmfmac: enable DFS_OFFLOAD extended feature if supported

If the firmware supports 802.11h and the device can operate in 5GHz band we can enable DFS_OFFLOAD extended feature. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211/brcmfmac

Re: [PATCH 3/7] brcmsmac: switch source files to using SPDX license identifier

+ Alan On 5/17/2019 8:07 PM, Rafał Miłecki wrote: Another option could be MIT license which is in the preferred folder. Will have to consult our legal department about it though. Hey, if your legal department is going to get asked this, why not just switch it to GPLv2? That would make everythi

[RFC V2 7/8] cfg80211: ibss: use 11a mandatory rates for 6GHz band operation

The default mandatory rates, ie. when not specified by user-space, is determined by the band. Select 11a rateset for 6GHz band. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/ibss.c | 16 +++- 1 file changed, 11

[RFC V2 1/8] nl80211: add 6GHz band definition to enum nl80211_band

In the 802.11ax specification a new band is introduced, which is also proposed by FCC for unlicensed use. This band is referred to as 6GHz spanning frequency range from 5925 to 7125 MHz. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- changes

[RFC V2 5/8] cfg80211: add 6GHz in code handling array with NUM_NL80211_BANDS entries

-by: Arend van Spriel --- net/wireless/nl80211.c | 1 + net/wireless/trace.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index fc83dd1..57bc35a 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -667,6

[RFC V2 6/8] cfg80211: use same IR permissive rules for 6GHz band

The function cfg80211_ir_permissive_chan() is applicable for 6GHz band as well so make sure it is handled. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/chan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[RFC V2 2/8] cfg80211: add 6GHz UNII band definitions

For the new 6GHz there are new UNII band definitions as listed in the FCC notice [1]. [1] https://docs.fcc.gov/public/attachments/FCC-18-147A1_Rcd.pdf Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/reg.c | 21

[RFC V2 4/8] cfg80211: extend ieee80211_operating_class_to_band() for 6GHz

Add 6GHz operating class range as defined in 802.11ax D4.1 Annex E. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/wireless/util.c b/net/wireless/util.c index

[RFC V2 8/8] cfg80211: apply same mandatory rate flags for 5GHz and 6GHz

For the new 6GHz band the same rules apply for mandatory rates so add it to set_mandatory_flags_band() function. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/wireless

[RFC V2 3/8] cfg80211: util: add 6GHz channel to freq conversion and vice versa

Extend the functions ieee80211_channel_to_frequency() and ieee80211_frequency_to_channel() to support 6GHz band according specification in 802.11ax D4.1 27.3.22.2. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/util.c | 10

[RFC V2 0/8] nl80211: add 6GHz band support

van Spriel (8): nl80211: add 6GHz band definition to enum nl80211_band cfg80211: add 6GHz UNII band definitions cfg80211: util: add 6GHz channel to freq conversion and vice versa cfg80211: extend ieee80211_operating_class_to_band() for 6GHz cfg80211: add 6GHz in code handling array with

Re: [RESEND] brcmfmac support for BCM4359 sdio on arm64 ??

Hi Christian, Here it is. Hopefully unmangled this time. Regards, Arend --- diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c index ec129864cc9c..7be8064c6dc7 100644 --- a/drivers/net/wireless/broadcom/brcm80211/b

Re: [PATCH v2 2/3] nl80211: Limit certain commands to interface owner

On 6/22/2019 3:44 PM, Marcel Holtmann wrote: Hi Arend, If the wdev object has been created (via NEW_INTERFACE) with SOCKET_OWNER attribute set, then limit certain commands only to the process that created that wdev. This can be used to make sure no other process on the system interferes by sen

Re: iwlwifi/brcmfmac public action frames crash (RESENDING)

On June 21, 2019 10:09:10 PM Denis Kenzior wrote: Ping, is anyone looking into these crashes? Did not see this message before. On 06/13/2019 11:45 AM, James Prestwood wrote: Sorry if this comes in twice, I sent it ~12 hours ago but never saw it hit the list, nor in the archives so I am re

Re: [PATCH v2 2/3] nl80211: Limit certain commands to interface owner

On 6/21/2019 7:14 PM, Denis Kenzior wrote: Hi Arend, On 06/21/2019 03:09 AM, Arend Van Spriel wrote: On 6/21/2019 12:07 AM, Denis Kenzior wrote: If the wdev object has been created (via NEW_INTERFACE) with SOCKET_OWNER attribute set, then limit certain commands only to the process that

Re: [RFC 0/8] nl80211: add 6GHz band support

On 6/3/2019 12:39 PM, Arend Van Spriel wrote: On 5/27/2019 10:46 PM, Arend Van Spriel wrote: On 5/24/2019 8:38 PM, Arend Van Spriel wrote: On May 24, 2019 1:56:43 PM Johannes Berg wrote: Hi Arend, On Mon, 2019-05-20 at 14:00 +0200, Arend van Spriel wrote: In 802.11ax D4.0 a new band has

Re: [PATCH v2 2/3] nl80211: Limit certain commands to interface owner

On 6/21/2019 12:07 AM, Denis Kenzior wrote: If the wdev object has been created (via NEW_INTERFACE) with SOCKET_OWNER attribute set, then limit certain commands only to the process that created that wdev. This can be used to make sure no other process on the system interferes by sending unwanted

Re: wpa_supplicant 2.8 fails in brcmf_cfg80211_set_pmk

On 6/19/2019 7:26 AM, Marcel Holtmann wrote: Hi Arend, i was able to reproduce an (maybe older issue) with 4-way handshake offloading for 802.1X in the brcmfmac driver. My setup consists of Raspberry Pi 3 B (current linux-next, arm64/defconfig) on STA side and a Raspberry Pi 3 A+ (Linux 4.19) o

Re: wpa_supplicant 2.8 fails in brcmf_cfg80211_set_pmk

On 6/18/2019 7:03 PM, Stefan Wahren wrote: Hi, Am 18.06.19 um 10:27 schrieb Arend Van Spriel: + Jouni On 6/18/2019 7:33 AM, Chi-Hsien Lin wrote: On 06/17/2019 10:33, Marcel Holtmann wrote: Hi Chi-hsien, i was able to reproduce an (maybe older issue) with 4-way handshake offloading for

Re: wpa_supplicant 2.8 fails in brcmf_cfg80211_set_pmk

+ Jouni On 6/18/2019 7:33 AM, Chi-Hsien Lin wrote: On 06/17/2019 10:33, Marcel Holtmann wrote: Hi Chi-hsien, i was able to reproduce an (maybe older issue) with 4-way handshake offloading for 802.1X in the brcmfmac driver. My setup consists of Raspberry Pi 3 B (current linux-next, arm64/def

Re: [RESEND] brcmfmac support for BCM4359 sdio on arm64 ??

On 6/8/2019 5:39 AM, Christian Hewitt wrote: Hello Arend, Last October Christoph Müllner reported BCM4359 SDIO issues here: https://www.spinics.net/lists/linux-wireless/msg178783.html but the investigation stalled after the needs/timescale of his project forced a change to a different (workin

Re: [PATCH V2] iw: print HE capabilities

On 6/7/2019 4:11 AM, Joe Perches wrote: On Tue, 2019-05-28 at 08:58 +0200, John Crispin wrote: Print the HE MAC/PHY capabilities and MCS/NSS sets. trivia: diff --git a/util.c b/util.c [] +void print_he_info(struct nlattr *nl_iftype) +{ + struct nlattr *tb[NL80211_BAND_IFTYPE_ATTR_MAX

Re: [RFC 0/8] nl80211: add 6GHz band support

On 5/27/2019 10:46 PM, Arend Van Spriel wrote: On 5/24/2019 8:38 PM, Arend Van Spriel wrote: On May 24, 2019 1:56:43 PM Johannes Berg wrote: Hi Arend, On Mon, 2019-05-20 at 14:00 +0200, Arend van Spriel wrote: In 802.11ax D4.0 a new band has been proposed. This series contains changes to

Re: [RFC 1/8] nl80211: add 6GHz band definition to enum nl80211_band

On May 30, 2019 7:43:27 PM Jeff Johnson wrote: On 2019-05-30 09:07, Arend Van Spriel wrote: Sigh! Obviously that is a concern. Johannes already mentioned it. Sorry, overlooked his comment on the [0/8] patch. I'll climb back under my rock. No need to do that. It is mainly me feeling s

Re: [RFC 1/8] nl80211: add 6GHz band definition to enum nl80211_band

On May 30, 2019 4:53:13 PM Jeff Johnson wrote: On 2019-05-20 05:00, Arend van Spriel wrote: [...snip...] enum nl80211_band { NL80211_BAND_2GHZ, NL80211_BAND_5GHZ, + NL80211_BAND_6GHZ, NL80211_BAND_60GHZ, NUM_NL80211_BANDS, Is it not a concern that

Re: brcmfmac & DEL_INTERFACE

On 5/28/2019 8:16 PM, Denis Kenzior wrote: Hi Arend, We noticed that brcmfmac doesn't support .del_virtual_intf for non-p2p/ap interface types.  Any chance this can be added? We currently remove all wifi interfaces and re-create the needed ones with SOCKET_OWNER set, and it would be nice if

Re: [RFC 0/8] nl80211: add 6GHz band support

On 5/24/2019 8:38 PM, Arend Van Spriel wrote: On May 24, 2019 1:56:43 PM Johannes Berg wrote: Hi Arend, On Mon, 2019-05-20 at 14:00 +0200, Arend van Spriel wrote: In 802.11ax D4.0 a new band has been proposed. This series contains changes to cfg80211 for supporting this band. With 2GHz and

Re: [RFC 0/8] nl80211: add 6GHz band support

On May 24, 2019 1:56:43 PM Johannes Berg wrote: Hi Arend, On Mon, 2019-05-20 at 14:00 +0200, Arend van Spriel wrote: In 802.11ax D4.0 a new band has been proposed. This series contains changes to cfg80211 for supporting this band. With 2GHz and 5GHz there was no overlap in channel number

Re: [PATCH 1/7] brcm80211: switch common header files to using SPDX license identifier

On May 23, 2019 11:17:22 AM Kalle Valo wrote: Arend Van Spriel writes: Or do you want me to resend the whole series without patch 3? If the series applies without patch 3 (and I assume it does) no need to resend the whole series. Thanks, Kalle I assume the same. Regards, Arend

Re: [PATCH 1/7] brcm80211: switch common header files to using SPDX license identifier

On 5/20/2019 6:54 PM, Kalle Valo wrote: Arend Van Spriel writes: On 5/16/2019 10:57 PM, Arend Van Spriel wrote: On 5/16/2019 2:04 PM, Arend van Spriel wrote: With ISC license text in place under the LICENSES folder switch to using the SPDX license identifier to refer to the ISC license

[RFC 2/8] cfg80211: add 6GHz UNII band definitions

For the new 6GHz there are new UNII band definitions as listed in the FCC notice [1]. [1] https://docs.fcc.gov/public/attachments/FCC-18-147A1_Rcd.pdf Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/reg.c | 21

[RFC 3/8] cfg80211: util: add 6GHz channel to freq conversion and vice versa

Extend the functions ieee80211_channel_to_frequency() and ieee80211_frequency_to_channel() to support 6GHz band according specification in 802.11ax D4.1 27.3.22.2. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/util.c | 10

[RFC 4/8] cfg80211: extend ieee80211_operating_class_to_band() for 6GHz

Add 6GHz operating class range as defined in 802.11ax D4.1 Annex E. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/wireless/util.c b/net/wireless/util.c index

[RFC 5/8] cfg80211: add 6GHz in code handling array with NUM_NL80211_BANDS entries

-by: Arend van Spriel --- net/wireless/nl80211.c | 1 + net/wireless/trace.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index fffe4b3..c0224fc 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -627,6

[RFC 8/8] cfg80211: apply same mandatory rate flags for 5GHz and 6GHz

For the new 6GHz band the same rules apply for mandatory rates so add it to set_mandatory_flags_band() function. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/wireless

[RFC 0/8] nl80211: add 6GHz band support

in cfg80211_wext_freq(). Not sure how to deal with that so it is not part of this series. The series applies to the master branch of the mac80211-next repository. Arend van Spriel (8): nl80211: add 6GHz band definition to enum nl80211_band cfg80211: add 6GHz UNII band definitions cfg80211

[RFC 1/8] nl80211: add 6GHz band definition to enum nl80211_band

In the 802.11ax specification a new band is introduced, which is also proposed by FCC for unlicensed use. This band is referred to as 6GHz spanning frequency range from 5925 to 7125 MHz. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- include

[RFC 6/8] cfg80211: use same IR permissive rules for 6GHz band

The function cfg80211_ir_permissive_chan() is applicable for 6GHz band as well so make sure it is handled. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/chan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[RFC 7/8] cfg80211: ibss: use 11a mandatory rates for 6GHz band operation

The default mandatory rates, ie. when not specified by user-space, is determined by the band. Select 11a rateset for 6GHz band. Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Leon Zegers Signed-off-by: Arend van Spriel --- net/wireless/ibss.c | 16 +++- 1 file changed, 11

Re: [PATCH 0/3] brcmfmac: sdio: Deal better w/ transmission errors waking from sleep

On 5/18/2019 12:54 AM, Douglas Anderson wrote: This series attempts to deal better with the expected transmission errors that we get when waking up the SDIO-based WiFi on rk3288-veyron-minnie, rk3288-veyron-speedy, and rk3288-veyron-mickey. Some details about those errors can be found in

Re: [PATCH 3/7] brcmsmac: switch source files to using SPDX license identifier

On 5/17/2019 8:07 PM, Rafał Miłecki wrote: On Fri, 17 May 2019 at 01:25, Arend Van Spriel wrote: On 5/16/2019 10:01 PM, Greg Kroah-Hartman wrote: On Thu, May 16, 2019 at 09:45:19PM +0200, Arend Van Spriel wrote: On 5/16/2019 7:31 PM, Greg Kroah-Hartman wrote: On Thu, May 16, 2019 at 02:04

Re: [PATCH 1/7] brcm80211: switch common header files to using SPDX license identifier

On 5/16/2019 10:57 PM, Arend Van Spriel wrote: On 5/16/2019 2:04 PM, Arend van Spriel wrote: With ISC license text in place under the LICENSES folder switch to using the SPDX license identifier to refer to the ISC license. Hi Kalle, Given the feedback on checkpatch (or spdxcheck) failures

Re: [PATCH 1/7] brcm80211: switch common header files to using SPDX license identifier

On 5/16/2019 2:04 PM, Arend van Spriel wrote: With ISC license text in place under the LICENSES folder switch to using the SPDX license identifier to refer to the ISC license. Hi Kalle, Given the feedback on checkpatch (or spdxcheck) failures let me respin this series. Gr. AvS

Re: [PATCH 3/7] brcmsmac: switch source files to using SPDX license identifier

On 5/16/2019 10:01 PM, Greg Kroah-Hartman wrote: On Thu, May 16, 2019 at 09:45:19PM +0200, Arend Van Spriel wrote: On 5/16/2019 7:31 PM, Greg Kroah-Hartman wrote: On Thu, May 16, 2019 at 02:04:07PM +0200, Arend van Spriel wrote: With ISC license text in place under the LICENSES folder switch

Re: SPDX identifier

On 5/16/2019 8:17 PM, Thomas Gleixner wrote: Arend, On Thu, 16 May 2019, Arend Van Spriel wrote: Hi Kalle, Thomas, I added SPDX tags in brcm80211 driver sources. Although it is a no-brainer I decided to run checkpatch for the changes and quirky stuff started to happen. For all files I added

Re: [PATCH 3/7] brcmsmac: switch source files to using SPDX license identifier

On 5/16/2019 7:31 PM, Greg Kroah-Hartman wrote: On Thu, May 16, 2019 at 02:04:07PM +0200, Arend van Spriel wrote: With ISC license text in place under the LICENSES folder switch to using the SPDX license identifier to refer to the ISC license. Cc: Thomas Gleixner Cc: Greg Kroah-Hartman

Re: SPDX identifier

On May 16, 2019 4:17:55 PM James Hughes wrote: On Thu, 16 May 2019 at 12:36, Arend Van Spriel wrote: Hi Kalle, Thomas, I added SPDX tags in brcm80211 driver sources. Although it is a no-brainer I decided to run checkpatch for the changes and quirky stuff started to happen. For all files

[PATCH 1/7] brcm80211: switch common header files to using SPDX license identifier

With ISC license text in place under the LICENSES folder switch to using the SPDX license identifier to refer to the ISC license. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- .../net/wireless/broadcom/brcm80211

[PATCH 6/7] brcmfmac: use separate Kconfig file for brcmfmac

The number of Kconfig items related to brcmfmac is considerable and upcoming changes will add some more so it seems good idea to have a separate Kconfig file for brcmfmac. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel

[PATCH 7/7] brcm80211: select WANT_DEV_COREDUMP conditionally for brcmfmac

CONFIG_BRCMDBG selects WANT_DEV_COREDUMP but is only used by brcmfmac so reflect that in the Kconfig. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211/Kconfig | 2 +- 1 file

[PATCH 0/7] brcm80211: SPDX tags and Kconfig cleanup

This series consist of: * adding SPDX identifiers. * clean Kconfig files. The patches apply to the master branch of the wireless-drivers-next repository. Arend van Spriel (7): brcm80211: switch common header files to using SPDX license identifier brcmutil: switch source files to using SPDX

[PATCH 5/7] brcmfmac: switch source files to using SPDX license identifier

With ISC license text in place under the LICENSES folder switch to using the SPDX license identifier to refer to the ISC license. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211

[PATCH 2/7] brcmutil: switch source files to using SPDX license identifier

With ISC license text in place under the LICENSES folder switch to using the SPDX license identifier to refer to the ISC license. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211

[PATCH 3/7] brcmsmac: switch source files to using SPDX license identifier

With ISC license text in place under the LICENSES folder switch to using the SPDX license identifier to refer to the ISC license. Cc: Thomas Gleixner Cc: Greg Kroah-Hartman Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel

[PATCH 4/7] brcmsmac: switch phy source files to using SPDX license identifier

With ISC license text in place under the LICENSES folder switch to using the SPDX license identifier to refer to the ISC license. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- .../net/wireless/broadcom/brcm80211

SPDX identifier

Hi Kalle, Thomas, I added SPDX tags in brcm80211 driver sources. Although it is a no-brainer I decided to run checkpatch for the changes and quirky stuff started to happen. For all files I added: // SPDX-License-Identifier but checkpatch started complaining I should use /* ... */ instead of

Re: [PATCH 2/6] brcmfmac: send port authorized event for 802.1X 4-way handshake offload

+ Jouni On 5/9/2019 10:58 AM, Stanley Hsu wrote: On Mon, Jan 07, 2019 at 10:44:01AM +0100, Arend Van Spriel wrote: On 1/4/2019 7:11 AM, Chi-Hsien Lin wrote: From: Chung-Hsien Hsu With 4-way handshake offload for 802.1X authentication, a port authorized event should be sent to user space

  1   2   3   4   5   6   7   8   9   10   >