Re: [PATCH] RFC: Universal scan proposal

On 8-12-2016 23:35, Dmitry Shmidt wrote: > On Wed, Dec 7, 2016 at 12:51 PM, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 7-12-2016 19:39, Dmitry Shmidt wrote: >>> On Tue, Dec 6, 2016 at 10:44 PM, Johannes Berg >>> <johan...@sipsolutions

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

On 8-12-2016 18:52, Malinen, Jouni wrote: > On Wed, Dec 07, 2016 at 09:03:23PM +0100, Arend Van Spriel wrote: >> On 7-12-2016 10:33, Vamsi, Krishna wrote: >>>> -Original Message- >>>> From: Johannes Berg [mailto:johan...@sipsolutions.net] >>>

Re: [PATCH 1/1] orinoco: fix improper return value

On 8-12-2016 1:40, Pan Bian wrote: > Function orinoco_ioctl_commit() returns 0 (indicates success) when the > call to orinoco_lock() fails. Thus, the return value is inconsistent with > the execution status. It may be better to return "-EBUSY" when the call > to orinoco_lock() fails. > >

Re: [PATCH] RFC: Universal scan proposal

On 7-12-2016 19:39, Dmitry Shmidt wrote: > On Tue, Dec 6, 2016 at 10:44 PM, Johannes Berg > wrote: >> >>> Indeed, results are results. I just want to take care of two things: >>> 1) Memory consumption - we can clear stale scan results for >>> connection, but not for

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

On 2-12-2016 22:59, Jouni Malinen wrote: > From: vamsi krishna > > Enhance sched scan to support option of finding a better BSS while in > connected state. Firmware scans the medium and reports when it finds a > known BSS which has better RSSI than the current connected

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

On 7-12-2016 10:33, Vamsi, Krishna wrote: >> -Original Message- >> From: Johannes Berg [mailto:johan...@sipsolutions.net] > >> What about Arend's comment regarding this functionality overlapping with the >> BSS selection offload configuration? >> >> Do you think there's any ability to

Re: [RFC V2 1/5] nl80211: allow reporting RTT information in scan results

On 30-11-2016 9:22, Johannes Berg wrote: > On Mon, 2016-11-28 at 21:07 +0100, Arend Van Spriel wrote: >> >> I was wondering about the meaning of the term "parent_bssid". Given >> your remark it means something else than my guess. I actually meant >> the dis

Re: [PATCH] mac80211: fix Tx BA session stuck issue during sw scanning

On 29-11-2016 13:59, Johannes Berg wrote: > On Wed, 2016-11-23 at 15:59 +0800, Chris Chiu wrote: >> ieee80211_iface_work() will check if sw scanning is in progress >> before handling block ack session. In our case, the RTL8821AE >> operate in station mode, when tx session expired, DELBA packet

Re: [PATCH 00/12] brcmfmac: scheduled scan cleanup and chip support

On 29-11-2016 8:37, Rafał Miłecki wrote: > On 23 November 2016 at 11:25, Arend van Spriel > <arend.vanspr...@broadcom.com> wrote: >> This patch series contains: >> * cleanup of scheduled scan code. >> * fix handling schedules scan results for newer chips. >

Re: [RFC] qtn: add FullMAC firmware for Quantenna QSR10G wifi device

On 29-11-2016 10:10, IgorMitsyanko wrote: > On 11/29/2016 06:49 AM, Oleksij Rempel wrote: >> Am 28.11.2016 um 20:01 schrieb IgorMitsyanko: >>> On 11/28/2016 08:33 PM, Oleksij Rempel wrote: Am 28.11.2016 um 18:10 schrieb Oleksij Rempel: [...] >>> Oleksij, yes, that's correct, it includes

Re: [PATCH 03/12] brcmfmac: move pno helper functions in separate source file

On 29-11-2016 8:57, Johannes Berg wrote: > On Tue, 2016-11-29 at 08:08 +0100, Rafał Miłecki wrote: >> On 23 November 2016 at 11:25, Arend van Spriel >> <arend.vanspr...@broadcom.com> wrote: >>> >>> Introducing new source file for pno related functiona

Re: [RFC V2 4/5] nl80211: add support for gscan

On 28-11-2016 15:38, Johannes Berg wrote: > >> * the nl80211 feature flags for the device. >> + * @NL80211_SCAN_FLAGS_IE_DATA: request the device to supply IE data >> in the >> + * request. > > What does that mean? I meant "supply IE data in the result". So it informs the driver that

Re: [RFC V2 1/5] nl80211: allow reporting RTT information in scan results

On 28-11-2016 15:32, Johannes Berg wrote: > >> + * @distance: distance to AP with %parent_bssid in centimeters. Zero >> + * value indicates this is undetermined. >> + * @var_distance: variance of %distance indicating accurracy. > > accuracy > > The distance between the two APs? Where are you

Re: [PATCH 2/2] cfg80211: Add support to sched scan to report better BSSs

On 23-11-2016 23:07, Jouni Malinen wrote: > From: vamsi krishna > > Enhance sched scan to support option of finding a better BSS while in > connected state. Firmware scans the medium and reports when it finds a > known BSS which has a significantly better RSSI than the

[PATCH 00/12] brcmfmac: scheduled scan cleanup and chip support

-drivers-next repository. Arend van Spriel (11): brcmfmac: add support for 43341 chip brcmfmac: move pno helper functions in separate source file brcmfmac: fix handling ssids in .sched_scan_start() callback brcmfmac: change prototype for brcmf_do_escan() brcmfmac: make internal escan more

[PATCH 04/12] brcmfmac: fix handling ssids in .sched_scan_start() callback

com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 103 ++--- .

[PATCH 12/12] brcmfmac: fix scheduled scan result handling for newer chips

ule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 24 +-

[PATCH 08/12] brcmfmac: move scheduled scan activation to pno source file

com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 65 +--- .../net/wireless/broadcom/brcm80211/brcmfmac/pno.c | 110 + .../net/wireless/broadcom/brcm80211/brcmfmac/pno.h | 29 +- 3 file

[PATCH 05/12] brcmfmac: change prototype for brcmf_do_escan()

com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wir

[PATCH 10/12] brcmfmac: remove restriction from .sched_scan_start() callback

viewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 5 + 1 file changed, 1 i

[PATCH 07/12] brcmfmac: split up brcmf_pno_config() function

Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 11 +++- .../net/wireless/broadcom/brcm80211/brcmfmac/pno.c | 60 -- .../net/wireless/broadcom/brcm80211/brcmfmac/pno.h | 17 +++

[PATCH 11/12] brcmfmac: use requested scan interval in scheduled scan

adcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 1 + drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c | 6 +- drivers/net/wir

[PATCH 06/12] brcmfmac: make internal escan more generic

Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 187 - .../broadcom/brcm8

[PATCH 09/12] brcmfmac: use provided channels for scheduled scan

viewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/fwil_types.h | 16 + .../net/wireless/bro

Re: [PATCH] RFC: Universal scan proposal

On 22-11-2016 21:54, Dmitry Shmidt wrote: > On Tue, Nov 22, 2016 at 12:41 PM, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 22-11-2016 18:29, Dmitry Shmidt wrote: >>> Hi Luca, >>> >>> On Mon, Nov 21, 2016 at 11:24 PM, Luca Coelho <l.

Re: wl1251 & mac address & calibration data

On 22-11-2016 18:05, Pali Rohár wrote: > On Tuesday 22 November 2016 17:14:28 Michal Kazior wrote: >> On 22 November 2016 at 16:31, Pali Rohár wrote: >>> On Tuesday 22 November 2016 16:22:57 Michal Kazior wrote: On 21 November 2016 at 16:51, Pali Rohár

Re: [PATCH] RFC: Universal scan proposal

On 22-11-2016 18:29, Dmitry Shmidt wrote: > Hi Luca, > > On Mon, Nov 21, 2016 at 11:24 PM, Luca Coelho wrote: >> Hi Dmitry, >> On Wed, 2016-11-16 at 22:47 +, dimitr...@google.com wrote: >>> From 68a9d37a4c7e9dc7a90a6e922cdea52737a98d66 Mon Sep 17 00:00:00 2001 >>> From:

Re: [PATCH] nl80211: provide minimum scheduled scan (plan) interval

On 22-11-2016 14:38, Johannes Berg wrote: > >> +if (wiphy->min_sched_scan_plan_interval && >> +request->scan_plans[i].interval < >> +wiphy->min_sched_scan_plan_interval) >> +return -EINVAL; >> > I'm not sure we should break the API

[PATCH] nl80211: provide minimum scheduled scan (plan) interval

The interval for scheduled scan may have a minimum value for the device. Allow drivers to specify a minimum value in the struct wiphy so user-space interval values can be validated against it. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- include/net/cfg80211.h

Re: [PATCH] nl80211: change validation of scheduled scan interval values

On 22-11-2016 11:22, Arend van Spriel wrote: > When user-space does not provide scheduled scan plans, ie. uses the > old scheduled scan API containing NL80211_ATTR_SCHED_SCAN_INTERVAL. > The interval value passed by user-space is validated against > struct wiphy::max_sched_scan_p

Re: scheduled scan interval

On 22-11-2016 10:19, Luca Coelho wrote: > On Tue, 2016-11-22 at 10:10 +0100, Arend Van Spriel wrote: >> On 22-11-2016 6:59, Luca Coelho wrote: >>> Oh, I see. The problem is that the "max_sched_scan_plan_interval" was >>> intro

[PATCH] nl80211: change validation of scheduled scan interval values

validation has been simalarly adjusted to assure the limit is non-zero. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- net/wireless/nl80211.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 2

Re: scheduled scan interval

On 22-11-2016 10:19, Luca Coelho wrote: > On Tue, 2016-11-22 at 10:10 +0100, Arend Van Spriel wrote: >> On 22-11-2016 6:59, Luca Coelho wrote: >>> Oh, I see. The problem is that the "max_sched_scan_plan_interval" was >>> intro

Re: scheduled scan interval

On 22-11-2016 6:59, Luca Coelho wrote: > Hi Arend, > On Mon, 2016-11-21 at 20:34 +0100, Arend Van Spriel wrote: >> On 21-11-2016 16:08, Luca Coelho wrote: >>> Hi Arend, >>> >>> On Mon, 2016-11-21 at 13:03 +0100, Arend Van Spriel wrote: >>>> On 21

Re: scheduled scan interval

On 21-11-2016 16:08, Luca Coelho wrote: > Hi Arend, > > On Mon, 2016-11-21 at 13:03 +0100, Arend Van Spriel wrote: >> On 21-11-2016 12:30, Arend Van Spriel wrote: >>> On 21-11-2016 12:19, Arend Van Spriel wrote: >>>> Hi Johannes, Luca, >>>> &g

Re: scheduled scan interval

On 21-11-2016 17:59, Dave Taht wrote: > On Mon, Nov 21, 2016 at 7:08 AM, Luca Coelho <l...@coelho.fi> wrote: >> Hi Arend, >> >> On Mon, 2016-11-21 at 13:03 +0100, Arend Van Spriel wrote: >>> On 21-11-2016 12:30, Arend Van Spriel wrote: >>>> On 21

Re: [PATCH] nl80211: fix logic inversion in start_nan()

On 21-11-2016 13:57, Arend Van Spriel wrote: > On 21-11-2016 13:55, Johannes Berg wrote: >> From: Johannes Berg <johannes.b...@intel.com> >> >> Arend inadvertedly inverted the logic while converting to >> wdev_running(), fix that. > > It was indeed i

Re: [PATCH] nl80211: fix logic inversion in start_nan()

On 21-11-2016 13:55, Johannes Berg wrote: > From: Johannes Berg > > Arend inadvertedly inverted the logic while converting to > wdev_running(), fix that. It was indeed inadvertedly. Thanks, Arend > Fixes: 73c7da3dae1e ("cfg80211: add generic helper to check interface

Re: scheduled scan interval

On 21-11-2016 12:19, Arend Van Spriel wrote: > Hi Johannes, Luca, > > The gscan work made me look at scheduled scan and the implementation of > it in brcmfmac. The driver ignored the interval parameter from > user-space. Now I am fixing that. One thing is that our firmware

scheduled scan interval

Hi Johannes, Luca, The gscan work made me look at scheduled scan and the implementation of it in brcmfmac. The driver ignored the interval parameter from user-space. Now I am fixing that. One thing is that our firmware has a minimum interval which can not be indicated in struct wiphy. The other

Re: BCM4356 + Ubuntu 16.10

+ linux-wireless On 20-11-2016 14:26, Familie Stepniak wrote: > Hi, > > I try run Ubuntu 16.10 on the Trekstor W2 Tablet but Wi-Fi donts work.. > that find WLAN-Network, I give to Passwort and Nothing.. the chip ist > BCM4356B.. please Help me to install the true Driver on the Linux-Ubuntu..

Re: [PATCH] RFC: Universal scan proposal

On 16-11-2016 23:47, dimitr...@google.com wrote: > From 68a9d37a4c7e9dc7a90a6e922cdea52737a98d66 Mon Sep 17 00:00:00 2001 > From: Dmitry Shmidt > Date: Wed, 16 Nov 2016 14:27:26 -0800 > Subject: [PATCH] RFC: Universal scan proposal > > Currently we have sched scan with

Re: [RFC 0/5] nl80211: add support for g-scan

On 17-11-2016 15:39, Johannes Berg wrote: > On Thu, 2016-11-17 at 13:18 +0000, Arend van Spriel wrote: >> Android employs a Wifi-HAL layer in its wireless frame. It basically >> abstracts dealing with netlink messages from the framework. For some >> features it employs nl

Re: [PATCH 1/5] nl80211: allow reporting RTT information in scan results

On 17-11-2016 17:15, Dan Williams wrote: > On Thu, 2016-11-17 at 11:39 +0000, Arend van Spriel wrote: >> Add distance and its variance to the BSS structure so drivers >> may provide RTT information for BSS instances found during >> scanning. >> >> Reviewe

[RFC V2 2/5] nl80211: add reporting of gscan capabilities

From: Arend van Spriel <ar...@broadcom.com> GScan is a scan offload feature used in recent Android releases. This patch adds possibility for wireless device drivers to report their capabilities and provide it to user-space. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com&

[RFC V2 3/5] nl80211: rename some notification functions

aming them to nl80211_send_scan_event{,_msg}(). Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com>

[RFC V2 4/5] nl80211: add support for gscan

This patch adds support for GScan which is a scan offload feature used in Android. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by

[RFC V2 5/5] nl80211: add driver api for gscan notifications

The driver can indicate gscan results are available or gscan operation has stopped. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by

Re: [PATCH 5/5] nl80211: add driver api for gscan notifications

On 17-11-2016 12:39, Arend van Spriel wrote: > The driver can indicate gscan results are available or gscan operation > has stopped. > > Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> > Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com>

Re: [PATCH 1/2] cfg80211: get rid of name indirection trick for ieee80211_get_channel()

; > url: > https://github.com/0day-ci/linux/commits/Arend-van-Spriel/cfg80211-get-rid-of-name-indirection-trick-for-ieee80211_get_channel/20161117-175449 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master > config: x86_64-allmodconfig (attached a

[PATCH V2] cfg80211: get rid of name indirection trick for ieee80211_get_channel()

The comment on the name indirection suggested an issue but turned out to be untrue. Digging in older kernel version showed issue with ipw2x00 but that is no longer true so get rid on the name indirection. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wirele

Re: [PATCH 3/5] nl80211: add support for gscan

the system] > > url: > https://github.com/0day-ci/linux/commits/Arend-van-Spriel/nl80211-add-support-for-g-scan/20161117-194818 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master > config: i386-randconfig-x004-201646 (attached as .co

[PATCH 1/5] nl80211: allow reporting RTT information in scan results

Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- include/net/cfg80211.h | 11 +++ include/uapi/linux/nl80211.h | 6 ++ net/wireless/nl80211.c | 8 net/wireless/scan.c | 2 ++ 4 files changed, 27 i

[RFC 0/5] nl80211: add support for g-scan

those use-case(s). A current hurdle for me is that the device stores m scans so a BSS could end up in the result of either of them. However, cfg80211 stores BSS-es uniquely with latest scan information. Does user-space need results per scan or is flat BSS storage fine. Anyway, here is some more fuel t

[PATCH 3/5] nl80211: add support for gscan

This patch adds support for GScan which is a scan offload feature used in Android. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by

[PATCH 2/5] nl80211: add reporting of gscan capabilities

From: Arend van Spriel <ar...@broadcom.com> GScan is a scan offload feature used in recent Android releases. This patch adds possibility for wireless device drivers to report their capabilities and provide it to user-space. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com&

[PATCH 5/5] nl80211: add driver api for gscan notifications

The driver can indicate gscan results are available or gscan operation has stopped. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by

[PATCH 4/5] nl80211: rename some notification functions

aming them to nl80211_send_scan_event{,_msg}(). Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com>

[PATCH 2/2] nl80211: check NL80211_ATTR_SCHED_SCAN_INTERVAL only once

The presence of the NL80211_ATTR_SCHED_SCAN_INTERVAL attribute was checked in nl80211_parse_sched_scan() and nl80211_parse_sched_scan_plans() which might be a bit redundant so removing one. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- net/wireless/nl80211.c | 5 +-

[PATCH 1/2] cfg80211: get rid of name indirection trick for ieee80211_get_channel()

The comment on the name indirection suggested an issue but turned out to be untrue. Digging in older kernel version showed issue with ipw2x00 but that is no longer true so get rid on the name indirection. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- include/net/cfg8

Re: [PATCH] broadcom/brcm80211/brcmfmac/cfg80211 driver, bad regulatory domain frequency value

On 15-11-2016 12:10, Kalle Valo wrote: > Gianfranco Costamagna writes: > >>> Well, not before you pointed it out ;-). You are welcome to send a patch >>> fixing it. Otherwise, I will take care of it. >> >> attaching a format-patch like version. >> I don't think we need

Re: [PATCH] broadcom/brcm80211/brcmfmac/cfg80211 driver, bad regulatory domain frequency value

On 14-11-2016 12:34, Gianfranco Costamagna wrote: > Hi Arend, > > >> Finally response. As it turns out the range was explcitly changed > >> enabling channels 12 and 13 to be used where applicable. They forgot to >> update the comment. > > > so, the struct in net/wireless/reg.c is actually

Re: [PATCH] broadcom/brcm80211/brcmfmac/cfg80211 driver, bad regulatory domain frequency value

On 28-10-2016 22:41, Arend Van Spriel wrote: > On 28-10-2016 18:15, Gianfranco Costamagna wrote: >> (resending from my debian.org mail address, to avoid spam filtering) >> >> Hi Broadcom developers and linux wireless list. >> >> We found a possible iss

Re: BCM43602 firmware reports multiple BRCMF_E_DEAUTH

On 19-10-2016 14:34, Rafał Miłecki wrote: > On 10/04/2016 08:15 PM, Rafał Miłecki wrote: >> # My smartphone remains in the same place (1 m from the AP) but there >> is some >> # connection/A-MPDU problem. >> Tue Oct 4 17:22:22 2016 kern.debug kernel: [ 247.509120] brcmfmac: >> CONSOLE:

cookie_counter in wiphy object

Hi Johannes, Since commit a442b761b24b ("cfg80211: add add_nan_func / del_nan_func") there is a cookie_counter in the wiphy object. It is only used by the add_nan_func now, but do we want to consolidate all cookie returning functions to use this cookie counter, eg. in .remain_on_channel callback.

Re: [PATCH 2/2] mac80211: use inline kernel-doc for struct ieee80211_hw

On 21-10-16 15:01, Johannes Berg wrote: > On Fri, 2016-10-21 at 15:57 +0300, Jani Nikula wrote: >> It's easier to manage the kernel-doc for the fields when they >> documentation is next to the field. > > Hah, I wasn't even aware this was possible. Thanks! Me neither. I actually found it annoying

Re: [PATCH] cfg80211: allow vendor commands to be sent to nan interface

On 20-10-2016 14:45, Johannes Berg wrote: > On Thu, 2016-10-20 at 14:44 +0200, Arend Van Spriel wrote: >> >> Sure. On top of this patch or will you deal with those conflicts? >> > > I already applied this, so on top please (i.e. just resend what you > just had

[PATCH] cfg80211: add generic helper to check interface is running

Adding a helper using wdev to check if interface is running. This deals with both non-netdev and netdev interfaces. In struct wireless_dev replacing 'p2p_started' and 'nan_started' by 'is_running' as those are mutual exclusive anyway. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.

Re: [PATCH] cfg80211: allow vendor commands to be sent to nan interface

On 19-10-2016 6:47, Luca Coelho wrote: > From: Andrei Otcheretianski > > Allow vendor commands that require WIPHY_VENDOR_CMD_NEED_RUNNING flag, to > be sent to NAN interface. > > Signed-off-by: Andrei Otcheretianski >

Re: BCM43602 firmware reports multiple BRCMF_E_DEAUTH

Ok. Did you also try the firmware I sent you? Regards, Arend On Fri, Oct 14, 2016 at 8:33 AM, Rafał Miłecki <zaj...@gmail.com> wrote: > On 10/05/2016 11:08 AM, Arend Van Spriel wrote: >> >> On 4-10-2016 20:15, Rafał Miłecki wrote: >>> >>> On 0

Re: [PATCH] cfg80211: Add support to update connection parameters

On 13-10-16 17:39, Jouni Malinen wrote: > From: vamsi krishna > > Add functionality to update the connection parameters when in connected > state, so that driver/firmware uses the updated parameters for > subsequent roaming. This is for drivers that support internal BSS

Re: TCP data throughput for BCM43362

On 12-10-16 16:27, Jörg Krause wrote: > On Mi, 2016-10-12 at 10:11 +0200, Arend Van Spriel wrote: >> On 11-10-2016 8:14, Jörg Krause wrote: >>> >>> >>> >>> Hi Arend, >>> >>> Am 22. September 2016 16:00:36 MESZ, schrieb Arend Van Sprie

Re: bcmdhd: Strange Power Save messages

On 12-10-16 16:26, Gucea Doru wrote: > On Tue, Oct 11, 2016 at 10:12 PM, Arend van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 07-10-16 16:33, Gucea Doru wrote: >>> On Thu, Oct 6, 2016 at 10:25 AM, Arend Van Spriel >>> <arend.vanspr...@broadcom.com

Re: TCP data throughput for BCM43362

On 11-10-2016 8:14, Jörg Krause wrote: > > > Hi Arend, > > Am 22. September 2016 16:00:36 MESZ, schrieb Arend Van Spriel > <arend.vanspr...@broadcom.com>: >> Op 22 sep. 2016 14:52 schreef "Jörg Krause" >> <joerg.krause@embedded.rocks>: >&g

Re: bcmdhd: Strange Power Save messages

On 07-10-16 16:33, Gucea Doru wrote: > On Thu, Oct 6, 2016 at 10:25 AM, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 6-10-2016 10:07, Gucea Doru wrote: >>> On Wed, Oct 5, 2016 at 11:12 AM, Arend Van Spriel >>> <arend.vanspr...@broadcom.com

Re: bcmdhd: Strange Power Save messages

On 6-10-2016 10:07, Gucea Doru wrote: > On Wed, Oct 5, 2016 at 11:12 AM, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 4-10-2016 13:39, Gucea Doru wrote: >>> On Sat, Oct 1, 2016 at 2:52 PM, Arend van Spriel >>>> <arend.vanspr...@broadcom

Re: bcmdhd: Strange Power Save messages

On 4-10-2016 13:39, Gucea Doru wrote: > On Sat, Oct 1, 2016 at 2:52 PM, Arend van Spriel >> <arend.vanspr...@broadcom.com> wrote: >>> >>> >>> On 29-09-16 13:32, Gucea Doru wrote: >>>> On Tue, Sep 27, 2016 at 12:03 PM, Gucea Doru <gucea.d..

Re: BCM43602 firmware reports multiple BRCMF_E_DEAUTH

On 4-10-2016 20:15, Rafał Miłecki wrote: > On 09/28/2015 11:00 AM, Rafał Miłecki wrote: >> I'm using recent brcmfmac and brcmfmac43602-pcie.ap.bin that currently >> sits in linux-firmware.git. >> >> In OpenWrt we have hostapd with a feature of banning STAs. It works in >> a quite simple way.

Re: nl80211 fine timing measurement support

On 20-09-16 22:57, Lior David wrote: > On 9/20/2016 9:39 AM, Luca Coelho wrote: >> On Mon, 2016-09-19 at 20:42 +0200, Arend Van Spriel wrote: >>> >>> On 19-9-2016 19:31, Lior David wrote: >>>> >>>> Hi Johannes, >>>> >>>>

Re: bcmdhd: Strange Power Save messages

On 29-09-16 13:32, Gucea Doru wrote: > On Tue, Sep 27, 2016 at 12:03 PM, Gucea Doru wrote: >> What is the decision triggering the exit from the PS mode immediately >> after the ping request? I am asking this because 802.11 PS legacy >> specifies that the client should wait

Re: [PATCH] brcmfmac: implement more accurate skb tracking

On 29-9-2016 23:57, Rafał Miłecki wrote: > On 27 September 2016 at 11:24, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 26-9-2016 14:38, Rafał Miłecki wrote: >>> On 26 September 2016 at 14:13, Rafał Miłecki <zaj...@gmail.com> wrote: >>>

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

On 27-9-2016 13:58, Rafał Miłecki wrote: > On 27 September 2016 at 13:44, Rafał Miłecki <zaj...@gmail.com> wrote: >> On 27 September 2016 at 13:27, Kalle Valo <kv...@codeaurora.org> wrote: >>> Arend Van Spriel <arend.vanspr...@broadcom.com> writes: >>>

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

On 27-9-2016 13:27, Kalle Valo wrote: > Arend Van Spriel <arend.vanspr...@broadcom.com> writes: > >> On 27-9-2016 11:14, Rafał Miłecki wrote: >>> From: Rafał Miłecki <ra...@milecki.pl> >>> >>> Flowrings contain skbs waiting for transmission that

Re: [PATCH] nl80211: add key management offload feature

On 27-9-2016 12:56, Amitkumar Karwar wrote: > From: lihz Also the mailing list is no longer at shmoo.com. Should be: hos...@lists.infradead.org Regards, Arend

Re: [PATCH] brcmfmac: replace WARNING on timeout with a simple error message

anymore > and backtrace wasn't much useful. Indeed the interesting part would be in another context. So: Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > Signed-off-by: Rafał Miłecki <ra...@milecki.pl> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/c

Re: [PATCH] nl80211: add key management offload feature

On 27-9-2016 12:56, Amitkumar Karwar wrote: > From: lihz minor thing. Could you use another prefix iso 'nl80211:'. That has different expectation for me at least, ie. changes in nl80211 api, but this patch is for hostap repo so 'hostap:' or 'wpa_supp:' would be better fit here.

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

use freeing function > that will check for 802.1x type as well. > > Freeing skbs without a proper check was leading to counter not being > properly decreased. This was triggering a WARNING every time > brcmf_netdev_wait_pend8021x was called. Acked-by: Arend van Spriel <ar.

Re: [PATCH] brcmfmac: implement more accurate skb tracking

On 26-9-2016 14:38, Rafał Miłecki wrote: > On 26 September 2016 at 14:13, Rafał Miłecki <zaj...@gmail.com> wrote: >> On 26 September 2016 at 13:46, Arend Van Spriel >> <arend.vanspr...@broadcom.com> wrote: >>> On 26-9-2016 12:23, Rafał Miłecki wrote: >&g

Re: [PATCH] brcmfmac: implement more accurate skb tracking

On 26-9-2016 16:59, Dan Williams wrote: > On Mon, 2016-09-26 at 14:13 +0200, Rafał Miłecki wrote: >> On 26 September 2016 at 13:46, Arend Van Spriel >> <arend.vanspr...@broadcom.com> wrote: >>> >>> On 26-9-2016 12:23, Rafał Miłecki wrote: >>

Re: [PATCH] brcmfmac: implement more accurate skb tracking

On 26-9-2016 14:13, Rafał Miłecki wrote: > On 26 September 2016 at 13:46, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 26-9-2016 12:23, Rafał Miłecki wrote: >>> From: Rafał Miłecki <ra...@milecki.pl> >>> >>> We need to track 8

Re: [PATCH] brcmfmac: implement more accurate skb tracking

On 26-9-2016 12:23, Rafał Miłecki wrote: > From: Rafał Miłecki > > We need to track 802.1x packets to know if there are any pending ones > for transmission. This is required for performing key update in the > firmware. The problem we are trying to solve is a pretty old one.

Re: [PATCH 1/2] brcmfmac: initialize fws(ignal) for BCDC protocol only

On 24-9-2016 22:44, Rafał Miłecki wrote: > From: Rafał Miłecki > > There are two protocols used by Broadcom FullMAC devices: BCDC and > msgbuf. They use different ways for (some part of) communication with > the firmware. Firmware Signaling is required for the first one only >

Re: [PATCH] brcmfmac: fix memory leak in brcmf_fill_bss_param

On 21-9-2016 8:23, Rafał Miłecki wrote: > From: Rafał Miłecki <ra...@milecki.pl> > > This function is called from get_station callback which means that every > time user space was getting/dumping station(s) we were leaking 2 KiB. > Acked-by: Arend van Spriel <aren

Re: TCP data throughput for BCM43362

On 19-9-2016 8:36, Jörg Krause wrote: > Hi Arend, > > On Wed, 2016-09-14 at 20:13 +0200, Arend Van Spriel wrote: >> On 14-9-2016 15:41, Jörg Krause wrote: >>> >>> Hi, >>> >>> On Mon, 2016-08-29 at 23:15 +0200, Jörg Krause wrote: >>>>

Re: TCP data throughput for BCM43362

On 19-09-16 08:36, Jörg Krause wrote: > Hi Arend, > > On Wed, 2016-09-14 at 20:13 +0200, Arend Van Spriel wrote: >> On 14-9-2016 15:41, Jörg Krause wrote: >>> >>> Hi, >>> >>> On Mon, 2016-08-29 at 23:15 +0200, Jörg Krause wrote: >>>>

Re: [PATCH v3 0/9] Add support for Neighbor Awareness Networking

On 20-9-2016 16:31, Luca Coelho wrote: > From: Luca Coelho > > Hi, > > Now v3 of the NAN patchset. Ayala has taken care of the kbuild bot > compilation errors and of all Arend's comments, except for the one > about adding a helper function instead checking for

Re: [PATCH v2 2/9] mac80211: add boilerplate code for start / stop NAN

On 20-9-2016 16:36, Luca Coelho wrote: > Hi Arend, > > On Tue, 2016-09-20 at 14:29 +0200, Arend Van Spriel wrote: >> On 20-9-2016 13:45, Beker, Ayala wrote: >>> I don't think there is something in common to those interface types >>> that can fit such a fu

Re: [PATCH v2 2/9] mac80211: add boilerplate code for start / stop NAN

On 20-9-2016 13:45, Beker, Ayala wrote: > -Original Message- > From: Arend Van Spriel [mailto:arend.vanspr...@broadcom.com] > Sent: Sunday, September 18, 2016 22:01 > To: Otcheretianski, Andrei <andrei.otcheretian...@intel.com>; Luca Coelho > <l...@coelho.fi>

Re: [PATCH 1/1] rsi: fix memory leak in debugfs entry and supported bands

On 20-9-2016 8:43, Prameela Rani Garnepudi wrote: > From: Prameela Rani Garnepudi > > Signed-off-by: Prameela Rani Garnepudi > Signed-off-by: Prameela Rani Garnepudi Now you are

Re: nl80211 fine timing measurement support

On 19-9-2016 19:31, Lior David wrote: > Hi Johannes, > > We are working on adding indoor location support to the wil6210 11ad driver. > This includes fine timing measurement (FTM) as well as something we call > angle of arrival (AOA) which measures azimuth and elevation. > Initially we

<    7   8   9   10   11   12   13   14   15   16   >