Re: [PATCH] brcmfmac: shut down AP and set IBSS mode only on primary interface

2016-08-10 Thread Arend Van Spriel
On 10-8-2016 10:01, Wright Feng wrote: > When stopping hostap on virtual interface, driver will set INFRA and AP > mode that may affect the functionality on primary interface. For example, > if we create and stop hostapd on virtual interface then association > cannot work on primary interface becau

Re: [PATCH] brcmfmac: shut down AP and set IBSS mode only on primary interface

2016-08-10 Thread Arend Van Spriel
On 10-8-2016 11:44, Wright Feng wrote: > Hi Arend, > > Thanks for the reply. > > On 10-8-2016 10:26, Arend Van Spriel wrote: >> On 10-8-2016 10:01, Wright Feng wrote: >>> When stopping hostap on virtual interface, driver will set INFRA and >>> AP mode that

Re: [PATCH v2 8/8] p54: convert to sysdata API

2016-08-10 Thread Arend Van Spriel
On 10-8-2016 20:32, Luis R. Rodriguez wrote: > On Fri, Jun 17, 2016 at 08:35:03PM +0200, Luis R. Rodriguez wrote: >> On Thu, Jun 16, 2016 at 05:09:30PM -1000, Linus Torvalds wrote: >>> On Thu, Jun 16, 2016 at 3:36 PM, Luis R. Rodriguez >>> wrote: Reason this could not wait is folks seem

[PATCH 3/4] cfg80211: rdev-ops: remove callback check from rdev_start_radar_detection()

2016-08-10 Thread Arend van Spriel
move the callback checking in nl80211_start_radar_detection() before the other checks. Signed-off-by: Arend van Spriel --- net/wireless/nl80211.c | 7 --- net/wireless/rdev-ops.h | 7 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/net/wireless/nl80211.c b/net

[PATCH 2/4] cfg80211: rdev-ops: remove callback check from rdev_set_mcast_rate()

2016-08-10 Thread Arend van Spriel
van Spriel --- net/wireless/rdev-ops.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/wireless/rdev-ops.h b/net/wireless/rdev-ops.h index 903b58a..d002415 100644 --- a/net/wireless/rdev-ops.h +++ b/net/wireless/rdev-ops.h @@ -1050,11 +1050,10 @@ rdev_set_mcast_rate

[PATCH 1/4] cfg80211: rdev-ops: remove callback check from rdev_set_coalesce()

2016-08-10 Thread Arend van Spriel
The wrapper rdev_set_coalesce() checks whether the driver provides the set_coalesce callback and returns -ENOTSUPP if not. However, this check is already performed in nl80211_set_coalesce() resulting in -EOPNOTSUPP. This patch removes check from rdev wrapper function. Signed-off-by: Arend van

[PATCH 4/4] cfg80211: rdev-ops: remove checks from rdev_{add,del}_tx_ts()

2016-08-10 Thread Arend van Spriel
The wrappers check if callback is specified. Just have the checks in nl80211.c checking the NL80211_FEATURE_SUPPORTS_WMM_ADMISSION feature flag. If the driver sets this flag the callbacks are being checked in wiphy_register(). Signed-off-by: Arend van Spriel --- net/wireless/core.c | 4

Re: TCP data throughput for BCM43362

2016-08-07 Thread Arend van Spriel
gt; > > Am 5. August 2016 23:01:10 MESZ, schrieb Arend Van Spriel < > arend.vanspr...@broadcom.com>: > > > Op 5 aug. 2016 22:46 schreef "Jörg Krause" > : > > > > Hi, > > I'm using a custom ARM board with an BCM43362 wifi chip from >

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

2016-08-03 Thread Arend van Spriel
On 03-08-16 17:35, Dmitry Torokhov wrote: >> In my opinion the kernel should provide functionality to user-space and >> > user-space providing functionality to the kernel should be avoided. > Why? We have bunch of stuff running in userspace for the kernel. Fuse > for example. I am sure there are

Re: [RFC] ath10k: silence firmware file probing warnings

2016-08-03 Thread Arend van Spriel
On 03-08-16 19:10, Luis R. Rodriguez wrote: > On Wed, Aug 03, 2016 at 03:04:39PM +, Valo, Kalle wrote: >> "Luis R. Rodriguez" writes: >> >>> On Wed, Aug 03, 2016 at 01:33:31PM +0200, Arend van Spriel wrote: >>>> On 02-08-16 16:16, Luis R. Rodrig

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

2016-08-03 Thread Arend van Spriel
On 03-08-16 09:42, Dmitry Torokhov wrote: > On Tue, Aug 2, 2016 at 12:41 AM, Luis R. Rodriguez wrote: >> On Tue, Aug 02, 2016 at 08:53:55AM +0200, Daniel Wagner wrote: >>> On 08/02/2016 08:34 AM, Luis R. Rodriguez wrote: On Tue, Aug 02, 2016 at 07:49:19AM +0200, Daniel Wagner wrote: >> Th

Re: [RFC] ath10k: silence firmware file probing warnings

2016-08-03 Thread Arend van Spriel
On 02-08-16 16:16, Luis R. Rodriguez wrote: > On Tue, Aug 02, 2016 at 11:10:22AM +, Valo, Kalle wrote: >> "Luis R. Rodriguez" writes: >> >>> I was considering this as a future extension to the firmware API >>> through the new extensible firmware API, the sysdata API. >> >> I think Linus ment

Re: [PATCH 0768/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Arend van Spriel
On 02-08-16 19:52, Kalle Valo wrote: > (Trimming CC) > > Baole Ni writes: > >> I find that the developers often just specified the numeric value >> when calling a macro which is defined with a parameter for access permission. >> As we know, these numeric value for access permission have had th

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

2016-07-30 Thread Arend van Spriel
+ Luis (again) ;-) On 29-07-16 08:13, Daniel Wagner wrote: > On 07/28/2016 09:01 PM, Bjorn Andersson wrote: >> On Thu 28 Jul 11:33 PDT 2016, Dmitry Torokhov wrote: >> >>> On Thu, Jul 28, 2016 at 09:55:11AM +0200, Daniel Wagner wrote: From: Daniel Wagner >> [..] >>> >>> Do not quite like

Re: [RFC] ath10k: silence firmware file probing warnings

2016-07-28 Thread Arend van Spriel
On 23-07-16 00:15, Luis R. Rodriguez wrote: > On Fri, Jul 22, 2016 at 12:26:00PM +0200, Stanislaw Gruszka wrote: >> On Fri, Jul 22, 2016 at 10:38:24AM +0200, Arend Van Spriel wrote: >>> + Luis >>> >>> On 21-7-2016 13:51, Stanislaw Gruszka wrote: >>

Re: [RFC] ath10k: silence firmware file probing warnings

2016-07-28 Thread Arend van Spriel
On 23-07-16 00:05, Luis R. Rodriguez wrote: > On Fri, Jul 22, 2016 at 10:38:24AM +0200, Arend Van Spriel wrote: >> + Luis >> >> On 21-7-2016 13:51, Stanislaw Gruszka wrote: >>> (cc: firmware and brcmfmac maintainers) >>> >>> On Thu, Jul 21,

Re: brcm4330 fails to load on newer kernels

2016-07-28 Thread Arend van Spriel
On 27-07-16 22:57, Fabio Estevam wrote: > Hi Arend, > > On Wed, Jul 27, 2016 at 5:51 PM, Arend van Spriel > wrote: >> On 27-07-16 00:35, Fabio Estevam wrote: >>> Hi, >>> >>> On a imx6sl-warp board with a brcm4330 I get the following results >>

Re: brcm4330 fails to load on newer kernels

2016-07-27 Thread Arend van Spriel
On 27-07-16 00:35, Fabio Estevam wrote: > Hi, > > On a imx6sl-warp board with a brcm4330 I get the following results > depending on the kernel version: > > - Kernel 4.4.15: place brcmfmac4330-sdio.bin and brcmfmac4330-sdio.txt > in the rootfs and the kernel is able to read them correctly. wlan0 i

Re: BRCM4339 NVRAM file

2016-07-26 Thread Arend van Spriel
On 25-07-16 22:36, Fabio Estevam wrote: > Hi, > > I am trying to use brcm4339 on a imx6ul-pico board running kernel 4.7. > > According to commit bed89b64bcbc7 (" brcmfmac: add firmware and nvram > file name for bcm4339") we need to provide brcmfmac4339-sdio.bin and > brcmfmac4339-sdio.txt files

Re: [RFC] ath10k: silence firmware file probing warnings

2016-07-22 Thread Arend Van Spriel
On 22-7-2016 12:26, Stanislaw Gruszka wrote: > On Fri, Jul 22, 2016 at 10:38:24AM +0200, Arend Van Spriel wrote: >> + Luis >> >> On 21-7-2016 13:51, Stanislaw Gruszka wrote: >>> (cc: firmware and brcmfmac maintainers) >>> >>> On Thu, Jul 21,

Re: [RFC] ath10k: silence firmware file probing warnings

2016-07-22 Thread Arend Van Spriel
+ Luis On 21-7-2016 13:51, Stanislaw Gruszka wrote: > (cc: firmware and brcmfmac maintainers) > > On Thu, Jul 21, 2016 at 06:23:11AM -0400, Prarit Bhargava wrote: >> >> >> On 07/21/2016 04:05 AM, Stanislaw Gruszka wrote: >>> On Thu, Jul 21, 2016 at 10:36:42AM +0300, Emmanuel Grumbach wrote:

Re: Problem connecting to wifi on libertas_cpio (sd8686)

2016-07-22 Thread Arend Van Spriel
On 22-7-2016 0:00, Christopher Williamson wrote: > I’ve created cleaner logs (particularly the dmesg one) and have added > timestamps line-by-line to both so it should be easier to track > between the two log files: > > wpa_supplicant: > http://termbin.com/cx0e > > dmesg | grep libertas: > http:/

Re: [PATCH 0/4] brcm80211: Misc coverity fixes

2016-07-19 Thread Arend Van Spriel
On 19-7-2016 20:30, Florian Fainelli wrote: > On 07/19/2016 11:21 AM, Arend Van Spriel wrote: >> On 19-7-2016 18:41, Florian Fainelli wrote: >>> On 07/19/2016 02:20 AM, Arend Van Spriel wrote: >>>> + Bob >>>> >>>> On 19-7-2016 1:24, Florian F

Re: [PATCH 3/4] brcmsmac: Fix invalid memcpy() size in brcms_c_d11hdrs_mac80211

2016-07-19 Thread Arend Van Spriel
On 19-7-2016 18:42, Florian Fainelli wrote: > On 07/19/2016 03:38 AM, Arend Van Spriel wrote: >> On 19-7-2016 1:24, Florian Fainelli wrote: >>> struct ieee80211_rts::ra is only ETH_ALEN wide, yet we attempt to copy 2 >>> * ETH_ALEN, which will potentially ove

Re: [PATCH 0/4] brcm80211: Misc coverity fixes

2016-07-19 Thread Arend Van Spriel
On 19-7-2016 18:41, Florian Fainelli wrote: > On 07/19/2016 02:20 AM, Arend Van Spriel wrote: >> + Bob >> >> On 19-7-2016 1:24, Florian Fainelli wrote: >>> Hi, >>> >>> This patch series addresses several coverity issues, they all seemed >>>

Re: [PATCH 3/4] brcmsmac: Fix invalid memcpy() size in brcms_c_d11hdrs_mac80211

2016-07-19 Thread Arend Van Spriel
On 19-7-2016 1:24, Florian Fainelli wrote: > struct ieee80211_rts::ra is only ETH_ALEN wide, yet we attempt to copy 2 > * ETH_ALEN, which will potentially overrun the destination buffer. NACK - this is intentional. Have to admit it is a bit of trickery. struct ieee80211_rts is mapped over struct d

Re: [PATCH 4/4] brcmsmac: Initialize power in brcms_c_stf_ss_algo_channel_get()

2016-07-19 Thread Arend Van Spriel
re calling into wlc_phy_txpower_get_current(). > > Reported-by: coverity (CID 146011) > Fixes: 5b435de0d7868 ("net: wireless: add brcm80211 drivers") Acked-by: Arend van Spriel > Signed-off-by: Florian Fainelli > --- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/stf.c

Re: [PATCH 1/4] brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain

2016-07-19 Thread Arend Van Spriel
73 ("brcmfmac: fix brcmf_sdcard_recv_chain() for host > without sg support") Acked-by: Arend van Spriel > Signed-off-by: Florian Fainelli > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > dif

Re: [PATCH 2/4] brcmsmac: Free packet if dma_mapping_error() fails in dma_rxfill

2016-07-19 Thread Arend Van Spriel
by lack of calls to > dma_mapping_error()") Acked-by: Arend van Spriel > Signed-off-by: Florian Fainelli > --- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/

Re: [PATCH 0/4] brcm80211: Misc coverity fixes

2016-07-19 Thread Arend Van Spriel
+ Bob On 19-7-2016 1:24, Florian Fainelli wrote: > Hi, > > This patch series addresses several coverity issues, they all seemed relevant > to me. Hi Florian, Been a while so nice to see coverity fixes popping up. Actually something that I have on my todo list to add our brcm80211 to coverity wi

Re: [PATCH v2] cfg80211: Allow differnt beacon interval if driver supports

2016-07-18 Thread Arend Van Spriel
On 18-7-2016 21:21, Arend Van Spriel wrote: > On 18-7-2016 21:15, Johannes Berg wrote: >> On Mon, 2016-07-18 at 21:13 +0200, Arend Van Spriel wrote: >>> >>> On 18-7-2016 20:56, Johannes Berg wrote: >>>> On Mon, 2016-07-18 at 19:23 +0530, Purushottam Kushwah

Re: [PATCH v2] cfg80211: Allow differnt beacon interval if driver supports

2016-07-18 Thread Arend Van Spriel
On 18-7-2016 21:15, Johannes Berg wrote: > On Mon, 2016-07-18 at 21:13 +0200, Arend Van Spriel wrote: >> >> On 18-7-2016 20:56, Johannes Berg wrote: >>> On Mon, 2016-07-18 at 19:23 +0530, Purushottam Kushwaha wrote: >>>> Driver may allow support for

Re: [PATCH v2] cfg80211: Allow differnt beacon interval if driver supports

2016-07-18 Thread Arend Van Spriel
On 18-7-2016 20:56, Johannes Berg wrote: > On Mon, 2016-07-18 at 19:23 +0530, Purushottam Kushwaha wrote: >> Driver may allow support for different beacon interval on virtual >> interfaces. >> Allow if such support is advertised by driver. This adds new >> ext_feature as NL80211_EXT_FEATURE_DIFF_

Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property

2016-07-18 Thread Arend Van Spriel
On 17-7-2016 23:45, Rob Herring wrote: > On Thu, Jul 07, 2016 at 10:46:28AM +0200, Arnd Bergmann wrote: >> On Wednesday, July 6, 2016 9:19:41 PM CEST Arend Van Spriel wrote: >>> On 6-7-2016 15:42, Arnd Bergmann wrote: >>>> On Wednesday, July 6, 2016 10:08:55

[PATCH] brcmfmac: defer DPC processing during probe

2016-07-15 Thread Arend van Spriel
Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- Hi Kalle, Here a straggler commit for wireless-drivers-next. No harm if it does not make it in v4.8. Regards, Arend --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 7 +++ 1 file

[PATCH] brcmfmac: restore stopping netdev queue when bus clogs up

2016-07-15 Thread Arend van Spriel
tored. Cc: sta...@vger.kernel.org # v4.5, v4.6, v4.7 Fixes: 9cd18359d31e ("brcmfmac: Make FWS queueing configurable.") Tested-by: Per Förlin Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- Hi Kalle, The issue f

Re: [PATCH 1/4 v2 iface_work] New function ieee80211_is_skb_handled_by_pkt_type

2016-07-15 Thread Arend Van Spriel
On 15-7-2016 11:06, Alex Briskin wrote: > Split ieee80211_iface_work in two. Moved part of a code that checks > pkt_type. As mentioned before the subject of the patches should use "mac80211: " prefix. So: [PATCH 1/4 v2] mac80211: New function ieee80211_is_skb_handled_by_pkt_type So I did not mea

Re: [PATCH v4] brcmfmac: Decrease 8021x_cnt for dropped packets

2016-07-14 Thread Arend Van Spriel
On 13-7-2016 20:52, Per Förlin wrote: > 2016-07-13 13:20 GMT+02:00 Arend Van Spriel : >> On 12-7-2016 12:23, Per Förlin wrote: >>> 2016-07-12 11:48 GMT+02:00 Arend Van Spriel : >>>> >>>> >>>> On 12-7-2016 10:35, Per Förlin wrote: >>&

Re: [PATCH 0/4 v1] Refactoring ieee80211_iface_work

2016-07-14 Thread Arend Van Spriel
On 13-7-2016 22:19, Alex Briskin wrote: > Hi All, > This is my first patch(s). Hi Alex, As these patches are touching mac80211 it would be good to use 'mac80211: ' prefix. > I've decided to refactor ieee80211_iface_work function and break it down > to smaller better defined function. > > I thin

Re: [PATCH v4] brcmfmac: Decrease 8021x_cnt for dropped packets

2016-07-13 Thread Arend Van Spriel
On 12-7-2016 12:23, Per Förlin wrote: > 2016-07-12 11:48 GMT+02:00 Arend Van Spriel : >> >> >> On 12-7-2016 10:35, Per Förlin wrote: >>> 2016-07-06 11:53 GMT+02:00 Per Förlin : >>>> I have now verified this patch on backports 4.4. >>>> >

Re: iwlwifi + wpa2-leap + multiple AP's = call trace

2016-07-12 Thread Arend Van Spriel
On 13-7-2016 2:29, Ismael Farfán wrote: > Hello list > > I searched this error around and didn't find anything, so here it goes. > > Today I tried to connect to an enterprise network, which means, > literally, tens of AP's sharing the same name... the network requieres > user/password authentic

Re: building brcmfmac driver for iMX6 Ultralite platform

2016-07-12 Thread Arend Van Spriel
On 12-7-2016 23:10, Rafał Miłecki wrote: > On 12 July 2016 at 21:17, Michael Eskowitz wrote: >> Arend, > > What about my reply? ;) > > >> That is news to me. I was under the impression that bcmdhd was Broadcom's >> proprietary (closed source) Linux driver and brcmfmac was the open source >>

Re: [PATCH v4] brcmfmac: Decrease 8021x_cnt for dropped packets

2016-07-12 Thread Arend Van Spriel
On 12-7-2016 10:35, Per Förlin wrote: > 2016-07-06 11:53 GMT+02:00 Per Förlin : >> I have now verified this patch on backports 4.4. >> >> 2016-04-12 23:55 GMT+02:00 : >>> From: Per Forlin >>> >>> This patch resolves an issue where pend_8021x_cnt was not decreased >>> on txfinalize. This caused

Re: [RFC v2 1/3] nl80211: Add nl80211_notify_iface

2016-07-11 Thread Arend Van Spriel
On 11-7-2016 9:39, Marcel Holtmann wrote: > Hi Julian, > >> This function emits NL80211_CMD_NEW_INTERFACE or >> NL80211_CMD_DEL_INTERFACE events. This is meant to be used by the core >> to notify userspace applications such as wpa_supplicant when a netdev >> related to a wireless

Re: [RFC v2 1/3] nl80211: Add nl80211_notify_iface

2016-07-10 Thread Arend Van Spriel
On 9-7-2016 16:05, Marcel Holtmann wrote: > Hi Denis, > >> This function emits NL80211_CMD_NEW_INTERFACE or >> NL80211_CMD_DEL_INTERFACE events. This is meant to be used by the core >> to notify userspace applications such as wpa_supplicant when a netdev >> related to a wireless device has been

Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property

2016-07-07 Thread Arend Van Spriel
On 7-7-2016 10:46, Arnd Bergmann wrote: > On Wednesday, July 6, 2016 9:19:41 PM CEST Arend Van Spriel wrote: >> On 6-7-2016 15:42, Arnd Bergmann wrote: >>> On Wednesday, July 6, 2016 10:08:55 AM CEST Arend Van Spriel wrote: >>>> On Tue, Jul 5, 2016 at 3:43 PM,

Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property

2016-07-06 Thread Arend Van Spriel
On 6-7-2016 15:42, Arnd Bergmann wrote: > On Wednesday, July 6, 2016 10:08:55 AM CEST Arend Van Spriel wrote: >> On Tue, Jul 5, 2016 at 3:43 PM, Arnd Bergmann wrote: >>> On Monday, July 4, 2016 8:36:05 PM CEST Arend van Spriel wrote: >>>> On 04-07-16 16:54, Arnd B

Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property

2016-07-06 Thread Arend Van Spriel
On Tue, Jul 5, 2016 at 3:43 PM, Arnd Bergmann wrote: > On Monday, July 4, 2016 8:36:05 PM CEST Arend van Spriel wrote: >> On 04-07-16 16:54, Arnd Bergmann wrote: >> > On Monday, July 4, 2016 11:08:38 AM CEST Arend Van Spriel wrote: >> > >> > In drivers/net/

Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property

2016-07-04 Thread Arend van Spriel
On 04-07-16 16:54, Arnd Bergmann wrote: > On Monday, July 4, 2016 11:08:38 AM CEST Arend Van Spriel wrote: >> On 4-7-2016 10:55, Arnd Bergmann wrote: >>> On Monday, July 4, 2016 10:41:20 AM CEST Arend Van Spriel wrote: >>>> On 2-7-2016 23:30, Arnd Bergmann wrote: >

Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property

2016-07-04 Thread Arend Van Spriel
On 4-7-2016 10:55, Arnd Bergmann wrote: > On Monday, July 4, 2016 10:41:20 AM CEST Arend Van Spriel wrote: >> On 2-7-2016 23:30, Arnd Bergmann wrote: >>> On Saturday, July 2, 2016 8:20:35 PM CEST Arend Van Spriel wrote: >>>>> If you want a separate prop

Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property

2016-07-04 Thread Arend Van Spriel
On 2-7-2016 23:30, Arnd Bergmann wrote: > On Saturday, July 2, 2016 8:20:35 PM CEST Arend Van Spriel wrote: >>> If you want a separate property, then I repeat my very first >>> suggestion, the well defined model property. >>> e.g. >>> >>

Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property

2016-07-02 Thread Arend Van Spriel
On 1-7-2016 10:58, Jonas Gorski wrote: > Hi, > > On 30 June 2016 at 21:23, Arend Van Spriel > wrote: >> >> >> On 30-6-2016 13:31, Arnd Bergmann wrote: >>> On Thursday, June 30, 2016 12:25:15 PM CEST Hans de Goede wrote: >>>>> So then how

Re: [patch] mwifiex: fix mwifiex_add_virtual_intf()

2016-07-02 Thread Arend Van Spriel
On 2-7-2016 9:20, Dan Carpenter wrote: > We accidentally left some if statements out so the > mwifiex_add_virtual_intf() function returns early. > > Fixes: 7311ea850079 ('mwifiex: fix AP start problem for newly added > interface') > Signed-off-by: Dan Carpenter Someone beat you to it [1] ;-)

Re: building brcmfmac driver for iMX6 Ultralite platform

2016-07-01 Thread Arend Van Spriel
On 1-7-2016 11:07, Rafał Miłecki wrote: > On 30 June 2016 at 21:24, Michael Eskowitz wrote: >> insmod brcmfmac.ko >> firmware_path=ISM4334X_Wifi_FW_6.10.190.49_P.bin >> nvram_path=ISM4334X_NVRAM_C1.txt >> >> I receive the following errors: >> >> brcmfmac: Unknown symbol brcmu_pktq

Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property

2016-07-01 Thread Arend Van Spriel
On 1-7-2016 4:08, Rob Herring wrote: > On Wed, Jun 29, 2016 at 04:04:31PM +0200, Hans de Goede wrote: >> Add a brcm,nvram_file_name dt property to allow overruling the default >> nvram filename for sdio devices. The idea is that we can specify a >> board specific nvram file, e.g. brcmfmac43362-ap

Re: building brcmfmac driver for iMX6 Ultralite platform

2016-07-01 Thread Arend Van Spriel
On 30-6-2016 21:24, Michael Eskowitz wrote: > I am trying to bring up the brcmfmac driver on an iMX6 Ultralite board. I > have both a 43341 and 43362 Wi-Fi SDIO module up and running on this > platform already using the standard bcmdhd. I am told by some Broadcom > folks that the brcmfmac driver

Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property

2016-06-30 Thread Arend Van Spriel
On 30-6-2016 13:31, Arnd Bergmann wrote: > On Thursday, June 30, 2016 12:25:15 PM CEST Hans de Goede wrote: >>> So then how about making use of a more specific compatible string? >>> >>> e.g. >>> >>> brcmf { >>> compatible = "foo,ap6210", "brcm,bcm4329-fmac"; >>> ... >>> }; >>> >>

Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property

2016-06-29 Thread Arend Van Spriel
On 29-6-2016 20:51, Arend Van Spriel wrote: > On 29-6-2016 20:01, Hans de Goede wrote: >> Hi, >> >> On 29-06-16 19:00, Kalle Valo wrote: >>> Hans de Goede writes: >>> >>>> Hi, >>>> >>>> On 29-06-16 16:42, Jonas Gorski

Re: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property

2016-06-29 Thread Arend Van Spriel
On 29-6-2016 20:01, Hans de Goede wrote: > Hi, > > On 29-06-16 19:00, Kalle Valo wrote: >> Hans de Goede writes: >> >>> Hi, >>> >>> On 29-06-16 16:42, Jonas Gorski wrote: Hi, On 29 June 2016 at 16:04, Hans de Goede wrote: > Add a brcm,nvram_file_name dt property to allow overr

Re: [PATCH RFC v2 1/2] Documentation: dt: net: add ath9k wireless device binding

2016-06-23 Thread Arend Van Spriel
On 23-6-2016 19:45, Martin Blumenstingl wrote: > Add documentation how devicetree can be used to configure ath9k based > devices. > > Signed-off-by: Martin Blumenstingl > --- > changes in v1 -> v2: > - use vendor prefix "qca" instead of "ath" > - extend the example so it includes the "compatibl

Re: [PATCH] brcmfmac: Add USB ID for Cisco Linksys AE1200

2016-06-22 Thread Arend van Spriel
On 22-06-16 20:36, Ismael Luceno wrote: > On 21/Jun/2016 21:02, Arend van Spriel wrote: >> On 21-06-16 02:18, Ismael Luceno wrote: >>> Signed-off-by: Ismael Luceno >> >> A bit more description would be nice. I am actually wondering why you >> would be adding t

Re: [PATCH] brcmfmac: Add USB ID for Cisco Linksys AE1200

2016-06-21 Thread Arend van Spriel
On 21-06-16 02:18, Ismael Luceno wrote: > Signed-off-by: Ismael Luceno A bit more description would be nice. I am actually wondering why you would be adding this. If I am not mistaken the AE1200 can not be handled by brcmfmac. Otherwise I am interested in a kernel log showing the device probe seq

Re: [PATCH RFC 2/2] brcmfmac: support removing AP interfaces with "interface_remove"

2016-06-18 Thread Arend van Spriel
On 18-06-16 20:18, Rafał Miłecki wrote: > New firmwares (e.g. 10.10.69.36 for BCM4366) support "interface_remove" > for removing interfaces. Try to use this method on cfg80211 request. In > case of older firmwares (e.g. 7.35.177.56 for BCM43602 as I tested) this > will just result in firmware rejec

Re: [PATCH RFC 1/2] brcmfmac: remove interface before notifying listener

2016-06-18 Thread Arend van Spriel
On 18-06-16 20:18, Rafał Miłecki wrote: > So far when receiving event about in-firmware-interface removal we were > notifying our listener and afterwards we were removing Linux interface. > [snip] > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c > b/drivers/net/wireless

Re: [PATCH RFC] brcmfmac: support deleting MBSS AP interfaces

2016-06-17 Thread Arend van Spriel
On 17-06-16 14:30, Rafał Miłecki wrote: > On 1 June 2016 at 21:00, Arend van Spriel > wrote: >> On 01-06-16 16:36, Rafał Miłecki wrote: >>> We already support adding extra (AP) interfaces so it also makes an >>> obvious sense to allow deleting them. >>> &g

Re: [PATCHv2 1/2] add basic register-field manipulation macros

2016-06-14 Thread Arend van Spriel
On 14-06-16 13:44, Jakub Kicinski wrote: > C bitfields are problematic and best avoided. Developers > interacting with hardware registers find themselves searching > for easy-to-use alternatives. Common approach is to define > structures or sets of macros containing mask and shift pair. > Operati

Re: [PATCH] brcmfmac: rework function picking free BSS index

2016-06-13 Thread Arend van Spriel
On 09-06-16 21:16, Arend van Spriel wrote: > On 26-05-16 01:44, Rafał Miłecki wrote: >> The old implementation was overcomplicated and slightly bugged in some >> corner cases. >> [...] >> New code is simpler, placed in file where it's really used, handles &

Re: NL80211_ATTR_PAD question

2016-06-13 Thread Arend van Spriel
On 10-06-16 23:08, Johannes Berg wrote: > On Fri, 2016-06-10 at 12:47 -0700, Ben Greear wrote: >> I see this was added sometime recently: NL80211_ATTR_PAD >> >> If another enum member is added, should it replace the PAD enum? > > No. > >> At the least, I think we need some comments about how t

Re: NL80211_ATTR_PAD question

2016-06-10 Thread Arend van Spriel
On 10-06-16 21:47, Ben Greear wrote: > I see this was added sometime recently: NL80211_ATTR_PAD > > If another enum member is added, should it replace the PAD enum? Nope. This attribute is used as padattr by 64-bit aligned netlink functions, ie. nla_put_u64_64bit(). > At the least, I think we

Re: [PATCH] brcmfmac: rework function picking free BSS index

2016-06-09 Thread Arend van Spriel
On 26-05-16 01:44, Rafał Miłecki wrote: > The old implementation was overcomplicated and slightly bugged in some > corner cases. > > Consider following state of BSS-es (limited to 6 for simplification): > drvr->iflist[0]: { bsscfgidx:0, ndev->name:wlan1, } > drvr->iflist[1]: (null) > drvr->iflist

Re: [PATCH] brcmfmac: slightly simplify building interface combinations

2016-06-09 Thread Arend van Spriel
nels >before preparing limits). > 3) It modifies mbss code to use i variable just like other combos do. Acked-by: Arend van Spriel > Signed-off-by: Rafał Miłecki > --- > .../broadcom/brcm80211/brcmfmac/cfg80211.c | 37 > ++ > 1 file changed,

Re: [PATCH] nl80211: avoid possible memleak on nl80211_set_reg

2016-06-09 Thread Arend Van Spriel
On 9-6-2016 9:58, Johannes Berg wrote: > On Mon, 2016-06-06 at 16:56 +0200, Eduardo Abinader wrote: >> Setting NULL just after freeing regdomain. >> >> Signed-off-by: Eduardo Abinader >> --- >> net/wireless/nl80211.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/ne

[PATCH 6/6] brcm80211: update maintainers email addresses

2016-06-03 Thread Arend van Spriel
From: Arend van Spriel Update MAINTAINERS file because of organizational changes. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel --- MAINTAINERS | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff

[PATCH 2/6] brcmfmac: revise SDIO error message in brcmf_sdio_drivestrengthinit

2016-06-03 Thread Arend van Spriel
commit message] Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index

[PATCH 3/6] brcmfmac: use ndev->needed_headroom to reserve additional header space

2016-06-03 Thread Arend van Spriel
to definition of LL_RESERVED_SPACE() and hard_header_len, we should use hard_header_len to reserve for L2 header, like ethernet header(ETH_HLEN) in our case and use needed_headroom for the additional headroom needed by hardware. Reviewed-by: Arend Van Spriel Signed-off-by: Wright Feng Signed-o

[PATCH 5/6] brcmfmac: change rx_seq check log from error print to debug print

2016-06-03 Thread Arend van Spriel
error message is rephrased and changed to a debug message. Reviewed-by: Arend Van Spriel Signed-off-by: Wright Feng Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless

[PATCH 1/6] brcmfmac: fix skb priority handling

2016-06-03 Thread Arend van Spriel
From: Hante Meuleman SKBs can come with a prioriy. Currently a priority of 0..7 is assumed. But this assumption is incorrect. To fix this any priority of 0 or higher then 7 will be adjusted by calling cfg80211_classify8021d Reviewed-by: Arend Van Spriel Reviewed-by: Franky Lin Reviewed-by

[PATCH 4/6] brcmfmac: add support for the PCIE devices 43525 and 43465

2016-06-03 Thread Arend van Spriel
From: Hante Meuleman This patch adds support for the new PCIE devices 43525 and 43465. Reviewed-by: Arend Van Spriel Reviewed-by: Franky (Zhenhui) Lin Reviewed-by: Pieter-Paul Giesberts Signed-off-by: Hante Meuleman Signed-off-by: Arend van Spriel --- drivers/net/wireless/broadcom

[PATCH 0/6] brcm80211: contact info update and new devices

2016-06-03 Thread Arend van Spriel
This patch series provides: * update contact info in MAINTAINERS file. * support for BCM43525 and BCM43465 PCIe devices. * couple of smallish fixes in SDIO. The patch series is intended for v4.8 and applies to the master branch of the wireless-drivers-next repository. Arend van Spriel (1

Re: [PATCH for-4.7] brcmfmac: add eth_type_trans back for PCIe full dongle

2016-06-02 Thread Arend van Spriel
On 02-06-16 11:44, Kalle Valo wrote: > Kalle Valo writes: > >> Arend van Spriel writes: >> >>> From: Franky Lin >>> >>> A regression was introduced in commit 9c349892ccc9 ("brcmfmac: revise >>> handling events in receive path") w

[PATCH V2 for-4.7] brcmfmac: add eth_type_trans back for PCIe full dongle

2016-06-02 Thread Arend van Spriel
8b 15 59 c5 42 00 RIP [] enqueue_to_backlog+0x56/0x260 RSP CR2: 0048 Fixes: 9c349892ccc9 ("brcmfmac: revise handling events in receive path") Reported-by: Rafal Milecki Reported-by: Grey Christoforo Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Arend Van Spriel Reviewed-by

Re: 4.7-rc1 wifi driver bug report

2016-06-01 Thread Arend Van Spriel
On 31-5-2016 13:46, Grey Christoforo wrote: > Hi, > > I found the following in my dmesg today when I tried out 4.7-rc1 on my > Dell XPS15 9550. My WiFi doesn't work. > > Relevant bits of my lsusb & lspci are: > > $ lsusb > ... > Bus 001 Device 002: ID 0a5c:6410 Broadcom Corp. > ... > $ lspci > .

Re: [PATCH for-4.7] brcmfmac: add eth_type_trans back for PCIe full dongle

2016-06-01 Thread Arend Van Spriel
On 1-6-2016 23:13, Arend van Spriel wrote: > From: Franky Lin > > A regression was introduced in commit 9c349892ccc9 ("brcmfmac: revise > handling events in receive path") which moves eth_type_trans() call > to brcmf_rx_frame(). Msgbuf layer doesn't us

[PATCH for-4.7] brcmfmac: add eth_type_trans back for PCIe full dongle

2016-06-01 Thread Arend van Spriel
8b 15 59 c5 42 00 RIP [] enqueue_to_backlog+0x56/0x260 RSP CR2: 0048 Reported-by: Grey Christoforo Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Arend Van Spriel Reviewed-by: Hante Meuleman Signed-off-by: Franky Lin [ar...@broadcom.com: rephrased the commit message] Signed-off

Re: [PATCH RFC] brcmfmac: support deleting MBSS AP interfaces

2016-06-01 Thread Arend van Spriel
On 01-06-16 16:36, Rafał Miłecki wrote: > We already support adding extra (AP) interfaces so it also makes an > obvious sense to allow deleting them. > > Adding a new interface is implemented by sending request to firmware for > creating a new BSS and waiting for a proper event. Ideally deleting >

Re: BCM4331 reset leads to wl lockup

2016-05-29 Thread Arend van Spriel
On 29-05-16 13:02, Lukas Wunner wrote: > On Thu, May 26, 2016 at 02:42:46PM +0200, Michael Büsch wrote: >> On Thu, 26 May 2016 14:12:10 +0200 Lukas Wunner wrote: >>> + mmio = early_ioremap(addr, BCM4331_MMIO_SIZE); >>> + if (!mmio) { >>> + pr_err("Cannot iomap Apple AirPort card\n");

Re: BCM4331 reset leads to wl lockup

2016-05-29 Thread Arend van Spriel
On 29-05-16 13:02, Lukas Wunner wrote: > On Thu, May 26, 2016 at 02:42:46PM +0200, Michael Büsch wrote: >> On Thu, 26 May 2016 14:12:10 +0200 Lukas Wunner wrote: >>> + mmio = early_ioremap(addr, BCM4331_MMIO_SIZE); >>> + if (!mmio) { >>> + pr_err("Cannot iomap Apple AirPort card\n");

Re: [RFCv2] brcmfmac: Add tracepoints for bcmdhd-dissector tool

2016-05-27 Thread Arend Van Spriel
On 27-5-2016 16:24, Mikael Kanstrup wrote: > Add hexdump tracepoints to be used bcmdhd-dissector: > https://github.com/kanstrup/bcmdhd-dissector > > bcmdhd-dissector is a Wireshark LUA plugin dissector used to decode > protocol data between the brcmfmac driver and the wifi chip firmware. > This

Re: [PATCH V5] brcmfmac: print errors if creating interface fails

2016-05-27 Thread Arend Van Spriel
On 27-5-2016 11:13, Julian Calaby wrote: > Hi Arend, > > On Fri, May 27, 2016 at 6:49 PM, Arend van Spriel wrote: >> From: Rafał Miłecki >> >> This is helpful for debugging. Without this all I was getting from "iw" >> command on failed creating of P2P

[PATCH V6] brcmfmac: print errors if creating interface fails

2016-05-27 Thread Arend van Spriel
ation] Signed-off-by: Arend van Spriel --- V2: s/in/if/ in commit message V3: Add one more error message as suggested by Arend V4: Also update brcmf_cfg80211_add_iface & print error for AP V5: remove error prints from p2p.c V6: fix compiler warning and remove duplicate calls --- .../net/

[PATCH V5] brcmfmac: print errors if creating interface fails

2016-05-27 Thread Arend van Spriel
ation] Signed-off-by: Arend van Spriel --- V2: s/in/if/ in commit message V3: Add one more error message as suggested by Arend V4: Also update brcmf_cfg80211_add_iface & print error for AP V5: remove error prints from p2p.c --- drivers/net/wireless/broadcom/brcm80211/brcmfma

Re: [PATCH V3] brcmfmac: print error if p2p_ifadd firmware command fails

2016-05-26 Thread Arend Van Spriel
On 26-5-2016 0:44, Rafał Miłecki wrote: > This is helpful for debugging, without this all I was getting from "iw" > command on device with BCM43602 was: >> command failed: Too many open files in system (-23) > > Signed-off-by: Rafał Miłecki > --- > V2: s/in/if/ in commit message > V3: Add one mor

Re: [PATCH] brcmfmac: fix setting AP channel with new firmwares

2016-05-25 Thread Arend van Spriel
On 24-05-16 11:09, Rafał Miłecki wrote: > Firmware for new chipsets is based on a new major version of code > internally maintained at Broadcom. E.g. brcmfmac4366b-pcie.bin (used for > BCM4366B1) is based on 10.10.69.3309 while brcmfmac43602-pcie.ap.bin was > based on 7.35.177.56. > > Currently

Re: [PATCH V2] brcmfmac: print error if p2p_ifadd firmware command fails

2016-05-25 Thread Arend van Spriel
On 24-05-16 23:05, Rafał Miłecki wrote: > This is helpful for debugging, without this all I was getting from "iw" > command on device with BCM43602 was: >> command failed: Too many open files in system (-23) > > Signed-off-by: Rafał Miłecki > --- > V2: s/in/if/ in commit message > --- > drivers/

Re: Problem with brcmfmac removing extra interface

2016-05-24 Thread Arend Van Spriel
On 23-3-2016 20:13, Rafał Miłecki wrote: > On 23 March 2016 at 11:44, Arend Van Spriel > wrote: >> On 23-3-2016 9:47, Rafał Miłecki wrote: >>> On 22 March 2016 at 21:24, Arend van Spriel >>> wrote: >>>> On 22-3-2016 7:36, Rafał Miłecki wrote: >&

Re: Concurrent AP and STA mode issues with power mgt on BCM43438

2016-05-21 Thread Arend van Spriel
On 17-05-16 02:56, Barry Reinhold wrote: > > Hi, > > [This is a follow on to the thread entitled Limit rate of BCM34348 on > Raspberry PI-3 via brcmfmac, but since our understanding of the issue has > changed we are starting a new thread.] > > We have been attempting to get a Raspberry PI-3 (R

Re: [PATCH] brcmfmac: use kmemdup

2016-05-20 Thread Arend Van Spriel
On 19-5-2016 15:59, Muhammad Falak R Wani wrote: > Use kmemdup when some other buffer is immediately copied into allocated > region. It replaces call to allocation followed by memcpy, by a single > call to kmemdup. Acked-by: Arend van Spriel > Signed-off-by: Muhammad

Re: [PATCH 4.8 1/2] brcmutil: add field storing control channel to the struct brcmu_chan

2016-05-20 Thread Arend Van Spriel
r control channel. The need to "access all info" is probably the other patch so you might hint here that this change is needed for the .get_channel() callback. Reviewed-by: Arend van Spriel > Signed-off-by: Rafał Miłecki > --- > .../broadcom/brcm80211/brcmfmac/cfg80211.c

Re: [PATCH 4.8 2/2] brcmfmac: support get_channel cfg80211 callback

2016-05-20 Thread Arend Van Spriel
On 19-5-2016 13:02, Rafał Miłecki wrote: > This is important for brcmfmac as the firmware may pick different > channel than requested. This has been tested with BCM4366B1 (in D-Link > DIR-885L). Can you elaborate? Is this for AP or STA mode? > Signed-off-by: Rafał Miłecki > --- > .../broadcom/b

Re: [PATCH 1/1] brcm80211: simplify assignment

2016-05-18 Thread Arend Van Spriel
On 18-5-2016 2:57, Heinrich Schuchardt wrote: > Simplify assignment in wlc_phy_rxcal_gainctrl_nphy_rev5. Acked-by: Arend van Spriel > Signed-off-by: Heinrich Schuchardt > --- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 2 +- > 1 file changed, 1 insertion

<    11   12   13   14   15   16   17   18   19   20   >