Re: [PATCH 1/4] treewide: convert ISO_8859-1 text comments to utf-8

24 Jul 2018 13:13:25 +0200 Arnd Bergmann wrote: >> > > Almost all files in the kernel are either plain text or UTF-8 >> > > encoded. A couple however are ISO_8859-1, usually just a few >> > > characters in a C comments, for historic reasons. >> > >

Re: [PATCH v2 04/24] mtd: rawnand: s3c2410: Allow selection of this driver when COMPILE_TEST=y

On Wed, Jul 11, 2018 at 1:32 PM, Boris Brezillon wrote: > On Wed, 11 Jul 2018 13:27:53 +0200 > Arnd Bergmann wrote: > >> On Wed, Jul 11, 2018 at 1:16 PM, Boris Brezillon >> wrote: >> > On Mon, 9 Jul 2018 22:09:25 +0200 >> > Boris Brezillon wrote: &g

Re: [PATCH v2 04/24] mtd: rawnand: s3c2410: Allow selection of this driver when COMPILE_TEST=y

On Wed, Jul 11, 2018 at 1:16 PM, Boris Brezillon wrote: > On Mon, 9 Jul 2018 22:09:25 +0200 > Boris Brezillon wrote: > >> It just makes NAND maintainers' life easier by allowing them to >> compile-test this driver without having ARCH_S3C24XX or ARCH_S3C64XX >> enabled. >> >> We add a dependency

Re: [PATCH v2 00/24] mtd: rawnand: Improve compile-test coverage

On Mon, Jul 9, 2018 at 10:09 PM, Boris Brezillon wrote: > Hello, > > This is an attempt at adding "depends || COMPILE_TEST" to all NAND > drivers that have no compile-time dependencies on arch > features/headers. > > This will hopefully help us (NAND/MTD maintainers) in detecting build > issues

Re: [PATCH v2 11/24] mtd: rawnand: sunxi: Make sure ret is initialized in sunxi_nfc_read_byte()

On Mon, Jul 9, 2018 at 10:09 PM, Boris Brezillon wrote: > Fixes the following smatch warning: > > drivers/mtd/nand/raw/sunxi_nand.c:551 sunxi_nfc_read_byte() error: > uninitialized symbol 'ret'. > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/raw/sunxi_nand.c | 2 +- > 1 file

Re: linux-next: build warning after merge of the mac80211-next tree

On Thu, May 24, 2018 at 6:11 AM, Kalle Valo <kv...@codeaurora.org> wrote: > Arnd Bergmann <a...@arndb.de> writes: >> I also bisected this new warning to the same commit above: >> >> net/batman-adv/bat_v_elp.c: In function 'batadv_v_elp_get_throughput': >> ne

Re: linux-next: build warning after merge of the mac80211-next tree

On Fri, May 11, 2018 at 2:20 PM, Kalle Valo wrote: > Stephen Rothwell writes: > >> After merging the mac80211-next tree, today's linux-next build (arm_multi >> v7_defconfig) produced this warning: >> >>

[PATCH] ath10k: avoid possible string overflow

: bc64d05220f3 ("ath10k: debugfs support to get final TPC stats for 10.4 variants") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/ath/ath10k/wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/driv

Re: [PATCH] mt76: enable MAC80211_LEDS by default

On Wed, Mar 21, 2018, 23:27 Lorenzo Bianconi <lorenzo.bianc...@redhat.com> wrote: > > On Mar 21, Arnd Bergmann wrote: > > On Wed, Mar 21, 2018 at 6:45 AM, Johannes Berg > > <johan...@sipsolutions.net> wrote: > > > On Fri, 2018-03-16 at 15:45 +0100, Lorenzo B

Re: [PATCH] mt76: enable MAC80211_LEDS by default

On Wed, Mar 21, 2018 at 6:45 AM, Johannes Berg wrote: > On Fri, 2018-03-16 at 15:45 +0100, Lorenzo Bianconi wrote: >> --- a/drivers/net/wireless/mediatek/mt76/Kconfig >> +++ b/drivers/net/wireless/mediatek/mt76/Kconfig >> @@ -1,5 +1,8 @@ >> config MT76_CORE >>

[PATCH] [v3] Bluetooth: btrsi: rework dependencies

from the RSI_COEX symbol. Fixes: 38aa4da50483 ("Bluetooth: btrsi: add new rsi bluetooth driver") Acked-by; Marcel Holtmann <mar...@holtmann.org> Signed-off-by: Arnd Bergmann <a...@arndb.de> --- v2: Pick a different approach from v1 v3: fix typo: s/BT_RSI/BT_HCIRSI/ --- drivers/bluet

Re: [PATCH] [v2] Bluetooth: btrsi: rework dependencies

gt; >> As the dependency is actually the reverse (RSI_91X uses >> the BT_RSI driver, not the other way round), this changes >> the dependency to match, and enables the bluetooth driver >> from the RSI_COEX symbol. >> >> Fixes: 38aa4da50483 ("Bluetooth: btr

[PATCH] [v2] Bluetooth: btrsi: rework dependencies

from the RSI_COEX symbol. Fixes: 38aa4da50483 ("Bluetooth: btrsi: add new rsi bluetooth driver") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- v2: Pick a different from v1 --- drivers/bluetooth/Kconfig| 4 +--- drivers/net/wireless/rsi/Kconfig | 4 +++- 2 files changed, 4 ins

Re: [PATCH] Bluetooth: btrsi: rework dependencies

On Thu, Mar 15, 2018 at 4:50 PM, Marcel Holtmann wrote: >> diff --git a/drivers/bluetooth/Makefile b/drivers/bluetooth/Makefile >> index 03cfc1b20c4a..9e8d22712ff3 100644 >> --- a/drivers/bluetooth/Makefile >> +++ b/drivers/bluetooth/Makefile >> @@ -28,7 +28,7 @@

[PATCH] Bluetooth: btrsi: rework dependencies

the #ifdefs work all the time - ensure that BT_HCIRSI is built-in whenever RSI_91X is built-in - prevent BT_HCIRSI from being enabled when CONFIG_BT=m and RSI_91X=y, as this cannot work Fixes: 38aa4da50483 ("Bluetooth: btrsi: add new rsi bluetooth driver") Signed-off-by: Arnd Bergm

Re: [PATCH 00/16] remove eight obsolete architectures

On Thu, Mar 15, 2018 at 10:59 AM, Hannes Reinecke wrote: > On 03/15/2018 10:42 AM, David Howells wrote: >> Do we have anything left that still implements NOMMU? >> > RISC-V ? > (evil grin :-) Is anyone producing a chip that includes enough of the Privileged ISA spec to have things

Re: [PATCH 00/16] remove eight obsolete architectures

On Thu, Mar 15, 2018 at 10:42 AM, David Howells wrote: > Do we have anything left that still implements NOMMU? Yes, plenty. I was wondering the same thing, but it seems that the architectures we remove are almost completely representative of what we support overall, except

[PATCH 11/16] treewide: simplify Kconfig dependencies for removed archs

A lot of Kconfig symbols have architecture specific dependencies. In those cases that depend on architectures we have already removed, they can be omitted. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- block/bounce.c | 2 +- drivers/ide/Kconfig

[PATCH 00/16] remove eight obsolete architectures

architectures for several years at this point. Arnd Arnd Bergmann (14): arch: remove frv port arch: remove m32r port arch: remove score port arch: remove blackfin port arch: remove tile port procfs: remove CONFIG_HARDWALL dependency mm: remove blackfin MPU support mm: remove

Re: [PATCH] ath10k: Enable IOMMU support for WCN3990 target

On Thu, Mar 1, 2018 at 2:18 PM, Govind Singh wrote: >>> The asm/dma-iommu.h header file exsists only on arm32, no other >>> architecture. >>> I'm not sure about the purpose of the patch to start with: >>> it's normally up to the platform code to allocate IOMMU domains,

Re: [PATCH] ath10k: Enable IOMMU support for WCN3990 target

On Thu, Mar 1, 2018 at 11:01 AM, Kalle Valo wrote: > Govind Singh writes: > >> When an IOMMU device is available on the platform bus, allocate >> an IOMMU domain and attach the wlan target to it. >> WCN3990 target can then attach an DMA I/O virtual

[4.4-stable 17/22] cw1200: fix bogus maybe-uninitialized warning

into do/while also makes this clear to the compiler. Suggested-by: David Laight <david.lai...@aculab.com> Signed-off-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: Kalle Valo <kv...@codeaurora.org> [arnd: rebased to 4.4] Signed-off-by: Arnd Bergmann <a...@arndb.de> --- dri

[PATCH] rtlwifi: rtl8192cu: remove pointless memcpy

/rtl8192cu/trx.c:430:2: error: 'memcpy' source argument is the same as destination [-Werror=restrict] Most likely this is harmless, but it's easy to just remove the line and get rid of the warning. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx

[PATCH] cfg80211: fix cfg80211_beacon_dup

we do in the rest of the function. Cc: sta...@vger.kernel.org Fixes: 73da7d5bab79 ("mac80211: add channel switch command and beacon callbacks") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- net/mac80211/cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/n

[PATCH] [wireless-next] mt76: fix building without CONFIG_LEDS_CLASS

code gets left out from the driver object. Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/mediatek/mt76/Kconfig | 5 + drivers/net/wireless/mediatek/mt76/m

[PATCH] wlcore: fix unused function warning

and what should not, it's easier to mark the top-level suspend/resume functions as __maybe_unused so the compiler can silently drop all the unused code. Fixes: 37bf241b8e7b ("wlcore: allow elp during wowlan suspend") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless

[PATCH] ath10k: use 64-bit crash dump timestamps

The dump format uses 64-bit timestamps already, but calling getnstimeofday() only returns a 32-bit number on 32-bit architectures, so that will overflow in y2038. This changes it to use ktime_get_real_ts64() instead. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wirele

[PATCH] wlcore: use boottime for fw time sync

running during suspend, boottime is better than monotonic, and ktime_get_boot_ns() will also save the additional conversion to nanoseconds. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/ti/wlcore/main.c | 4 +--- drivers/net/wireless/ti/wlcore/tx.c | 4 +--- 2

[PATCH] rt2x00: use monotonic timestamps for frame dump

m is a bad idea. However since this is in debugfs, we don't put any API stability rules on the interface according to Documentation/filesystems/debugfs.txt, and we can take the easy way out here; anyone using the frame dump feature can probably work out the differences here. Signed-off-by: Arn

[PATCH 3/3] rtlwifi: drop unused ppsc->last_wakeup_time

The calculation of ppsc->last_wakeup_time is not y2038-safe, but the variable is not used at all, so we can simply drop it. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 5 - drivers/net/wireless/realtek/rtlwifi/wifi.h

[PATCH 2/3] rtlwifi: use ktime_get_real_seconds() for suspend time

do_gettimeofday() is deprecated and slower than necessary for the purpose of reading the seconds. This changes rtl_op_suspend/resume to use ktime_get_real_seconds() instead, which is simpler and avoids confusion about whether it is y2038-safe or not. Signed-off-by: Arnd Bergmann <a...@arndb

[PATCH 1/3] rtlwifi: fix uninitialized rtlhal->last_suspend_sec time

so we probably want the patch backported to stable kernels. Cc: sta...@vger.kernel.org Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82839 Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 1 + 1 file changed, 1 insertion(+) diff --g

Re: [PATCH] ath10k: move pci suspend/resume functions

On Thu, Nov 2, 2017 at 4:23 PM, Kalle Valo <kv...@qca.qualcomm.com> wrote: > Arnd Bergmann <a...@arndb.de> writes: > >> The combination of two patches has led to a build failure: >> >> drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_suspend'

Re: [PATCH] rsi: sdio: fix building without CONFIG_PM

On Thu, Nov 2, 2017 at 3:57 PM, Kalle Valo <kv...@codeaurora.org> wrote: > Arnd Bergmann <a...@arndb.de> writes: > >> The addition of the WoWLAN support has caused a number of new >> build errors when CONFIG_PM is disabled, including: >> >> drivers/net/wi

[PATCH] rsi: sdio: fix building without CONFIG_PM

fails to build and that we know is not used without CONFIG_PM. Fixes: f3ac4e7394a1 ("rsi: sdio: add WOWLAN support for S3 suspend state") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/rsi/rsi_91x_mac80211.c | 4 +++- drivers/net/wireless/rsi/rsi_91x_mgmt.c

[PATCH] ath10k: move pci suspend/resume functions

the functions outside of the now incorrect #ifdef. Fixes: 96378bd2c6cd ("ath10k: fix core PCI suspend when WoWLAN is supported but disabled") Fixes: 6af1de2e4ec4 ("ath10k: mark PM functions as __maybe_unused") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net

[PATCH 1/2] cfg80211: don't print log output for building shipped-certs

80211: implement regdb signature checking") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- net/wireless/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/wireless/Makefile b/net/wireless/Makefile index 219baea57e4e..e585f3f71f77 100644 --- a/net/w

[PATCH 2/2] cfg80211: fix CFG80211_EXTRA_REGDB_KEYDIR typo

the correct symbol, the warning also goes away. Fixes: 90a53e4432b1 ("cfg80211: implement regdb signature checking") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- net/wireless/reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/reg.c b/net/wire

[PATCH] rsi: fix integer overflow warning

b ("rsi: tx and rx path enhancements for p2p mode") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/rsi/rsi_mgmt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/rsi/rsi_mgmt.h b/drivers/net/wireless/rsi/rsi_mgmt.h

Re: [PATCH v4 4/9] em28xx: fix em28xx_dvb_init for KASAN

On Thu, Sep 28, 2017 at 4:30 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Thu, Sep 28, 2017 at 6:09 AM, Andrey Ryabinin > <aryabi...@virtuozzo.com> wrote: >> On 09/27/2017 04:26 PM, Arnd Bergmann wrote: >>> On Tue, Sep 26, 2017 at 9:49 AM, Andrey Ryabinin &g

Re: [PATCH v4 4/9] em28xx: fix em28xx_dvb_init for KASAN

On Thu, Sep 28, 2017 at 6:09 AM, Andrey Ryabinin <aryabi...@virtuozzo.com> wrote: > On 09/27/2017 04:26 PM, Arnd Bergmann wrote: >> On Tue, Sep 26, 2017 at 9:49 AM, Andrey Ryabinin >> <aryabi...@virtuozzo.com> wrote: >> --- a/include/linux/string.h >> ++

Re: [PATCH v4 4/9] em28xx: fix em28xx_dvb_init for KASAN

On Tue, Sep 26, 2017 at 9:49 AM, Andrey Ryabinin <aryabi...@virtuozzo.com> wrote: > > > On 09/26/2017 09:47 AM, Arnd Bergmann wrote: >> On Mon, Sep 25, 2017 at 11:32 PM, Arnd Bergmann <a...@arndb.de> wrote: >> + ret = __builtin_strlen(q); > > > I t

Re: [PATCH v4 4/9] em28xx: fix em28xx_dvb_init for KASAN

On Mon, Sep 25, 2017 at 11:32 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Mon, Sep 25, 2017 at 7:41 AM, David Laight <david.lai...@aculab.com> wrote: >> From: Arnd Bergmann >>> Sent: 22 September 2017 22:29 >> ... >>> It seems that this i

Re: [PATCH v4 4/9] em28xx: fix em28xx_dvb_init for KASAN

On Mon, Sep 25, 2017 at 7:41 AM, David Laight <david.lai...@aculab.com> wrote: > From: Arnd Bergmann >> Sent: 22 September 2017 22:29 > ... >> It seems that this is triggered in part by using strlcpy(), which the >> compiler doesn't recognize as copying at m

[PATCH v4 0/9] bring back stack frame warning with KASAN

d [1] https://www.spinics.net/lists/linux-wireless/msg159819.html [2] https://www.spinics.net/lists/netdev/msg441918.html [3] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715 Arnd Bergmann (9): brcmsmac: make some local variables 'static const' to reduce stack size brcmsmac: split up wlc_p

[PATCH v4 2/9] brcmsmac: split up wlc_phy_workarounds_nphy

<arend.vanspr...@broadcom.com> Signed-off-by: Arnd Bergmann <a...@arndb.de> --- .../broadcom/brcm80211/brcmsmac/phy/phy_n.c| 178 - 1 file changed, 104 insertions(+), 74 deletions(-) This one and the following patch could be merged for either v4

[PATCH v4 8/9] netlink: fix nla_put_{u8,u16,u32} for KASAN

n argument. Cc: sta...@vger.kernel.org Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715 Signed-off-by: Arnd Bergmann <a...@arndb.de> --- include/net/netlink.h | 73 ++- 1 file changed, 55 insertions(+), 18 deletions(-) diff --git a/include/n

[PATCH v4 9/9] kasan: rework Kconfig settings

AN=y"). Signed-off-by: Arnd Bergmann <a...@arndb.de> --- lib/Kconfig.debug | 4 ++-- lib/Kconfig.kasan | 13 - lib/Kconfig.kmemcheck | 1 + scripts/Makefile.kasan | 3 +++ 4 files changed, 18 insertions(+), 3 deletions(-) diff --git a/lib/Kconfig.debug

[PATCH v4 7/9] rocker: fix rocker_tlv_put_* functions for KASAN

: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715 Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/ethernet/rocker/rocker_tlv.h | 48 1 file changed, 30 insertions(+), 18 deletions(-) diff --git a/drivers/net/ethernet/rocker/rocker_tlv.h b/d

[PATCH v4 6/9] dvb-frontends: fix i2c access helpers for KASAN

for the argument variables, but on older compilers we can get the same behavior by taking the pointer of a local variable rather than the inline function argument. Cc: sta...@vger.kernel.org Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715 Signed-off-by: Arnd Bergmann <a...@arndb.de> -

[PATCH v4 4/9] em28xx: fix em28xx_dvb_init for KASAN

have another larger patch that we could use in addition to this one, in order to shrink the stack for -fsanitize-address-use-after-scope (with gcc-7.1.1) as well, but that would not be appropriate for stable backports, so let's focus on this one first. Cc: sta...@vger.kernel.org Signed-off-by: Arnd

[PATCH v4 3/9] brcmsmac: reindent split functions

In the previous commit I left the indentation alone to help reviewing the patch, this one now runs the three new functions through 'indent -kr -8' with some manual fixups to avoid silliness. No changes other than whitespace are intended here. Signed-off-by: Arnd Bergmann <a...@arndb.de>

[PATCH v4 5/9] r820t: fix r820t_write_reg for KASAN

=] This is caused by a gcc bug that has now been fixed in gcc-8. To work around the problem, we can pass the register data through a local variable that older gcc versions can optimize out as well. Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715 Signed-off-by: Arnd Bergmann <a...@arndb

[PATCH v4 1/9] brcmsmac: make some local variables 'static const' to reduce stack size

in 'allmodconfig' below the 2048 byte limit so we can turn on the frame warning again globally, but I realize that the patch is larger than the normal limit for stable backports. The other two patches do not need to be backported. Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> Signed-off-by

[PATCH] ath10: mark PM functions as __maybe_unused

("ath10k: add the PCI PM core suspend/resume ops") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/ath/ath10k/pci.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/at

Re: [RFC 2/2] wl3501_cs: reduce stack size for KASAN

On Tue, Jul 25, 2017 at 2:52 PM, Kalle Valo <kv...@codeaurora.org> wrote: > Arnd Bergmann <a...@arndb.de> writes: > >> Inlining functions with local variables can lead to excessive stack usage >> with KASAN after a previous patch that modifies the outsb/insb helper

[RFC 2/2] wl3501_cs: reduce stack size for KASAN

bytes is larger than 1536 bytes [-Werror=frame-larger-than=] Marking the two callers of insb/outb 'noinline' prevents the compiler from adding up the stack usage for each of the local variables passed into those, reducing the maximum stack frame size to 800 bytes with KASAN again. Signed-off-by: Arnd

[RFC 1/2] x86: mark target address as output in 'insb' asm

size of 2232 bytes is larger than 1536 bytes [-Werror=frame-larger-than=] I'm not an x86 person and gcc inline assembly mystifies me all the time, so please review this carefully and suggest a better way if this is not how it should be done. Signed-off-by: Arnd Bergmann <a...@arndb.de> ---

Re: ath10k: ret used but uninitialized

On Fri, Jul 7, 2017 at 12:04 PM, Kalle Valo wrote: > Erik Stromdahl writes: > >>> With gcc 4.1.2: >>> >>> drivers/net/wireless/ath/ath10k/sdio.c: In function >>> ‘ath10k_sdio_mbox_rxmsg_pending_handler’: >>>

[PATCH] iwlwifi: mvm: fix iwl_mvm_sar_find_wifi_pkg corner case

ain, to only return a correct object, and to shut up that warning. Fixes: c386dacb4ed6 ("iwlwifi: mvm: refactor SAR init to prepare for dynamic SAR") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 8 +++- 1 file changed,

[PATCH v2 10/11] brcmsmac: reindent split functions

In the previous commit I left the indentation alone to help reviewing the patch, this one now runs the three new functions through 'indent -kr -8' with some manual fixups to avoid silliness. No changes other than whitespace are intended here. Signed-off-by: Arnd Bergmann <a...@arndb.de>

[PATCH v2 09/11] brcmsmac: split up wlc_phy_workarounds_nphy

<arend.vanspr...@broadcom.com> Signed-off-by: Arnd Bergmann <a...@arndb.de> --- .../broadcom/brcm80211/brcmsmac/phy/phy_n.c| 178 - 1 file changed, 104 insertions(+), 74 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.

[PATCH v2 08/11] brcmsmac: make some local variables 'static const' to reduce stack size

=] Here, I'm reducing the stack size by marking as many local variables as 'static const' as I can without changing the actual code. Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> Signed-off-by: Arnd Bergmann <a...@arndb.de> --- .../broadcom/brcm80211/brcmsmac/phy/phy_n.c

Re: [PATCH] mwifiex: Replace semaphore async_sem with mutex

--- > > This patch is part of a bigger effort to eliminate unwanted > semaphores from the linux kernel. Looks good, Reviewed-by: Arnd Bergmann <a...@arndb.de>

Re: [PATCH] bcm47xx: fix build regression

On Wed, May 31, 2017 at 3:12 PM, Paul E. McKenney <paul...@linux.vnet.ibm.com> wrote: > On Wed, May 31, 2017 at 12:21:10PM +0200, Arnd Bergmann wrote: >> On Wed, May 31, 2017 at 11:43 AM, Arend van Spriel >> <arend.vanspr...@broadcom.com> wrote: >> > On 5/

Re: [PATCH] bcm47xx: fix build regression

On Wed, May 31, 2017 at 11:43 AM, Arend van Spriel <arend.vanspr...@broadcom.com> wrote: > On 5/30/2017 1:20 PM, Arnd Bergmann wrote: >> >> An unknown change in the kernel headers caused a build regression >> in an MTD partition driver: >> >> In file inclu

[PATCH] bcm47xx: fix build regression

use in this function) Clearly we want to include linux/errno.h here. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- include/linux/bcm47xx_nvram.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/bcm47xx_nvram.h b/include/linux/bcm47xx_nvram.h index 2793652fbf66..a414a2

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

On Fri, May 19, 2017 at 2:15 PM, Tom Psyborg <pozega.tomis...@gmail.com> wrote: > > > On 19 May 2017 at 08:55, Arnd Bergmann <a...@arndb.de> wrote: >> >> >> On which base version did you apply my patches? There may be a conflict >> against patches th

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

On Fri, May 19, 2017 at 9:15 AM, Kalle Valo <kv...@codeaurora.org> wrote: > Arnd Bergmann <a...@arndb.de> writes: > >> On Fri, May 19, 2017 at 7:18 AM, Kalle Valo <kv...@codeaurora.org> wrote: >>> Arnd Bergmann <a...@arndb.de> writes: >>> >

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

On Fri, May 19, 2017 at 8:44 AM, Tom Psyborg wrote: > warning: 'rt2800_bbp_read' used but never defined > static u8 rt2800_bbp_read(struct rt2x00_dev *rt2x00dev, >^ >

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

On Fri, May 19, 2017 at 7:18 AM, Kalle Valo <kv...@codeaurora.org> wrote: > Arnd Bergmann <a...@arndb.de> writes: > >> I've managed to split up my long patch into a series of reasonble >> steps now. >> >> The first two are required to fix a regression

[PATCH v2 03/10] rt2x00: convert rt2x00_rf_read return type

rivers/net/wireless/ralink/rt2x00/rt* Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/ralink/rt2x00/rt2400pci.c | 2 +- drivers/net/wireless/ralink/rt2x00/rt2500pci.c | 4 ++-- drivers/net/wireless/ralink/rt2x00/rt2500usb.c | 4 ++-- drivers/net/wireless/ralink/rt2x00/

[PATCH v2 02/10] rt2x00: convert rt2800_rfcsr_read return type

*\));:\2 = \1);:' \ drivers/net/wireless/ralink/rt2x00/rt2800lib.c Fixes: 41977e86c984 ("rt2x00: add support for MT7620") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 322 - 1 file changed, 158 inse

[PATCH v2 10/10] rt2x00: convert rt2x00_desc_read return type

-i 's:\(\<_rt2x00_desc_read\>(.*, .*\), &\(.*\));:\2 = \1);:' \ drivers/net/wireless/ralink/rt2x00/rt* Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/ralink/rt2x00/rt2400pci.c | 32 +++--- drivers/net/wireless/ralink/rt2x00/rt2500pci.c | 26 +

[PATCH v2 05/10] rt2x00: convert rt2x00usb_register_read return type

' \ -i 's:\(\<rt2500usb_register_read\>(.*, .*\), &\(.*\));:\2 = \1);:' \ -i 's:\(\<rt2500usb_register_read_lock\>(.*, .*\), &\(.*\));:\2 = \1);:' \ drivers/net/wireless/ralink/rt2x00/* Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wire

[PATCH v2 08/10] rt2x00: convert rt2x00_eeprom_read return type

\ -i 's:= _\(rt2x00_eeprom_read\):= \1:' drivers/net/wireless/ralink/rt2x00/* Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/ralink/rt2x00/rt2400pci.c | 8 +++--- drivers/net/wireless/ralink/rt2x00/rt2500pci.c | 16 ++-- drivers/net/wireless/ralink/rt2x00/

[PATCH v2 01/10] rt2x00: change function pointers for register accessors

-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/ralink/rt2x00/rt2400pci.c | 18 +++ drivers/net/wireless/ralink/rt2x00/rt2500pci.c | 18 +++ drivers/net/wireless/ralink/rt2x00/rt2500usb.c | 24 ++-- drivers/net/wireless/ralink/rt2x00/rt280

[PATCH v2 04/10] rt2x00: convert rt2x00mmio_register_read return type

i 's:_rt2x00mmio_register_read:rt2x00mmio_register_read:' \ drivers/net/wireless/ralink/rt2x00/*.c The function itself was modified manually along with the one remaining caller that was not covered automatically. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wirel

[PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

I've managed to split up my long patch into a series of reasonble steps now. The first two are required to fix a regression from commit 41977e86c984 ("rt2x00: add support for MT7620"), the rest are just cleanups to have a consistent state across all the register access functions. Arnd

[PATCH v2 06/10] rt2x00: convert rt2800_register_read return type

's:\(rt2800_register_read_lock(.*, .*\), &\(.*\));:\2 = \1);:' \ drivers/net/wireless/ralink/rt2x00/rt2800lib.c The function itself was modified manually along with the one remaining multi-line caller that was not covered automatically and the indirect reference. Signed-off-by: Arnd

[PATCH v2 09/10] rt2x00: convert rt2800_eeprom_read return type

;:\3 = \1);:' drivers/net/wireless/ralink/rt2x00/rt2800lib.c Some manual tweaking was required here to work around the line wraps. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 194 - 1 file changed, 97 i

Re: [PATCH] rt2x00: improve calling conventions for register accessors

On Wed, May 17, 2017 at 2:17 PM, Tom Psyborg wrote: > > > On 16 May 2017 at 16:31, Jes Sorensen wrote: >> >> >> True - if the automatic conversion works without automatic intervention, I >> am less worried about it. Personally I would still

[PATCH v2 07/10] rt2x00: convert rt2*_bbp_read return type

's:\(\<rt.*_bbp_dcoc_read\>(.*, .*\), &\(.*\));:\2 = \1);:' \ -i 's:= _\(rt.*_bbp_read\):\1:' drivers/net/wireless/ralink/rt2x00/* Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/ralink/rt2x00/rt2400pci.c | 29 +++ drivers/net/wireless/ralink/rt2x00/rt2500pci.c

Re: [PATCH] rt2x00: improve calling conventions for register accessors

;> > Date: Mon, 15 May 2017 16:28:01 +0200 >> > >> > > On Mon, May 15, 2017 at 03:46:55PM +0200, Arnd Bergmann wrote: >> > >> With CONFIG_KASAN enabled and gcc-7, we get a warning about rather high >> > >> stack usage (with a private pa

Re: [PATCH] rt2x00: improve calling conventions for register accessors

On Tue, May 16, 2017 at 3:44 PM, Jes Sorensen wrote: > On 05/16/2017 07:55 AM, Stanislaw Gruszka wrote: >> >> On Mon, May 15, 2017 at 10:39:51AM -0400, David Miller wrote: >>> >>> Passing return values by reference is and always has been a really >>> poor way to achieve

Re: [PATCH] rt2x00: improve calling conventions for register accessors

On Mon, May 15, 2017 at 4:28 PM, Stanislaw Gruszka <sgrus...@redhat.com> wrote: > On Mon, May 15, 2017 at 03:46:55PM +0200, Arnd Bergmann wrote: >> With CONFIG_KASAN enabled and gcc-7, we get a warning about rather high >> stack usage (with a private patch set I have to

[PATCH] rt2x00: improve calling conventions for register accessors

by changing the calling convention to have the output as the return value of the function. This should also results in smaller object code, saving around 4KB in .text with KASAN, or 2KB without KASAN. Fixes: 41977e86c984 ("rt2x00: add support for MT7620") Signed-off-by: Arnd Bergmann <

[PATCH] wlcore: fix 64K page support

kernels no longer show the warning, but the bug is still there, as the allocation is based on the CPU page size rather than the actual capabilities of the hardware. This replaces the PAGE_SIZE macro with the SZ_4K macro, i.e. 4096 bytes per buffer. Cc: sta...@vger.kernel.org Signed-off-by: Arnd

[PATCH net-next] brcmfmac: fix build without CONFIG_BRCMFMAC_PROTO_BCDC

hen CONFIG_BRCMFMAC_PROTO_BCDC is enabled, so we can simply change the Makefile to build it conditionally. Fixes: acf8ac41dd73 ("brcmfmac: remove reference to fwsignal data from struct brcmf_pub") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/Makefi

Re: [PATCH v3 0/7] Remove unneeded build directory traversals

On Wed, Mar 15, 2017 at 10:15 PM, Andrew F. Davis <a...@ti.com> wrote: > On 03/15/2017 04:03 PM, Arnd Bergmann wrote: >> On Wed, Mar 15, 2017 at 5:37 PM, Andrew F. Davis <a...@ti.com> wrote: >>> Hello all, >>> >>> I was building a

Re: [PATCH v3 0/7] Remove unneeded build directory traversals

On Wed, Mar 15, 2017 at 5:37 PM, Andrew F. Davis wrote: > Hello all, > > I was building a kernel for x86 and noticed Make still descended into > directories like drivers/gpu/drm/hisilicon, this seems kind of odd given > nothing will be built here. It looks to be due to some

Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size

On Mon, Mar 6, 2017 at 5:19 PM, Kalle Valo <kv...@codeaurora.org> wrote: > Arend Van Spriel <arend.vanspr...@broadcom.com> writes: > >> On 2-3-2017 17:38, Arnd Bergmann wrote: >>> With KASAN and a couple of other patches applied, this driver is one >>> o

Re: [PATCH 07/26] brcmsmac: reduce stack size with KASAN

On Mon, Mar 6, 2017 at 12:16 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Mon, Mar 6, 2017 at 12:02 PM, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 6-3-2017 11:38, Arnd Bergmann wrote: >>> On Mon, Mar 6, 2017 at 10:16 AM, Arend Van Spriel

Re: [PATCH 07/26] brcmsmac: reduce stack size with KASAN

On Mon, Mar 6, 2017 at 12:02 PM, Arend Van Spriel <arend.vanspr...@broadcom.com> wrote: > On 6-3-2017 11:38, Arnd Bergmann wrote: >> On Mon, Mar 6, 2017 at 10:16 AM, Arend Van Spriel >> <arend.vanspr...@broadcom.com> wrote: >>> On

Re: [PATCH 07/26] brcmsmac: reduce stack size with KASAN

On Mon, Mar 6, 2017 at 10:16 AM, Arend Van Spriel <arend.vanspr...@broadcom.com> wrote: > On 2-3-2017 17:38, Arnd Bergmann wrote: >> The wlc_phy_table_write_nphy/wlc_phy_table_read_nphy functions always put an >> object >> on the stack, which will each require a

Re: [PATCH 25/26] isdn: eicon: mark divascapi incompatible with kasan

On Fri, Mar 3, 2017 at 4:22 PM, Andrey Ryabinin <aryabi...@virtuozzo.com> wrote: > On 03/03/2017 05:54 PM, Arnd Bergmann wrote: >> On Fri, Mar 3, 2017 at 3:20 PM, Andrey Ryabinin <aryabi...@virtuozzo.com> >> wrote: >>> On 03/02/2017 07:38 PM, Arnd Bergmann

Re: [PATCH 01/26] compiler: introduce noinline_for_kasan annotation

On Fri, Mar 3, 2017 at 3:33 PM, Alexander Potapenko <gli...@google.com> wrote: > On Fri, Mar 3, 2017 at 3:30 PM, Arnd Bergmann <a...@arndb.de> wrote: >> On Fri, Mar 3, 2017 at 2:55 PM, Alexander Potapenko <gli...@google.com> >> wrote: >> >> Wou

Re: [PATCH 25/26] isdn: eicon: mark divascapi incompatible with kasan

On Fri, Mar 3, 2017 at 3:20 PM, Andrey Ryabinin <aryabi...@virtuozzo.com> wrote: > > > On 03/02/2017 07:38 PM, Arnd Bergmann wrote: >> When CONFIG_KASAN is enabled, we have several functions that use rather >> large kernel stacks, e.g. >> >> drivers/isd

Re: [PATCH 26/26] kasan: rework Kconfig settings

On Fri, Mar 3, 2017 at 3:51 PM, Andrey Ryabinin <aryabi...@virtuozzo.com> wrote: > > > On 03/02/2017 07:38 PM, Arnd Bergmann wrote: > >> >> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug >> index 97d62c2da6c2..27c838c40a36 100644 >> --- a/li

Re: [PATCH 01/26] compiler: introduce noinline_for_kasan annotation

On Fri, Mar 3, 2017 at 2:55 PM, Alexander Potapenko wrote: > On Fri, Mar 3, 2017 at 2:50 PM, Andrey Ryabinin > wrote: >>> @@ -416,6 +416,17 @@ static __always_inline void __write_once_size(volatile >>> void *p, void *res, int s >>> */ >>> #define

  1   2   3   4   >