On Mon, Jun 27, 2016 at 9:53 AM, Chaitanya TK wrote:
> From: Chaitanya T K
>
> If peer support reception of STBC and LDPC, enable them for better
> performance.
>
> Signed-off-by: Chaitanya TK
> ---
> include/linux/ieee80211.h |1 +
> net/mac80211/rc80211_minstrel_ht.c | 25 +
On Sat, Nov 15, 2014 at 03:48:54AM +0100, Felix Fietkau wrote:
> The rate mask code currently assumes that a rate is legacy if
> IEEE80211_TX_RC_MCS is not set. This might be the cause of bogus VHT
> rates being reported with minstrel_ht.
>
> Signed-off-by: Felix Fietkau
> ---
> net/mac80211/rat
On Fri, Nov 14, 2014 at 07:36:48PM +0200, Jouni Malinen wrote:
> On Fri, Nov 14, 2014 at 06:18:32PM +0100, Karl Beldan wrote:
> > Yes, only with iw and nothing fancy, I also have had it running on some
> > boards for some weeks as is and with rfc version for more than a year at
>
On Fri, Nov 14, 2014 at 07:36:48PM +0200, Jouni Malinen wrote:
> On Fri, Nov 14, 2014 at 06:18:32PM +0100, Karl Beldan wrote:
> > Yes, only with iw and nothing fancy, I also have had it running on some
> > boards for some weeks as is and with rfc version for more than a year at
>
Hi,
On Fri, Nov 14, 2014 at 06:43:28PM +0200, Jouni Malinen wrote:
> On Tue, Oct 21, 2014 at 10:38:38AM +0200, Karl Beldan wrote:
> > When the new CONFIG_MAC80211_RC_MINSTREL_VHT is not set (default 'N'),
> > there is no behavioral change including in sampling and MCS_
On Fri, Oct 24, 2014 at 04:30:35PM +0200, Johannes Berg wrote:
> On Fri, 2014-10-24 at 14:34 +0200, Karl Beldan wrote:
> > From: Karl Beldan
> >
> > When CONFIG_MAC80211_RC_MINSTREL_VHT is set, the module param
> > minstrel_vht_only tells minstrel_ht whether to allow t
On Sat, Oct 18, 2014 at 11:11:48PM +0530, Krishna Chaitanya wrote:
> On Sat, Oct 18, 2014 at 10:43 PM, Karl Beldan wrote:
> >
> > From: Karl Beldan
> >
> >
> > Karl Beldan (4):
> > mac80211: minstrel_ht: Increase the range of handled rate indexes
> >
On Fri, Oct 24, 2014 at 02:34:49PM +0200, Karl Beldan wrote:
> From: Karl Beldan
>
> When CONFIG_MAC80211_RC_MINSTREL_VHT is set, the module param
> minstrel_vht_only tells minstrel_ht whether to allow the mix of ht rates
> with vht rates.
> ATM, minstrel_ht skips ht rates when
From: Karl Beldan
When CONFIG_MAC80211_RC_MINSTREL_VHT is set, the module param
minstrel_vht_only tells minstrel_ht whether to allow the mix of ht rates
with vht rates.
ATM, minstrel_ht skips ht rates when minstrel_vht_only is true, but it does
that even if vht is not supported, which makes the
Hi,
On Tue, Oct 21, 2014 at 10:38:38AM +0200, Karl Beldan wrote:
> From: Karl Beldan
>
> @@ -1026,13 +1184,47 @@ minstrel_ht_update_caps(void *priv, struct
> ieee80211_supported_band *sband,
> sta->bandwidth < IEEE80211_STA_RX_BW_40)
>
From: Karl Beldan
When displaying a rate through debugfs minstrel_ht guesses its flags
comparing group indexes. Since 3ec373c421b6 ("mac80211: minstrel_ht:
include type (cck/ht) in rates flag"), the rate flags of interest are
present in the mcs_group-s, so use it.
While improving the
On Wed, Oct 22, 2014 at 04:07:31PM +0200, Johannes Berg wrote:
> On Wed, 2014-10-22 at 15:54 +0200, Karl Beldan wrote:
> > On Tue, Oct 21, 2014 at 08:47:26PM +0200, Johannes Berg wrote:
> > > On Tue, 2014-10-21 at 17:26 +0200, Karl Beldan wrote:
> > >
> > >
On Tue, Oct 21, 2014 at 08:47:26PM +0200, Johannes Berg wrote:
> On Tue, 2014-10-21 at 17:26 +0200, Karl Beldan wrote:
>
> > I still don't know why I don't see the smatch array warnings here, I
> > guess I'll live with that for now.
>
> I'm hoping Dan
On Mon, Oct 20, 2014 at 09:33:17PM +0200, Johannes Berg wrote:
> On Mon, 2014-10-20 at 17:34 +0200, Karl Beldan wrote:
> > > Indeed, will resending only 4/4 do ?
>
> Sure.
>
> > > > CHECK
> > > > /home/johannes/sys/wireless/net/mac80211/rc80211
On Mon, Oct 20, 2014 at 09:40:35PM +0200, Johannes Berg wrote:
> On Mon, 2014-10-20 at 21:33 +0200, Johannes Berg wrote:
> > On Mon, 2014-10-20 at 17:34 +0200, Karl Beldan wrote:
> > > > Indeed, will resending only 4/4 do ?
> >
> > Sure.
>
> I merged p
From: Karl Beldan
When the new CONFIG_MAC80211_RC_MINSTREL_VHT is not set (default 'N'),
there is no behavioral change including in sampling and MCS_GROUP_RATES
remains 8.
Otherwise MCS_GROUP_RATES is 10, and a module parameter *vht_only*
(default 'true'), restricts the ra
On Mon, Oct 20, 2014 at 05:13:02PM +0200, Karl Beldan wrote:
> On Mon, Oct 20, 2014 at 04:49:06PM +0200, Johannes Berg wrote:
> > On Mon, 2014-10-20 at 15:45 +0200, Karl Beldan wrote:
> > > From: Karl Beldan
> > >
> > > Hi,
> > >
> > > Var
On Mon, Oct 20, 2014 at 04:49:06PM +0200, Johannes Berg wrote:
> On Mon, 2014-10-20 at 15:45 +0200, Karl Beldan wrote:
> > From: Karl Beldan
> >
> > Hi,
> >
> > Varka Bhadram reported checkpatch is noisy on this series.
> > I made another pass which affec
From: Karl Beldan
When the new CONFIG_MAC80211_RC_MINSTREL_VHT is not set (default 'N'),
there is no behavioral change including in sampling and MCS_GROUP_RATES
remains 8.
Otherwise MCS_GROUP_RATES is 10, and a module parameter *vht_only*
(default 'true'), restricts the ra
From: Karl Beldan
No functional change.
Signed-off-by: Karl Beldan
Cc: Felix Fietkau
---
net/mac80211/rc80211_minstrel_ht.c | 51 +++---
net/mac80211/rc80211_minstrel_ht.h | 15 +++--
net/mac80211/rc80211_minstrel_ht_debugfs.c | 10 +++---
3 files
From: Karl Beldan
ATM, we grep cck rates idx with idx / MCS_GROUP_RATES ==
MINSTREL_CCK_GROUP.
Matching neither-cck-non-ht rates could be done by replacing '==' with
'>', however it would be less versatile or explicit.
This will allow to match VHT rates with IEEE80211_TX_
From: Karl Beldan
Hi,
Varka Bhadram reported checkpatch is noisy on this series.
I made another pass which affects [2/4](trivially) and [4/4].
This could have been a patch on top of what Felix acked, I hope you
won't bother too much.
Thanks for reviewing,
Karl Beldan (4):
mac
From: Karl Beldan
Since 5935839ad735 ("mac80211: improve minstrel_ht rate sorting by
throughput & probability"), the rate indexes are manipulated via u8's
and hence allow for a maximum of 256 mcs_group entries in
minstrel_mcs_groups.
ATM, minstrel_ht advertizes suppor
Hi Varka Bhadram,
On Mon, Oct 20, 2014 at 02:31:31PM +0530, Varka Bhadram wrote:
> Hi Karl Beldan,
>
> On 10/20/2014 02:25 PM, Karl Beldan wrote:
> >From: Karl Beldan
> >
> >Hi,
> >
> >This is just a respin rebased on v2 of "mac80211: minstrels: fix
Felix, I added your Acks in the patches but git-send-email did not send
them to the Acked-by addresses.
Karl
On Mon, Oct 20, 2014 at 10:55:38AM +0200, Karl Beldan wrote:
> From: Karl Beldan
>
> Hi,
>
> This is just a respin rebased on v2 of "mac80211: minstrels: fix buf
From: Karl Beldan
Since 5935839ad735 ("mac80211: improve minstrel_ht rate sorting by
throughput & probability"), the rate indexes are manipulated via u8's
and hence allow for a maximum of 256 mcs_group entries in
minstrel_mcs_groups.
ATM, minstrel_ht advertizes suppor
From: Karl Beldan
ATM, we grep cck rates idx with idx / MCS_GROUP_RATES ==
MINSTREL_CCK_GROUP.
Matching neither-cck-non-ht rates could be done by replacing '==' with
'>', however it would be less versatile or explicit.
This will allow to match VHT rates with IEEE80211_TX_
From: Karl Beldan
Hi,
This is just a respin rebased on v2 of "mac80211: minstrels: fix buffer
overflow in HT debugfs" which only affects 4/4.
Karl Beldan (4):
mac80211: minstrel_ht: Increase the range of handled rate indexes
mac80211: minstrel_ht: macros adjustments for future
From: Karl Beldan
No functional change.
Signed-off-by: Karl Beldan
Acked-by: Felix Fietkau
---
net/mac80211/rc80211_minstrel_ht.c | 51 +++---
net/mac80211/rc80211_minstrel_ht.h | 14 ++--
net/mac80211/rc80211_minstrel_ht_debugfs.c | 10 +++---
3
From: Karl Beldan
When the new CONFIG_MAC80211_RC_MINSTREL_VHT is not set (default 'N'),
there is no behavioral change including in sampling and MCS_GROUP_RATES
remains 8.
Otherwise MCS_GROUP_RATES is 10, and a module parameter *vht_only*
(default 'true'), restricts the ra
From: Karl Beldan
ATM an HT rc_stats line is 106 chars.
Times 8(MCS_GROUP_RATES)*3(SS)*2(GI)*2(BW) + CCK(4), i.e. x100, this is
well above the current 8192 - sizeof(*ms) currently allocated.
Fix this by squeezing the output as follows (not that we're short on
memory but this also imp
Hi,
If that's not too late I'd like to fix some coding style, replace:
On Fri, Oct 17, 2014 at 08:34:00PM +0200, Karl Beldan wrote:
> From: Karl Beldan
> @@ -102,6 +102,8 @@ minstrel_stats_open(struct inode *inode, struct file
> *file)
> mi->sa
On Sat, Oct 18, 2014 at 11:11:48PM +0530, Krishna Chaitanya wrote:
> On Sat, Oct 18, 2014 at 10:43 PM, Karl Beldan wrote:
> >
> > From: Karl Beldan
> >
> >
> > Karl Beldan (4):
> > mac80211: minstrel_ht: Increase the range of handled rate indexes
> >
From: Karl Beldan
Since 5935839ad735 ("mac80211: improve minstrel_ht rate sorting by
throughput & probability"), the rate indexes are manipulated via u8's
and hence allow for a maximum of 256 mcs_group entries in
minstrel_mcs_groups.
ATM, minstrel_ht advertizes suppor
From: Karl Beldan
No functional change.
Signed-off-by: Karl Beldan
Cc: Felix Fietkau
---
net/mac80211/rc80211_minstrel_ht.c | 51 +++---
net/mac80211/rc80211_minstrel_ht.h | 14 ++--
net/mac80211/rc80211_minstrel_ht_debugfs.c | 10 +++---
3 files
From: Karl Beldan
When the new CONFIG_MAC80211_RC_MINSTREL_VHT is not set (default 'N'),
there is no behavioral change including in sampling and MCS_GROUP_RATES
remains 8.
Otherwise MCS_GROUP_RATES is 10, and a module parameter *vht_only*
(default 'true'), restricts the ra
From: Karl Beldan
Karl Beldan (4):
mac80211: minstrel_ht: Increase the range of handled rate indexes
mac80211: minstrel_ht: macros adjustments for future VHT_GROUPs
mac80211: minstrel_ht: include type (cck/ht) in rates flag
mac80211: minstrel_ht: add basic support for VHT rates <=
From: Karl Beldan
ATM, we grep cck rates idx with idx / MCS_GROUP_RATES ==
MINSTREL_CCK_GROUP.
Matching neither-cck-non-ht rates could be done by replacing '==' with
'>', however it would be less versatile or explicit.
This will allow to match VHT rates with IEEE80211_TX_
In v3 the moduleparam minstrel_vht_only should go under
CONFIG_MAC80211_RC_MINSTREL_VHT.
On Fri, Oct 17, 2014 at 09:50:59PM +0200, Karl Beldan wrote:
> @@ -91,6 +124,10 @@
> } \
> }
>
> +static bool minstrel_
From: Karl Beldan
(Sorry for spamming, Felix's address was mangled.)
Hi,
This is a split version of the VHT support addition to minstrel.
Thanks for reviewing,
Karl Beldan (4):
mac80211: minstrel_ht: Increase the range of handled rate indexes
mac80211: minstrel_ht: macros adjustment
From: Karl Beldan
No functional change.
Signed-off-by: Karl Beldan
Cc: Felix Fietkau
---
net/mac80211/rc80211_minstrel_ht.c | 51 +++---
net/mac80211/rc80211_minstrel_ht.h | 14 ++--
net/mac80211/rc80211_minstrel_ht_debugfs.c | 10 +++---
3 files
From: Karl Beldan
ATM, we grep cck rates idx with idx / MCS_GROUP_RATES ==
MINSTREL_CCK_GROUP.
Matching neither-cck-non-ht rates could be done by replacing '==' with
'>', however it would be less versatile or explicit.
This will allow to match VHT rates with IEEE80211_TX_
From: Karl Beldan
Since 5935839ad735 ("mac80211: improve minstrel_ht rate sorting by
throughput & probability"), the rate indexes are manipulated via u8's
and hence allow for a maximum of 256 mcs_group entries in
minstrel_mcs_groups.
ATM, minstrel_ht advertizes suppor
From: Karl Beldan
When the new CONFIG_MAC80211_RC_MINSTREL_VHT is not set (default 'N'),
there is no behavioral change including in sampling and MCS_GROUP_RATES
remains 8.
Otherwise MCS_GROUP_RATES is 10, and a module parameter *vht_only*
(default 'true'), restricts the ra
From: Karl Beldan
Since 5935839ad735 ("mac80211: improve minstrel_ht rate sorting by
throughput & probability"), the rate indexes are manipulated via u8's
and hence allow for a maximum of 256 mcs_group entries in
minstrel_mcs_groups.
ATM, minstrel_ht advertizes suppor
From: Karl Beldan
Hi,
This is a split version of the VHT support addition to minstrel.
Thanks for reviewing,
Karl Beldan (4):
mac80211: minstrel_ht: Increase the range of handled rate indexes
mac80211: minstrel_ht: macros adjustments for future VHT_GROUPs
mac80211: minstrel_ht: include
From: Karl Beldan
ATM an HT rc_stats line is 106 chars.
Times 8(MCS_GROUP_RATES)*3(SS)*2(GI)*2(BW) + CCK(4), i.e. x100, this is
well above the current 8192 - sizeof(*ms) currently allocated.
Fix this by squeezing the output as follows (not that we're short on
memory but this also imp
From: Karl Beldan
It affects non-(V)HT rates and can lead to selecting an rts_cts rate
that is not a basic rate or way superior to the reference rate (ATM
rates[0] used for the 1st attempt of the protected frame data).
E.g, assuming drivers register growing (bitrate) sorted tables of
Properly cc'ing stable (I used kernel.org instead of vger.kernel.org).
On Mon, Oct 13, 2014 at 11:48:12AM +0200, Karl Beldan wrote:
> From: Karl Beldan
>
> It affects non-(V)HT rates and can lead to selecting an rts_cts rate
> that is not a basic rate or way superior to the re
From: Karl Beldan
It affects non-(V)HT rates and can lead to selecting an rts_cts rate
that is not a basic rate or way superior to the reference rate (ATM
rates[0] used for the 1st attempt of the protected frame data).
E.g, assuming drivers register growing (bitrate) sorted tables of
On Fri, Oct 10, 2014 at 05:11:31PM +0200, Johannes Berg wrote:
> On Fri, 2014-10-10 at 17:10 +0200, Johannes Berg wrote:
> > On Thu, 2014-10-09 at 22:49 +0200, Karl Beldan wrote:
> >
> > > > Either way - is it worth for 3.18/stable?
> > > >
> > >
On Thu, Oct 09, 2014 at 05:22:21PM +0200, Johannes Berg wrote:
> On Thu, 2014-10-09 at 16:45 +0200, Karl Beldan wrote:
>
> > > > The typo is clearly showing but the faulty behavior clearly demands more
> > > > detail indeed.
> > > >
> > > > I
On Thu, Oct 09, 2014 at 08:36:33PM +0200, Johannes Berg wrote:
> Heh, so I guess this goes way back ... what does it actually affect
> really though? only connections with iw, which should really not be done
> that much? potentially wpa_s with wext, though I'm not even sure that
> works?
>
For wex
On Thu, Oct 09, 2014 at 05:22:21PM +0200, Johannes Berg wrote:
> On Thu, 2014-10-09 at 16:45 +0200, Karl Beldan wrote:
>
> > > > The typo is clearly showing but the faulty behavior clearly demands more
> > > > detail indeed.
> > > >
> > > > I
On Thu, Oct 09, 2014 at 03:26:02PM +0200, Johannes Berg wrote:
> On Thu, 2014-10-09 at 15:00 +0200, Karl Beldan wrote:
> > On Thu, Oct 09, 2014 at 11:32:57AM +0200, Johannes Berg wrote:
> > > On Tue, 2014-10-07 at 11:42 +0200, Karl Beldan wrote:
> > > > From: Kar
On Thu, Oct 09, 2014 at 04:15:03PM +0200, Johannes Berg wrote:
> On Thu, 2014-10-09 at 16:06 +0200, Karl Beldan wrote:
> > On Thu, Oct 09, 2014 at 11:06:26AM +0200, Johannes Berg wrote:
> > > On Tue, 2014-10-07 at 15:53 +0200, Karl Beldan wrote:
> > > > From: Kar
On Thu, Oct 09, 2014 at 11:06:26AM +0200, Johannes Berg wrote:
> On Tue, 2014-10-07 at 15:53 +0200, Karl Beldan wrote:
> > From: Karl Beldan
>
> Is that really trivial? It seems to have some impact on the code, but I
> can't right now say exactly what the impact is. Can yo
On Thu, Oct 09, 2014 at 11:32:57AM +0200, Johannes Berg wrote:
> On Tue, 2014-10-07 at 11:42 +0200, Karl Beldan wrote:
> > From: Karl Beldan
> >
> > ATM, specifying the frequency when connecting sends a void 'supported
> > rates' EID.
>
> Seems lik
On Thu, Oct 09, 2014 at 10:58:21AM +0200, Johannes Berg wrote:
> On Mon, 2014-09-29 at 02:36 +0200, Karl Beldan wrote:
> > From: Karl Beldan
> >
> > Commit 4441e8e9 ("mac80211: improve minstrel_ht rate sorting by
> > throughput & probability")
>
>
From: Karl Beldan
Fixes: 5253ffb8 ("mac80211: always pick a basic rate to tx RTS/CTS for pre-HT
rates")
Signed-off-by: Karl Beldan
---
net/mac80211/rate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mac80211/rate.c b/net/mac80211/rate.c
index 8fdadf
From: Karl Beldan
ATM, specifying the frequency when connecting sends a void 'supported
rates' EID.
Signed-off-by: Karl Beldan
---
net/wireless/sme.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index 8bbeeb
Hi,
On Tue, Sep 09, 2014 at 11:22:14PM +0200, Thomas Huehn wrote:
> @@ -260,13 +399,14 @@ minstrel_ht_update_stats(struct minstrel_priv *mp,
> struct minstrel_ht_sta *mi)
> mi->sample_slow = 0;
> mi->sample_count = 0;
>
> - for (group = 0; group < ARRAY_SIZE(minstrel_mcs_groups)
Unless I can spare some space in rc_stats, v2 will need an increase in
minstrel_debugfs_info buffer (ATM 1 line is > 100 chars).
Karl
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://v
On Mon, Sep 29, 2014 at 01:46:15PM +0200, Felix Fietkau wrote:
> On 2014-09-29 02:38, Karl Beldan wrote:
> > diff --git a/net/mac80211/rc80211_minstrel_ht.h
> > b/net/mac80211/rc80211_minstrel_ht.h
> > index 01570e0..7856062 100644
> > --- a/net/mac80211/rc80211_
From: Karl Beldan
When the new CONFIG_MAC80211_RC_MINSTREL_VHT is not set, there is no
behavioral change including in sampling and MCS_GROUP_RATES remains 8.
When it is, MCS_GROUP_RATES is 10 and we restrict to VHT rates for stats
readability (though it is possible to use both HT and VHT (unset
From: Karl Beldan
Commit 4441e8e9 ("mac80211: improve minstrel_ht rate sorting by
throughput & probability") replaced the constant 8 with MCS_GROUP_RATES
when getting the number of streams of an HT MCS. See commit 7a5e3fa2
("mac80211: minstrel_ht: replace some occurences
On Tue, Sep 09, 2014 at 11:22:14PM +0200, Thomas Huehn wrote:
> This patch improves the way minstrel_ht sorts rates according to throughput
> and success probability. 3 FOR-loops across the entire rate and mcs group set
> in function minstrel_ht_update_stats() which where used to determine the
> fa
67 matches
Mail list logo
