Re: [PATCH] nl80211: provide minimum scheduled scan (plan) interval

2016-11-25 Thread Luca Coelho
On Fri, 2016-11-25 at 11:06 +0100, Arend van Spriel wrote: > > On 11/25/2016 9:25 AM, Johannes Berg wrote: > > Sorry, forgot to reply to this until Luca's email bumped it up... > > > > On Tue, 2016-11-22 at 21:06 +0100, Arend Van Spriel wrote: > > > > > Are we? Currently, the minimum is not che

Re: [PATCH] nl80211: provide minimum scheduled scan (plan) interval

2016-11-25 Thread Arend van Spriel
On 11/25/2016 9:25 AM, Johannes Berg wrote: Sorry, forgot to reply to this until Luca's email bumped it up... On Tue, 2016-11-22 at 21:06 +0100, Arend Van Spriel wrote: Are we? Currently, the minimum is not checked in nl80211, but that does not say anything about the driver which might valid

Re: [PATCH] nl80211: provide minimum scheduled scan (plan) interval

2016-11-25 Thread Luca Coelho
Hi Arend, On Tue, 2016-11-22 at 13:31 +, Arend van Spriel wrote: > The interval for scheduled scan may have a minimum value for > the device. Allow drivers to specify a minimum value in the > struct wiphy so user-space interval values can be validated > against it. > > Signed-off-by: Arend va

Re: [PATCH] nl80211: provide minimum scheduled scan (plan) interval

2016-11-25 Thread Johannes Berg
Sorry, forgot to reply to this until Luca's email bumped it up... On Tue, 2016-11-22 at 21:06 +0100, Arend Van Spriel wrote: > Are we? Currently, the minimum is not checked in nl80211, but that > does not say anything about the driver which might validate the > interval as well and return an erro

Re: [PATCH] nl80211: provide minimum scheduled scan (plan) interval

2016-11-22 Thread Arend Van Spriel
On 22-11-2016 14:38, Johannes Berg wrote: > >> +if (wiphy->min_sched_scan_plan_interval && >> +request->scan_plans[i].interval < >> +wiphy->min_sched_scan_plan_interval) >> +return -EINVAL; >> > I'm not sure we should break the API th

Re: [PATCH] nl80211: provide minimum scheduled scan (plan) interval

2016-11-22 Thread Johannes Berg
> + if (wiphy->min_sched_scan_plan_interval && > + request->scan_plans[i].interval < > + wiphy->min_sched_scan_plan_interval) > + return -EINVAL; > I'm not sure we should break the API that way - just move it up if it's smaller? joh

[PATCH] nl80211: provide minimum scheduled scan (plan) interval

2016-11-22 Thread Arend van Spriel
The interval for scheduled scan may have a minimum value for the device. Allow drivers to specify a minimum value in the struct wiphy so user-space interval values can be validated against it. Signed-off-by: Arend van Spriel --- include/net/cfg80211.h | 3 +++ include/uapi/linux/nl80211.h