Re: [EXT] Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump

2018-05-23 Thread Kalle Valo
Ganapathi Bhat writes: > Hi Kalle, > >> Arend van Spriel writes: >> >> > On 5/23/2018 9:54 AM, Kalle Valo wrote: >> >> Ganapathi Bhat writes: >> >> >> >>> In V2: >> >>> >> >>> return ret; >> >>> } >> >>>

RE: [EXT] Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump

2018-05-23 Thread Ganapathi Bhat
Hi Kalle, > Arend van Spriel writes: > > > On 5/23/2018 9:54 AM, Kalle Valo wrote: > >> Ganapathi Bhat writes: > >> > >>> In V2: > >>> > >>> return ret; > >>> } > >>> +EXPORT_SYMBOL_GPL(mwifiex_send_cmd); > >>> > >>> Instead of

Re: [EXT] Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump

2018-05-23 Thread Kalle Valo
Arend van Spriel writes: > On 5/23/2018 9:54 AM, Kalle Valo wrote: >> Ganapathi Bhat writes: >> >>> In V2: >>> >>> return ret; >>> } >>> +EXPORT_SYMBOL_GPL(mwifiex_send_cmd); >>> >>> Instead of exporting 'mwifiex_send_cmd' we can

Re: [EXT] Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump

2018-05-23 Thread Arend van Spriel
On 5/23/2018 9:54 AM, Kalle Valo wrote: Ganapathi Bhat writes: In V2: return ret; } +EXPORT_SYMBOL_GPL(mwifiex_send_cmd); Instead of exporting 'mwifiex_send_cmd' we can prepare a wrapper for the command 'MWIFIEX_IFACE_WORK_DEVICE_DUMP' in mwifiex module. Let me

Re: [EXT] Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump

2018-05-23 Thread Kalle Valo
Ganapathi Bhat writes: > In V2: > > return ret; > } > +EXPORT_SYMBOL_GPL(mwifiex_send_cmd); > > Instead of exporting 'mwifiex_send_cmd' we can prepare a wrapper for > the command 'MWIFIEX_IFACE_WORK_DEVICE_DUMP' in mwifiex module. Let me > know if we can send a follow

RE: [EXT] Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump

2018-05-21 Thread Ganapathi Bhat
Hi arend.vanspriel, > > -- > On 5/16/2018 3:50 PM, Kalle Valo wrote: > > Arend van Spriel writes: > > > >> Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") > >> it is possible to

Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump

2018-05-16 Thread Arend van Spriel
On 5/16/2018 3:50 PM, Kalle Valo wrote: Arend van Spriel writes: Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is possible to initiate a device coredump from user-space. This patch adds support for it adding the .coredump() driver

Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump

2018-05-16 Thread Kalle Valo
Arend van Spriel writes: > Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") > it is possible to initiate a device coredump from user-space. This > patch adds support for it adding the .coredump() driver callback. > As there is no longer a need to

[PATCH V2 3/6] mwifiex: support sysfs initiated device coredump

2018-05-16 Thread Arend van Spriel
Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is possible to initiate a device coredump from user-space. This patch adds support for it adding the .coredump() driver callback. As there is no longer a need to initiate it through debugfs remove that code. Signed-off-by: