Re: [PATCH net] brcmfmac: clear skb head state on xmit

2017-02-08 Thread Arend Van Spriel
On 8-2-2017 10:29, Paolo Abeni wrote: > On Wed, 2017-02-08 at 09:52 +0100, Rafał Miłecki wrote: >> On 8 February 2017 at 09:38, Paolo Abeni wrote: >>> On Tue, 2017-02-07 at 20:23 +0100, Arend Van Spriel wrote: On 7-2-2017 17:50, Paolo Abeni wrote: > the skbs can be

Re: [PATCH net] brcmfmac: clear skb head state on xmit

2017-02-08 Thread Kalle Valo
Paolo Abeni writes: > On Tue, 2017-02-07 at 20:23 +0100, Arend Van Spriel wrote: >> On 7-2-2017 17:50, Paolo Abeni wrote: >> > the skbs can be held by the driver for a long time, so we need >> > to clear any state on xmit to avoid hanging other subsystems. >> > The skbs are

Re: [PATCH net] brcmfmac: clear skb head state on xmit

2017-02-08 Thread Paolo Abeni
On Wed, 2017-02-08 at 12:27 +0200, Kalle Valo wrote: > Paolo Abeni writes: > > > On Tue, 2017-02-07 at 20:23 +0100, Arend Van Spriel wrote: > > > On 7-2-2017 17:50, Paolo Abeni wrote: > > > > the skbs can be held by the driver for a long time, so we need > > > > to clear any

Re: [PATCH net] brcmfmac: clear skb head state on xmit

2017-02-08 Thread Paolo Abeni
On Wed, 2017-02-08 at 09:52 +0100, Rafał Miłecki wrote: > On 8 February 2017 at 09:38, Paolo Abeni wrote: > > On Tue, 2017-02-07 at 20:23 +0100, Arend Van Spriel wrote: > > > On 7-2-2017 17:50, Paolo Abeni wrote: > > > > the skbs can be held by the driver for a long time, so we

Re: [PATCH net] brcmfmac: clear skb head state on xmit

2017-02-08 Thread Rafał Miłecki
On 8 February 2017 at 09:38, Paolo Abeni wrote: > On Tue, 2017-02-07 at 20:23 +0100, Arend Van Spriel wrote: >> On 7-2-2017 17:50, Paolo Abeni wrote: >> > the skbs can be held by the driver for a long time, so we need >> > to clear any state on xmit to avoid hanging other

Re: [PATCH net] brcmfmac: clear skb head state on xmit

2017-02-08 Thread Paolo Abeni
On Tue, 2017-02-07 at 20:23 +0100, Arend Van Spriel wrote: > On 7-2-2017 17:50, Paolo Abeni wrote: > > the skbs can be held by the driver for a long time, so we need > > to clear any state on xmit to avoid hanging other subsystems. > > The skbs are already orphaned later in cmsg code, so we just >

Re: [PATCH net] brcmfmac: clear skb head state on xmit

2017-02-07 Thread Arend Van Spriel
On 7-2-2017 17:50, Paolo Abeni wrote: > the skbs can be held by the driver for a long time, so we need > to clear any state on xmit to avoid hanging other subsystems. > The skbs are already orphaned later in cmsg code, so we just > need to clear the nf/dst/secpath. > Do it early, while the

[PATCH net] brcmfmac: clear skb head state on xmit

2017-02-07 Thread Paolo Abeni
the skbs can be held by the driver for a long time, so we need to clear any state on xmit to avoid hanging other subsystems. The skbs are already orphaned later in cmsg code, so we just need to clear the nf/dst/secpath. Do it early, while the relevant entries are hopefully still hot in the cache.