[PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error

2017-02-27 Thread Hans de Goede
Using pr_err for things which are not errors is a bad idea. E.g. it will cause the plymouth bootsplash screen to drop back to the text console so that the user can see the error, which is not what we normally want to happen. Instead add a new brcmf_info macro and use that. Signed-off-by: Hans de

Re: [PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error

2017-03-07 Thread Arend Van Spriel
On 27-2-2017 22:45, Hans de Goede wrote: > Using pr_err for things which are not errors is a bad idea. E.g. it > will cause the plymouth bootsplash screen to drop back to the text > console so that the user can see the error, which is not what we > normally want to happen. > > Instead add a new br

Re: [PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error

2017-03-07 Thread Kalle Valo
Hans de Goede writes: > Using pr_err for things which are not errors is a bad idea. E.g. it > will cause the plymouth bootsplash screen to drop back to the text > console so that the user can see the error, which is not what we > normally want to happen. > > Instead add a new brcmf_info macro and

Re: [PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error

2017-03-08 Thread Hans de Goede
Hi, On 07-03-17 10:59, Arend Van Spriel wrote: On 27-2-2017 22:45, Hans de Goede wrote: Using pr_err for things which are not errors is a bad idea. E.g. it will cause the plymouth bootsplash screen to drop back to the text console so that the user can see the error, which is not what we normall

Re: [PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error

2017-03-08 Thread Arend Van Spriel
On 8-3-2017 9:23, Hans de Goede wrote: > Hi, > > On 07-03-17 10:59, Arend Van Spriel wrote: >> On 27-2-2017 22:45, Hans de Goede wrote: >>> Using pr_err for things which are not errors is a bad idea. E.g. it >>> will cause the plymouth bootsplash screen to drop back to the text >>> console so that

Re: [PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error

2017-03-08 Thread Kalle Valo
Hans de Goede writes: >>> I think Kalle prefers the whole series to be resubmitted. >>> >>> Kalle, >>> >>> Can you confirm (or deny)? >> >> Exactly, I want to apply the full series (with the highest version >> number). Not waste time guessing what patches I should take and what to >> drop, with t

Re: [PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error

2017-03-08 Thread Hans de Goede
HI, On 08-03-17 10:57, Kalle Valo wrote: Arend Van Spriel writes: On 8-3-2017 9:23, Hans de Goede wrote: Hi, On 07-03-17 10:59, Arend Van Spriel wrote: On 27-2-2017 22:45, Hans de Goede wrote: Using pr_err for things which are not errors is a bad idea. E.g. it will cause the plymouth boot

Re: [PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error

2017-03-08 Thread Kalle Valo
Arend Van Spriel writes: > On 8-3-2017 9:23, Hans de Goede wrote: >> Hi, >> >> On 07-03-17 10:59, Arend Van Spriel wrote: >>> On 27-2-2017 22:45, Hans de Goede wrote: Using pr_err for things which are not errors is a bad idea. E.g. it will cause the plymouth bootsplash screen to drop b

Re: [PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error

2017-03-08 Thread Arend Van Spriel
On 8-3-2017 11:08, Hans de Goede wrote: > HI, > > On 08-03-17 10:57, Kalle Valo wrote: >> Arend Van Spriel writes: >> >>> On 8-3-2017 9:23, Hans de Goede wrote: Hi, On 07-03-17 10:59, Arend Van Spriel wrote: > On 27-2-2017 22:45, Hans de Goede wrote: >> Using pr_err for thi