Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-23 Thread Kalle Valo
Adrian Chadd writes: > On 23 April 2018 at 08:50, Kalle Valo wrote: > >> >> Adrian was also commenting something similar about adding a debugfs >> interface but I don't really see the point right now while we are adding >> initial wcn3990 support. If

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-23 Thread Adrian Chadd
On 23 April 2018 at 08:50, Kalle Valo wrote: > > Adrian was also commenting something similar about adding a debugfs > interface but I don't really see the point right now while we are adding > initial wcn3990 support. If someone wants to run measurements with and > without

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-23 Thread Kalle Valo
Arend van Spriel writes: > On 4/20/2018 9:21 AM, Sebastian Gottschall wrote: >> Yes this is WIFI chip set level power-save(based on idleness) and not related to protocol power save. FW will turn off/scale down the resources(clock/rails) based on

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-20 Thread govinds
On 2018-04-20 13:46, Arend van Spriel wrote: On 4/20/2018 9:21 AM, Sebastian Gottschall wrote: Yes this is WIFI chip set level power-save(based on idleness) and not related to protocol power save. FW will turn off/scale down the resources(clock/rails) based on opportunity(when ever idle mode

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-20 Thread Arend van Spriel
On 4/20/2018 9:21 AM, Sebastian Gottschall wrote: Yes this is WIFI chip set level power-save(based on idleness) and not related to protocol power save. FW will turn off/scale down the resources(clock/rails) based on opportunity(when ever idle mode is detected). This power save is mostly done

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-20 Thread Sebastian Gottschall
Yes this is WIFI chip set level power-save(based on idleness) and not related to protocol power save. FW will turn off/scale down the resources(clock/rails) based on opportunity(when ever idle mode is detected). This power save is mostly done in disconnected state. I am not really sure when

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-19 Thread Adrian Chadd
Hi, My 2c here. As much as I like power save stuff, I've been bitten enough times by these wifi chips kinda implementing mostly-ok-but-not-that-particular-time power savings stuff and so have had to make it configurable chip by chip. A good example is active state power management in various

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-19 Thread Kalle Valo
govi...@codeaurora.org writes: > On 2018-04-18 18:46, Kalle Valo wrote: >> (fixing top posting) >> >> govi...@codeaurora.org writes: >> >>> On 2018-04-18 12:36, Sebastian Gottschall wrote: from my point of view powersave should be optional and not forced. consider : iw dev

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-18 Thread govinds
On 2018-04-18 18:46, Kalle Valo wrote: (fixing top posting) govi...@codeaurora.org writes: On 2018-04-18 12:36, Sebastian Gottschall wrote: from my point of view powersave should be optional and not forced. consider : iw dev set power_save on/off so there is already a config option made

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-18 Thread Arend van Spriel
On 4/18/2018 3:16 PM, Kalle Valo wrote: (fixing top posting) govi...@codeaurora.org writes: On 2018-04-18 12:36, Sebastian Gottschall wrote: from my point of view powersave should be optional and not forced. consider : iw dev set power_save on/off so there is already a config option made

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-18 Thread Kalle Valo
(fixing top posting) govi...@codeaurora.org writes: > On 2018-04-18 12:36, Sebastian Gottschall wrote: >> from my point of view powersave should be optional and not forced. >> >> consider : >> iw dev set power_save on/off >> >> so there is already a config option made for that purpose, > >

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-18 Thread govinds
On 2018-04-18 12:36, Sebastian Gottschall wrote: from my point of view powersave should be optional and not forced. consider : iw dev set power_save on/off so there is already a config option made for that purpose, Sebastian Am 17.04.2018 um 14:07 schrieb pill...@codeaurora.org: From:

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-18 Thread Sebastian Gottschall
from my point of view powersave should be optional and not forced. consider : iw dev set power_save on/off so there is already a config option made for that purpose, Sebastian Am 17.04.2018 um 14:07 schrieb pill...@codeaurora.org: From: Govind Singh Enable sta

[PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-17 Thread pillair
From: Govind Singh Enable sta power save in fw for the targets that supports idle power save. The idle ps enable command will be ignored by the firmware which does not support this feature. Signed-off-by: Govind Singh Signed-off-by: Rakesh Pillai