Re: [PATCH v5 0/4] add VHT support to minstrel_ht

2014-10-22 Thread Johannes Berg
On Wed, 2014-10-22 at 16:15 +0200, Karl Beldan wrote: > > Wait, are you saying it *is* out of bounds when VHT isn't turned on? > > > > The smatch warning pops on > { > if (!(mi->groups[i].supported & BIT(j))) > continue; > ... > else if (i >= MINSTREL_VHT_GROUP_0) > } > > MINSTREL_V

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

2014-10-22 Thread Karl Beldan
On Wed, Oct 22, 2014 at 04:07:31PM +0200, Johannes Berg wrote: > On Wed, 2014-10-22 at 15:54 +0200, Karl Beldan wrote: > > On Tue, Oct 21, 2014 at 08:47:26PM +0200, Johannes Berg wrote: > > > On Tue, 2014-10-21 at 17:26 +0200, Karl Beldan wrote: > > > > > > > I still don't know why I don't see the

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

2014-10-22 Thread Johannes Berg
On Wed, 2014-10-22 at 15:54 +0200, Karl Beldan wrote: > On Tue, Oct 21, 2014 at 08:47:26PM +0200, Johannes Berg wrote: > > On Tue, 2014-10-21 at 17:26 +0200, Karl Beldan wrote: > > > > > I still don't know why I don't see the smatch array warnings here, I > > > guess I'll live with that for now. >

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

2014-10-22 Thread Karl Beldan
On Tue, Oct 21, 2014 at 08:47:26PM +0200, Johannes Berg wrote: > On Tue, 2014-10-21 at 17:26 +0200, Karl Beldan wrote: > > > I still don't know why I don't see the smatch array warnings here, I > > guess I'll live with that for now. > > I'm hoping Dan will eventually pick up on it ;-) > smatch i

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

2014-10-21 Thread Johannes Berg
On Tue, 2014-10-21 at 17:26 +0200, Karl Beldan wrote: > I still don't know why I don't see the smatch array warnings here, I > guess I'll live with that for now. I'm hoping Dan will eventually pick up on it ;-) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

2014-10-21 Thread Karl Beldan
On Mon, Oct 20, 2014 at 09:33:17PM +0200, Johannes Berg wrote: > On Mon, 2014-10-20 at 17:34 +0200, Karl Beldan wrote: > > > Indeed, will resending only 4/4 do ? > > Sure. > > > > > CHECK > > > > /home/johannes/sys/wireless/net/mac80211/rc80211_minstrel_ht_debugfs.c > > > > /home/johannes/sy

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

2014-10-21 Thread Karl Beldan
On Mon, Oct 20, 2014 at 09:40:35PM +0200, Johannes Berg wrote: > On Mon, 2014-10-20 at 21:33 +0200, Johannes Berg wrote: > > On Mon, 2014-10-20 at 17:34 +0200, Karl Beldan wrote: > > > > Indeed, will resending only 4/4 do ? > > > > Sure. > > I merged patches 1-3 now. > Thanks. karl -- To unsub

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

2014-10-20 Thread Johannes Berg
On Mon, 2014-10-20 at 21:33 +0200, Johannes Berg wrote: > On Mon, 2014-10-20 at 17:34 +0200, Karl Beldan wrote: > > > Indeed, will resending only 4/4 do ? > > Sure. I merged patches 1-3 now. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a m

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

2014-10-20 Thread Johannes Berg
On Mon, 2014-10-20 at 17:34 +0200, Karl Beldan wrote: > > Indeed, will resending only 4/4 do ? Sure. > > > CHECK > > > /home/johannes/sys/wireless/net/mac80211/rc80211_minstrel_ht_debugfs.c > > > /home/johannes/sys/wireless/net/mac80211/rc80211_minstrel_ht_debugfs.c:47 > > > minstrel_ht_sta

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

2014-10-20 Thread Karl Beldan
On Mon, Oct 20, 2014 at 05:13:02PM +0200, Karl Beldan wrote: > On Mon, Oct 20, 2014 at 04:49:06PM +0200, Johannes Berg wrote: > > On Mon, 2014-10-20 at 15:45 +0200, Karl Beldan wrote: > > > From: Karl Beldan > > > > > > Hi, > > > > > > Varka Bhadram reported checkpatch is noisy on this series. >

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

2014-10-20 Thread Karl Beldan
On Mon, Oct 20, 2014 at 04:49:06PM +0200, Johannes Berg wrote: > On Mon, 2014-10-20 at 15:45 +0200, Karl Beldan wrote: > > From: Karl Beldan > > > > Hi, > > > > Varka Bhadram reported checkpatch is noisy on this series. > > I made another pass which affects [2/4](trivially) and [4/4]. > > This c

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

2014-10-20 Thread Johannes Berg
On Mon, 2014-10-20 at 15:45 +0200, Karl Beldan wrote: > From: Karl Beldan > > Hi, > > Varka Bhadram reported checkpatch is noisy on this series. > I made another pass which affects [2/4](trivially) and [4/4]. > This could have been a patch on top of what Felix acked, I hope you > won't bother to

[PATCH v5 0/4] add VHT support to minstrel_ht

2014-10-20 Thread Karl Beldan
From: Karl Beldan Hi, Varka Bhadram reported checkpatch is noisy on this series. I made another pass which affects [2/4](trivially) and [4/4]. This could have been a patch on top of what Felix acked, I hope you won't bother too much. Thanks for reviewing, Karl Beldan (4): mac80211: minstrel_h