Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-03-20 Thread Thomas Pedersen
On Thu, Mar 2, 2017 at 9:41 AM, Jesse Jones wrote: >> Hi Alexis, >> >> > This is loosely based on RFC5148, specifically event-triggered message >> > generation as described in section 5.2. >> >> I'm confused. I see how that generally seems to apply to any mobile >> network, but it *does* state up-

Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-03-18 Thread Alexis Green
Hi Johannes, Thank you for the comments, I'll see if I can apply all of your suggestions and resubmit. Alexis On Thu, Mar 16, 2017 at 3:18 AM, Johannes Berg wrote: > Sorry - this is the other half of my reply that I accidentally deleted > before sending... > >> +static void flush_tx_skbs(struct

Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-03-16 Thread Johannes Berg
Sorry - this is the other half of my reply that I accidentally deleted before sending...   > +static void flush_tx_skbs(struct ieee80211_sub_if_data *sdata) > +{ > + struct ieee80211_if_mesh *ifmsh = &sdata->u.mesh; > + struct mesh_tx_queue *tx_node; > + > + spin_lock_bh(&ifmsh->mesh_tx

Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-03-16 Thread Johannes Berg
Hi, So I guess after all the discussion, you should amend the commit log a bit, certainly at least to mention the hidden-node issue. Regarding the patch itself, I'm not super happy with how big it is, some additional comments below: > +struct mesh_tx_queue { > + struct list_head list; > +

Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-03-14 Thread Johannes Berg
> Isn't CWmin and CWmax only used for retries? No. > We recently had the problem that on 5MHz channels probe-responses of > APs which can't hear each other (hidden node problem) always collide. I think this is what I neglected - if the APs won't hear each other, all their own sensing and NAV wo

Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-03-13 Thread Benjamin Beichler
Am 09.03.2017 um 16:49 schrieb Matthias May: > On 06/03/17 13:38, Johannes Berg wrote: >>> Well it certainly attempts to via stuff like carrier sense. But that >>> is not fool proof and any time two routers hear a frame and both >>> decide to forward it immediately there is a chance that they will

Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-03-10 Thread Alexis Green
These images work intermittently for me. Here they are rehosted: [1] http://i.imgur.com/zM0eLNk.png [2] http://i.imgur.com/E7GL7U3.png On Fri, Mar 10, 2017 at 12:40 AM, Kalle Valo wrote: > Matthias May writes: > >> [1] http://may.nu/images/problem.png >> [2] http://may.nu/images/jittered.png >

Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-03-10 Thread Kalle Valo
Matthias May writes: > [1] http://may.nu/images/problem.png > [2] http://may.nu/images/jittered.png I get 404 "Not Found" for these. -- Kalle Valo

Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-03-09 Thread Matthias May
On 06/03/17 13:38, Johannes Berg wrote: > >> Well it certainly attempts to via stuff like carrier sense. But that >> is not fool proof and any time two routers hear a frame and both >> decide to forward it immediately there is a chance that they will >> both sense the air at the same time, decide

RE: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-03-06 Thread Jesse Jones
> > Well it certainly attempts to via stuff like carrier sense. But that > > is not fool proof and any time two routers hear a frame and both > > decide to forward it immediately there is a chance that they will both > > sense the air at the same time, decide that it is clear, and lose both > > the

Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-03-06 Thread Johannes Berg
> Well it certainly attempts to via stuff like carrier sense. But that > is not fool proof and any time two routers hear a frame and both > decide to forward it immediately there is a chance that they will > both sense the air at the same time, decide that it is clear, and > lose both their forwar

RE: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-03-02 Thread Jesse Jones
> Hi Alexis, > > > This is loosely based on RFC5148, specifically event-triggered message > > generation as described in section 5.2. > > I'm confused. I see how that generally seems to apply to any mobile > network, but it *does* state up-front that > In some instances, these problems can be s

Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-03-02 Thread Johannes Berg
Hi Alexis, > This is loosely based on RFC5148, specifically event-triggered > message generation as described in section 5.2. I'm confused. I see how that generally seems to apply to any mobile network, but it *does* state up-front that In some instances, these problems can be solved in these

Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-02-27 Thread Alexis Green
Hi Johannes, This is loosely based on RFC5148, specifically event-triggered message generation as described in section 5.2. The frames are not duplicated, but, hopefully offset enough so they don't collide at the receiver (and, since, these are management frames, there is no retransmission and

Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-02-27 Thread Johannes Berg
On Fri, 2017-02-24 at 11:58 -0800, Alexis Green wrote: > From: Jesse Jones > > Changes since v1: Only flush tx queue if interface is mesh mode. >   This prevents kernel panics due to uninitialized spin_lock. > > When more than one station hears a broadcast request, it is possible > that multiple