Re: [PATCH] mac80211_hwsim: allow setting custom features/iftypes

2018-10-09 Thread Kalle Valo
James Prestwood writes: > The current driver hard codes various features, ext features and supported > interface types when a new radio is created. This patch adds several new > hwsim attributes so user space can specify specific features the radio should > have: > > - HWSIM_ATTR_FEATURE_SUPPORT

Re: [PATCH] mac80211_hwsim: allow setting custom features/iftypes

2018-10-09 Thread James Prestwood
On Tue, 2018-10-09 at 22:47 +0200, Johannes Berg wrote: > On Tue, 2018-10-09 at 13:42 -0700, James Prestwood wrote: > > > > In general, I guess what would work is to be able to *restrict* > > > the > > > advertised features over what's currently the case, but I suspect > > > that's not something

Re: [PATCH] mac80211_hwsim: allow setting custom features/iftypes

2018-10-09 Thread Johannes Berg
On Tue, 2018-10-09 at 13:42 -0700, James Prestwood wrote: > > In general, I guess what would work is to be able to *restrict* the > > advertised features over what's currently the case, but I suspect > > that's not something that would be so very much useful for you (unless we > > also add more

Re: [PATCH] mac80211_hwsim: allow setting custom features/iftypes

2018-10-09 Thread James Prestwood
On Tue, 2018-10-09 at 22:13 +0200, Johannes Berg wrote: > On Tue, 2018-10-09 at 13:12 -0700, James Prestwood wrote: > > > Ok, that makes sense. The intent here was to test logic for > > detecting > > and handling supported driver features/iftypes, rather than > > actually > > using the features.

Re: [PATCH] mac80211_hwsim: allow setting custom features/iftypes

2018-10-09 Thread Johannes Berg
On Tue, 2018-10-09 at 13:12 -0700, James Prestwood wrote: > Ok, that makes sense. The intent here was to test logic for detecting > and handling supported driver features/iftypes, rather than actually > using the features. But I do understand it would be strange for anyone > trying to enable a

Re: [PATCH] mac80211_hwsim: allow setting custom features/iftypes

2018-10-09 Thread James Prestwood
On Tue, 2018-10-09 at 21:41 +0200, Johannes Berg wrote: > On Tue, 2018-10-09 at 10:48 -0700, James Prestwood wrote: > > The current driver hard codes various features, ext features and > > supported > > interface types when a new radio is created. This patch adds > > several new > > hwsim

Re: [PATCH] mac80211_hwsim: allow setting custom features/iftypes

2018-10-09 Thread Johannes Berg
On Tue, 2018-10-09 at 10:48 -0700, James Prestwood wrote: > The current driver hard codes various features, ext features and supported > interface types when a new radio is created. This patch adds several new > hwsim attributes so user space can specify specific features the radio should > have: