On Thu, 2016-03-17 at 15:02 +0200, Emmanuel Grumbach wrote:
> From: Johannes Berg
>
> The code is only used with iwlwifi, but still should have proper
> mac80211 naming scheme; fix that.
>
All 4 applied.
johannes
--
To unsubscribe from this list: send the line "unsubscrib
I've applied 1,3-5 of this series.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2016-03-18 at 22:03 -0400, Bob Copeland wrote:
> The mesh_path_reclaim() function, called from an rcu callback,
> cancels
> the mesh_path_timer associated with a mesh path. Unfortunately, this
> call can happen much later, perhaps after the hash table itself is
> destroyed.
>
[...]
appli
On Fri, 2016-03-18 at 22:11 -0400, Bob Copeland wrote:
> This series makes a few minor mesh cleanups after the rhashtable
> rework -- mostly some reductions in padding and allocation waste.
>
Also applied.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
t
Also applied both of these.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2016-02-23 at 17:15 +0100, Johannes Berg wrote:
> > > Perhaps we could live with this being done only for the fast-xmit
> > > case?
> > I don't think we should pass padded vs non-padded frames depending
> > on
> > whether fast-xmit was used. The n
Applied both now, I've had to fix a locking issue in the first patch.
I also worded the requirement for drivers more strongly - drivers
really *must* update the max length if they set the flag and don't use
minstrel.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wire
On Tue, 2016-04-05 at 09:33 -0400, Jeff Mahoney wrote:
> On 4/5/16 5:43 AM, Johannes Berg wrote:
> >
> > On Mon, 2016-04-04 at 14:15 -0400, Jeff Mahoney wrote:
> > >
> > > This fixes:
> > >
> > > net/mac80211/mesh_hwmp.c:603:26: warning: ‘targ
On Thu, 2016-03-31 at 12:28 +0200, Michal Kazior wrote:
> +++ b/net/mac80211/codel.h
> +++ b/net/mac80211/codel_i.h
Do we really need all this code in .h files? It seems very odd to me to
have all the algorithm implementation there rather than a C file, you
should (can?) only include codel.h into
On Wed, 2016-04-06 at 07:35 +0200, Michal Kazior wrote:
> I just wanted to follow the suggested/implied usage of codel code and
> keep modifications to a minimum. I could very well just assimilate it
> if you wish.
I don't really feel all that strongly about it, but I also don't see
the point. It
[removing other lists since they spam me with moderation bounces]
> The hope had been the original codel.h would have been reusable,
> which is not the case at present.
So what's the strategy for making it happen? Unless there is one, I
don't see the point in making the code more complicated than
On Tue, 2016-04-05 at 19:46 -0400, Avery Pennarun wrote:
> This test was with backports-20150525 on ath9k. (We have newer
> versions in the queue, but they haven't rolled out to our customers
> yet. Anyway, earlier in this thread, I was able to trigger the race
> condition on much newer backport
> /**
> + * struct cfg80211_nan_conf - nan configuration
> + *
> + * This struct defines nan configuration parameters
I think you should consistently capitalize "NAN" in comments.
> + * @start_nan: Start the NAN interface.
> + * @stop_nan: Stop the NAN interface.
johannes
--
To unsubscribe from
On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote:
> This codes doens't do much besides allowing to start and
> stop the vif.
Few typos? :)
> + * @start_nan: join an existing nan cluster, or create a new one.
> + * @stop_nan: leave the nan cluster.
NAN
johannes
--
To unsubscribe from t
On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote:
> + * @cookie: user defined cookie (will be returned with
> notifications)
Didn't we change it to not be user defined?
> + * @NL80211_NAN_FUNC_TTL: number of DWs this function should stay
> active. 0 is
> + * equivalent to no TTL at a
On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote:
> Some NAN configuration paramaters
parameters
> /**
> + * enum cfg80211_nan_conf_changes - indicates changed fields in nan
> configuration
again, NAN please
> + *
> + * @CFG80211_NAN_CONF_CHANGED_PREF: master preference
> + * @CFG80
> + NL80211_ATTR_NAN_FUNC_INST_ID,
I don't see why this has to be a top-level attribute.
> +enum nl80211_nan_func_attributes {
> + __NL80211_NAN_FUNC_INVALID,
> + NL80211_NAN_FUNC_TYPE,
You can easily move it into here, and
> + /* propagate the instance id and cookie to usersp
On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote:
>
> +/**
> + * enum nl80211_nan_match_attributes - NAN match attributes
> + * @__NL80211_NAN_MATCH_INVALID: invalid
> + * @NL80211_NAN_MATCH_FUNC_TYPE: &enum nl80211_nan_function_type
> (u8). This is
> + * the type of the function which
On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote:
>
> @@ -2246,6 +2248,7 @@ enum nl80211_attrs {
> NL80211_ATTR_NAN_FUNC,
> NL80211_ATTR_NAN_FUNC_INST_ID,
> NL80211_ATTR_NAN_MATCH,
> + NL80211_ATTR_NAN_FUNC_TERM_REASON,
You can add this as a nested function attribu
> +int cfg80211_clone_nan_func_members(struct cfg80211_nan_func *f1,
> + const struct cfg80211_nan_func *f2)
> +{
> + memcpy(f1, f2, sizeof(*f1));
That's pretty weird. And the only user of this (in a later patch) is
first allocating the f1. I think this functio
On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote:
>
> * @start_nan: join an existing nan cluster, or create a new one.
> * @stop_nan: leave the nan cluster.
> + * @nan_change_conf: change nan configuration. The data in
> cfg80211_nan_conf
> + * contains full new configuration and c
On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote:
> + * @rm_nan_func: Remove a nan function. The driver must call
> + * ieee80211_nan_func_terminated() with
> + * NL80211_NAN_FUNC_TERM_REASON_USER_REQUEST reason code upon
> removal.
bad indentation.
Also here: nan -> NAN.
> + /* O
On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote:
>
> +void ieee80211_nan_func_match(struct ieee80211_vif *vif,
> + struct cfg80211_nan_match_params
> *match,
> + gfp_t gfp)
> +{
> + struct ieee80211_sub_if_data *sdata = vif_to_sdat
On Wed, 2016-04-06 at 11:20 +0300, Dmitrijs Ivanovs wrote:
> Hi Johannes!
>
> I will prepare patch which does not send NETLINK_URELEASE for unbound
> sockets as you suggest. But I think protocol check in nl80211 is
> still needed because port_id is unique per-protocol.
>
Yes, good point. Can you
On Wed, 2016-04-06 at 09:38 +, Malinen, Jouni wrote:
>
> > +void cfg80211_nan_match(struct wireless_dev *wdev,
> > + struct cfg80211_nan_match_params *match,
> > gfp_t gfp);
> Looks like this function is common for publish, subscribe and follow
> up. If so, can we please have
> Why NL80211_ATTR_NAN_MASTER_PREF is mandatory? The spec suggests to
> assume master preference value of 128 if not provided. Please see
> quoted text from NAN 1.0 specification:
> "A NAN Device which out-of-the-box will have a Master Preference
> greater than or equal to 128 with the intention o
On Tue, 2016-03-29 at 13:53 +0300, Jouni Malinen wrote:
> If the user space issues a NL80211_CMD_CONNECT with
> NL80211_ATTR_PREV_BSSID when there is already a connection, allow
> this
> to proceed as a reassociation instead of rejecting the new connect
> command with EALREADY.
>
> Signed-off-by:
On Mon, 2016-04-04 at 14:15 -0400, Jeff Mahoney wrote:
> This fixes:
>
> net/mac80211/mesh_hwmp.c:603:26: warning: ‘target_metric’ may be used
> uninitialized in this function
>
> target_metric is only consumed when reply = true so no bug exists
> here,
> but gcc doesn't notice that. Initializin
P buffered multicast frames with queue control and txq
Ilan Peer (1):
mac80211: Fix BW upgrade for TDLS peers
Jeff Mahoney (1):
mac80211: fix "warning: ‘target_metric’ may be used uninitialized"
Johannes Berg (1):
mac80211: properly deal with station hashtable insert
gic
mac80211: add A-MSDU tx support
mac80211: minstrel_ht: set A-MSDU tx limits based on selected
max_prob_rate
Johannes Berg (17):
wext: unregister_pernet_subsys() on notifier registration failure
mac80211: allow drivers to report CLOCK_BOOTTIME for scan results
mac
On Wed, 2016-04-06 at 15:25 +0200, Johannes Berg wrote:
> Hi Dave,
>
> For the 4.6 cycle, there's of course much more. The few things that
>
Err, -next, so that's 4.7.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
On Wed, 2016-04-06 at 17:22 +0300, Dmitry Ivanov wrote:
> This patch corrects the problem where non-privileged user may create
> netlink socket with port_id equal to port_id used by hostapd to
> create
> virtual wireless network interfaces. Call to bind() will fail for
> such
> socket, but release
if
NFULNL_CFG_CMD_UNBIND/NFQNL_CFG_CMD_UNBIND had been called.
Fix this problem by checking that the socket is bound before generating
the NETLINK_URELEASE notification.
Cc: sta...@vger.kernel.org
Signed-off-by: Dmitry Ivanov
Signed-off-by: Johannes Berg
---
net/netlink/af_netlink.c | 2 +-
1
On Wed, 2016-04-06 at 17:23 +0300, Dmitry Ivanov wrote:
> This patch corrects the problem where non-privileged user can create
> netlink socket with the same port_id as used by hostapd but different
> protocol number. Upon close() or process termination, a notification
> is
> sent to nl80211 subsy
On Wed, 2016-04-06 at 10:39 -0700, Dave Taht wrote:
> > > The hope had been the original codel.h would have been reusable,
> > > which is not the case at present.
> > So what's the strategy for making it happen?
> Strategy? to meander towards a result that gives low latency to all
> stations, no m
On Wed, 2016-04-06 at 17:38 +0300, Jouni Malinen wrote:
> The roaming cases for the Connect command were not fully covered and
> neither Connect nor Associate command uses of the prev_bssid
> parameter
> were very clear. Add details to describe how the prev_bssid argument
> is
> supposed to be used
On Thu, 2016-04-07 at 18:31 +0530, Krishna Chaitanya wrote:
> Hi,
>
> When using HW_PS and running Downlink only traffic like UDP-RX,
> mac80211 has the mechanism to not to enter power-save (postpone the
> dynamic ps timer).
>
> But if we are already in power-save it continues to stay in PS
> and
On Thu, 2016-04-07 at 21:32 -0400, Avery Pennarun wrote:
> Yes. Here it is:
> http://apenwarr.ca/tmp/mac80211-agg-status-crash.ko
>
Unfortunately there are no debug symbols in this file, so it doesn't
help me much. I can't even seem to get objdump to disassemble it
correctly: looks like the fil
On Fri, 2016-04-08 at 08:56 +0200, Johannes Berg wrote:
> On Thu, 2016-04-07 at 21:32 -0400, Avery Pennarun wrote:
>
> >
> > Yes. Here it is:
> > http://apenwarr.ca/tmp/mac80211-agg-status-crash.ko
> >
> Unfortunately there are no debug symbols in this file
On Fri, 2016-04-08 at 09:01 +0200, Johannes Berg wrote:
> On Fri, 2016-04-08 at 08:56 +0200, Johannes Berg wrote:
> >
> > On Thu, 2016-04-07 at 21:32 -0400, Avery Pennarun wrote:
> >
> > >
> > >
> > > Yes. Here it is:
> >
On Fri, 2016-04-08 at 21:27 -0400, Avery Pennarun wrote:
> > Just to be clear, this crash is only from *reading* the agg_status
> > files. I don't know if the crashiness reduces when disabling the
> > aggregation timeouts, since that's a separate bug (in which the
> > queue gets stuck and the 'pe
On Tue, 2016-04-12 at 21:53 +0200, Arend van Spriel wrote:
>
> On 12-04-16 15:58, Johannes Berg wrote:
> >
> > From: Johannes Berg
> >
> > This enum is already perfectly aliased to enum nl80211_band, and
> > the only reason for it is that we get IEEE80211
On Tue, 2016-04-12 at 16:48 -0700, Ben Greear wrote:
> If a station and it's peer can both do VHT, is there ever a good
> reason to even try HT rates?
>
Not really; perhaps if you could do HT greenfield preamble (which VHT
doesn't have) you could get something out of it, beyond that I don't
see a
> The patch was build-tested / debugged by removing the
> "if VERBOSE > SHOW_ERROR_MESSAGES" guards.
Stands to reason that we should just remove the (more or less) dead
code, since I don't think anyone really ever touches this driver any
more or will ever again ...
johannes
--
To unsubscribe fro
To synchronize with Kalle, here's just a big change that affects
all drivers - removing the duplicated enum ieee80211_band and
replacing it by enum nl80211_band. On top of that, just a small
documentation update.
----
Johannes Berg (1
Hi Dave,
Since I didn't get anything else, and this has been pending for a week,
here's the other part of the nl80211 socket problem fix (the netlink
family URELEASE was the first part.)
Let me know if there's any problem.
Thanks,
johannes
The following changes since commit 30d237a6c2e9be1bb8
Hi,
I know this is a LONG time ago, but nonetheless...
> -static struct ieee80211_iface_combination hwsim_if_comb = {
> - .limits = hwsim_if_limits,
> - .n_limits = ARRAY_SIZE(hwsim_if_limits),
> - .max_interfaces = 2048,
> - .num_different_channels = 1,
> +static const struct iee
On Thu, 2016-04-07 at 19:59 +0530, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan
>
> Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION'.
> 'NL80211_STA_INFO_RX_DURATION' accounts for aggregate PPDU duration
> in microseconds for all the frames from a peer. Dri
On Mon, 2016-04-11 at 15:16 +0530, Kanchanapally, Vidyullatha wrote:
> From: "Kanchanapally, Vidyullatha"
>
> Since cfg80211 maintains separate BSS table entries for APs if the
> same
> BSSID, SSID pair is seen on multiple channels, it is possible that it
> can map the current_bss to a BSS entry
On Sat, 2016-04-16 at 14:30 +0800, Herbert Xu wrote:
> Johannes Berg wrote:
> >
> >
> > diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> > index 215fc08c02ab..330ebd600f25 100644
> > --- a/net/netlink/af_netlink.c
> > +++ b/net/ne
On Fri, 2016-04-15 at 16:57 +0530, Kanchanapally, Vidyullatha wrote:
>
> +struct wiphy_iftype_ext_capab {
> + enum nl80211_iftype iftype;
> + const u8 *ext_capab;
> + const u8 *ext_capab_mask;
> + u8 ext_capab_len;
I think you should reuse the struct member names that we used befo
> +static void ieee80211_txq_enqueue(struct ieee80211_local *local,
> + struct txq_info *txqi,
> + struct sk_buff *skb)
> +{
> + lockdep_assert_held(&txqi->queue.lock);
[...]
> + atomic_inc(&local->num_tx_queued);
This global kind
On Thu, 2016-04-14 at 14:18 +0200, Michal Kazior wrote:
>
> +++ b/net/mac80211/fq.h
>
Now that you've mostly rewritten it, why keep it in a .h file?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More ma
On Sun, 2016-04-17 at 00:23 +0200, Johannes Berg wrote:
> On Thu, 2016-04-14 at 14:18 +0200, Michal Kazior wrote:
> >
> >
> > +++ b/net/mac80211/fq.h
> >
> Now that you've mostly rewritten it, why keep it in a .h file?
>
I think I just confused this w
On Thu, 2016-04-14 at 14:18 +0200, Michal Kazior wrote:
>
> + struct ieee80211_vif *vif;
> +
> + /* When packets are enqueued on txq
> it's easy
> + * to re-construct the vif pointer.
> There's no
> +
On Sun, 2016-04-17 at 01:34 +0200, Arnd Bergmann wrote:
> On Wednesday 13 April 2016 10:38:26 Johannes Berg wrote:
> >
> > >
> > > The patch was build-tested / debugged by removing the
> > > "if VERBOSE > SHOW_ERROR_MESSAGES" guards.
> > S
On Mon, 2016-04-18 at 00:10 +0200, Arnd Bergmann wrote:
> On Sunday 17 April 2016 14:42:33 Johannes Berg wrote:
> >
> >
> > I was thinking more restrictively of just the stuff that can't even
> > be
> > built without modifying the sources - like th
On Mon, 2016-04-18 at 14:38 +0200, Michal Kazior wrote:
> On 18 April 2016 at 07:31, Michal Kazior
> wrote:
> >
> > On 17 April 2016 at 00:29, Johannes Berg > > wrote:
> > >
> > > On Thu, 2016
On Mon, 2016-04-18 at 15:36 +0200, Michal Kazior wrote:
> FWIW cfg80211 drivers might become another user of the fq/codel stuff
> in the future.
>
> Arguably I should make include/net/codel.h not be qdisc specific as
> it is now (and hence re-usable by mac80211) and submit fq.h to
> include/net/.
On Mon, 2016-04-18 at 13:23 +0200, Michal Kazior wrote:
> You can't really implement complete IPv6 support in relayd though.
> Link-local routing is forbidden by the spec explicitly and a patch
> I've cooked up was rejected[1].
>
> I guess this leaves either the kernel's wireless stack to take up
On Tue, 2016-04-19 at 11:31 +0200, Michal Kazior wrote:
> > We should just get rid of all the rate stuff and convert everything
> > to use rate tables, but ... :)
> I'm guessing it's not trivial either and you risk breaking a lot of
> stuff? :)
It's not "tricky" in the same sense - but we'd have
> > How much of that could be done with nftables btw?
> I'm not sure if I follow. Do you mean what I've been able to do with
> relayd until now? Without link-local ipv6 routing DHCPv6 is broken
> (could probably addressed with DHCPv6 Relay to a certain degree) and
> RS/RA may not work (if it pro
On Wed, 2016-04-20 at 18:05 +0100, Ben Hutchings wrote:
>
> I see. You could make this work when the interface is down and
> return -EBUSY if the interface is up.
>
It's slightly more complicated, since it doesn't just affect a single
netdev but possibly more than one (since the table is shared
On Thu, 2016-04-21 at 08:15 -0700, Ben Greear wrote:
> The thing is, it actually works just fine with the patch I posted
> to fix mac80211, and at any rate, even if the mac80211 patch isn't
> applied, the ath10k driver works just fine in HT mode.
This patch has no implications on HT, and I wasn't
From: Johannes Berg
Since a/b/g/n no longer exist as spec amendements and VHT (ex 802.11ac)
wasn't handled at all, it's better to just remove the amendment strings
to avoid confusion.
Signed-off-by: Johannes Berg
---
net/wireless/wext-compat.c | 35 -
Hi Nicholas,
Thanks for doing this.
I'll also add a fix for the macro-generated nla_put_64() in
nl80211_send_station(), unless there was a particular reason you didn't
take that one?
I suspect you just missed it while grepping, but wanted to ask.
johannes
--
To unsubscribe from this list: send
From: Johannes Berg
Nicolas converted most users, but didn't realize some were generated
by macros. Convert those over as well.
Signed-off-by: Johannes Berg
---
include/uapi/linux/nl80211.h | 4
net/wireless/nl80211.c | 36 ++--
2 files change
On Tue, 2016-04-26 at 02:56 -0600, Reinoud Koornstra wrote:
> I'm also using the 7620 AC.
> When I type:
>
> sudo iw dev wlp0s4 scan I see:
>
"scan" is completely irrelevant for what actually ends up getting used.
"link" is relevant, but if you want to see the hardware capabilities
(like what iw
On Tue, 2016-04-26 at 12:54 +0100, Radu P wrote:
> Is there a way running
>
> ./iw dev wlanX link
>
> but to get the output for the 5 Ghz frequency?
> now I am getting only this:
>
> freq: 2432
> tx bitrate: 130.0 MBit/s MCS 14 short GI
Sure: connect to a 5 GHz AP first :)
johannes
--
To unsub
From: Johannes Berg
In the case that dev_alloc_name() fails, e.g. because the name was
given by the user and already exists, we need to clean up properly
and free the per-CPU statistics. Fix that.
Cc: sta...@vger.kernel.org
Fixes: 5a490510ba5f ("mac80211: use per-CPU TX/RX statistics&quo
case.
Johannes Berg (1):
mac80211: fix statistics leak if dev_alloc_name() fails
net/mac80211/iface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@
On Wed, 2016-04-27 at 15:07 +0530, Krishna Chaitanya wrote:
>
> If many vendors need this support, then mac80211 appraoch would be
> good. If not, we should stick to driver approach.
Trying to do this in the driver gets practically impossible, so no, it
really should be done in mac80211 either wa
Hi,
Since I've been getting questions about the next possible workshop and
its organisation, I decided to make a poll about it:
http://goo.gl/forms/iMcE8b4TYU
Please reply by
May 16th
so I can aggregate/evaluate the responses and we can make a decision.
I don't know anything about opt
On Fri, 2016-04-29 at 09:26 +1000, Julian Calaby wrote:
> > +
> > +# Silence some warnings for now. Needs to be fixed upstream.
> > b/26105799
> Comments like this worry me: who is being referred to as "upstream",
> what are these warnings and why has nobody fixed them?
>
It's funny, because we'
On Tue, 2016-04-26 at 09:35 +0200, Johannes Berg wrote:
> From: Johannes Berg
>
> Since a/b/g/n no longer exist as spec amendements and VHT (ex
> 802.11ac)
> wasn't handled at all, it's better to just remove the amendment
> strings
> to avoid confusion.
>
Ap
> + if (vhtc->cap & IEEE80211_VHT_CAP_ ## a)+
> p += scnprintf(p, sizeof(buf) + buf
> - p, \
> + "\t\t%s\n", b);
Why not use #a instead of b?
> + PFLAG(MAX_MPDU_LENGTH_3895, "MAX-MPDU-3895")
On Mon, 2016-05-02 at 14:23 -0700, gree...@candelatech.com wrote:
> From: Ben Greear
>
> This makes it a lot easier to understand the capabilities used
> by the station:
>
> VHT supported
> cap: 0x300819b2
> MAX-MPDU-11454
> RXLDPC
> SHORT-GI-80
>
On Tue, 2016-05-03 at 08:53 +0200, Martin Willi wrote:
> While wiphys can be moved into network namespaces over nl80211, the
> creation and removal of hwsim radios is currently limited to the
> initial namespace. This patch allows management of namespaced radios
> from the owning namespace by setti
On Tue, 2016-05-03 at 18:23 +0530, Krishna Chaitanya wrote:
> Hi,
>
> When the HW is in PS and Dynamic PS is enabled we are dropping
> all the offchannel frames. Sequence is as below
>
> if hw is in PS: stop_queues reason=PS, queue dynamic_ps_disable_work
> send Offchannel mgmt_tx
> drop the pack
On Tue, 2016-05-03 at 20:02 +0530, Krishna Chaitanya wrote:
> > i don't see any issues in the powersave w.r.t driver. Isn't it a
> > valid case? you meant implementing dynamic_ps?
No, I really did mean implementing the entire PS logic in the driver,
instead of having mac80211 do it.
> If it adve
On Tue, 2016-05-03 at 19:21 +0200, Janusz Dziedzic wrote:
>
> Why not remove PS code from the mac80211 then, while is broken and
> should not be used?
>
It'd still be a regression since some drivers can kinda use it.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wi
On Fri, 2016-04-22 at 14:52 +, Kanchanapally, Vidyullatha wrote:
>
> > So I'm thinking something like
> >
> > supported_on_all = iftype_ext_capab[0]
> > for i in 1..num_iftype_ext_capab-1:
> > supported_on_all &= iftype_ext_capab[i]
> > WARN_ON(wiphy->ext_capa_mask & ~supported_on_all)
On Tue, 2016-05-03 at 08:53 +0200, Martin Willi wrote:
>
> +static __net_init int hwsim_init_net(struct net *net)
> +{
> + struct mac80211_hwsim_data *data;
> + bool exists = true;
> + int netgroup = 0;
> +
> + spin_lock_bh(&hwsim_radio_lock);
> + while (exists) {
> +
There is, btw, perhaps a different way - just fix the damn stuff.
Requires moving everything into ifmgd rather than local, and then
perhaps if only a single managed interface exists mirroring its state
into the existing driver calls etc.
It'd still be a big task, and I don't see much advantage ov
On Wed, 2016-05-04 at 01:20 +0530, Krishna Chaitanya wrote:
> On Wed, May 4, 2016 at 1:05 AM, Johannes Berg net> wrote:
> >
> > There is, btw, perhaps a different way - just fix the damn stuff.
> >
> > Requires moving everything into ifmgd rather than local,
On Tue, 2016-05-03 at 16:40 -0400, Kangjie Lu wrote:
> The 6-bytes array “mac_addr” is not initialized in the dump_station
> implementations of
> “drivers/staging/wilc1000/wilc_wfi_cfgoperations.c”
> and “drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c”, so all 6
> bytes may be leaked.
Like I sa
On Wed, 2016-05-04 at 10:33 +0200, Martin Willi wrote:
> > This changes today's default behaviour of moving the wiphys to the
> > default namespace. Did you intend to destroy them based on the
> > netgroup, i.e. based on the namespace that created them? Actually,
> > maybe they should move back to
> >
> > + data->netgroup = *(int *)net_generic(net, hwsim_net_id);
> Anything doing *(integer_type *) rings alarm bells.
>
> I suspect you should be defining a structure that currently contains
> one integer member.
> Something (maybe a compile time assert) needs to check that buffer
> space y
On Mon, 2016-11-28 at 21:07 +0100, Arend Van Spriel wrote:
>
> I was wondering about the meaning of the term "parent_bssid". Given
> your remark it means something else than my guess. I actually meant
> the distance to the AP indicated by this BSS. Our gscan code obtains
> the gscan results from f
On Fri, 2016-12-02 at 21:56 +0100, Andrew Zaborowski wrote:
> Disconnect or deauthenticate when the owning socket is closed if this
> flag has been supplied to CMD_CONNECT, CMD_AUTHENTICATE or
> CMD_ASSOCIATE.
Huh. That I think needs a lot more commit log to justify this code -
why do you think th
> Thanks, these are obviously all valid concerns. Sorry for being
> sloppy
> with the ifdefs. If I get positive feedback on the proposed feature
> itself, all these issues (and the warning pointed out in the other
> message) will be resolved in v2.
Looks fine, please do that.
johannes
On Tue, 2016-11-29 at 10:05 -0800, gree...@candelatech.com wrote:
> From: Ben Greear
>
> This fixes OOM when using pktgen to drive a wifi station at more than
> the station can transmit. pktgen uses ndo_start_xmit instead of
> going
> through the queue layer, so it will not back off when the que
On Wed, 2016-11-30 at 09:06 +0900, Masashi Honma wrote:
> Previously, kernel sends NEW_PEER_CANDIDATE event to user land even
> if the found peer does not have any room to accept other peer. This
> causes continuous connection trials.
Thanks, applied.
johannes
On Tue, 2016-11-29 at 10:07 -0800, gree...@candelatech.com wrote:
> From: Ben Greear
>
> For non-station devices. This gives at least some useful
> summary in some cases (especially when we know AP has only one
> station attached, for instance).
I never saw the point in having ethtool statistic
On Mon, 2016-12-05 at 09:13 +0100, Michal Kazior wrote:
> On 2 December 2016 at 03:29, wrote:
> >
> > From: Ben Greear
> >
> > This appears to fix a problem where ath10k firmware would crash,
> > mac80211 would start re-adding interfaces to the driver, but the
> > iterate-active-interfaces log
Hi Dmitry,
Sorry I didn't respond earlier.
> Currently we have sched scan with possibility of various
> intervals. We would like to extend it to support also
> different types of scan.
"Different types of scan" is a bit misleading though, isn't it? I mean,
mostly they differ in the reporting
On Tue, 2016-11-08 at 18:45 +0530, c_tr...@qti.qualcomm.com wrote:
> From: Tamizh chelvam
>
> This patch adds support to enable or disable btcoex by
> adding NL80211_ATTR_WIPHY_BTCOEX_ENABLE attribute in
> NL80211_CMD_SET_WIPHY command. By default BTCOEX disabled in driver.
I think overloading S
On Tue, 2016-11-08 at 18:45 +0530, c_tr...@qti.qualcomm.com wrote:
>
> + * struct cfg80211_btcoex_priority - BTCOEX support frame type
> + *
> + * This structure defines the driver supporting frame types for
> BTCOEX
> + *
> + * @wlan_be_preferred: best effort frames preferred over bt traffic
> +
+static ssize_t misc_read(struct file *file, char __user *user_buf,
> + size_t count, loff_t *ppos)
> +{
> + struct ieee80211_local *local = file->private_data;
> + size_t bufsz = 1000;
> + char *buf = kzalloc(bufsz, GFP_KERNEL);
You need at most IEEE80211_MAX_QUEU
> Unless I screwed up, this patch also returns an average.
Oops, sorry. I missed the whole mac_div() indirection thing.
I'm not super convinced anyway though - all of this data already is
available in a much more reliable fashion, even trackable when stations
are removed (all data gets sent in t
1101 - 1200 of 4576 matches
Mail list logo
