On Wed, Jun 27, 2007 at 11:12:11PM +0200, Stefan Reinauer wrote:
> * Uwe Hermann <[EMAIL PROTECTED]> [070625 23:45]:
> > This header doesn't have the "part of LinuxBIOS" line and the copyright
> > holder.
>
> Just for common understanding.. What is it good for?
I think I've explained this once or
* Uwe Hermann <[EMAIL PROTECTED]> [070626 00:57]:
> > +#include
> > #endif /* LIB_H */
>
> I think we handle this differently currently (and that works fine
> so far) -- we should not include include/arch/x86/arch/lib.h
> in include/lib.h, but rather change the Makefile to add the
> include/arch
* Uwe Hermann <[EMAIL PROTECTED]> [070625 23:45]:
> This header doesn't have the "part of LinuxBIOS" line and the copyright
> holder.
Just for common understanding.. What is it good for?
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664
On 6/25/07, Peter Stuge <[EMAIL PROTECTED]> wrote:
> include/lib.h currently has:
>
> log2, {u,m,}delay, beep_{short,long}, smbus_read_byte, ram_failure
> and ram_initialize.
>
> Shouldn't they just go into separate .h files?
That's what made V2 "too greppy" in the words of one. No, I don't like
On Mon, Jun 25, 2007 at 04:16:04PM -0700, ron minnich wrote:
> Right, I did this arch/lib.h thing in response to a request; people
> did not like arch/x86/lib.h in includes. I personally like it, as
> it reduces "magic".
We shouldn't need "magic" - just some simple logic.
Ie. 1:1 rules for what f
Sorry for being so quiet lately. Too much backlog. :(
Sorry also for only complaining again. :(
On Tue, Jun 26, 2007 at 12:57:40AM +0200, Uwe Hermann wrote:
> I think we handle this differently currently (and that works fine
> so far) -- we should not include include/arch/x86/arch/lib.h
> in inc
On 6/25/07, Uwe Hermann <[EMAIL PROTECTED]> wrote:
> I think we handle this differently currently (and that works fine
> so far) -- we should not include include/arch/x86/arch/lib.h
> in include/lib.h, but rather change the Makefile to add the
> include/arch/x86 path to the includes.
>
> The only
On Mon, Jun 25, 2007 at 02:59:51PM -0700, ron minnich wrote:
> try this one.
Better, thanks, but some more comments:
> arch library file
> inluded in include/lib.h
> Signed-off-by: Ronald G. Minnich <[EMAIL PROTECTED]>
>
> Index: include/lib.h
> =
try this one.
ron
arch library file
inluded in include/lib.h
Signed-off-by: Ronald G. Minnich <[EMAIL PROTECTED]>
Index: include/lib.h
===
--- include/lib.h (revision 364)
+++ include/lib.h (working copy)
@@ -37,4 +37,5 @@
void ra
On Mon, Jun 25, 2007 at 02:19:35PM -0700, ron minnich wrote:
> Per discussion on the list, we are adding an arch directory to
> arch/x86, and putting a lib and other files in there we want to
> include with #include
>
> Signed-off-by: Ronald G. Minnich <[EMAIL PROTECTED]>
NAK.
> Index: include
Per discussion on the list, we are adding an arch directory to
arch/x86, and putting a lib and other files in there we want to
include with #include
Signed-off-by: Ronald G. Minnich <[EMAIL PROTECTED]>
Index: include/arch/x86/arch/lib.h
===
11 matches
Mail list logo
