Attempt at addressing head*.S for modpost warnings

2007-07-24 Thread Kumar Gala
Stephen, Paul said you were looking into this issue as well. Wanted to post what I did on ppc32/e500 as a start for you to look at. I think the other ppc32 head*.S can follow the same pattern if we like this. However, wasn't sure how to do _ENTRY() for ppc64. - k diff --git a/arch/powerpc/ker

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-07-24 Thread Alan Curry
Benjamin Herrenschmidt writes the following: > >Doesn't it have something in "compatible" instead ? that would be the >way to go. > Assuming that would be represented as a file named "compatible" in the directory /proc/device-tree/*/*/[EMAIL PROTECTED] ... no, it doesn't have one of those. For th

Re: Please pull from 'for_paulus' branch

2007-07-24 Thread Zang Roy-r61911
On Tue, 2007-07-24 at 05:01, Kumar Gala wrote: > Please pull from 'for_paulus' branch of > > master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git > for_paulus > > Sorry I wasn't able to get this pull request out before -rc1 got > released, > but had some issues w/accessing email/

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-07-24 Thread Benjamin Herrenschmidt
On Tue, 2007-07-24 at 21:28 -0400, Alan Curry wrote: > As of 2.6.22 the kernel doesn't recognize the i8042 keyboard/mouse controller > on the PegasosPPC. This is because of a feature/bug in the OF device tree: > the "device_type" attribute is an empty string instead of "8042" as the > kernel expect

Re: [PATCH] xmon consistency clean up

2007-07-24 Thread Benjamin Herrenschmidt
On Wed, 2007-07-25 at 11:57 +0900, Ishizaki Kou wrote: > This patch cleans up xmon to keep consistency. > > In xmon, we should use console I/O functions that are named the same > as user space stdio functions. But commit > 4d404edce30f911004850d472e05a31efd751662 broke this consistency. > > Signe

[PATCH] [POWERPC] Don't try to allocate resources for a POWERPC PHB

2007-07-24 Thread Kumar Gala
The Freescale PCI PHBs actual report back values in the BAR registers this causes issues in that we try to allocate resources for them and will get error messages like the following on MPC8544 DS: PCI: Failed to allocate mem resource #1:[EMAIL PROTECTED] for :00:00.0 To address this if we are

[PATCH] xmon consistency clean up

2007-07-24 Thread Ishizaki Kou
This patch cleans up xmon to keep consistency. In xmon, we should use console I/O functions that are named the same as user space stdio functions. But commit 4d404edce30f911004850d472e05a31efd751662 broke this consistency. Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> --- Index: linux-powerpc-

Re: [PATCH] Re: 2.6.22-git hangs during boot on PowerBook G3 in 0.0 seconds

2007-07-24 Thread Benjamin Herrenschmidt
> for the enumerated PHYs. As the original commit comment states, I was > getting these messages: > > prom_parse: Bad cell count for /[EMAIL PROTECTED]/[EMAIL PROTECTED]/[EMAIL > PROTECTED] > prom_parse: Bad cell count for /[EMAIL PROTECTED]/[EMAIL PROTECTED]/[EMAIL > PROTECTED] Well, I would

Re: Which Git Tree to pull from?

2007-07-24 Thread Paul Mackerras
Morrison, Tom writes: > I am a little confused here. I've been working in an older (2.6.11) > > ppc release and haven't been paying much attention to where I > > should be getting the latest / stable git tree (for powerpc). > > > > I am working on an e500/8548 branch - it looks like Kumar'

[PATCH] powerpc: Pegasos keyboard detection

2007-07-24 Thread Alan Curry
As of 2.6.22 the kernel doesn't recognize the i8042 keyboard/mouse controller on the PegasosPPC. This is because of a feature/bug in the OF device tree: the "device_type" attribute is an empty string instead of "8042" as the kernel expects. This patch (against 2.6.22.1) adds a secondary detection w

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andrew Morton
On Wed, 25 Jul 2007 11:09:21 +1000 Paul Mackerras <[EMAIL PROTECTED]> wrote: > Also, I prefer the style where the ? and : operators have a space > after them but not before them, rather than a space either side. Could I point out that your likes and dislikes are immaterial? The whole point here

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Paul Mackerras
Andy Whitcroft writes: > Ok, this is something we need to decide on. Currently we only ask for > consistent spacing on all the mathematic operators. This is mostly as > we do see a large number of non-spaced uses in defines and the like. > > I am happy to expand these tests so they are always s

Re: [PATCH] Re: 2.6.22-git hangs during boot on PowerBook G3 in 0.0 seconds

2007-07-24 Thread Kim Phillips
On Tue, 24 Jul 2007 09:55:23 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > After hours of fun git bisecting, finally found the commit to revert > > > to make my PowerBook G3 Lombard boot again. This does not result in > > > the complains the reverted commit was revering to. > >

[PATCH] [POWERPC] iSeries: fix section mismatch warning in lpevents

2007-07-24 Thread Stephen Rothwell
WARNING: vmlinux.o(.text+0x4f568): Section mismatch: reference to .init.text:.__alloc_bootmem (between '.setup_hvlpevent_queue' and '.process_hvlpevents') setup_hvlpevent_queue is only called from __init code so make it __init as well. Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- ar

[PATCH] [POWERPC] iSeries: fix section mismatch warnings

2007-07-24 Thread Stephen Rothwell
WARNING: vmlinux.o(.text+0x8124): Section mismatch: reference to .init.text:.iSeries_early_setup (between '.__start_initialization_iSeries' and '.__mmu_off') WARNING: vmlinux.o(.text+0x8128): Section mismatch: reference to .init.text:.early_setup (between '.__start_initialization_iSeries' and '

"do section mismatch check on full vmlinux" breaks powerpc build

2007-07-24 Thread Nathan Lynch
Hello- 2.6.23-rc1 breaks the build for 64-bit powerpc for me (using maple_defconfig): LD vmlinux.o powerpc64-unknown-linux-gnu-ld: dynreloc miscount for kernel/built-in.o, section .opd powerpc64-unknown-linux-gnu-ld: can not edit opd Bad value make: *** [vmlinux.o] Error 1 This is on a i3

Patches for -rc2

2007-07-24 Thread Guennadi Liakhovetski
Hi Paul, could we get these 2 patches: http://patchwork.ozlabs.org/linuxppc/patch?id=12556 http://patchwork.ozlabs.org/linuxppc/patch?id=12538 in for -rc2 if there are no further objections, as seems to be the case. They let linkstation work with new i2c API and thus fix a regression. Thanks G

Re: [PATCH] eHEA: net_poll support

2007-07-24 Thread Jeff Garzik
Jan-Bernd Themann wrote: > net_poll support for eHEA added > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> > --- > > > drivers/net/ehea/ehea.h |2 +- > drivers/net/ehea/ehea_main.c | 22 +- > 2 files changed, 22 insertions(+), 2 deletions(-) applied __

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andrew Morton
On Tue, 24 Jul 2007 08:37:09 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Andy Whitcroft wrote: > > Andrew Morton wrote: > > > >>> + start_sector = req->sector*priv->blocking_factor; > >>> + sectors = req->nr_sectors*priv->blocking_factor; > >> s/*/ * /. checkpatch missed this. > > > > Ok, th

[PATCH] 86xx: Remove unnecessary loops_per_jiffy initialization code.

2007-07-24 Thread Jon Loeliger
Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]> --- arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c b/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c index 5b01ec7..566c311 1006

Re: [PATCH 21/25] [POWERPC] 85xxCDS: Delay 8259 cascade hookup.

2007-07-24 Thread Kumar Gala
On Jul 24, 2007, at 6:52 AM, Paul Mackerras wrote: > Kumar Gala writes: > >> From: Randy Vinson <[EMAIL PROTECTED]> > >> +device_initcall(mpc85xx_cds_8259_attach); > > I don't see any platform test in mpc85xx_cds_8259_attach to make sure > it only does its stuff on suitable platforms. Looks like

Re: Which Git Tree to pull from?

2007-07-24 Thread Kumar Gala
On Jul 24, 2007, at 7:21 AM, Morrison, Tom wrote: > I am a little confused here. I’ve been working in an older (2.6.11) > > ppc release and haven’t been paying much attention to where I > > should be getting the latest / stable git tree (for powerpc). > > > > I am working on an e500/8548 branch –

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Jeff Garzik
Andreas Schwab wrote: > Jeff Garzik <[EMAIL PROTECTED]> writes: > >> Andy Whitcroft wrote: >>> Andrew Morton wrote: >>> > + start_sector = req->sector*priv->blocking_factor; > + sectors = req->nr_sectors*priv->blocking_factor; s/*/ * /. checkpatch missed this. >>> Ok, this is somethi

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andreas Schwab
Jeff Garzik <[EMAIL PROTECTED]> writes: > Andy Whitcroft wrote: >> Andrew Morton wrote: >> + start_sector = req->sector*priv->blocking_factor; + sectors = req->nr_sectors*priv->blocking_factor; >>> s/*/ * /. checkpatch missed this. >> >> Ok, this is something we need to decide on.

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Jeff Garzik
Andy Whitcroft wrote: > Andrew Morton wrote: > >>> + start_sector = req->sector*priv->blocking_factor; >>> + sectors = req->nr_sectors*priv->blocking_factor; >> s/*/ * /. checkpatch missed this. > > Ok, this is something we need to decide on. Currently we only ask for > consistent spacing o

Which Git Tree to pull from?

2007-07-24 Thread Morrison, Tom
I am a little confused here. I've been working in an older (2.6.11) ppc release and haven't been paying much attention to where I should be getting the latest / stable git tree (for powerpc). I am working on an e500/8548 branch - it looks like Kumar's Git tree looks relatively new with lo

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andy Whitcroft
Andrew Morton wrote: >> +start_sector = req->sector*priv->blocking_factor; >> +sectors = req->nr_sectors*priv->blocking_factor; > > s/*/ * /. checkpatch missed this. Ok, this is something we need to decide on. Currently we only ask for consistent spacing on all the mathematic operators

Re: [PATCH 21/25] [POWERPC] 85xxCDS: Delay 8259 cascade hookup.

2007-07-24 Thread Paul Mackerras
Kumar Gala writes: > From: Randy Vinson <[EMAIL PROTECTED]> > +device_initcall(mpc85xx_cds_8259_attach); I don't see any platform test in mpc85xx_cds_8259_attach to make sure it only does its stuff on suitable platforms. Looks like it needs one. Paul. __

2.6.23-rc1 build breaks on ppc64.

2007-07-24 Thread Srinivasa Ds
Compilation of 2.6.23-rc1 breaks on ppc64, if CONFIG_SOFTWARE_SUSPEND is not set. === CHK include/linux/version.h CHK include/linux/utsrelease.h CALLscripts/checksyscalls.sh CHK include/linux/compile.h CC arch/

RE: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-24 Thread Benjamin Herrenschmidt
On Tue, 2007-07-24 at 17:25 +0800, Zhang Wei-r63237 wrote: > Hi, Ben, > > Thanks! Please see my inline comments. > > > > > Well, you would have to look at a cell blade or pSeries machine > > device-tree, I don't have one at hand in DTS form... but basically, > > those don't have a 1:1 relations

RE: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-24 Thread Zhang Wei-r63237
Hi, Ben, Thanks! Please see my inline comments. > > Well, you would have to look at a cell blade or pSeries machine > device-tree, I don't have one at hand in DTS form... but basically, > those don't have a 1:1 relationship between hosts and nodes. Is there any problem when the relationship be

Re: [PATCH 5/6 v2] 85xxCDS: Misc 8548 PCI Corrections.

2007-07-24 Thread Arnd Bergmann
On Tuesday 24 July 2007, Zang Roy-r61911 wrote: > > From: Randy Vinson [mailto:[EMAIL PROTECTED] > > I don't think you can have 2 primary bridges. > > Why? > They belong to two separate pci domain. PCI host bridge == PCI domain A PHB canhave multiple buses, but only one PHB can be the primary on