Re: [PATCH] Power5,Power6 BSR driver

2008-06-18 Thread Sonny Rao
On Tue, Jun 17, 2008 at 05:44:43PM -0500, Sonny Rao wrote: > On Tue, Jun 17, 2008 at 05:39:52PM -0500, Nathan Lynch wrote: > > Hi, mainly a couple of coding style things, but one minor bug (I > > think). > > Ok Will fix and send out again From: Sonny Rao <[EMAIL PROTECTED]> Adds a character dri

Re: [PATCH] Power5,Power6 BSR driver

2008-06-18 Thread Sonny Rao
On Mon, Jun 16, 2008 at 01:53:44PM -0500, [EMAIL PROTECTED] wrote: > From: Sonny Rao <[EMAIL PROTECTED]> > > Adds a character driver for BSR support on IBM POWER systems including > Power5 and Power6. The BSR is an optional processor facility not currently > implemented by any other processors.

Re: [PATCH] [82xx] powerpc: Add support for mpc8247 based board MGCOGE from keymile.

2008-06-18 Thread Heiko Schocher
Hello, changes since the last patch: update the Portpin initialization. [powerpc] Added support for the MPC8247 based board MGCOGE from Keymile. Signed-off-by: Heiko Schocher <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mgcoge.dts | 174 +++ arch/powerpc/configs/mgcoge_d

Re: [PATCH] Power5,Power6 BSR driver

2008-06-18 Thread Sonny Rao
On Tue, Jun 17, 2008 at 05:39:52PM -0500, Nathan Lynch wrote: > Hi, mainly a couple of coding style things, but one minor bug (I > think). > > [EMAIL PROTECTED] wrote: > > From: Sonny Rao <[EMAIL PROTECTED]> > > > > +static int bsr_mmap(struct file *filp, struct vm_area_struct *vma) > > +{ > > +

[PATCH 0/3] ALSA fixes for non-coherent ppc32

2008-06-18 Thread Takashi Iwai
Hi, I've tried to renew the fixes of ALSA issues about non-coherent DMA memories. The last patch worked for SG-buffers somehow but would result in a problem if many pages are allocated because of dma_alloc_coherent() handling. Now, I chose a more simpler workaround: the SG-buffers are handled as

[PATCH 1/3] ppc: Add dma_mmap_coherent() for PPC32

2008-06-18 Thread Takashi Iwai
A very lazy version of dma_mmap_coherent() implementation for ppc32. Signed-off-by: Takashi Iwai <[EMAIL PROTECTED]> --- include/asm-powerpc/dma-mapping.h | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/include/asm-powerpc/dma-mapping.h b/include/asm-po

[PATCH 2/3] ALSA: Fix mapping of DMA buffers

2008-06-18 Thread Takashi Iwai
The DMA buffers allocated via dma_alloc_coherent() aren't easily mmappable for many architectures. This is a quick fix for some known archs that don't work properly with the current code. Signed-off-by: Takashi Iwai <[EMAIL PROTECTED]> --- sound/core/Kconfig |7 +++ sound/core/pcm_n

[PATCH 3/3] ALSA: Fix SG-buffer DMA with non-coherent architectures

2008-06-18 Thread Takashi Iwai
Using SG-buffers with dma_alloc_coherent() is messy for non-coherent architectures. So, simply disable SG-buffers but just allocate normal continuous buffers instead. Signed-off-by: Takashi Iwai <[EMAIL PROTECTED]> --- include/sound/memalloc.h | 19 +++ include/sound/pcm.

RE: CPM2 mii-bitbang: Allowing mdio on port pins other than port C

2008-06-18 Thread Mark Ware
Hi Laurent, > -Original Message- > From: Laurent Pinchart [mailto:[EMAIL PROTECTED] > Sent: Monday, 16 June 2008 18:53 > To: linuxppc-dev@ozlabs.org > Cc: Mark Ware > Subject: Re: CPM2 mii-bitbang: Allowing mdio on port pins > other than port C > > Hi Mark, > > On Monday 16 June 2008

Re: [PATCH 0/9] powerpc: Add kernel support for POWER7 VSX.

2008-06-18 Thread Kumar Gala
On Jun 17, 2008, at 7:47 PM, Michael Neuling wrote: The following set of patches adds Vector Scalar Extentions (VSX) support for POWER7. Includes context switch, ptrace and signals support. Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> --- This series is on top of the POWER7 cputable

[git pull] Please pull powerpc.git merge branch

2008-06-18 Thread Paul Mackerras
Linus, Please pull from the 'merge' branch of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git merge to get two more small bug-fixes for powerpc, as listed below. Thanks, Paul. arch/powerpc/kernel/head_44x.S |7 ++- arch/powerpc/mm/hash_low_64.S |4 2 files c

Re: [PATCH 1/2] fs_enet: fix checkpatch.pl problems

2008-06-18 Thread John Rigby
I agree, I'll separate the fec_t -> struct fec changes out. On Tue, Jun 17, 2008 at 11:20 PM, Grant Likely <[EMAIL PROTECTED]> wrote: > On Tue, Jun 17, 2008 at 5:03 PM, John Rigby <[EMAIL PROTECTED]> wrote: > > Fixed all errors and warnings that checkpatch.pl > > reports if this was a new submiss

Re: CPM2 mii-bitbang: Allowing mdio on port pins other than port C

2008-06-18 Thread Laurent Pinchart
Hi Mark, On Wednesday 18 June 2008 14:21, Mark Ware wrote: > Hi Laurent, > > Hi Mark, > > > > On Monday 16 June 2008 08:19, Mark Ware wrote: > > > Hello, > > > > > > I am preparing a board port (from 2.4.18!) for a proprietary board > > > which has it's mdio on a different port than mdc. The c

Re: [PATCH 2/2] fs_enet: MDIO on GPIO support

2008-06-18 Thread Laurent Pinchart
Hi Scott, On Monday 16 June 2008 18:34, Scott Wood wrote: > On Mon, Jun 16, 2008 at 10:57:02AM +0200, Laurent Pinchart wrote: > > On Monday 26 May 2008 11:53, Laurent Pinchart wrote: > > > Port the fs_enet driver to support the MDIO on GPIO driver for PHY > > > access in addition to the mii-bitban

Re: [PATCH 1/9] powerpc: Fix msr setting in 32 bit signal code

2008-06-18 Thread Kumar Gala
On Jun 17, 2008, at 7:47 PM, Michael Neuling wrote: If we set the SPE MSR bit in save_user_regs we can blow away the VEC bit. This will never happen in reality, but it looks bad. Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> --- arch/powerpc/kernel/signal_32.c | 10 ++ 1 file c

Re: [PATCH 2/2] fs_enet: MDIO on GPIO support

2008-06-18 Thread Jeff Garzik
Laurent Pinchart wrote: Hi Scott, On Monday 16 June 2008 18:34, Scott Wood wrote: On Mon, Jun 16, 2008 at 10:57:02AM +0200, Laurent Pinchart wrote: On Monday 26 May 2008 11:53, Laurent Pinchart wrote: Port the fs_enet driver to support the MDIO on GPIO driver for PHY access in addition to the

[PATCH] fs_enet: restore promiscuous and multicast settings in restart()

2008-06-18 Thread Laurent Pinchart
The restart() function is called when the link state changes and resets multicast and promiscous settings. This patch restores those settings at the end of restart(). Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> --- drivers/net/fs_enet/mac-fcc.c |3 +++ 2 files changed, 4 insertion

Re: [PATCH 1/2] fs_enet: fix checkpatch.pl problems

2008-06-18 Thread Kumar Gala
On Jun 17, 2008, at 11:12 PM, John Rigby wrote: Sorry, I thought I was doing the right thing to base the patch on Kumar's patch that removes the CONFIG_PPC_CPM_NEW_BINDING stuff. That is likely why it did not apply. It is the right thing, we just need to work out the logistics here. Je

Re: [PATCH 2/2] fs_enet: MDIO on GPIO support

2008-06-18 Thread Laurent Pinchart
On Wednesday 18 June 2008 17:00, Jeff Garzik wrote: > Laurent Pinchart wrote: > > Hi Scott, > > > > On Monday 16 June 2008 18:34, Scott Wood wrote: > >> On Mon, Jun 16, 2008 at 10:57:02AM +0200, Laurent Pinchart wrote: > >>> On Monday 26 May 2008 11:53, Laurent Pinchart wrote: > Port the fs_e

Re: [PATCH] Added support for PRTLVT based boards (MPC5121)

2008-06-18 Thread John Rigby
Hi David, Looks like your device tree is based on the beta ltib bsp. There were some changes in release 1 that you may want to incorporate: First as a convention I changed all the interrupt numbers in the tuples to be decimal. I like this better because the interrupts are decimal in the referen

Re: [PATCH] [Rev2] MPC5121 FEC support

2008-06-18 Thread Scott Wood
On Tue, Jun 17, 2008 at 04:52:25PM -0700, Trent Piepho wrote: > Why is FS_ENET_HAS_SCC a bool, and not tristate? That was an oversight on my part -- they should be tristate. -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org

Re: [PATCH 1/2] fs_enet: fix checkpatch.pl problems

2008-06-18 Thread Scott Wood
On Tue, Jun 17, 2008 at 05:03:13PM -0600, John Rigby wrote: > static int __devinit find_phy(struct device_node *np, > - struct fs_platform_info *fpi) > + struct fs_platform_info *fpi) Please don't make this sort of change. Spaces were used d

[PATCH 0/2][Rev4] Add MPC5121 FEC suppport

2008-06-18 Thread John Rigby
Changes since last patch set: This patch no longer assmues Kumar's patch that removes CONFIG_PPC_CPM_NEW_BINDING stuff. That was just confusing. No checkpatch.pl fixes. Addresses all comments to previous patch. Does not rework the Kconfig logic. More work is need than w

[PATCH 1/2][Rev4] fs_enet: change fec_t to struct fec

2008-06-18 Thread John Rigby
This is in preparation of adding support for MPC5121 FEC. The 5121 patch needs to add a different struct fec because it has a different register layout. This patch allows the 5121 patch to not include a typedef fec_t which checkpatch complains about. Signed-off-by: John Rigby <[EMAIL PROTECTED]>

Re: Question regarding mpic_assign_isu() in storcenter.c

2008-06-18 Thread Jon Loeliger
Eric Witcher wrote: The answer is that mpic_assign_isu(mpic, 1, paddr + 0x11000) places the initial base register for isu 1 on a reserved location in the PIC register map (see *). I guess you can infer from this that no badness occurs when you write to a reserved location on the PIC. See? S

[RFC] cpm2: Rework baud rate generators configuration to support external clocks.

2008-06-18 Thread Laurent Pinchart
Hi everybody, I have to configure a CPM2 baud rate generator to use an external clock in a device driver. To avoid code duplication I'd like to reorganize the CPM2 baud rate configuration functions as proposed in the attached patch. Would this be acceptable ? -- The CPM2 BRG setup functions c

Re: powerpc: Add cputable entry for POWER7

2008-06-18 Thread Joel Schopp
I'll send out some additional entries in a minute when I rebase what I have on this. I think a couple of those lines were originally authored by me so... Signed-off-by: Joel Schopp <[EMAIL PROTECTED]> Michael Neuling wrote: Add a cputable entry for the POWER7 processor. Also tell firmware

Re: [PATCH 6/9] powerpc: Add VSX CPU feature

2008-06-18 Thread Joel Schopp
A couple of these lines originated with me. Signed-off-by: Joel Schopp <[EMAIL PROTECTED]> Michael Neuling wrote: Add a VSX CPU feature. Also add code to detect if VSX is available from the device tree. Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> --- arch/powerpc/kernel/prom.c |

Re: Question regarding mpic_assign_isu() in storcenter.c

2008-06-18 Thread Kumar Gala
On Jun 18, 2008, at 11:10 AM, Jon Loeliger wrote: Eric Witcher wrote: The answer is that mpic_assign_isu(mpic, 1, paddr + 0x11000) places the initial base register for isu 1 on a reserved location in the PIC register map (see *). I guess you can infer from this that no badness occurs when

Re: [PATCHv2 1/2] [POWERPC] CPM2: Implement GPIO LIB API on CPM2 Freescale SoC.

2008-06-18 Thread Jochen Friedrich
Hi Laurent, Agreed. Jochen, will you resubmit or should I do it ? Please do as i'm currently away and won't be back until next week. Thanks, Jochen ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxp

[PATCHv3 1/2] [POWERPC] CPM2: Implement GPIO LIB API on CPM2 Freescale SoC.

2008-06-18 Thread Laurent Pinchart
Based on earlier work by Jochen Friedrich. This patch implement GPIO LIB support for the CPM2 GPIOs. Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> Cc: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/platforms/Kconfig |2 + arch/powerpc/sysdev/cpm2.c | 11 arch/powe

Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

2008-06-18 Thread Matvejchikov Ilya
I'm glad that you have corrected it. Half a year ago I pointed out that there was such a mistake: http://patchwork.ozlabs.org/linuxppc/patch?id=10700 Thanks. 2008/6/18 Laurent Pinchart <[EMAIL PROTECTED]>: > The restart() function is called when the link state changes and resets > multicast and p

Re: [PATCH 5/9] powerpc: Introduce VSX thread_struct and CONFIG_VSX

2008-06-18 Thread Kumar Gala
On Jun 17, 2008, at 7:47 PM, Michael Neuling wrote: The layout of the new VSR registers and how they overlap on top of the legacy FPR and VR registers is: VSR doubleword 0 VSR doubleword 1 --

Re: [U-Boot-Users] mpc5121 cache coherency

2008-06-18 Thread John Rigby
Unlike other SOCs with e300 cores the 5121 is not cache coherent. The problem is an internal bridge that the processor can not snoop across. On Wed, Jun 18, 2008 at 1:29 PM, Kenneth Johansson <[EMAIL PROTECTED]> wrote: > I have tried to speed up u-boot by turning on I/D cache during boot. > > It

mpc5121 cache coherency

2008-06-18 Thread Kenneth Johansson
I have tried to speed up u-boot by turning on I/D cache during boot. It sort of works and gives quite a boost but I'm having problems with the ethernet driver that no longer works. What I'm seeing is that the cpu do not notice the ethernet hardwares updates that is located in DRAM. Basically w

[PATCH 0/2] more power7 bits

2008-06-18 Thread jschopp
The patches following add some additional cputable, architecture-vec, etc bits for Power7. Specifically the bits for running in 2.06 architected mode. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-de

[PATCH 2/2][Rev4][Resend] fs_enet: add MPC5121 FEC support

2008-06-18 Thread John Rigby
Add support for MPC512x to fs_enet driver MPC5121 has an FEC core that is nearly identical to the FEC in 8xx. The only problem is that the registers locations have been shuffled. Because of this shuffling of registers, one needs a different structure to describe the 5121 FEC. This is not a huge

[PATCH 1/2] Power7 architected entry

2008-06-18 Thread jschopp
Add an entry for Power7 architected mode and add "(raw)" to Power7 raw mode to distinguish it more clearly. Signed-off-by: Joel Schopp <[EMAIL PROTECTED]> --- arch/powerpc/kernel/cputable.c | 48 + arch/powerpc/platforms/pseries/cpu_setup.S |6 +++ i

[PATCH 2/2] 2.06 architecture-vec

2008-06-18 Thread jschopp
Add the bits to the architecture-vec so that ibm,client-architecture lets the firmware know we support the 2.06 architecture. Signed-off-by: Joel Schopp <[EMAIL PROTECTED]> Index: 2.6.26-rc6/arch/powerpc/kernel/prom_init.c === --- 2.

44x defconfig directory

2008-06-18 Thread John Linn
I'm adding a new defconfig file to the new configs/44x directory and make doesn't seem to find it. I must be missing something as this seems simple. Should I have to specify 44x in the path (make ARCH=powerpc 44x/defconfig) as this does work? Thanks, John This email and any attachments are int

Re: 44x defconfig directory

2008-06-18 Thread Sean MacLennan
On Wed, 18 Jun 2008 14:36:37 -0600 "John Linn" <[EMAIL PROTECTED]> wrote: > Should I have to specify 44x in the path (make ARCH=powerpc > 44x/defconfig) as this does work? Yes. At least I have to now. Cheers, Sean ___ Linuxppc-dev mailing list Linux

Re: [PATCH 1/2] Power7 architected entry

2008-06-18 Thread Olof Johansson
On Jun 18, 2008, at 3:18 PM, [EMAIL PROTECTED] wrote: Add an entry for Power7 architected mode and add "(raw)" to Power7 raw mode to distinguish it more clearly. Signed-off-by: Joel Schopp <[EMAIL PROTECTED]> --- arch/powerpc/kernel/cputable.c | 48 +++

Re: 44x defconfig directory

2008-06-18 Thread Kumar Gala
On Jun 18, 2008, at 3:36 PM, John Linn wrote: I'm adding a new defconfig file to the new configs/44x directory and make doesn't seem to find it. I must be missing something as this seems simple. Should I have to specify 44x in the path (make ARCH=powerpc 44x/defconfig) as this does work? i

[RFC PATCH V2] Keep 3 high personality bytes across exec

2008-06-18 Thread Eric B Munson
Currently when a 32 bit process is exec'd on a powerpc 64 bit host the value in the top three bytes of the personality is clobbered. This patch adds a check in the SET_PERSONALITY macro that will carry all the values in the top three bytes across the exec. These three bytes currently carry flags

Re: [U-Boot-Users] mpc5121 cache coherency

2008-06-18 Thread kenneth johansson
On Wed, 2008-06-18 at 13:38 -0600, John Rigby wrote: > Unlike other SOCs with e300 cores the 5121 is not cache coherent. The > problem is an internal bridge that the processor can not snoop across. I do not have access to the manuals right now but I search all over an this was not something I fou

kgdb issues for ppc target

2008-06-18 Thread SEEMA pm
Hello, I have an mpc8540 target board with a BSP - linux-2.6.11. I have a host machine where I have ppc-target configured gdb obtained from gdb-6.8.tar.gz. I am able to debug userspace files by running gdbserver in target machine. Now I want to debug kernel files of my target machine. I have CONFIG

Re: [PATCH 1/2] Power7 architected entry

2008-06-18 Thread Joel Schopp
Olof Johansson wrote: On Jun 18, 2008, at 3:18 PM, [EMAIL PROTECTED] wrote: Add an entry for Power7 architected mode and add "(raw)" to Power7 raw mode to distinguish it more clearly. Signed-off-by: Joel Schopp <[EMAIL PROTECTED]> --- arch/powerpc/kernel/cputable.c | 48 ++

[patch 1/6] mm: Allow architectures to define additional protection bits

2008-06-18 Thread shaggy
This patch allows architectures to define functions to deal with additional protections bits for mmap() and mprotect(). arch_calc_vm_prot_bits() maps additonal protection bits to vm_flags arch_vm_get_page_prot() maps additional vm_flags to the vma's vm_page_prot arch_validate_prot() checks for val

[patch 0/6] Strong Access Ordering page attributes for POWER7

2008-06-18 Thread shaggy
Andrew, The first patch in this series hits architecture independent code, but the rest is contained in the powerpc subtree. Could you pick up the first patch into -mm? I can send the rest of them through the powerpc git tree. The first patch and the rest of the set are independent and can be me

[patch 4/6] powerpc: Add SAO Feature bit to the cputable

2008-06-18 Thread shaggy
This patch applies on top of the patches posted today to linuxppc-dev by Michael Neuling and Joel Schopp. Signed-off-by: Joel Schopp <[EMAIL PROTECTED]> Signed-off-by: Dave Kleikamp <[EMAIL PROTECTED]> Index: linux-2.6.26-rc5/include/asm-powerpc/cputable.h

[patch 5/6] powerpc: Add Strong Access Ordering

2008-06-18 Thread shaggy
Allow an application to enable Strong Access Ordering on specific pages of memory on Power 7 hardware. Currently, power has a weaker memory model than x86. Implementing a stronger memory model allows an emulator to more efficiently translate x86 code into power code, resulting in faster code execut

[patch 6/6] powerpc: Dont clear _PAGE_COHERENT when _PAGE_SAO is set

2008-06-18 Thread shaggy
Signed-off-by: Dave Kleikamp <[EMAIL PROTECTED]> Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- arch/powerpc/platforms/pseries/lpar.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux-2.6.26-rc5/arch/powerpc/platforms/pseries/lpar.c =

[patch 3/6] powerpc: Define flags for Strong Access Ordering

2008-06-18 Thread shaggy
This patch defines: - PROT_SAO, which is passed into mmap() and mprotect() in the prot field - VM_SAO in vma->vm_flags, and - _PAGE_SAO, the combination of WIMG bits in the pte that enables strong access ordering for the page. NOTE: There doesn't seem to be a precedent for architecture-dependent

[patch 2/6] powerpc: hash_huge_page() should get the WIMG bits from the lpte

2008-06-18 Thread shaggy
Signed-off-by: Dave Kleikamp <[EMAIL PROTECTED]> Cc: Jon Tollefson <[EMAIL PROTECTED]> Cc: Adam Litke <[EMAIL PROTECTED]> Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- arch/powerpc/mm/hugetlbpage.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Index: linux-2.6.26-rc5/arch/po

Re: [PATCH 5/9] powerpc: Introduce VSX thread_struct and CONFIG_VSX

2008-06-18 Thread Paul Mackerras
Kumar Gala writes: > Is VSX mutually exclusive with altivec/fp? is there a MSR bit for it? It's not exclusive, it's an extension of altivec/fp, and yes it has its own MSR bit to enable it. Paul. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org ht

Re: [PATCH 1/2][Rev4] fs_enet: change fec_t to struct fec

2008-06-18 Thread Stephen Rothwell
On Wed, 18 Jun 2008 09:15:53 -0600 John Rigby <[EMAIL PROTECTED]> wrote: > > This is in preparation of adding support for > MPC5121 FEC. The 5121 patch needs to add a different > struct fec because it has a different register layout. > > This patch allows the 5121 patch to not include a typedef >

Re: [PATCH 0/9] powerpc: Add kernel support for POWER7 VSX.

2008-06-18 Thread Michael Neuling
> On Jun 17, 2008, at 7:47 PM, Michael Neuling wrote: > > > The following set of patches adds Vector Scalar Extentions (VSX) > > support for POWER7. Includes context switch, ptrace and signals > > support. > > > > Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> > > --- > > This series is on

Re: [PATCH 1/9] powerpc: Fix msr setting in 32 bit signal code

2008-06-18 Thread Michael Neuling
In message <[EMAIL PROTECTED]> you wrote: > > On Jun 17, 2008, at 7:47 PM, Michael Neuling wrote: > > > If we set the SPE MSR bit in save_user_regs we can blow away the VEC > > bit. This will never happen in reality, but it looks bad. > > > > Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> >

[RFC/PATCH 0/3] sched: allow arch override of cpu power

2008-06-18 Thread Nathan Lynch
There is an "interesting" quality of POWER6 cores, which each have 2 hardware threads: assuming one thread on the core is idle, the primary thread is a little "faster" than the secondary thread. To illustrate: for cpumask in 0x1 0x2 ; do taskset $cpumask /usr/bin/time -f "%e elapsed, %U user,

[RFC/PATCH 2/3] add cpu_power to machdep_calls, override SD_SIBLING_INIT

2008-06-18 Thread Nathan Lynch
Add a cpu_power() call to machdep_calls, which will allow platforms to override the scheduler's default cpu power calculation. If the platform does not provide a cpu_power() method, the scheduler's default value is used. Copy the default SD_SIBLING_INIT to powerpc's topology.h and add the SD_ASYM

[RFC/PATCH 1/3] sched: support arch override of sched_group cpu power

2008-06-18 Thread Nathan Lynch
Add a new sched domain flag, SD_ASYM_CPU_POWER, which signifies that the architecture may override the cpu power for a cpu via a hook in init_sched_groups_power(). Add a dummy definition of arch_cpu_power() which conforms with the existing behavior. Signed-off-by: Nathan Lynch <[EMAIL PROTECTED]>

[RFC/PATCH 3/3] adjust cpu power for secondary threads on POWER6

2008-06-18 Thread Nathan Lynch
On POWER6 processors, cpu-bound programs generally perform better on the primary thread when the secondary thread is idle than they do on the secondary thread while the primary thread is idle. This difference can be observed by timing a simple shell loop: for cpumask in 0x1 0x2 ; do tasks

Re: [RFC/PATCH 3/3] adjust cpu power for secondary threads on POWER6

2008-06-18 Thread Olof Johansson
Hi, +static unsigned int pseries_cpu_power(int cpu, unsigned int default_power) +{ + struct device_node *np; + unsigned int thread, power; + + if (!cpu_has_feature(CPU_FTR_ASYM_POWER)) + return default_power; + + power = default_power; Why not just NULL

Re: [RFC/PATCH 3/3] adjust cpu power for secondary threads on POWER6

2008-06-18 Thread Olof Johansson
On Jun 18, 2008, at 9:58 PM, Olof Johansson wrote: Why not just NULL out the cpu_power function pointers on platforms that don't have the feature bit instead? (or the other way around: NULL by default, and set only on platforms that have imbalanced threads. Nevermind; bogus optimization.

Re: [PATCH 5/9] powerpc: Introduce VSX thread_struct and CONFIG_VSX

2008-06-18 Thread Kumar Gala
On Jun 18, 2008, at 5:58 PM, Paul Mackerras wrote: Kumar Gala writes: Is VSX mutually exclusive with altivec/fp? is there a MSR bit for it? It's not exclusive, it's an extension of altivec/fp, and yes it has its own MSR bit to enable it. what MSR bit does it use... I'm not seeing the co

Re: [PATCH 5/9] powerpc: Introduce VSX thread_struct and CONFIG_VSX

2008-06-18 Thread Kumar Gala
Index: linux-2.6-ozlabs/include/asm-powerpc/processor.h === --- linux-2.6-ozlabs.orig/include/asm-powerpc/processor.h +++ linux-2.6-ozlabs/include/asm-powerpc/processor.h @@ -78,6 +78,7 @@ extern long kernel_thread(int (*fn)(void /*

Re: [PATCH 5/9] powerpc: Introduce VSX thread_struct and CONFIG_VSX

2008-06-18 Thread Michael Neuling
In message <[EMAIL PROTECTED]> you wrote: > > On Jun 18, 2008, at 5:58 PM, Paul Mackerras wrote: > > > Kumar Gala writes: > > > >> Is VSX mutually exclusive with altivec/fp? is there a MSR bit for > >> it? > > > > It's not exclusive, it's an extension of altivec/fp, and yes it has > > its own

Re: [PATCH 5/9] powerpc: Introduce VSX thread_struct and CONFIG_VSX

2008-06-18 Thread Michael Neuling
In message <[EMAIL PROTECTED]> you wrote : > > > > > > Index: linux-2.6-ozlabs/include/asm-powerpc/processor.h > > === > > --- linux-2.6-ozlabs.orig/include/asm-powerpc/processor.h > > +++ linux-2.6-ozlabs/include/asm-powerpc/processor

Re: [PATCH 5/9] powerpc: Introduce VSX thread_struct and CONFIG_VSX

2008-06-18 Thread Kumar Gala
On Jun 18, 2008, at 11:35 PM, Michael Neuling wrote: In message <5AEB0769-1394-4924-803D- [EMAIL PROTECTED]> you wrote : Index: linux-2.6-ozlabs/include/asm-powerpc/processor.h === --- linux-2.6-ozlabs.orig/include/asm-powerpc/

Re: [PATCH 5/9] powerpc: Introduce VSX thread_struct and CONFIG_VSX

2008-06-18 Thread Michael Neuling
In message <[EMAIL PROTECTED]> you wrote : > > On Jun 18, 2008, at 11:35 PM, Michael Neuling wrote: > > > In message <5AEB0769-1394-4924-803D- > > [EMAIL PROTECTED]> you wrote > > : > >>> > >>> > >>> Index: linux-2.6-ozlabs/include/asm-powerpc/processor.h > >>> ==

Re: [PATCH 5/9] powerpc: Introduce VSX thread_struct and CONFIG_VSX

2008-06-18 Thread Kumar Gala
+ } fpvsr __attribute__((aligned(16))); Do we really need a union here? what would happen if you just changed the type of fpr[32] from double to vector if #CONFIG_VSX? I really dont like the union and think we can just make the storage look opaque which is the key. I doubt we every real

Re: [PATCH 5/9] powerpc: Introduce VSX thread_struct and CONFIG_VSX

2008-06-18 Thread Michael Neuling
In message <[EMAIL PROTECTED]> you wrote : > > + } fpvsr __attribute__((aligned(16))); > > Do we really need a union here? what would happen if you just > changed > the type of fpr[32] from double to vector if #CONFIG_VSX? > > I really dont like the union an

Re: [PATCH 5/9] powerpc: Introduce VSX thread_struct and CONFIG_VSX

2008-06-18 Thread Kumar Gala
On Jun 19, 2008, at 1:01 AM, Michael Neuling wrote: In message [EMAIL PROTECTED]> you wrote : + } fpvsr __attribute__((aligned(16))); Do we really need a union here? what would happen if you just changed the type of fpr[32] from double to vector if #CONFIG_VSX? I really dont like the

Re: [PATCH 1/6] Move code patching code into arch/powerpc/lib/code-patching.c

2008-06-18 Thread Kumar Gala
On May 29, 2008, at 1:20 AM, Michael Ellerman wrote: We currently have a few routines for patching code in asm/system.h, because they didn't fit anywhere else. I'd like to clean them up a little and add some more, so first move them into a dedicated C file - they don't need to be inlined.

Re: [PATCH 6/9] powerpc: Add VSX CPU feature

2008-06-18 Thread David Woodhouse
On Wed, 2008-06-18 at 10:47 +1000, Michael Neuling wrote: > {"ibm,vmx", 1, CPU_FTR_ALTIVEC, PPC_FEATURE_HAS_ALTIVEC}, > #endif /* CONFIG_ALTIVEC */ > +#ifdef CONFIG_VSX > + {"ibm,vmx", 2, CPU_FTR_VSX, PPC_FEATURE_HAS_VSX}, > +#endif /* CONFIG_VSX */ Should that be "ibm,vsx"? -- dw

Re: [PATCH 1/6] Move code patching code into arch/powerpc/lib/code-patching.c

2008-06-18 Thread Michael Ellerman
On Thu, 2008-06-19 at 01:15 -0500, Kumar Gala wrote: > On May 29, 2008, at 1:20 AM, Michael Ellerman wrote: > > > We currently have a few routines for patching code in asm/system.h, > > because > > they didn't fit anywhere else. I'd like to clean them up a little > > and add > > some more, so