[PATCH] powerpc: Fix decrementer setup on 1GHz boards

2010-01-12 Thread Stefan Roese
We noticed that recent kernels didn't boot on our 1GHz Canyonlands 460EX boards anymore. As it seems, patch 8d165db1 [powerpc: Improve decrementer accuracy] introduced this problem. The routine div_sc() overflows with shift = 32 resulting in this incorrect setup: time_init: decrementer frequency =

Re: [PATCH] 8xx: fix user space TLB walk in dcbX fixup

2010-01-12 Thread Benjamin Herrenschmidt
On Tue, 2010-01-12 at 08:07 +0100, Joakim Tjernlund wrote: > Benjamin Herrenschmidt wrote on 12/01/2010 > 03:40:45: > > > > On Fri, 2010-01-08 at 17:46 +0100, Joakim Tjernlund wrote: > > > The newly added fixup for buggy dcbX insn's has > > > a bug that always trigger a kernel TLB walk so a user

Re: [RFC,PATCH 0/7 v2] Common struct clk implementation

2010-01-12 Thread Russell King - ARM Linux
On Tue, Jan 12, 2010 at 05:58:31PM +1100, Jeremy Kerr wrote: > The first two patches are for the architecture-independent kernel code, > introducing the common clk API. The remaining patches are specific to > the ARM 'versatile' and 'realview' platforms. You're still only touching the "easy" platf

Re: [RFC,PATCH 1/7 v2] Add a common struct clk

2010-01-12 Thread Russell King - ARM Linux
On Tue, Jan 12, 2010 at 09:48:44AM +0100, Francesco VIRLINZI wrote: > Hi Jeremy > In November I already sent a proposal on > a generic linux clk framework. > On that I would suggest: > >> >> +struct clk { >> +const struct clk_operations *ops; >> >spinlock_t lock; >c

Re: [PATCH] 8xx: fix user space TLB walk in dcbX fixup

2010-01-12 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 12/01/2010 09:44:09: > > On Tue, 2010-01-12 at 08:07 +0100, Joakim Tjernlund wrote: > > Benjamin Herrenschmidt wrote on 12/01/2010 > > 03:40:45: > > > > > > On Fri, 2010-01-08 at 17:46 +0100, Joakim Tjernlund wrote: > > > > The newly added fixup for buggy dcbX ins

Re: [RFC,PATCH 1/7 v2] Add a common struct clk

2010-01-12 Thread Francesco VIRLINZI
Hi Jeremy In November I already sent a proposal on a generic linux clk framework. On that I would suggest: +struct clk { + const struct clk_operations *ops; spinlock_t lock; const char *name; int id; unsigned long rate; +}; + +struct clk_

[PATCH] qe: Update the SNUM table for MPC8569 Rev2.0

2010-01-12 Thread Liu Yu
From: Dave Liu The MPC8569 Rev2.0 has the correct SNUM table as QE Reference Manual, we must follow it. However the Rev1.0 silicon need the old SNUM table as workaround due to Rev1.0 silicon SNUM erratum. So, we support both snum table, and choose the one FDT tell us. And u-boot will fixup FDT

[PATCH] powerpc: Mark some variables in the page fault path __read_mostly

2010-01-12 Thread Anton Blanchard
Using perf to trace L1 dcache misses and dumping data addresses I found a few variables taking a lot of misses. Since they are almost never written, they should go into the __read_mostly section. Signed-off-by: Anton Blanchard --- Index: linux-cpumask/arch/powerpc/xmon/xmon.c ==

[PATCH] powerpc: Reduce footprint of irq_stat

2010-01-12 Thread Anton Blanchard
PowerPC is currently using asm-generic/hardirq.h which statically allocates an NR_CPUS irq_stat array. Switch to an arch specific implementation which uses per cpu data: On a kernel with NR_CPUS=1024, this saves quite a lot of memory: textdata bss dec hexfilename 8767

[PATCH] powerpc: Reduce footprint of xics_ipi_struct

2010-01-12 Thread Anton Blanchard
Right now we allocate a cacheline sized NR_CPUS array for xics IPI communication. Since irq_stat is now PowerPC specific and using DECLARE_PER_CPU_SHARED_ALIGNED (which should mean remote writes to this should not conflict with other per cpu data), we can put it in there. On a kernel with NR_CPUS

Re: PCI-PCI bridge scanning broken on 460EX

2010-01-12 Thread Felix Radensky
Hi Ben Benjamin Herrenschmidt wrote: On Tue, 2010-01-12 at 00:48 +0200, Felix Radensky wrote: Maybe because the bus behind root P2P bridge is bus 0, and type 1 cycles are needed for bus numbers greater than 0. That's what 460EX manual says. Well, no... the bus behind the root P2P is b

RE: PCI-PCI bridge scanning broken on 460EX

2010-01-12 Thread Stef van Os
Hello Felix, Glad to know this is working for you! I'll try to send out a patch later today. The same change should also be applied to the "ppc4xx_probe_pci_bridge" function, as it also initialises PCI without type 1 transactions. With kind regards / Met vriendelijke groet, Stef van Os Prodriv

Re: [PATCH 03/31] hvc_console: make the ops pointer const.

2010-01-12 Thread Rusty Russell
On Tue, 12 Jan 2010 12:51:46 pm Benjamin Herrenschmidt wrote: > On Tue, 2009-12-22 at 20:04 +0530, Amit Shah wrote: > > From: Rusty Russell > > > > This is nicer for modern R/O protection. And noone needs it non-const, so > > constify the callers as well. > > Rusty, do you want me to take these

Re: [PATCH]: powerpc: Fix build breakage due to incorrect location of autoconf.h

2010-01-12 Thread Joakim Tjernlund
> > Hi Anton, > > On Tue, 12 Jan 2010 13:21:51 +1100 Anton Blanchard wrote: > > > > commit ac4c2a3bbe5db5fc570b1d0ee1e474db7cb22585 (zlib: optimize inffast when > > copying direct from output) referenced include/linux/autoconf.h which > > is now called include/generated/autoconf.h. > > Even with t

Re: linux-next: origin tree build failure

2010-01-12 Thread Joakim Tjernlund
Stephen Rothwell wrote on 12/01/2010 00:58:05: > > Hi all, > > Today's linux-next build (powerpc ppc64_defconfig) failed like this: > > cc1: error: include/linux/autoconf.h: No such file or directory > > (while building the boot wrappers - lots more of the same) > > Caused by commit ac4c2a3bbe5db5

Re: [PATCH 03/13] mpc52xx: add SCLPC register bit definitions

2010-01-12 Thread Grant Likely
On Tue, Jan 12, 2010 at 12:55 AM, Roman Fietze wrote: > Hello Grant, > > On Monday 11 January 2010 20:21:22 Grant Likely wrote: > >> Unrelated whitespace change? > > My fault, as with some other white space changes. My Emacs is > configured using some older setup found in a 2.4 > Documentation/Cod

[PATCH] powerpc/4xx: Add support for type 1 pci transactions on 4xx boards

2010-01-12 Thread Stef van Os
This patch adds type 1 PCI transactions to 4xx PCI code, enabling the discovery of devices behind a PCI bridge. Signed-off-by: Stef van Os --- arch/powerpc/sysdev/ppc4xx_pci.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/sysdev/ppc4xx_pci.c b/arch/po

Re: kernel panic on MPC8323 custom board

2010-01-12 Thread Dario Presti
Scott Wood-2 wrote: > > > Turn off that mapping driver, and turn on CONFIG_MTD_PHYSMAP_OF. This > stuff was very new in 2.6.20, though, so there may be issues. I'd > upgrade if you can. > I rebuilded another kernel version 2.6.20.6 whit LTIB and u-boot 1.3.2 (I don't have the correspondi

Re: [RFC,PATCH 1/7 v2] Add a common struct clk

2010-01-12 Thread Ben Dooks
On Tue, Jan 12, 2010 at 05:58:31PM +1100, Jeremy Kerr wrote: > We currently have 21 definitions of struct clk in the ARM architecture, > each defined on a per-platform basis. This makes it difficult to define > platform- (or architecture-) independent clock sources without making > assumptions abou

Re: [PATCH 03/13] mpc52xx: add SCLPC register bit definitions

2010-01-12 Thread Grant Likely
On Tue, Jan 12, 2010 at 12:55 AM, Roman Fietze wrote: > On Monday 11 January 2010 20:21:22 Grant Likely wrote: >> Why is the list head being removed? > > Not used at all, except in initialization? > > Of course a seperate patch would have been needed. For the record, I put the list_head in when w

Re: [PATCH 02/13] powerpc/5200: LocalPlus driver: use SCLPC register structure

2010-01-12 Thread Grant Likely
On Tue, Jan 12, 2010 at 12:06 AM, Roman Fietze wrote: > Hello Grant, > > On Monday 11 January 2010 20:15:58 Grant Likely wrote: > >> No patch description?  Very few patches are sufficiently described by >> the subject line alone.  Tell me what the problem is, what the patch >> changes, and why. >

Re: [RFC,PATCH 1/7 v2] Add a common struct clk

2010-01-12 Thread Ben Dooks
On Tue, Jan 12, 2010 at 09:01:49AM +, Russell King - ARM Linux wrote: > On Tue, Jan 12, 2010 at 09:48:44AM +0100, Francesco VIRLINZI wrote: > > Hi Jeremy > > In November I already sent a proposal on > > a generic linux clk framework. > > On that I would suggest: > > > >> > >> +struct clk { > >

Re: [RFC,PATCH 1/7 v2] Add a common struct clk

2010-01-12 Thread Ben Dooks
On Tue, Jan 12, 2010 at 09:01:49AM +, Russell King - ARM Linux wrote: > On Tue, Jan 12, 2010 at 09:48:44AM +0100, Francesco VIRLINZI wrote: > > Hi Jeremy > > In November I already sent a proposal on > > a generic linux clk framework. > > On that I would suggest: > > > >> > >> +struct clk { > >

Re: [PATCH-V3] mpc8xxx_gpio: add interrupt support

2010-01-12 Thread Peter Korsgaard
> Peter Korsgaard writes: Hi, Anton, any comments on this? > Signed-off-by: Peter Korsgaard > --- > Changes since v1: > - Document OF binding for IRQ as requested by Kumar. > Changes since v2: > - Fix xlate prototype mismatch warning (intspec should be const) > .../powerpc/dts-bi

Re: [RFC,PATCH 3/7 v2] arm/versatile: use generic struct clk

2010-01-12 Thread Russell King - ARM Linux
On Tue, Jan 12, 2010 at 05:58:31PM +1100, Jeremy Kerr wrote: > diff --git a/arch/arm/common/clkdev.c b/arch/arm/common/clkdev.c > index aae5bc0..71e7596 100644 > --- a/arch/arm/common/clkdev.c > +++ b/arch/arm/common/clkdev.c > @@ -85,11 +85,13 @@ struct clk *clk_get(struct device *dev, const char

Re: kernel panic on MPC8323 custom board

2010-01-12 Thread Dario Presti
Dario Presti wrote: > > > But still hte mapping is not showed on boot, it seems to not read yet the > blob node. The boot-log is: > > Ok now mapping woks fine. The error was in .dts file, changing fl...@fc00 { device_type = "rom"; compatible = "cfi-flash

Re: [PATCH-V3] mpc8xxx_gpio: add interrupt support

2010-01-12 Thread Anton Vorontsov
On Tue, Jan 12, 2010 at 05:24:10PM +0100, Peter Korsgaard wrote: > > Peter Korsgaard writes: > > Hi, > > Anton, any comments on this? > > > Signed-off-by: Peter Korsgaard Acked-by: Anton Vorontsov Thanks! -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 ___

Re: Sleep-capable GPIO slave-selects on MPC52xx?

2010-01-12 Thread Bill Gatliff
Bill Gatliff wrote: > > It looks like the current version of the MPC52xx SPI driver won't work > with sleep-capable GPIOs for slave-selects. In particular, it looks > like mpc52xx_spi_fsmstate_transfer() is an interrupt handler that calls > mpc52xx_spi_chipsel(), which itself calls gpio_set_value(

Re: [PATCH] proc_devtree: fix THIS_MODULE without module.h

2010-01-12 Thread Alexey Dobriyan
On Mon, Jan 11, 2010 at 03:58:47PM -0700, Grant Likely wrote: > On Sat, Jan 9, 2010 at 4:01 AM, Alexey Dobriyan wrote: > > I'd say, remove .owner line. > > It definitely not needed in non-modular code. > > No. Jeremy's fix is the better one. Having the .owner line doesn't > cost anything and it

Re: [PATCH] Make cpu hotplug driver lock part of ppc_md

2010-01-12 Thread Nathan Fontenot
Benjamin Herrenschmidt wrote: The intention of the cpu_hotplug_driver_locks to add additional serialization during cpu hotplug operations. For pseries this is used during DLPAR of cpu operations so that cpu hotplug actions cannot be initiated whiloe a DLPAR operation is in flight. For example,

Re: [PATCH] powerpc/4xx: Add support for type 1 pci transactions on 4xx boards

2010-01-12 Thread Benjamin Herrenschmidt
On Tue, 2010-01-12 at 15:09 +0100, Stef van Os wrote: > This patch adds type 1 PCI transactions to 4xx PCI code, enabling the > discovery of > devices behind a PCI bridge. Your patch appears word wrapped and whitespace damaged... I'll fix it up manually this time around but please check your mail

Re: [RFC,PATCH 0/7 v2] Common struct clk implementation

2010-01-12 Thread Jeremy Kerr
Hi Russell, > But the point I was trying to convey is that OMAP doesn't work with > _either_ a pure operations struct _or_ a bunch of per-clock function > pointers - it currently uses a mixture of the two. With the common clk, you can do exactly that: struct clk_foo { /* ->ops provides f

[PATCH] zlib: Fix build of powerpc boot wrapper

2010-01-12 Thread Benjamin Herrenschmidt
Commit ac4c2a3bbe5db5fc570b1d0ee1e474db7cb22585 broke the build of all powerpc boot wrappers. It attempts to add an include of autoconf.h but used the wrong path for it. It also adds -D__KERNEL__ to our boot wrapper, both things that we pretty much didn't do on purpose so far. We want our boot wr

Re: [PATCH] of/flattree: use callback to setup initrd from /chosen

2010-01-12 Thread Grant Likely
On Tue, Dec 22, 2009 at 6:17 AM, Michael Ellerman wrote: > On Tue, 2009-12-22 at 18:54 +0800, Jeremy Kerr wrote: >> Hi Michael, >> >> > >  void early_init_dt_setup_initrd_arch(unsigned long start, >> > >                                 unsigned long end); >> > >> > arch_early_init_dt_setup_initrd(

[PATCH 1/1] powerpc/iseries: Initialise on-stack completion

2010-01-12 Thread Michael Ellerman
get_viotape_info() declares a vio_waitevent on the stack, which contains a completion, but never initialises the completion. I have no idea how this ever worked, and on recent kernels it causes an oops in handle_tape_event() when we access the non-initialised completion. Signed-off-by: Michael El

[PATCH] lmb: Add lmb_free()

2010-01-12 Thread Michael Ellerman
We can free memory allocated with lmb_alloc() by removing it from the list of reserved LMBs. Rework lmb_remove() to allow that possibility and add lmb_free() which exploits it. Signed-off-by: Michael Ellerman --- include/linux/lmb.h |1 + lib/lmb.c | 13 +++-- 2 files cha

[RFC/PATCH] powerpc: Dynamically allocate pacas

2010-01-12 Thread Michael Ellerman
On 64-bit kernels we currently have a 512 byte struct paca_struct for each cpu (usually just called "the paca"). Currently they are statically allocated, which means a kernel built for a large number of cpus will waste a lot of space if it's booted on a machine with few cpus. We can avoid that by