On 06/23/2014 10:34 PM, Benjamin Herrenschmidt wrote:
On Mon, 2014-06-23 at 22:05 -0700, Guenter Roeck wrote:
On 06/23/2014 09:35 PM, Benjamin Herrenschmidt wrote:
On Fri, 2014-06-13 at 09:38 -0700, Guenter Roeck wrote:
If compiled with W=1, the following warning is seen in powerpc builds.
On 06/23/2014 10:14 AM, Gavin Shan wrote:
The patch implements one OPAL firmware sysfs file to support PCI error
injection: /sys/firmware/opal/errinjct, which will be used like the
way described as follows.
According to PAPR spec, there are 3 RTAS calls related to error injection:
Commit e58e263 PPC, KVM, CMA: use general CMA reserved area management
framework in next-20140624 removed arch/powerpc/kvm/book3s_hv_cma.c but
neglected to update the Makefile, thus breaking the build.
Signed-off-by: Michael Ellerman m...@ellerman.id.au
---
Hi Andrew,
This is in your akpm
Is it reasonable to do error injection with CONFIG_IOMMU_API ?
That means if use default config(CONFIG_IOMMU_API = n), we can not do
error injection to pci devices?
Well we can't pass them through either so ...
In any case, this is not a priority. First we need to implement a solid
error
On Mon, 2014-06-23 at 23:01 -0700, Guenter Roeck wrote:
I thought that only happens if a const is dropped, but maybe not.
Sigh. Much easier to break something than to fix it. That would mean
to get approval
from at least three maintainers, and all that to get rid of a warning.
I don't
On 06/24/2014 02:36 PM, Benjamin Herrenschmidt wrote:
Is it reasonable to do error injection with CONFIG_IOMMU_API ?
That means if use default config(CONFIG_IOMMU_API = n), we can not do
error injection to pci devices?
Well we can't pass them through either so ...
In any case, this is not a
On Tue, 2014-06-24 at 14:57 +0800, Mike Qiu wrote:
Is that mean *host* side error injection should base on
CONFIG_IOMMU_API ? If it is just host side(no guest, no pass through),
can't we do error inject?
Maybe I misunderstand :)
Ah no, make different patches, we don't want to use IOMMU
On Tue, Jun 24, 2014 at 04:36:47PM +1000, Michael Ellerman wrote:
Commit e58e263 PPC, KVM, CMA: use general CMA reserved area management
framework in next-20140624 removed arch/powerpc/kvm/book3s_hv_cma.c but
neglected to update the Makefile, thus breaking the build.
Signed-off-by: Michael
On Tue, 2014-06-24 at 15:51 +0900, Joonsoo Kim wrote:
On Tue, Jun 24, 2014 at 04:36:47PM +1000, Michael Ellerman wrote:
Commit e58e263 PPC, KVM, CMA: use general CMA reserved area management
framework in next-20140624 removed arch/powerpc/kvm/book3s_hv_cma.c but
neglected to update
In commit 27f4488872d9 Add OPAL takeover from PowerVM we added support
for takeover on OPAL v1 machines.
This was a mode of operation where we would boot under pHyp, and query
for the presence of OPAL. If detected we would then do a special
sequence to take over the machine, and the kernel would
On Wed, Jun 18, 2014 at 01:51:44PM -0700, Andrew Morton wrote:
On Tue, 17 Jun 2014 10:25:07 +0900 Joonsoo Kim iamjoonsoo@lge.com wrote:
v2:
- Although this patchset looks very different with v1, the end result,
that is, mm/cma.c is same with v1's one. So I carry Ack to patch
Reported-and-tested-by: Mike Qiu qiud...@linux.vnet.ibm.com
Thanks
Mike
On 06/24/2014 03:17 PM, Michael Ellerman wrote:
In commit 27f4488872d9 Add OPAL takeover from PowerVM we added support
for takeover on OPAL v1 machines.
This was a mode of operation where we would boot under pHyp, and
ret is unused when CONFIG_FSL_SOC defined,
so include it with #ifndef CONFIG_FSL_SOC.
Signed-off-by: Zhao Qiang b45...@freescale.com
---
drivers/spi/spi-fsl-lib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-fsl-lib.c b/drivers/spi/spi-fsl-lib.c
index
Currently we have sys_sigpending and sys_old_getrlimit defined to use
COMPAT_SYS() in systbl.h, but then both are #defined to sys_ni_syscall
in systbl.S.
This seems to have been done when ppc and ppc64 were merged, in commit
9994a33 Introduce entry_{32,64}.S, misc_{32,64}.S, systbl.S.
AFAICS
deal with a compile warning: comparison between
'enum qe_fltr_largest_external_tbl_lookup_key_size'
and 'enum qe_fltr_tbl_lookup_key_size'
the code:
if (ug_info-largestexternallookupkeysize ==
QE_FLTR_TABLE_LOOKUP_KEY_SIZE_8_BYTES)
is warned because different enum, so modify
The commit 71ec7c55ed91 introduced the magic symbol .TOC. for ELFv2 ABI.
This symbol is built manually and has no CRC value computed. A zero value
is put in the CRC section to avoid modpost complaining about a missing CRC.
Unfortunately, this breaks the kernel module loading when the kernel is
On 06/10/2014 11:56 AM, Wei Yang wrote:
Current iommu_table of a PE is a static field. This will have a problem when
iommu_free_table is called.
What kind of problem? This table is per PE and PE is not going anywhere.
This patch allocate iommu_table dynamically.
Signed-off-by: Wei Yang
On 06/21/2014 09:12 AM, Benjamin Herrenschmidt wrote:
On Thu, 2014-06-19 at 21:21 -0600, Alex Williamson wrote:
Working on big endian being an accident may be a matter of perspective
:-)
The comment remains that this patch doesn't actually fix anything except
the overhead on big endian
Use the proper mask which is 0xefff
---
arch/powerpc/net/bpf_jit_comp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/net/bpf_jit_comp.c b/arch/powerpc/net/bpf_jit_comp.c
index 6dcdade..af0ed4d 100644
--- a/arch/powerpc/net/bpf_jit_comp.c
+++
We have to return the boolean here if the tag presents
or not, not jusr ORing the TCI with the mask which results to:
[ 709.412097] test_bpf: #18 LD_VLAN_TAG_PRESENT
[ 709.412245] ret 4096 != 1
[ 709.412332] ret 4096 != 1
[ 709.412333] FAIL (2 times)
---
arch/powerpc/net/bpf_jit_comp.c | 4
On 24.06.14 12:11, Alexey Kardashevskiy wrote:
On 06/21/2014 09:12 AM, Benjamin Herrenschmidt wrote:
On Thu, 2014-06-19 at 21:21 -0600, Alex Williamson wrote:
Working on big endian being an accident may be a matter of perspective
:-)
The comment remains that this patch doesn't actually
On 06/24/2014 08:41 PM, Alexander Graf wrote:
On 24.06.14 12:11, Alexey Kardashevskiy wrote:
On 06/21/2014 09:12 AM, Benjamin Herrenschmidt wrote:
On Thu, 2014-06-19 at 21:21 -0600, Alex Williamson wrote:
Working on big endian being an accident may be a matter of perspective
:-)
The
On 24.06.14 14:50, Alexey Kardashevskiy wrote:
On 06/24/2014 08:41 PM, Alexander Graf wrote:
On 24.06.14 12:11, Alexey Kardashevskiy wrote:
On 06/21/2014 09:12 AM, Benjamin Herrenschmidt wrote:
On Thu, 2014-06-19 at 21:21 -0600, Alex Williamson wrote:
Working on big endian being an
On 06/24/2014 10:52 PM, Alexander Graf wrote:
On 24.06.14 14:50, Alexey Kardashevskiy wrote:
On 06/24/2014 08:41 PM, Alexander Graf wrote:
On 24.06.14 12:11, Alexey Kardashevskiy wrote:
On 06/21/2014 09:12 AM, Benjamin Herrenschmidt wrote:
On Thu, 2014-06-19 at 21:21 -0600, Alex Williamson
On 24.06.14 15:01, Alexey Kardashevskiy wrote:
On 06/24/2014 10:52 PM, Alexander Graf wrote:
On 24.06.14 14:50, Alexey Kardashevskiy wrote:
On 06/24/2014 08:41 PM, Alexander Graf wrote:
On 24.06.14 12:11, Alexey Kardashevskiy wrote:
On 06/21/2014 09:12 AM, Benjamin Herrenschmidt wrote:
On
On 18.06.14 17:45, Mihai Caraman wrote:
The patch 08c9a188d0d0fc0f0c5e17d89a06bb59c493110f
kvm: powerpc: use caching attributes as per linux pte
do not handle properly the error case, letting mmu_lock locked. The lock
will further generate a RCU stall from kvmppc_e500_emul_tlbwe()
On Tue, 2014-06-24 at 15:22 +0200, Alexander Graf wrote:
On 24.06.14 15:01, Alexey Kardashevskiy wrote:
On 06/24/2014 10:52 PM, Alexander Graf wrote:
On 24.06.14 14:50, Alexey Kardashevskiy wrote:
On 06/24/2014 08:41 PM, Alexander Graf wrote:
On 24.06.14 12:11, Alexey Kardashevskiy wrote:
Hello.
On 06/24/2014 01:59 PM, Denis Kirjanov wrote:
We have to return the boolean here if the tag presents
or not, not jusr ORing the TCI with the mask which results to:
[ 709.412097] test_bpf: #18 LD_VLAN_TAG_PRESENT
[ 709.412245] ret 4096 != 1
[ 709.412332] ret 4096 != 1
[
This patch set contains fixes for the PAMU driver.
The patches are based on 3.16-rc1.
Varun Sethi (3):
Fix PAMU window size check.
Fix the device domain attach condition.
Fix the error condition during iommu group creation.
drivers/iommu/fsl_pamu.c|8
On 06/25/2014 12:21 AM, Alex Williamson wrote:
On Tue, 2014-06-24 at 15:22 +0200, Alexander Graf wrote:
On 24.06.14 15:01, Alexey Kardashevskiy wrote:
On 06/24/2014 10:52 PM, Alexander Graf wrote:
On 24.06.14 14:50, Alexey Kardashevskiy wrote:
On 06/24/2014 08:41 PM, Alexander Graf wrote:
On
From: Alexey Kardashevskiy
...
So IMHO we should either create new, generic iowrite helpers that don't
do any endian swapping at all or do iowrite32(cpu_to_le32(val)) calls.
I'm one of those people for whom iowrite32(le32_to_cpu(val)) makes sense
I do not understand why @val is
On Wed, 2014-06-25 at 00:33 +1000, Alexey Kardashevskiy wrote:
On 06/25/2014 12:21 AM, Alex Williamson wrote:
On Tue, 2014-06-24 at 15:22 +0200, Alexander Graf wrote:
On 24.06.14 15:01, Alexey Kardashevskiy wrote:
On 06/24/2014 10:52 PM, Alexander Graf wrote:
On 24.06.14 14:50, Alexey
is_power_of_2 requires an unsigned long parameter which would
lead to truncation of 64 bit values on 32 bit architectures.
__ffs also expects an unsigned long parameter thus won't work
for 64 bit values on 32 bit architectures.
Signed-off-by: Varun Sethi varun.se...@freescale.com
---
On 06/25/2014 12:43 AM, Alex Williamson wrote:
On Wed, 2014-06-25 at 00:33 +1000, Alexey Kardashevskiy wrote:
On 06/25/2014 12:21 AM, Alex Williamson wrote:
On Tue, 2014-06-24 at 15:22 +0200, Alexander Graf wrote:
On 24.06.14 15:01, Alexey Kardashevskiy wrote:
On 06/24/2014 10:52 PM,
On Mon, 2014-06-23 at 01:20 -0500, Zhao Qiang-B45475 wrote:
On Sat, 2014-06-21 at 12:19, Wood Scott wrote:
-Original Message-
From: Wood Scott-B07421
Sent: Saturday, June 21, 2014 12:19 AM
To: Zhao Qiang-B45475
Cc: linuxppc-dev@lists.ozlabs.org; linux-...@vger.kernel.org;
Earlier PTR_ERR was being returned even if group was set to null.
Now, we explicitly set an ERR_PTR value in case the group pointer is
NULL.
Signed-off-by: Varun Sethi varun.se...@freescale.com
---
drivers/iommu/fsl_pamu_domain.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
On Tue, 2014-06-24 at 15:55 +0800, Zhao Qiang wrote:
ret is unused when CONFIG_FSL_SOC defined,
so include it with #ifndef CONFIG_FSL_SOC.
Signed-off-by: Zhao Qiang b45...@freescale.com
---
drivers/spi/spi-fsl-lib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
This needs to be
On 06/23/2014 09:58 AM, Grant Likely wrote:
On Thu, 19 Jun 2014 11:33:20 +0300, Pantelis Antoniou
pantelis.anton...@konsulko.com wrote:
Hi Grant,
CCing Thomas Gleixner Steven Rostedt, since they might have a few
ideas...
On Jun 18, 2014, at 11:07 PM, Grant Likely wrote:
Hi Nathan and
On 06/23/2014 09:48 AM, Grant Likely wrote:
On Thu, 19 Jun 2014 10:26:15 -0500, Nathan Fontenot nf...@austin.ibm.com
wrote:
On 06/18/2014 03:07 PM, Grant Likely wrote:
Hi Nathan and Tyrel,
I'm looking into lifecycle issues on nodes modified by OF_DYNAMIC, and
I'm hoping you can help me.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On Tue, 2014-06-24 at 12:41 +0200, Alexander Graf wrote:
Is there actually any difference in generated code with this patch
applied and without? I would hope that iowrite..() is inlined and
cancels out the cpu_to_le..() calls that are also inlined?
No, the former uses byteswapping asm, the
On Wed, 2014-06-25 at 00:33 +1000, Alexey Kardashevskiy wrote:
I do not understand why @val is considered LE here and need to be
converted
to CPU. Really. I truly believe it should be cpu_to_le32().
No. Both are slightly wrong semantically but le32_to_cpu() is less
wrong :-)
iowrite32
[PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info
When saving the callchain on Power, the kernel conservatively saves excess
entries in the callchain. A few of these entries are needed in some cases
but not others. We should use the DWARF debug information to determine
when
On Tue, Jun 24, 2014 at 05:00:52PM +1000, Benjamin Herrenschmidt wrote:
On Tue, 2014-06-24 at 14:57 +0800, Mike Qiu wrote:
Is that mean *host* side error injection should base on
CONFIG_IOMMU_API ? If it is just host side(no guest, no pass through),
can't we do error inject?
Maybe I
On Mon, Jun 23, 2014 at 04:36:44PM +1000, Michael Neuling wrote:
On Mon, 2014-06-23 at 12:14 +1000, Gavin Shan wrote:
The patch implements one OPAL firmware sysfs file to support PCI error
injection: /sys/firmware/opal/errinjct, which will be used like the
way described as follows.
According
On Mon, 2014-06-23 at 16:11 +0200, Martijn de Gouw wrote:
From: Martijn de Gouw martijn.de.g...@prodrive.nl
Add support for mapping and unmapping of inbound rapidio windows.
Signed-off-by: Martijn de Gouw martijn.de.g...@prodrive-technologies.com
---
arch/powerpc/sysdev/fsl_rio.c | 92
Commit 143e1e28cb (sched: Rework sched_domain topology definition)
introduced a number of functions with a return value of 'const int'.
gcc doesn't know what to do with that and, if the kernel is compiled
with W=1, complains with the following warnings whenever sched.h
is included.
On Tue, Jun 24, 2014 at 08:06:32PM +1000, Alexey Kardashevskiy wrote:
On 06/10/2014 11:56 AM, Wei Yang wrote:
Current iommu_table of a PE is a static field. This will have a problem when
iommu_free_table is called.
What kind of problem? This table is per PE and PE is not going anywhere.
Yes,
Commit 59a53afe70fd530040bdc69581f03d880157f15a powerpc: Don't setup
CPUs with bad status broke ePAPR SMP booting. ePAPR says that CPUs
that aren't presently running shall have status of disabled, with
enable-method being used to determine whether the CPU can be enabled.
Fix by checking for
On Tue, 2014-06-24 at 18:05 -0700, Guenter Roeck wrote:
.../...
Drop 'const' from the function declarations to fix the problem.
The fix for all three patches has to be applied together to avoid
compilation failures for the affected architectures.
Cc: Dietmar Eggemann
ret is unused when CONFIG_FSL_SOC defined,
so include it with #ifndef CONFIG_FSL_SOC.
Signed-off-by: Zhao Qiang b45...@freescale.com
---
drivers/spi/spi-fsl-lib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-fsl-lib.c b/drivers/spi/spi-fsl-lib.c
index
From: Wood Scott-B07421
Sent: Wednesday, June 25, 2014 1:34 AM
To: Zhao Qiang-B45475
Cc: linuxppc-dev@lists.ozlabs.org; linux-...@vger.kernel.org;
w...@grandegger.com; m...@pengutronix.de
Subject: Re: [PATCH v2 1/2] flexcan: add err_irq handler for
On 06/25/2014 07:54 AM, Benjamin Herrenschmidt wrote:
On Wed, 2014-06-25 at 00:33 +1000, Alexey Kardashevskiy wrote:
I do not understand why @val is considered LE here and need to be
converted
to CPU. Really. I truly believe it should be cpu_to_le32().
No. Both are slightly wrong
On 06/25/2014 08:03 AM, Gavin Shan wrote:
On Tue, Jun 24, 2014 at 05:00:52PM +1000, Benjamin Herrenschmidt wrote:
On Tue, 2014-06-24 at 14:57 +0800, Mike Qiu wrote:
Is that mean *host* side error injection should base on
CONFIG_IOMMU_API ? If it is just host side(no guest, no pass through),
On Wed, 2014-06-25 at 11:05 +0800, Mike Qiu wrote:
Here maybe /sys/kernel/debug/powerpc/errinjct is better, because
it
will supply PCI_domain_nr in parameters, so no need supply errinjct
for each PCI domain.
Another reason is error inject not only for PCI(in future), so better
not in
Eeh sysfs entry created must be after EEH_ENABLED been set
in eeh_subsystem_flags.
In PowerNV platform, it try to create sysfs entry before
EEH_ENABLED been set, when boot up. So nothing will be
created for eeh in sysfs.
Signed-off-by: Mike Qiu qiud...@linux.vnet.ibm.com
---
In commit 752a6422f, new stack frame is created for parameters.
However, the r1 is added back a little earlier, so r3 and r4 are
restored from a wrong place, which could cause following error during
boot:
Querying for OPAL presence... there !
DEFAULT CATCH!, exception-handler=fff00700
at
Hi Zhong,
I really need this patch :)
BTW, it seems that this bug just happens in 3.16-rc1 as I reported.
Thanks
Mike
On 06/25/2014 12:00 PM, Li Zhong wrote:
In commit 752a6422f, new stack frame is created for parameters.
However, the r1 is added back a little earlier, so r3 and r4 are
On 06/25/2014 11:12 AM, Wei Yang wrote:
On Tue, Jun 24, 2014 at 08:06:32PM +1000, Alexey Kardashevskiy wrote:
On 06/10/2014 11:56 AM, Wei Yang wrote:
Current iommu_table of a PE is a static field. This will have a problem when
iommu_free_table is called.
What kind of problem? This table is
On Wed, 2014-06-25 at 12:00 +0800, Li Zhong wrote:
In commit 752a6422f, new stack frame is created for parameters.
However, the r1 is added back a little earlier, so r3 and r4 are
restored from a wrong place, which could cause following error during
boot:
Thanks ! However I've decided to
DaYu just reminded me that Michael already had a patch removing all the
related code.
Please ignore this patch..
Thanks, Zhong
On Wed, 2014-06-25 at 12:00 +0800, Li Zhong wrote:
In commit 752a6422f, new stack frame is created for parameters.
However, the r1 is added back a little earlier,
On Wed, 2014-06-25 at 12:20 +0800, Li Zhong wrote:
DaYu just reminded me that Michael already had a patch removing all the
related code.
Please ignore this patch..
Thanks for tracking down what the actual problem was.
cheers
___
Linuxppc-dev
This patch changes the name of a make variable (TARGETS) to prevent it
from colliding with a value set by the user on the command line (as
they are recommended to do by tools/testing/selftests/README.txt).
Before this patch, make -C tools/testing/selftests TARGETS=powerpc
would fail.
On Wed, Jun 25, 2014 at 02:12:34PM +1000, Alexey Kardashevskiy wrote:
On 06/25/2014 11:12 AM, Wei Yang wrote:
On Tue, Jun 24, 2014 at 08:06:32PM +1000, Alexey Kardashevskiy wrote:
On 06/10/2014 11:56 AM, Wei Yang wrote:
Current iommu_table of a PE is a static field. This will have a problem
On Tue, Jun 24, 2014 at 11:32:07PM -0400, Mike Qiu wrote:
[ cc Richard ]
Eeh sysfs entry created must be after EEH_ENABLED been set
in eeh_subsystem_flags.
In PowerNV platform, it try to create sysfs entry before
EEH_ENABLED been set, when boot up. So nothing will be
created for eeh in sysfs.
65 matches
Mail list logo
