Re: [PATCH 1/2 v5] powerpc/kvm: support to handle sw breakpoint

2014-09-09 Thread Madhavan Srinivasan
On Monday 08 September 2014 06:35 PM, Alexander Graf wrote: On 07.09.14 18:31, Madhavan Srinivasan wrote: This patch adds kernel side support for software breakpoint. Design is that, by using an illegal instruction, we trap to hypervisor via Emulation Assistance interrupt, where we check

Re: [PATCH 2/2 v5] powerpc/kvm: common sw breakpoint instr across ppc

2014-09-09 Thread Madhavan Srinivasan
On Monday 08 September 2014 06:39 PM, Alexander Graf wrote: On 07.09.14 18:31, Madhavan Srinivasan wrote: This patch extends the use of illegal instruction as software breakpoint instruction across the ppc platform. Patch extends booke program interrupt code to support software breakpoint.

Re: bit fields data tearing

2014-09-09 Thread Arnd Bergmann
On Monday 08 September 2014 19:27:14 H. Peter Anvin wrote: On 09/08/2014 03:43 PM, James Bottomley wrote: This was years ago (possibly decades). We had to implement in-kernel unaligned traps for the networking layer because it could access short and int fields that weren't of the

[PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Shengjiu Wang
Move the ipg clock enable and disable operation to startup and shutdown, that is only enable ipg clock when ssi is working. we don't need to enable ipg clock in probe. Another register accessing need the ipg clock, so use devm_regmap_init_mmio_clk instead of devm_regmap_init_mmio. Signed-off-by:

[PATCH v2 0/3] sched: Always check the integrity of the canary

2014-09-09 Thread Aaron Tomlin
Resending with v2 added to each subject line: Currently in the event of a stack overrun a call to schedule() does not check for this type of corruption. This corruption is often silent and can go unnoticed. However once the corrupted region is examined at a later stage, the outcome is undefined

[PATCH v2 3/3] sched: BUG when stack end location is over written

2014-09-09 Thread Aaron Tomlin
Currently in the event of a stack overrun a call to schedule() does not check for this type of corruption. This corruption is often silent and can go unnoticed. However once the corrupted region is examined at a later stage, the outcome is undefined and often results in a sporadic page fault which

[PATCH v2 1/3] init/main.c: Give init_task a canary

2014-09-09 Thread Aaron Tomlin
Tasks get their end of stack set to STACK_END_MAGIC with the aim to catch stack overruns. Currently this feature does not apply to init_task. This patch removes this restriction. Note that a similar patch was posted by Prarit Bhargava [1] some time ago but was never merged. [1]:

[PATCH v2 2/3] sched: Add helper for task stack page overrun checking

2014-09-09 Thread Aaron Tomlin
This facility is used in a few places so let's introduce a helper function to improve code readability. Signed-off-by: Aaron Tomlin atom...@redhat.com --- arch/powerpc/mm/fault.c| 4 +--- arch/x86/mm/fault.c| 4 +--- include/linux/sched.h | 2 ++ kernel/trace/trace_stack.c | 2

RE: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread li.xi...@freescale.com
Hi, Subject: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module Move the ipg clock enable and disable operation to startup and shutdown, that is only enable ipg clock when ssi is working. we don't need to enable ipg clock in probe. Another register accessing need the ipg

Re: bit fields data tearing

2014-09-09 Thread Peter Hurley
On 09/08/2014 10:56 PM, James Bottomley wrote: On Mon, 2014-09-08 at 19:30 -0400, Peter Hurley wrote: On 09/08/2014 01:50 AM, James Bottomley wrote: But additionally, even if gcc combines adjacent writes _that are part of the program flow_ then I believe the situation is no worse than would

RE: [PATCH v2] QE: move qe code from arch/powerpc to drivers/soc

2014-09-09 Thread qiang.z...@freescale.com
On Fri, 2014-09-05 at 06:47 AM, Wood Scott wrote: Subject: Re: [PATCH v2] QE: move qe code from arch/powerpc to drivers/soc On Thu, 2014-09-04 at 13:06 +0800, Zhao Qiang wrote: LS1 is arm cpu and it has qe ip block. move qe code from platform directory to public directory. QE is an

Re: bit fields data tearing

2014-09-09 Thread Peter Hurley
On 09/08/2014 06:47 PM, Peter Hurley wrote: On 09/08/2014 01:59 PM, H. Peter Anvin wrote: On 09/08/2014 10:52 AM, One Thousand Gnomes wrote: On Fri, 05 Sep 2014 08:41:52 -0700 H. Peter Anvin h...@zytor.com wrote: On 09/05/2014 08:31 AM, Peter Hurley wrote: Which is a bit ironic because I

Re: bit fields data tearing

2014-09-09 Thread Peter Hurley
On 09/08/2014 03:17 PM, One Thousand Gnomes wrote: I think the whole removing Alpha EV5 support is basically bonkers. Just use set_bit in the tty layer. Alpha will continue to work as well as it always has done and you won't design out support for any future processor that turns out not to do

[PATCH] powerpc/iommu/ddw: Fix endianness

2014-09-09 Thread Alexey Kardashevskiy
rtas_call() accepts and returns values in CPU endianness. of_read_number() accepts big-endian values but create.addr_hi/lo returned by rtas_call() are in CPU endiannes. The dynamic_dma_window_prop struct defines all members as BE so let's make it true. struct dynamic_dma_window_prop {

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Mark Brown
On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: + if (ssi_private-soc-imx) + clk_prepare_enable(ssi_private-clk); + We're ignoring the error code here. - ssi_private-clk = devm_clk_get(pdev-dev, NULL); + ssi_private-clk = devm_clk_get(pdev-dev, ipg);

Re: [alsa-devel] [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Markus Pargmann
Hi, On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: Move the ipg clock enable and disable operation to startup and shutdown, that is only enable ipg clock when ssi is working. we don't need to enable ipg clock in probe. Another register accessing need the ipg clock, so use

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Timur Tabi
Shengjiu Wang wrote: + if (ssi_private-soc-imx) + clk_prepare_enable(ssi_private-clk); How about this instead? if (ssi_private-clk) clk_prepare_enable(ssi_private-clk); ___ Linuxppc-dev mailing list

Re: [PATCH / RFC] PowerPC: boot: Parse chosen/cmdline-timeout parameter

2014-09-09 Thread Grant Likely
On Tue, Sep 9, 2014 at 3:01 PM, Simon Kågström simon.kagst...@netinsight.net wrote: A 5 second timeout during boot might be too long, so make it configurable. The property is added to the chosen node, e.g., chosen { bootargs = console=ttyUL0 root=/dev/ram0;

[PATCH / RFC] PowerPC: boot: Parse chosen/cmdline-timeout parameter

2014-09-09 Thread Simon Kågström
A 5 second timeout during boot might be too long, so make it configurable. The property is added to the chosen node, e.g., chosen { bootargs = console=ttyUL0 root=/dev/ram0; linux,stdout-path = /plb@0/serial@4600; cmdline-timeout = 100;

[PATCH v2] PowerPC: boot: Parse chosen/cmdline-timeout parameter

2014-09-09 Thread Simon Kågström
A 5 second timeout during boot might be too long, so make it configurable. Run the loop at least once to let the user stop the boot by holding a key pressed. The property is added to the chosen node, e.g., chosen { bootargs = console=ttyUL0 root=/dev/ram0;

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Mark Brown
On Tue, Sep 09, 2014 at 08:17:51AM -0500, Timur Tabi wrote: Shengjiu Wang wrote: +if (ssi_private-soc-imx) +clk_prepare_enable(ssi_private-clk); How about this instead? if (ssi_private-clk) clk_prepare_enable(ssi_private-clk); Should be a !IS_ERR() - NULL is a valid

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Timur Tabi
On 09/09/2014 10:21 AM, Mark Brown wrote: if (ssi_private-clk) clk_prepare_enable(ssi_private-clk); Should be a !IS_ERR() - NULL is a valid clock. In that case, ssi_private-clk needs to be initialized to -EINVAL or something, so that the check works on systems that don't have any

Re: [PATCH v2 3/5] ARM: mvebu: Change vendor prefix for Intersil Corporation to isil

2014-09-09 Thread Jason Cooper
On Mon, Sep 08, 2014 at 11:19:18AM +0200, Philipp Zabel wrote: Currently there is a wild mixture of isl, isil, and intersil compatibles in the kernel. At this point, changing the vendor symbol to the most often used variant, which is equal to the NASDAQ symbol, isil, should not hurt.

[PATCH 1/2 v6] powerpc/kvm: support to handle sw breakpoint

2014-09-09 Thread Madhavan Srinivasan
This patch adds kernel side support for software breakpoint. Design is that, by using an illegal instruction, we trap to hypervisor via Emulation Assistance interrupt, where we check for the illegal instruction and accordingly we return to Host or Guest. Patch also adds support for software

[PATCH 0/2 v6] powerpc/kvm: support to handle sw breakpoint

2014-09-09 Thread Madhavan Srinivasan
This patchset adds ppc64 server side support for software breakpoint and extends the use of illegal instruction as software breakpoint across ppc platform. Patch 1, adds kernel side support for software breakpoint. Design is that, by using an illegal instruction, we trap to hypervisor via

[PATCH 2/2 v6] powerpc/kvm: common sw breakpoint instr across ppc

2014-09-09 Thread Madhavan Srinivasan
This patch extends the use of illegal instruction as software breakpoint instruction across the ppc platform. Patch extends booke program interrupt code to support software breakpoint. Signed-off-by: Madhavan Srinivasan ma...@linux.vnet.ibm.com --- Patch is only compile tested. Will really help

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Nicolin Chen
On Tue, Sep 09, 2014 at 12:27:50PM +0100, Mark Brown wrote: On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: - ssi_private-clk = devm_clk_get(pdev-dev, NULL); + ssi_private-clk = devm_clk_get(pdev-dev, ipg); if (IS_ERR(ssi_private-clk)) { ret =

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Mark Brown
On Tue, Sep 09, 2014 at 11:03:10AM -0700, Nicolin Chen wrote: On Tue, Sep 09, 2014 at 12:27:50PM +0100, Mark Brown wrote: On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: - ssi_private-clk = devm_clk_get(pdev-dev, NULL); + ssi_private-clk = devm_clk_get(pdev-dev, ipg);

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Nicolin Chen
On Tue, Sep 09, 2014 at 07:15:16PM +0100, Mark Brown wrote: On Tue, Sep 09, 2014 at 11:03:10AM -0700, Nicolin Chen wrote: On Tue, Sep 09, 2014 at 12:27:50PM +0100, Mark Brown wrote: On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: - ssi_private-clk =

[PATCH 0/3] Improve slab consumption with memoryless nodes

2014-09-09 Thread Nishanth Aravamudan
Anton noticed (http://www.spinics.net/lists/linux-mm/msg67489.html) that on ppc LPARs with memoryless nodes, a large amount of memory was consumed by slabs and was marked unreclaimable. He tracked it down to slab deactivations in the SLUB core when we allocate remotely, leading to poor efficiency

[PATCH v3] topology: add support for node_to_mem_node() to determine the fallback node

2014-09-09 Thread Nishanth Aravamudan
From: Joonsoo Kim iamjoonsoo@lge.com We need to determine the fallback node in slub allocator if the allocation target node is memoryless node. Without it, the SLUB wrongly select the node which has no memory and can't use a partial slab, because of node mismatch. Introduced function,

[PATCH 2/3] slub: fallback to node_to_mem_node() node if allocating on memoryless node

2014-09-09 Thread Nishanth Aravamudan
From: Joonsoo Kim iamjoonsoo@lge.com Update the SLUB code to search for partial slabs on the nearest node with memory in the presence of memoryless nodes. Additionally, do not consider it to be an ALLOC_NODE_MISMATCH (and deactivate the slab) when a memoryless-node specified allocation goes

[PATCH 3/3] Partial revert of 81c98869faa5 (kthread: ensure locality of task_struct allocations)

2014-09-09 Thread Nishanth Aravamudan
After discussions with Tejun, we don't want to spread the use of cpu_to_mem() (and thus knowledge of allocators/NUMA topology details) into callers, but would rather ensure the callees correctly handle memoryless nodes. With the previous patches (topology: add support for node_to_mem_node() to

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Timur Tabi
On 09/09/2014 01:38 PM, Nicolin Chen wrote: make sure to have the call for imx only because it seems that the other platforms do not depend on the clock. Although I doubt anyone will every add support for clocks to PowerPC side of this driver, I would prefer to avoid IMX-specific changes.

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Nicolin Chen
On Tue, Sep 09, 2014 at 02:37:42PM -0500, Timur Tabi wrote: On 09/09/2014 01:38 PM, Nicolin Chen wrote: make sure to have the call for imx only because it seems that the other platforms do not depend on the clock. Although I doubt anyone will every add support for clocks to PowerPC side of

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Timur Tabi
On 09/09/2014 02:59 PM, Nicolin Chen wrote: + /* +* Initially mark the clock to NULL for all platforms so that later +* clk_prepare_enable() will ignore and return 0 for non-clock cases. +*/ + ssi_private-clk = NULL; According to Mark, NULL is a valid clock,

[RFC PATCH] powerpc/numa: add ability to disable and debug topology updates

2014-09-09 Thread Nishanth Aravamudan
We have hit a few customer issues with the topology update code (VPHN and PRRN). It would be nice to be able to debug the notifications coming from the hypervisor in both cases to the LPAR, as well as to disable reacting to the notifications, to narrow down the source of the problems. Add a basic

Re: [PATCH V7 04/17] PCI: Take additional IOV BAR alignment in sizing and assigning

2014-09-09 Thread Bjorn Helgaas
On Wed, Aug 20, 2014 at 12:14 AM, Wei Yang weiy...@linux.vnet.ibm.com wrote: On Tue, Aug 19, 2014 at 09:08:41PM -0600, Bjorn Helgaas wrote: On Thu, Jul 24, 2014 at 02:22:14PM +0800, Wei Yang wrote: At resource sizing/assigning stage, resources are divided into two lists, requested list and

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Nicolin Chen
On Tue, Sep 09, 2014 at 03:03:53PM -0500, Timur Tabi wrote: On 09/09/2014 02:59 PM, Nicolin Chen wrote: +/* + * Initially mark the clock to NULL for all platforms so that later + * clk_prepare_enable() will ignore and return 0 for non-clock cases. + */ +ssi_private-clk =

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Timur Tabi
On 09/09/2014 03:27 PM, Nicolin Chen wrote: I guess Mark's comment is merely against the check for clk validation because if talking about clk validation, we should check IS_ERR(clk) rather than check !=NULL directly. Ah, that makes sense now. However, my approach doesn't need any check. The

Re: [PATCH 1/2 v6] powerpc/kvm: support to handle sw breakpoint

2014-09-09 Thread Alexander Graf
On 09.09.14 19:07, Madhavan Srinivasan wrote: This patch adds kernel side support for software breakpoint. Design is that, by using an illegal instruction, we trap to hypervisor via Emulation Assistance interrupt, where we check for the illegal instruction and accordingly we return to Host

Re: [PATCH 0/2 v6] powerpc/kvm: support to handle sw breakpoint

2014-09-09 Thread Alexander Graf
On 09.09.14 19:07, Madhavan Srinivasan wrote: This patchset adds ppc64 server side support for software breakpoint and extends the use of illegal instruction as software breakpoint across ppc platform. Patch 1, adds kernel side support for software breakpoint. Design is that, by using an

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Nicolin Chen
On Tue, Sep 09, 2014 at 03:37:26PM -0500, Timur Tabi wrote: However, my approach doesn't need any check. The open() or pm_resume() can just call clk_prepare_enable() directly. The __clk_enable() will then handle the 'clk == NULL' case: Yes, I was thinking the same thing. Because that's

Re: [PATCH v3] topology: add support for node_to_mem_node() to determine the fallback node

2014-09-09 Thread Andrew Morton
On Tue, 9 Sep 2014 12:03:27 -0700 Nishanth Aravamudan n...@linux.vnet.ibm.com wrote: From: Joonsoo Kim iamjoonsoo@lge.com We need to determine the fallback node in slub allocator if the allocation target node is memoryless node. Without it, the SLUB wrongly select the node which has no

Re: [PATCH 2/3] slub: fallback to node_to_mem_node() node if allocating on memoryless node

2014-09-09 Thread Andrew Morton
On Tue, 9 Sep 2014 12:05:14 -0700 Nishanth Aravamudan n...@linux.vnet.ibm.com wrote: From: Joonsoo Kim iamjoonsoo@lge.com Update the SLUB code to search for partial slabs on the nearest node with memory in the presence of memoryless nodes. Additionally, do not consider it to be an

Re: [PATCH v3] topology: add support for node_to_mem_node() to determine the fallback node

2014-09-09 Thread Nishanth Aravamudan
On 09.09.2014 [17:11:15 -0700], Andrew Morton wrote: On Tue, 9 Sep 2014 12:03:27 -0700 Nishanth Aravamudan n...@linux.vnet.ibm.com wrote: From: Joonsoo Kim iamjoonsoo@lge.com We need to determine the fallback node in slub allocator if the allocation target node is memoryless

Re: [PATCH 2/3] slub: fallback to node_to_mem_node() node if allocating on memoryless node

2014-09-09 Thread Nishanth Aravamudan
On 09.09.2014 [17:11:25 -0700], Andrew Morton wrote: On Tue, 9 Sep 2014 12:05:14 -0700 Nishanth Aravamudan n...@linux.vnet.ibm.com wrote: From: Joonsoo Kim iamjoonsoo@lge.com Update the SLUB code to search for partial slabs on the nearest node with memory in the presence of

Re: [PATCH v2] QE: move qe code from arch/powerpc to drivers/soc

2014-09-09 Thread Scott Wood
On Tue, 2014-09-09 at 04:27 -0500, Zhao Qiang-B45475 wrote: On Fri, 2014-09-05 at 06:47 AM, Wood Scott wrote: Subject: Re: [PATCH v2] QE: move qe code from arch/powerpc to drivers/soc On Thu, 2014-09-04 at 13:06 +0800, Zhao Qiang wrote: LS1 is arm cpu and it has qe ip block.

Re: [PATCH] powerpc/eeh: fix crashing when passing VF

2014-09-09 Thread Wei Yang
Hi, Ben Sounds this is not merged in the mainline yet. Would you like me sending a new version with those fix? Or you don't like this? On Wed, Aug 20, 2014 at 12:07:35PM +1000, Gavin Shan wrote: On Tue, Aug 19, 2014 at 10:27:09AM +0800, Wei Yang wrote: The subject would be powerpc/eeh: Fix

Re: [PATCH V7 04/17] PCI: Take additional IOV BAR alignment in sizing and assigning

2014-09-09 Thread Wei Yang
On Tue, Sep 09, 2014 at 02:09:46PM -0600, Bjorn Helgaas wrote: On Wed, Aug 20, 2014 at 12:14 AM, Wei Yang weiy...@linux.vnet.ibm.com wrote: On Tue, Aug 19, 2014 at 09:08:41PM -0600, Bjorn Helgaas wrote: On Thu, Jul 24, 2014 at 02:22:14PM +0800, Wei Yang wrote: At resource sizing/assigning stage,

RE: [PATCH v2] QE: move qe code from arch/powerpc to drivers/soc

2014-09-09 Thread qiang.z...@freescale.com
On Wed, 2014-09-10 at 07:27 -0500, Wood Scott-B07421 wrote: -Original Message- From: Wood Scott-B07421 Sent: Wednesday, September 10, 2014 7:27 AM To: Zhao Qiang-B45475 Cc: Li Yang-Leo-R58472; linuxppc-dev@lists.ozlabs.org; Xie Xiaobo-R63061; linux-ker...@vger.kernel.org Subject:

Re: [PATCH] powerpc: dts: t208x: Change T208x USB controller version

2014-09-09 Thread Scott Wood
On Tue, 2014-09-09 at 23:45 -0500, Badola Nikhil-B46172 wrote: -Original Message- From: Wood Scott-B07421 Sent: Friday, August 22, 2014 4:07 AM To: Badola Nikhil-B46172 Cc: linuxppc-dev@lists.ozlabs.org; devicet...@vger.kernel.org Subject: Re: [PATCH] powerpc: dts: t208x: Change

RE: [PATCH] powerpc: dts: t208x: Change T208x USB controller version

2014-09-09 Thread nikhil.bad...@freescale.com
-Original Message- From: Wood Scott-B07421 Sent: Friday, August 22, 2014 4:07 AM To: Badola Nikhil-B46172 Cc: linuxppc-dev@lists.ozlabs.org; devicet...@vger.kernel.org Subject: Re: [PATCH] powerpc: dts: t208x: Change T208x USB controller version On Thu, 2014-08-21 at 16:01 +0530, Nikhil

[PATCH] rtc/tpo: Driver to support rtc and wakeup on PowerNV platform

2014-09-09 Thread Neelesh Gupta
The patch implements the OPAL rtc driver that binds with the rtc driver subsystem. The driver uses the platform device infrastructure to probe the rtc device and register it to rtc class framework. The 'wakeup' is supported depending upon the property 'has-tpo' present in the OF node. It provides