Re: [PATCH v6 40/53] PCI: Unify skip_ioresource_align()

On Wed, 30 Sep 2015, Yinghai Lu wrote: > There are powerpc generic version and x86 local version for > skip_ioresource_align(). > > Move the powerpc version to setup-bus.c, and kill x86 local version. > > Also kill dummy version in microblaze. > > Cc: Michal Simek > Cc: Paul

[PATCH 3/3] gianfar: Add WAKE_UCAST and "wake-on-filer" support

This enables eTSEC's filer (Rx parser) and the FGPI Rx interrupt (Filer General Purpose Interrupt) as a wakeup source event. Upon entering suspend state, the eTSEC filer is given a rule to match incoming L2 unicast packets. A packet matching the rule will be enqueued in the Rx ring and a FGPI Rx

Re: [RFC v2 4/7] powerpc: atomic: Implement xchg_* and atomic{,64}_xchg_* variants

On Wed, Sep 16, 2015 at 11:49:32PM +0800, Boqun Feng wrote: > Implement xchg_relaxed and define atomic{,64}_xchg_* as xchg_relaxed, > based on these _relaxed variants, release/acquire variants can be built. > > Note that xchg_relaxed and atomic_{,64}_xchg_relaxed are not compiler > barriers.

Re: [RFC v2 6/7] powerpc: atomic: Make atomic{,64}_xchg and xchg a full barrier

On Wed, Sep 16, 2015 at 11:49:34PM +0800, Boqun Feng wrote: > According to memory-barriers.txt, xchg and its atomic{,64}_ versions > need to imply a full barrier, however they are now just RELEASE+ACQUIRE, > which is not a full barrier. > > So remove the definition of xchg(), and let

Re: [RFC v2 5/7] powerpc: atomic: Implement cmpxchg{,64}_* and atomic{,64}_cmpxchg_* variants

On Thu, Oct 01, 2015 at 02:27:15PM +0200, Peter Zijlstra wrote: > On Wed, Sep 16, 2015 at 11:49:33PM +0800, Boqun Feng wrote: > > Unlike other atomic operation variants, cmpxchg{,64}_acquire and > > atomic{,64}_cmpxchg_acquire don't have acquire semantics if the cmp part > > fails, so we need to

[PATCH 2/3] powerpc: dts: p1022si: Add fsl,wake-on-filer for eTSEC

Enable the "wake-on-filer" (aka. wake on user defined packet) wake on lan capability for the eTSEC ethernet nodes. Cc: Li Yang Cc: Zhao Chenhui Signed-off-by: Claudiu Manoil ---

[PATCH 1/3] doc: dt: net: Add fsl,wake-on-filer for eTSEC

Add the "fsl,wake-on-filer" property for eTSEC nodes to indicate that the system has the power management infrastructure needed to be able to wake up the system via FGPI (filer, aka. h/w rx parser) interrupt. Cc: Li Yang Cc: Zhao Chenhui

Re: [RFC v2 5/7] powerpc: atomic: Implement cmpxchg{,64}_* and atomic{,64}_cmpxchg_* variants

On Wed, Sep 16, 2015 at 11:49:33PM +0800, Boqun Feng wrote: > Unlike other atomic operation variants, cmpxchg{,64}_acquire and > atomic{,64}_cmpxchg_acquire don't have acquire semantics if the cmp part > fails, so we need to implement these using assembly. I think that is actually expected and

Re: [RFC v2 5/7] powerpc: atomic: Implement cmpxchg{,64}_* and atomic{,64}_cmpxchg_* variants

On Thu, Oct 01, 2015 at 02:36:26PM +0200, Peter Zijlstra wrote: > On Thu, Oct 01, 2015 at 02:27:15PM +0200, Peter Zijlstra wrote: > > On Wed, Sep 16, 2015 at 11:49:33PM +0800, Boqun Feng wrote: > > > Unlike other atomic operation variants, cmpxchg{,64}_acquire and > > > atomic{,64}_cmpxchg_acquire

Re: [PATCH V2 19/31] powerpc/mm: Convert 4k hash insert to C

On 10/01/2015 01:48 AM, Benjamin Herrenschmidt wrote: > On Wed, 2015-09-30 at 17:37 +0530, Anshuman Khandual wrote: >>> + if (unlikely(old_pte & _PAGE_BUSY)) >>> + return 0; >>> + /* If PTE permissions don't match, take page fault */ >> >> We are already

Re: [PATCH v4 17/32] cxlflash: Remove dual port online dependency

> On Sep 30, 2015, at 6:50 PM, Daniel Axtens wrote: > (resending to the list this time, apologies!) > >>> I'm not sure I fully understand the flow of this function, but it looks >>> like you set rc=0 regardless of how things actually go: is this ever >>> going to print a return

Re: [RFC v2 4/7] powerpc: atomic: Implement xchg_* and atomic{,64}_xchg_* variants

On Thu, Oct 01, 2015 at 02:24:40PM +0200, Peter Zijlstra wrote: > On Wed, Sep 16, 2015 at 11:49:32PM +0800, Boqun Feng wrote: > > Implement xchg_relaxed and define atomic{,64}_xchg_* as xchg_relaxed, > > based on these _relaxed variants, release/acquire variants can be built. > > > > Note that

Re: [RFC v2 5/7] powerpc: atomic: Implement cmpxchg{,64}_* and atomic{,64}_cmpxchg_* variants

On Thu, Oct 01, 2015 at 02:36:26PM +0200, Peter Zijlstra wrote: > On Thu, Oct 01, 2015 at 02:27:15PM +0200, Peter Zijlstra wrote: > > On Wed, Sep 16, 2015 at 11:49:33PM +0800, Boqun Feng wrote: > > > Unlike other atomic operation variants, cmpxchg{,64}_acquire and > > > atomic{,64}_cmpxchg_acquire

[PATCH v5 32/34] cxlflash: Fix to avoid potential deadlock on EEH

Ioctl threads that use scsi_execute() can run for an excessive amount of time due to the fact that they have lengthy timeouts and retry logic built in. Under normal operation this is not an issue. However, once EEH enters the picture, a long execution time coupled with the possibility that a

[PATCH v5 34/34] cxlflash: Fix to escalate to LINK_RESET on login timeout

From: Manoj Kumar A 'login timed out' asynchronous error interrupt is generated if no response is seen to a FLOGI within 2 seconds. If the time out error is not escalated to a LINK_RESET the port will not be available for use. This fix provides the required escalation.

[PATCH v5 07/34] cxlflash: Fix context encode mask width

The context encode mask covers more than 32-bits, making it a long integer. This should be noted by appending the ULL width suffix to the mask. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King

[PATCH v5 14/34] cxlflash: Fix location of setting resid

The resid is incorrectly set which can lead to unnecessary retry attempts by the stack. This is due to resid _always_ being set using a value returned from the adapter. Instead, the value should only be interpreted and set when in an underrun scenario. Signed-off-by: Matthew R. Ochs

[PATCH v5 13/34] cxlflash: Fix to avoid stall while waiting on TMF

Borrowing the TMF waitq's spinlock causes a stall condition when waiting for the TMF to complete. To remedy, introduce our own spin lock to serialize TMF and use the appropriate wait services. Also add a timeout while waiting for a TMF completion. When a TMF times out, report back a failure such

[PATCH v5 19/34] cxlflash: Correct usage of scsi_host_put()

Currently, scsi_host_put() is being called prematurely in the remove path and is missing entirely in an error cleanup path. The former can lead to memory being freed too early with subsequent access potentially corrupting data whilst the former would result in a memory leak. Move the usage on

[PATCH v5 31/34] cxlflash: Correct trace string

The trace following the failure of alloc_mem() incorrectly identifies which function failed. This can lead to misdiagnosing a failure. Fix the string to correctly indicate that alloc_mem() failed. Reported-by: Brian King Signed-off-by: Matthew R. Ochs

Re: [PATCH v3 1/2] fsl: Add binding for RCPM

On Thu, 2015-10-01 at 12:05 -0500, Yoder Stuart-B08248 wrote: > > +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > @@ -0,0 +1,63 @@ > > +* Run Control and Power Management > > +--- > > +The RCPM performs all device-level tasks associated with

Re: [PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver

On 09/30/2015 04:24 PM, Alexander Popov wrote: Can you test for "!cs" here instead? +e = -EFAULT; +goto err_param; +} Unfortunately no: 0 is a valid value for Chip Select. Is it OK to leave it like that? Yes. +lpbfifo.ram_bus_addr = sg_dma_address(); /* For

Re: [RFC v2 4/7] powerpc: atomic: Implement xchg_* and atomic{,64}_xchg_* variants

On Thu, Oct 01, 2015 at 08:09:09AM -0700, Paul E. McKenney wrote: > On Thu, Oct 01, 2015 at 02:24:40PM +0200, Peter Zijlstra wrote: > > I must say I'm somewhat surprised by this level of relaxation, I had > > expected to only loose SMP barriers, not the program order ones. > > > > Is there a

[PATCH v5 05/34] cxlflash: Fix data corruption when vLUN used over multiple cards

If the same virtual LUN is accessed over multiple cards, only accesses made over the first card will be valid. Accesses made over the second card will go to the wrong LUN causing data corruption. This is because the global LUN's mode word was being used to determine whether the LUN table for that

[PATCH v5 21/34] cxlflash: Correct behavior in device reset handler following EEH

When the device reset handler is entered while a reset operation is taking place, the handler exits without actually sending a reset (TMF) to the targeted device. This behavior is incorrect as the device is not reset. Further complicating matters is the fact that a success is returned even when

[PATCH v5 24/34] cxlflash: Fix MMIO and endianness errors

Sparse uncovered several errors with MMIO operations (accessing directly) and handling endianness. These can cause issues when running in different environments. Introduce __iomem and proper endianness tags/swaps where appropriate to make driver sparse clean. Signed-off-by: Matthew R. Ochs

Re: [RFC v2 5/7] powerpc: atomic: Implement cmpxchg{,64}_* and atomic{,64}_cmpxchg_* variants

On Thu, Oct 01, 2015 at 08:12:19AM -0700, Paul E. McKenney wrote: > What C11 does is to allow the developer to specify different orderings > on success and failure. But it is no harder to supply a barrier (if > needed) on the failure path, right? Quite right.

[PATCH v5 04/34] cxlflash: Fix potential oops following LUN removal

When a LUN is removed, the sdev that is associated with the LUN remains intact until its reference count drops to 0. In order to prevent an sdev from being removed while a context is still associated with it, obtain an additional reference per-context for each LUN attached to the context. This

[PATCH v5 10/34] cxlflash: Make functions static

Found during code inspection, that the following functions are not being used outside of the file where they are defined. Make them static. int cxlflash_send_cmd(struct afu *, struct afu_cmd *); void cxlflash_wait_resp(struct afu *, struct afu_cmd *); int cxlflash_afu_reset(struct cxlflash_cfg

[PATCH v5 11/34] cxlflash: Refine host/device attributes

Implement the following suggestions and add two new attributes to allow for debugging the port LUN table. - use scnprintf() instead of snprintf() - use DEVICE_ATTR_RO and DEVICE_ATTR_RW Suggested-by: Shane Seymour Signed-off-by: Matthew R. Ochs

[PATCH v5 16/34] cxlflash: Fix async interrupt bypass logic

A bug was introduced earlier in the development cycle when cleaning up logic statements. Instead of skipping bits that are not set, set bits are skipped, causing async interrupts to not be handled correctly. To fix, simply add back in the proper evaluation for an unset bit. Signed-off-by:

[PATCH v5 22/34] cxlflash: Remove unnecessary scsi_block_requests

The host reset handler is called with I/O already blocked, thus there is no need to explicitly block and unblock I/O in the handler. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King

[PATCH v5 26/34] cxlflash: Correct spelling, grammar, and alignment mistakes

There are several spelling and grammar mistakes throughout the driver. Additionally there are a handful of places where there are extra lines and unnecessary variables/statements. These are a nuisance and pollute the driver. Fix spelling and grammar issues. Update some comments for clarity and

[PATCH v5 33/34] cxlflash: Fix to avoid leaving dangling interrupt resources

When running with an unsupported AFU, the cxlflash driver fails the probe. When the driver is removed, the following Oops is encountered on a show_interrupts() thread: Call Trace: [c01fba5a7a10] [0003] 0x3 (unreliable) [c01fba5a7a60] [c053dcf4] vsnprintf+0x204/0x4c0

[PATCH v5 01/34] cxlflash: Fix to avoid invalid port_sel value

From: Manoj Kumar If two concurrent MANAGE_LUN ioctls are issued with the same WWID parameter, it would result in an incorrect value of port_sel. This is because port_sel is modified without any locks being held. If the first caller stalls after the return from

[PATCH v5 15/34] cxlflash: Fix host link up event handling

Following a link up event, the LUNs available to the host may have changed. Without rescanning the host, the LUN topology is unknown to the user. In such a state, the user would be unable to locate provisioned resources. To remedy, the host should be rescanned after a link up event.

[PATCH v5 20/34] cxlflash: Fix to prevent workq from accessing freed memory

The workq can process work in parallel with a remove event, leading to a condition where the workq handler can access freed memory. To remedy, the workq should be terminated prior to freeing memory. Move the termination call earlier in remove and use cancel_work_sync() instead of flush_work() as

[PATCH v5 25/34] cxlflash: Fix to prevent EEH recovery failure

The process_sense() routine can perform a read capacity which can take some time to complete. If an EEH occurs while waiting on the read capacity, the EEH handler will wait to obtain the context's mutex in order to put the context in an error state. The EEH handler will sit and wait until the

[PATCH v5 00/34] cxlflash: Miscellaneous bug fixes and corrections

This patch set contains various fixes and corrections for issues that were found during test and code review. The series is based upon the code upstreamed in 4.3 and is intended for the rc phase. The entire set is bisectable. Please reference the changelog below for details on what has been

[PATCH v5 02/34] cxlflash: Replace magic numbers with literals

From: Manoj Kumar Magic numbers are not meaningful and can create confusion. As a remedy, replace them with descriptive literals. Replace 512 with literal MAX_SECTOR_UNIT. Replace 5 with literal CMD_RETRIES. Signed-off-by: Matthew R. Ochs

[PATCH v5 18/34] cxlflash: Fix AFU version access/storage and add check

The AFU version is stored as a non-terminated string of bytes within a 64-bit little-endian register. Presently the value is read directly (no MMIO accessor) and is stored in a buffer that is not big enough to contain a NULL terminator. Additionally the version obtained is not evaluated against a

[PATCH v5 23/34] cxlflash: Fix function prolog parameters and return codes

Several function prologs have incorrect parameter names and return code descriptions. This can lead to confusion when reviewing the source and creates inaccurate documentation. To remedy, update the function prologs to properly reflect parameter names and return codes. Signed-off-by: Matthew R.

[PATCH v5 28/34] MAINTAINERS: Add cxlflash driver

Add stanza for cxlflash SCSI driver. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King Reviewed-by: Andrew Donnellan --- MAINTAINERS | 9 +

[PATCH v5 29/34] cxlflash: Fix to double the delay each time

From: Manoj Kumar The operator used to double the master context response delay is incorrect and does not result in delay doubling. To fix, use a left shift instead of the XOR operator. Reported-by: Tomas Henzl Signed-off-by: Matthew R. Ochs

[PATCH v5 03/34] cxlflash: Fix read capacity timeout

From: Manoj Kumar The timeout value for read capacity is too small. Certain devices may take longer to respond and thus the command may prematurely timeout. Additionally the literal used for the timeout is stale. Update the timeout to 30 seconds (matches the value used in

[PATCH v5 06/34] cxlflash: Fix to avoid sizeof(bool)

Using sizeof(bool) is considered poor form for various reasons and sparse warns us of that. Correct by changing type from bool to u8. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King

[PATCH v5 09/34] cxlflash: Correct naming of limbo state and waitq

Limbo is not an accurate representation of this state and is also not consistent with the terminology that other drivers use to represent this concept. Rename the state and and its associated waitq to 'reset'. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N.

[PATCH v5 08/34] cxlflash: Fix to avoid CXL services during EEH

During an EEH freeze event, certain CXL services should not be called until after the hardware reset has taken place. Doing so can result in unnecessary failures and possibly cause other ill effects by triggering hardware accesses. This translates to a requirement to quiesce all threads that may

[PATCH v5 12/34] cxlflash: Fix to avoid spamming the kernel log

During run-time the driver can be very chatty and spam the system kernel log. Various print statements can be limited and/or moved to development-only mode. Additionally, numerous prints can be converted to trace the corresponding device. Lastly, one spelling correction was made: 'entra' to

[PATCH v5 17/34] cxlflash: Remove dual port online dependency

At present, both ports must be online for the device to configure properly. Remove this dependency and the unnecessary internal LUN override logic as well. Additionally, as a refactoring measure, change the return code variable name to match that used throughout the driver. With this change, the

[PATCH v5 30/34] cxlflash: Fix to avoid corrupting adapter fops

The fops owned by the adapter can be corrupted in certain scenarios, opening a window where certain fops are temporarily NULLed before being reset to their proper value. This can potentially lead software to make incorrect decisions, leaving the user with the inability to function as intended. An

Re: [RFC v2 4/7] powerpc: atomic: Implement xchg_* and atomic{,64}_xchg_* variants

On Thu, Oct 01, 2015 at 07:13:04PM +0200, Peter Zijlstra wrote: > On Thu, Oct 01, 2015 at 08:09:09AM -0700, Paul E. McKenney wrote: > > On Thu, Oct 01, 2015 at 02:24:40PM +0200, Peter Zijlstra wrote: > > > > I must say I'm somewhat surprised by this level of relaxation, I had > > > expected to

RE: [PATCH v3 1/2] fsl: Add binding for RCPM

> +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > @@ -0,0 +1,63 @@ > +* Run Control and Power Management > +--- > +The RCPM performs all device-level tasks associated with device run control > +and power management. > + > +Required properites: > +

Re: [RFC v2 4/7] powerpc: atomic: Implement xchg_* and atomic{,64}_xchg_* variants

On Thu, Oct 01, 2015 at 11:03:01AM -0700, Paul E. McKenney wrote: > On Thu, Oct 01, 2015 at 07:13:04PM +0200, Peter Zijlstra wrote: > > On Thu, Oct 01, 2015 at 08:09:09AM -0700, Paul E. McKenney wrote: > > > On Thu, Oct 01, 2015 at 02:24:40PM +0200, Peter Zijlstra wrote: > > > > > > I must say

Re: [RFC v2 4/7] powerpc: atomic: Implement xchg_* and atomic{,64}_xchg_* variants

On Thu, Oct 01, 2015 at 08:23:09PM +0200, Peter Zijlstra wrote: > On Thu, Oct 01, 2015 at 11:03:01AM -0700, Paul E. McKenney wrote: > > On Thu, Oct 01, 2015 at 07:13:04PM +0200, Peter Zijlstra wrote: > > > On Thu, Oct 01, 2015 at 08:09:09AM -0700, Paul E. McKenney wrote: > > > > On Thu, Oct 01,

[PATCH] drivers/macintosh: adb: fix misleading Kconfig help text

CONFIG_INPUT_KEYBDEV does not exist and no additional keyboard-specific options are needed to get the keyboard working. Signed-off-by: Aaro Koskinen --- drivers/macintosh/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v3 0/5] powerpc/pseries: bug fix and clean up

On 10/1/15, Andy Shevchenko wrote: > Changelog v2: > - fix compiler error > - rebase on top of recent linux-next > - compile tested > > Andy Shevchenko (5): > powerpc/pseries: extract of_helpers module > powerpc/pseries: fix a potential memory leak >

Re: [PATCH v5 33/34] cxlflash: Fix to avoid leaving dangling interrupt resources

Acked-by: Manoj Kumar ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC v2 6/7] powerpc: atomic: Make atomic{,64}_xchg and xchg a full barrier

Hi Peter, Please forgive me for the format of my reply. I'm travelling, and replying from my phone. 2015年10月1日 下午7:28，"Peter Zijlstra" 写道： > > On Wed, Sep 16, 2015 at 11:49:34PM +0800, Boqun Feng wrote: > > According to memory-barriers.txt, xchg and its atomic{,64}_

Re: [PATCH] powerpc/iommu: use iommu_num_pages() to calculate the number of iommu page

On Thu, Oct 01, 2015 at 02:15:45PM +1000, Michael Ellerman wrote: >On Thu, 2015-10-01 at 07:50 +0800, Wei Yang wrote: >> Hmm... some comments on this one? like it or not? > >It sounds like it's fixing a bug, but you don't really say. Have you seen this >fail in the wild? Hmm... as described in

[PATCH v6 52/53] PCI: Introduce resource_disabled()

Current is using !flags, and we are going to use IORESOURCE_DISABLED instead of clearing resource flags. Let's convert all !flags to helper function resource_disabled(). resource_disabled will check !flags and IORESOURCE_DISABLED both. Cc: linux-al...@vger.kernel.org Cc:

Re: [RFC PATCH 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG to be a target

On Fri, 2015-09-25 at 22:46 +0200, Michal Marek wrote: > Dne 24.9.2015 v 00:16 Michael Ellerman napsal(a): > > > > > > On 23 September 2015 19:50:52 GMT+10:00, Michal Marek > > wrote: > >> On 2015-09-23 07:40, Michael Ellerman wrote: > >>> +else ifneq ($(wildcard > >>

[PATCH 1/4] powerpc/pseries: Make PCI non-optional

The pseries build with PCI=n looks to have been broken for at least 5 years, and no one's noticed or cared. Following the obvious breakages backward, the first commit I can find that builds is the parent of 2eb4afb69ff3 ("powerpc/pci: Move pseries code into pseries platform specific area") from

[PATCH 2/4] powerpc/pseries: Remove use of CONFIG_PCI

Now that we always have CONFIG_PCI=y for pseries, we can stop guarding code with CONFIG_PCI ifdefs. Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/pseries/iommu.c | 10 -- arch/powerpc/platforms/pseries/setup.c | 4 2 files changed, 14 deletions(-)

Re: [RFC PATCH 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG to be a target

On 2015-10-01 08:14, Michael Ellerman wrote: > On Fri, 2015-09-25 at 22:46 +0200, Michal Marek wrote: >> Dne 24.9.2015 v 00:16 Michael Ellerman napsal(a): >>> >>> >>> On 23 September 2015 19:50:52 GMT+10:00, Michal Marek >>> wrote: On 2015-09-23 07:40, Michael Ellerman

Re: [GIT PULL 00/16] perf/core improvements and fixes

* Arnaldo Carvalho de Melo wrote: > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > The following changes since commit 9c17dbc6eb73bdd8a6aaea1baefd37ff78d86148: > > Merge tag 'perf-core-for-mingo' of >

[PATCH 3/4] powerpc/pseries: Move PCI objects to obj-y

Make it entirely clear in the Makefile that we always build the pci related files by moving them to obj-y. Note that CONFIG_EEH is now always enabled on pseries, because it depends on PSERIES && PCI. Signed-off-by: Michael Ellerman ---

[PATCH 4/4] powerpc/pseries: Drop always true CONFIG_PSERIES_MSI

Now that pseries selects PCI_MSI && PCI, EEH will always be true, and therefore CONFIG_PSERIES_MSI will always be true. So drop it, and move msi.o to obj-y. Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/pseries/Kconfig | 5 -

Re: [1/3] cxl: fix leak of IRQ names in cxl_free_afu_irqs()

On Wed, 2015-30-09 at 01:58:05 UTC, Andrew Donnellan wrote: > cxl_free_afu_irqs() doesn't free IRQ names when it releases an AFU's IRQ > ranges. The userspace API equivalent in afu_release_irqs() calls > afu_irq_name_free() to release the IRQ names. > > Call afu_irq_name_free() in

Re: [2/3] cxl: fix leak of ctx->irq_bitmap when releasing context via kernel API

On Wed, 2015-30-09 at 01:58:06 UTC, Andrew Donnellan wrote: > At present, ctx->irq_bitmap is freed in afu_release_irqs(), which is called > from afu_release() via cxl_context_detach(). > > Move the freeing of ctx->irq_bitmap from afu_release_irqs() to > reclaim_ctx() (called through

Re: [v2,5/5] powerpc/pseries: re-use code from of_helpers module

On 10/1/15, Michael Ellerman wrote: > On Wed, 2015-09-30 at 19:19 +0300, Andy Shevchenko wrote: >> On Fri, 2015-08-14 at 21:51 +1000, Michael Ellerman wrote: >> > On Tue, 2015-11-08 at 11:23:09 UTC, Andy Shevchenko wrote: >> > > int dlpar_attach_node(struct device_node *dn)

Re: [RFC PATCH 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG to be a target

On Thu, 2015-10-01 at 08:50 +0200, Michal Marek wrote: > On 2015-10-01 08:14, Michael Ellerman wrote: > > On Fri, 2015-09-25 at 22:46 +0200, Michal Marek wrote: > >> Dne 24.9.2015 v 00:16 Michael Ellerman napsal(a): > >>> On 23 September 2015 19:50:52 GMT+10:00, Michal Marek > >>>

[PATCH v6 40/53] PCI: Unify skip_ioresource_align()

There are powerpc generic version and x86 local version for skip_ioresource_align(). Move the powerpc version to setup-bus.c, and kill x86 local version. Also kill dummy version in microblaze. Cc: Michal Simek Cc: Paul Mackerras Cc: Michael Ellerman

Re: [1/3] cxl: fix leak of IRQ names in cxl_free_afu_irqs()

On Wed, 2015-30-09 at 01:58:05 UTC, Andrew Donnellan wrote: > cxl_free_afu_irqs() doesn't free IRQ names when it releases an AFU's IRQ > ranges. The userspace API equivalent in afu_release_irqs() calls > afu_irq_name_free() to release the IRQ names. > > Call afu_irq_name_free() in

Re: [3/3] cxl: fix leak of ctx->mapping when releasing kernel API contexts

On Wed, 2015-30-09 at 01:58:07 UTC, Andrew Donnellan wrote: > When a context is created via the kernel API, ctx->mapping is allocated > within the kernel and thus needs to be freed when the context is freed. > reclaim_ctx() attempts to do this for contexts with the ctx->kernelapi flag > set, but

Re: [PATCH v5 17/34] cxlflash: Remove dual port online dependency

"Matthew R. Ochs" writes: > At present, both ports must be online for the device to > configure properly. Remove this dependency and the unnecessary > internal LUN override logic as well. Additionally, as a refactoring > measure, change the return code variable name to

Re: [PATCH v5 18/34] cxlflash: Fix AFU version access/storage and add check

> On Oct 1, 2015, at 7:56 PM, Daniel Axtens wrote: > > "Matthew R. Ochs" writes: > >> The AFU version is stored as a non-terminated string of bytes within >> a 64-bit little-endian register. Presently the value is read directly >> (no MMIO accessor)

Re: [RFC PATCH 0/8] clk: qoriq: Move chip-specific knowledge into driver

[Resending to updated e-mail address] On Tue, 2015-08-11 at 11:25 -0700, Michael Turquette wrote: > Hi Scott, > > Quoting Scott Wood (2015-06-18 19:49:10) > > The existing device tree bindings are error-prone and inflexible. > > Correct the mistake by moving the knowledge into the driver, which

Re: [PATCH v5 18/34] cxlflash: Fix AFU version access/storage and add check

"Matthew R. Ochs" writes: > The AFU version is stored as a non-terminated string of bytes within > a 64-bit little-endian register. Presently the value is read directly > (no MMIO accessor) and is stored in a buffer that is not big enough > to contain a NULL

Re: [RFC PATCH 0/8] clk: qoriq: Move chip-specific knowledge into driver

On Tue, 2015-08-11 at 11:25 -0700, Michael Turquette wrote: > Hi Scott, > > Quoting Scott Wood (2015-06-18 19:49:10) > > The existing device tree bindings are error-prone and inflexible. > > Correct the mistake by moving the knowledge into the driver, which > > has more flexibility in describing

Re: [v3 1/8] devres: add devm_alloc_percpu()

On Thu, Sep 24, 2015 at 06:00:12PM +0300, Madalin Bucur wrote: > Introduce managed counterparts for alloc_percpu() and free_percpu(). > Add devm_alloc_percpu() and devm_free_percpu() into the managed > interfaces list. > > Signed-off-by: Madalin Bucur > Tested-by:

[PATCH v3 0/5] powerpc/pseries: bug fix and clean up

Changelog v2: - fix compiler error - rebase on top of recent linux-next - compile tested Andy Shevchenko (5): powerpc/pseries: extract of_helpers module powerpc/pseries: fix a potential memory leak powerpc/pseries: replace kmalloc + strlcpy powerpc/pseries: handle nodes without '/'

[PATCH v3 3/5] powerpc/pseries: replace kmalloc + strlcpy

The helper kstrndup() will do the same in one line. Signed-off-by: Andy Shevchenko --- arch/powerpc/platforms/pseries/of_helpers.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/pseries/of_helpers.c

[PATCH v3 5/5] powerpc/pseries: re-use code from of_helpers module

The derive_parent() has similar semantics to what we have in newly introduced of_helpers module. The replacement reduces code base and propagates the actual error code to the caller. Signed-off-by: Andy Shevchenko --- arch/powerpc/platforms/pseries/dlpar.c |

[PATCH v3 1/5] powerpc/pseries: extract of_helpers module

Extract a new module to share the code between other modules. There is no functional change. Signed-off-by: Andy Shevchenko --- arch/powerpc/platforms/pseries/Makefile | 1 + arch/powerpc/platforms/pseries/of_helpers.c | 38 +

[PATCH v3 2/5] powerpc/pseries: fix a potential memory leak

In case we have a full node name like /foo/bar and /foo is not found the parent_path left unfreed. So, free a memory before return to a caller. Signed-off-by: Andy Shevchenko --- arch/powerpc/platforms/pseries/of_helpers.c | 6 ++ 1 file changed, 2

[PATCH v3 4/5] powerpc/pseries: handle nodes without '/'

In case we have node without '/' strrchr() returns NULL which might lead to crash. Replace strrchr() by kbasename() and modify condition to avoid such behaviour. Suggested-by: Segher Boessenkool Signed-off-by: Andy Shevchenko ---

Re: [v5, 2/6] fsl/fman: Add FMan support

On Thu, Sep 24, 2015 at 12:10:34PM +0300, igal.liber...@freescale.com wrote: > +int fman_get_rx_extra_headroom(void) > +{ > + static bool fm_check_rx_extra_headroom; > + > + if (!fm_check_rx_extra_headroom) { > + if (fsl_fm_rx_extra_headroom > FSL_FM_RX_EXTRA_HEADROOM_MAX || >

Re: [PATCH] cxl: Workaround malformed pcie packets on some cards

Acked-by: Ian Munsie ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC v2 6/7] powerpc: atomic: Make atomic{,64}_xchg and xchg a full barrier

On Fri, Oct 02, 2015 at 07:19:04AM +0800, Boqun Feng wrote: > Hi Peter, > > Please forgive me for the format of my reply. I'm travelling, > and replying from my phone. > > 2015年10月1日 下午7:28，"Peter Zijlstra" 写道： > > > > On Wed, Sep 16, 2015 at 11:49:34PM +0800, Boqun Feng

Re: [PATCH v5 18/34] cxlflash: Fix AFU version access/storage and add check

"Matthew R. Ochs" writes: > Correct, downlevel (unsupported) AFUs don't implement the interface_version > register and thus will return -1 at that offset. Cool. It would be good to document that somewhere, either the comment or the commit message, but it's not worth

[PATCH] cxl: Workaround malformed pcie packets on some cards

From: Philippe Bergheaud This works around a pcie host bridge defect on some cards, that can cause malformed Transaction Layer Packet (TLP) errors to be erroneously reported. The upper nibble of the vendor section PSL revision is used to distinguish between different

Re: [v2,5/5] powerpc/pseries: re-use code from of_helpers module

On 10/1/15, Andy Shevchenko wrote: > On Thu, 2015-10-01 at 10:02 +0300, Denis Kirjanov wrote: >> On 10/1/15, Michael Ellerman wrote: >> > On Wed, 2015-09-30 at 19:19 +0300, Andy Shevchenko wrote: >> > > On Fri, 2015-08-14 at 21:51 +1000,

Re: [v2,5/5] powerpc/pseries: re-use code from of_helpers module

On Thu, 2015-10-01 at 10:02 +0300, Denis Kirjanov wrote: > On 10/1/15, Michael Ellerman wrote: > > On Wed, 2015-09-30 at 19:19 +0300, Andy Shevchenko wrote: > > > On Fri, 2015-08-14 at 21:51 +1000, Michael Ellerman wrote: > > > > On Tue, 2015-11-08 at 11:23:09 UTC, Andy