Re: [PATCH ppc-next] powerpc/fsl-booke: don't load early TLB at once

On Fri, Sep 21, 2018 at 03:00:19AM +0200, David Lamparter wrote: > On Thu, Sep 20, 2018 at 07:31:33PM -0500, Scott Wood wrote: > > Do you have a JTAG that can be used to find out where it's hanging? If > > not, I can try to get early debug working (needs an early IOMMU mapping). s/IOMMU

Re: [PATCH v3 2/3] powerpc/process: fix interleaved output in show_user_instructions()

On Fri, Sep 07, 2018 at 01:47:31PM +, Christophe Leroy wrote: > When two processes crash at the same time, we sometimes encounter > interleaving in the middle of a line: > > [4.365317] init[1]: segfault (11) at 0 nip 0 lr 0 code 1 > [4.370452] init[1]: code:

Re: [PATCH v3 3/3] powerpc/process: Constify the number of insns printed by show instructions functions.

On Fri, Sep 07, 2018 at 01:47:33PM +, Christophe Leroy wrote: > instructions_to_print var is assigned value 16 and there is no > way to change it. > > This patch replaces it by a constant. > > Signed-off-by: Christophe Leroy Reviewed-by: Murilo Opsfelder Araujo > --- > v3: no change >

Re: [PATCH 1/4] soc/fsl/qbman: Check if CPU is offline when initializing portals

On Thu, Sep 20, 2018 at 10:09 AM Madalin Bucur wrote: > > From: Roy Pledge > > If the affine portal for a specific CPU is offline at boot time > affine its interrupt to CPU 0. If the CPU is later brought online > the hotplug handler will correctly adjust the affinity. Although this does provide

Re: [PATCH v3 1/3] powerpc/process: fix casting and missing header

On Fri, Sep 07, 2018 at 01:47:29PM +, Christophe Leroy wrote: > This patch fixes the following warnings. The first ones are leftovers > from when __get_user() was replaced by probe_kernel_address(). > > The last one is from when show_user_instructions() was added. > >

Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function

On 09/20/2018 07:32 AM, YueHaibing wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to netdev_tx_t. >

Re: [PATCH ppc-next] powerpc/fsl-booke: don't load early TLB at once

On 09/21/2018 10:47 AM, Scott Wood wrote: > On Fri, 2018-09-21 at 17:40 +, York Sun wrote: >> On 09/20/2018 05:31 PM, Scott Wood wrote: >>> On Fri, 2018-09-21 at 00:48 +0200, David Lamparter wrote: This is a *partial* revert of "powerpc/85xx: Load all early TLB entries at once"

Re: [PATCH ppc-next] powerpc/fsl-booke: don't load early TLB at once

On Fri, 2018-09-21 at 17:40 +, York Sun wrote: > On 09/20/2018 05:31 PM, Scott Wood wrote: > > On Fri, 2018-09-21 at 00:48 +0200, David Lamparter wrote: > > > This is a *partial* revert of "powerpc/85xx: Load all early TLB entries > > > at once" (d9e1831a420267a7ced708bb259d65b0a3c0344d.) > >

Re: [PATCH ppc-next] powerpc/fsl-booke: don't load early TLB at once

On 09/20/2018 05:31 PM, Scott Wood wrote: > On Fri, 2018-09-21 at 00:48 +0200, David Lamparter wrote: >> This is a *partial* revert of "powerpc/85xx: Load all early TLB entries >> at once" (d9e1831a420267a7ced708bb259d65b0a3c0344d.) >> >> My dusty old P4080DS just completely fails to boot (no

Re: [PATCH v8 3/3] powerpc/sysfs: Add topology/smallcore_thread_siblings[_list]

rong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Gautham-R-Shenoy/powerpc-Detection-and-scheduler-optimization-for-POWER9-bigcore/20180921-085812 > base: https://git.kernel.org/pub/scm/linux/kernel/git/powe

Re: [PATCH v8 1/3] powerpc: Detect the presence of big-cores via "ibm,thread-groups"

Hello Michael, On Fri, Sep 21, 2018 at 01:02:45PM +1000, Michael Neuling wrote: > This doesn't compile for me with: > > arch/powerpc/kernel/smp.c: In function ‘smp_prepare_cpus’: > arch/powerpc/kernel/smp.c:812:23: error: ‘tg.threads_per_group’ may be used > uninitialized in this function

Re: powerpc/pkeys: Fix reading of ibm, processor-storage-keys property

On Thu, 2018-09-20 at 04:38:58 UTC, Thiago Jung Bauermann wrote: > scan_pkey_feature() uses of_property_read_u32_array() to read the > ibm,processor-storage-keys property and calls be32_to_cpu() on the > value it gets. The problem is that of_property_read_u32_array() already > returns the value

Re: [v4] powerpc: Avoid code patching freed init sections

On Fri, 2018-09-14 at 01:14:11 UTC, Michael Neuling wrote: > This stops us from doing code patching in init sections after they've > been freed. > > In this chain: > kvm_guest_init() -> > kvm_use_magic_page() -> > fault_in_pages_readable() -> >__get_user() -> >

Re: KVM: PPC: Book3S HV: Fix guest r11 corruption with POWER9 TM workarounds

On Thu, 2018-09-13 at 05:33:47 UTC, Michael Neuling wrote: > When we come into the softpatch handler (0x1500), we use r11 to store > the HSRR0 for later use by the denorm handler. > > We also use the softpatch handler for the TM workarounds for > POWER9. Unfortunately, in kvmppc_interrupt_hv we

Re: [kernel] powerpc/powernv/ioda2: Reduce upper limit for DMA window size (retry)

On Tue, 2018-09-11 at 05:38:05 UTC, Alexey Kardashevskiy wrote: > We use PHB in mode1 which uses bit 59 to select a correct DMA window. > However there is mode2 which uses bits 59:55 and allows up to 32 DMA > windows per a PE. > > Even though documentation does not clearly specify that, it seems

Re: powerpc: fix csum_ipv6_magic() on little endian platforms

On Mon, 2018-09-10 at 06:09:04 UTC, Christophe Leroy wrote: > On little endian platforms, csum_ipv6_magic() keeps len and proto in > CPU byte order. This generates a bad results leading to ICMPv6 packets > from other hosts being dropped by powerpc64le platforms. > > In order to fix this, len and

Re: [PATCH V3 1/6] powerpc/mm/book3s: Update pmd_present to look at _PAGE_PRESENT bit

Le 21/09/2018 à 12:26, Aneesh Kumar K.V a écrit : On 9/21/18 11:25 AM, Christophe LEROY wrote: Le 20/09/2018 à 20:09, Aneesh Kumar K.V a écrit : diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c index d71c669c..aee04b209b51 100644 --- a/arch/powerpc/mm/pgtable.c +++

[PATCH -next] powerpc/pseries/memory-hotplug: Fix return value type of find_aa_index

find_aa_index will return -1 when dlpar_clone_property fails, its return value type should be int. Also the caller update_lmb_associativity_index should use a int variable to get it,then compared with 0. Fixes: c05a5a40969e ("powerpc/pseries: Dynamic add entires to associativity lookup array")

Re: [PATCH V3 1/6] powerpc/mm/book3s: Update pmd_present to look at _PAGE_PRESENT bit

On 9/21/18 11:25 AM, Christophe LEROY wrote: Le 20/09/2018 à 20:09, Aneesh Kumar K.V a écrit : diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c index d71c669c..aee04b209b51 100644 --- a/arch/powerpc/mm/pgtable.c +++ b/arch/powerpc/mm/pgtable.c @@ -188,11 +188,10 @@

Re: [REVIEW][PATCH 0/9] signal/powerpc: siginfo cleanups

Hi Eric, On Tue, 18 Sep 2018 19:41:09 +0200 ebied...@xmission.com (Eric W. Biederman) wrote: > > Folks please review and double check me. I think I have kept these > changes simple and obviously correct but I am human and mess up > sometimes. Its always good to see a nicely set out patch

Re: [REVIEW][PATCH 9/9] signal/powerpc: Use force_sig_fault where appropriate

Hi Eric, On Tue, 18 Sep 2018 19:58:50 +0200 "Eric W. Biederman" wrote: > > Signed-off-by: "Eric W. Biederman" Again, looks all good to me. Reviewed-by: Stephen Rothwell -- Cheers, Stephen Rothwell pgpOOeo020j3Y.pgp Description: OpenPGP digital signature

Re: [REVIEW][PATCH 7/9] signal/poewrpc: Specialize _exception_pkey for handling pkey exceptions

Le 21/09/2018 à 10:54, Stephen Rothwell a écrit : Hi Eric, On Tue, 18 Sep 2018 19:58:48 +0200 "Eric W. Biederman" wrote: Now that _exception no longer calls _exception_pkey it is no longer necessary to handle any signal with any si_code. All pkey exceptions are SIGSEGV with paired with

Re: [REVIEW][PATCH 8/9] signal/powerpc: Simplify _exception_pkey by using force_sig_pkuerr

Hi Eric, On Tue, 18 Sep 2018 19:58:49 +0200 "Eric W. Biederman" wrote: > > Call force_sig_pkuerr directly instead of rolling it by hand > in _exception_pkey. > > Signed-off-by: "Eric W. Biederman" You can ignore the question in the previous email :-) Reviewed-by: Stephen Rothwell --

Re: [REVIEW][PATCH 7/9] signal/poewrpc: Specialize _exception_pkey for handling pkey exceptions

Hi Eric, On Tue, 18 Sep 2018 19:58:48 +0200 "Eric W. Biederman" wrote: > > Now that _exception no longer calls _exception_pkey it is no longer > necessary to handle any signal with any si_code. All pkey exceptions > are SIGSEGV with paired with SEGV_PKUERR. So just handle > that case and

Re: [REVIEW][PATCH 6/9] signal/powerpc: Call force_sig_fault from _exception

Hi Eric, On Tue, 18 Sep 2018 19:58:47 +0200 "Eric W. Biederman" wrote: > > The callers of _exception don't need the pkey exception logic because > they are not processing a pkey exception. So just call exception_common > directly and then call force_sig_fault to generate the appropriate

Re: [PATCH 3/3] mm: optimise pte dirty/accessed bit setting by demand based pte insertion

On Tue, 2018-09-18 at 03:53 +1000, Nicholas Piggin wrote: > On Wed, 5 Sep 2018 07:29:51 -0700 > Guenter Roeck wrote: > > > > > Hi, > > > > On Tue, Aug 28, 2018 at 09:20:34PM +1000, Nicholas Piggin wrote: > > > > > > Similarly to the previous patch, this tries to optimise > > > dirty/accessed

Re: [REVIEW][PATCH 5/9] signal/powerpc: Factor the common exception code into exception_common

Hi Eric, On Tue, 18 Sep 2018 19:58:46 +0200 "Eric W. Biederman" wrote: > > It is brittle and wrong to populate si_pkey when there was not a pkey > exception. The field does not exist for all si_codes and in some > cases another field exists in the same memory location. > > So factor out the

Re: [REVIEW][PATCH 4/9] signal/powerpc: Remove pkey parameter from __bad_area_nosemaphore

Hi Eric, On Tue, 18 Sep 2018 19:58:45 +0200 "Eric W. Biederman" wrote: > > Now that bad_key_fault_exception no longer calls __bad_area_nosemaphore > there is no reason for __bad_area_nosemaphore to handle pkeys. > > Signed-off-by: "Eric W. Biederman" Again, very straight forward given that

Re: [REVIEW][PATCH 3/9] signal/powerpc: Call _exception_pkey directly from bad_key_fault_exception

Hi Eric, On Tue, 18 Sep 2018 19:58:44 +0200 "Eric W. Biederman" wrote: > > This removes the need for other code paths to deal with pkey exceptions. > > Signed-off-by: "Eric W. Biederman" Straight forward expansion. Reviewed-by: Stephen Rothwell -- Cheers, Stephen Rothwell

Re: [REVIEW][PATCH 2/9] signal/powerpc: Remove pkey parameter from __bad_area

Hi Eric, On Tue, 18 Sep 2018 19:58:43 +0200 "Eric W. Biederman" wrote: > > There are no callers of __bad_area that pass in a pkey parameter so it makes > no sense to take one. > > Signed-off-by: "Eric W. Biederman" Fairly straight forward. Reviewed-by: Stephen Rothwell -- Cheers, Stephen

Re: [REVIEW][PATCH 1/9] signal/powerpc: Use force_sig_mceerr as appropriate

Hi Eric, On Tue, 18 Sep 2018 19:58:42 +0200 "Eric W. Biederman" wrote: > > In do_sigbus isolate the mceerr signaling code and call > force_sig_mceerr instead of falling through to the force_sig_info that > works for all of the other signals. > > Signed-off-by: "Eric W. Biederman" Looks good

Re: [PATCH v8 3/3] powerpc/sysfs: Add topology/smallcore_thread_siblings[_list]

/commits/Gautham-R-Shenoy/powerpc-Detection-and-scheduler-optimization-for-POWER9-bigcore/20180921-085812 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-mpc837x_mds_defconfig (attached as .config) compiler: powerpc-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0