Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Geert Uytterhoeven
Hi Saravana, On Wed, Jan 27, 2021 at 1:44 AM Saravana Kannan wrote: > On Tue, Jan 26, 2021 at 12:50 AM Geert Uytterhoeven > wrote: > > On Mon, Jan 25, 2021 at 11:42 PM Saravana Kannan > > wrote: > > > On Mon, Jan 25, 2021 at 11:49 AM Michael Walle wrote: > > > > Am 2021-01-21 12:01, schrieb

Re: [PATCH v6 05/39] powerpc: remove arguments from fault handler functions

2021-01-26 Thread Christophe Leroy
Le 15/01/2021 à 17:49, Nicholas Piggin a écrit : Make mm fault handlers all just take the pt_regs * argument and load DAR/DSISR from that. Make those that return a value return long. This is done to make the function signatures match other handlers, which will help with a future patch to add

Re: [PATCH v6 14/39] powerpc/perf: move perf irq/nmi handling details into traps.c

2021-01-26 Thread Athira Rajeev
On 20-Jan-2021, at 8:39 AM, Nicholas Piggin wrote:Excerpts from Athira Rajeev's message of January 19, 2021 8:24 pm:On 15-Jan-2021, at 10:19 PM, Nicholas Piggin wrote:This is required in order to allow more significant differences betweenNMI type interrupt handlers and regular asynchronous

Re: [PATCH v11 05/13] mm: HUGE_VMAP arch support cleanup

2021-01-26 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/huge-vmalloc-mappings/20210126-143141 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: x86_64

Re: [PATCH 04/13] livepatch: move klp_find_object_module to module.c

2021-01-26 Thread Jessica Yu
+++ Christoph Hellwig [21/01/21 08:49 +0100]: To uncouple the livepatch code from module loader internals move a slightly refactored version of klp_find_object_module to module.c This allows to mark find_module static and removes one of the last users of module_mutex outside of module.c.

Re: [PATCH v11 05/13] mm: HUGE_VMAP arch support cleanup

2021-01-26 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/huge-vmalloc-mappings/20210126-143141 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: x86_64

Re: [PATCH v11 12/13] mm/vmalloc: Hugepage vmalloc mappings

2021-01-26 Thread Ding Tianhong
On 2021/1/26 17:47, Nicholas Piggin wrote: > Excerpts from Ding Tianhong's message of January 26, 2021 4:59 pm: >> On 2021/1/26 12:45, Nicholas Piggin wrote: >>> Support huge page vmalloc mappings. Config option HAVE_ARCH_HUGE_VMALLOC >>> enables support on architectures that define

Re: [PATCH 3/5] powerpc/xive: remove unnecessary unmap_kernel_range

2021-01-26 Thread Cédric Le Goater
On 1/26/21 5:54 AM, Nicholas Piggin wrote: > iounmap will remove ptes. > > Cc: "Cédric Le Goater" > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Nicholas Piggin Looks good. Acked-by: Cédric Le Goater Thanks, C. > --- > arch/powerpc/sysdev/xive/common.c | 4 > 1 file changed,

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Geert Uytterhoeven
Hi Michael, On Tue, Jan 26, 2021 at 11:46 AM Michael Walle wrote: > Am 2021-01-26 11:02, schrieb Lorenzo Pieralisi: > > On Wed, Jan 20, 2021 at 11:52:46AM +0100, Michael Walle wrote: > >> fw_devlink will defer the probe until all suppliers are ready. We > >> can't > >> use

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Lorenzo Pieralisi
On Wed, 20 Jan 2021 11:52:46 +0100, Michael Walle wrote: > fw_devlink will defer the probe until all suppliers are ready. We can't > use builtin_platform_driver_probe() because it doesn't retry after probe > deferral. Convert it to builtin_platform_driver(). Applied to pci/dwc, thanks! [1/1]

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Michael Walle
Am 2021-01-26 11:02, schrieb Lorenzo Pieralisi: On Wed, Jan 20, 2021 at 11:52:46AM +0100, Michael Walle wrote: fw_devlink will defer the probe until all suppliers are ready. We can't use builtin_platform_driver_probe() because it doesn't retry after probe deferral. Convert it to

RE: [PATCH v4 11/23] powerpc/syscall: Rename syscall_64.c into syscall.c

2021-01-26 Thread David Laight
From: Nicholas Piggin > Sent: 26 January 2021 10:21 > > Excerpts from Christophe Leroy's message of January 26, 2021 12:48 am: > > syscall_64.c will be reused almost as is for PPC32. > > > > Rename it syscall.c > > Could you rename it to interrupt.c instead? A system call is an > interrupt, and

Re: [PATCH v4 11/23] powerpc/syscall: Rename syscall_64.c into syscall.c

2021-01-26 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of January 26, 2021 12:48 am: > syscall_64.c will be reused almost as is for PPC32. > > Rename it syscall.c Could you rename it to interrupt.c instead? A system call is an interrupt, and the file now also has code to return from other interrupts as well,

Re: [PATCH v4 14/23] powerpc/syscall: Save r3 in regs->orig_r3

2021-01-26 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of January 26, 2021 12:48 am: > Save r3 in regs->orig_r3 in system_call_exception() > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/kernel/entry_64.S | 1 - > arch/powerpc/kernel/syscall.c | 2 ++ > 2 files changed, 2 insertions(+), 1

Re: [PATCH v4 20/23] powerpc/syscall: Do not check unsupported scv vector on PPC32

2021-01-26 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of January 26, 2021 12:48 am: > Only PPC64 has scv. No need to check the 0x7ff0 trap on PPC32. > > And ignore the scv parameter in syscall_exit_prepare (Save 14 cycles > 346 => 332 cycles) > > Signed-off-by: Christophe Leroy > --- >

Re: [PATCH v4 19/23] powerpc/syscall: Avoid stack frame in likely part of system_call_exception()

2021-01-26 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of January 26, 2021 12:48 am: > When r3 is not modified, reload it from regs->orig_r3 to free > volatile registers. This avoids a stack frame for the likely part > of system_call_exception() > > Before the patch: > > c000b4d4 : > c000b4d4: 7c 08 02 a6

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Lorenzo Pieralisi
On Wed, Jan 20, 2021 at 11:52:46AM +0100, Michael Walle wrote: > fw_devlink will defer the probe until all suppliers are ready. We can't > use builtin_platform_driver_probe() because it doesn't retry after probe > deferral. Convert it to builtin_platform_driver(). > > Fixes: e590474768f1 ("driver

Re: [PATCH v11 02/13] mm: apply_to_pte_range warn and fail if a large pte is encountered

2021-01-26 Thread Miaohe Lin
Hi: On 2021/1/26 12:44, Nicholas Piggin wrote: > apply_to_pte_range might mistake a large pte for bad, or treat it as a > page table, resulting in a crash or corruption. Add a test to warn and > return error if large entries are found. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Nicholas

Re: [PATCH v11 01/13] mm/vmalloc: fix HUGE_VMAP regression by enabling huge pages in vmalloc_to_page

2021-01-26 Thread Miaohe Lin
Hi: On 2021/1/26 12:44, Nicholas Piggin wrote: > vmalloc_to_page returns NULL for addresses mapped by larger pages[*]. > Whether or not a vmap is huge depends on the architecture details, > alignments, boot options, etc., which the caller can not be expected > to know. Therefore HUGE_VMAP is a

RE: [PATCH v10 11/12] mm/vmalloc: Hugepage vmalloc mappings

2021-01-26 Thread Nicholas Piggin
Excerpts from David Laight's message of January 25, 2021 10:24 pm: > From: Christophe Leroy >> Sent: 25 January 2021 09:15 >> >> Le 24/01/2021 à 09:22, Nicholas Piggin a écrit : >> > Support huge page vmalloc mappings. Config option HAVE_ARCH_HUGE_VMALLOC >> > enables support on architectures

Re: [PATCH v11 12/13] mm/vmalloc: Hugepage vmalloc mappings

2021-01-26 Thread Nicholas Piggin
Excerpts from Ding Tianhong's message of January 26, 2021 4:59 pm: > On 2021/1/26 12:45, Nicholas Piggin wrote: >> Support huge page vmalloc mappings. Config option HAVE_ARCH_HUGE_VMALLOC >> enables support on architectures that define HAVE_ARCH_HUGE_VMAP and >> supports PMD sized vmap mappings.

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Geert Uytterhoeven
Hi Saravana, On Mon, Jan 25, 2021 at 11:42 PM Saravana Kannan wrote: > On Mon, Jan 25, 2021 at 11:49 AM Michael Walle wrote: > > Am 2021-01-21 12:01, schrieb Geert Uytterhoeven: > > > On Thu, Jan 21, 2021 at 1:05 AM Saravana Kannan > > > wrote: > > >> On Wed, Jan 20, 2021 at 3:53 PM Michael