Re: [PATCH v3 2/2] arch/powerpc/kvm: kvmppc_hv_entry: remove r4 argument

2023-03-20 Thread Kautuk Consul
Hi, On 2023-03-21 14:15:14, Nicholas Piggin wrote: > On Thu Mar 16, 2023 at 3:10 PM AEST, Kautuk Consul wrote: > > kvmppc_hv_entry is called from only 2 locations within > > book3s_hv_rmhandlers.S. Both of those locations set r4 > > as HSTATE_KVM_VCPU(r13) before calling kvmppc_hv_entry. > > So,

Re: [RFC PATCH 04/13] powerpc/dexcr: Support userspace ROP protection

2023-03-20 Thread Nicholas Piggin
On Tue Mar 7, 2023 at 3:37 PM AEST, Benjamin Gray wrote: > On Tue, 2023-03-07 at 15:05 +1000, Nicholas Piggin wrote: > > I think it is not quite per-process? I don't actually know how the > > user > > toolchain side is put together, but I'm thinking we can not give it a > > new > > salt on fork(),

Re: [PATCH v3 2/2] arch/powerpc/kvm: kvmppc_hv_entry: remove r4 argument

2023-03-20 Thread Nicholas Piggin
On Thu Mar 16, 2023 at 3:10 PM AEST, Kautuk Consul wrote: > kvmppc_hv_entry is called from only 2 locations within > book3s_hv_rmhandlers.S. Both of those locations set r4 > as HSTATE_KVM_VCPU(r13) before calling kvmppc_hv_entry. > So, shift the r4 load instruction to kvmppc_hv_entry and > thus

Re: [PATCH v7 5/5] powerpc/64s: enable MMU_LAZY_TLB_SHOOTDOWN

2023-03-20 Thread Nicholas Piggin
On Mon Feb 27, 2023 at 11:33 PM AEST, Peter Zijlstra wrote: > On Sun, Feb 26, 2023 at 02:12:38PM -0800, Andrew Morton wrote: > > On Fri, 3 Feb 2023 17:18:37 +1000 Nicholas Piggin > > wrote: > > > > > On a 16-socket 192-core POWER8 system, the context_switch1_threads > > > benchmark from

[PATCH v2] powerpc/pseries/vas: Ignore VAS update for DLPAR if copy/paste is not enabled

2023-03-20 Thread Haren Myneni
The hypervisor supports user-mode NX from Power10. pseries_vas_dlpar_cpu() is called from lparcfg_write() to update VAS windows for DLPAR event in shared processor mode and the kernel gets -ENOTSUPP for HCALLs if the user-mode NX is not supported. The current VAS implementation also supports

[PATCH] soc: fsl: dpio: fix net interfaces probe on big endian

2023-03-20 Thread dullfire
From: Jonathan Currier qbman-portal failed to correct for system endianness, resulting in command time outs. Signed-off-by: Jonathan Currier --- drivers/soc/fsl/dpio/qbman-portal.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

RE: [PATCH V6 09/15] spi: Add stacked and parallel memories support in SPI core

2023-03-20 Thread Mahapatra, Amit Kumar
Hello, > -Original Message- > From: Jonas Gorski > Sent: Sunday, March 12, 2023 9:30 PM > To: Mahapatra, Amit Kumar > Cc: broo...@kernel.org; miquel.ray...@bootlin.com; rich...@nod.at; > vigne...@ti.com; ji...@kernel.org; tudor.amba...@microchip.com; > praty...@kernel.org; Mehta, Sanju

Re: [next-20230317][PPC/MLX5][bisected 4d5ab0a] Boot WARNING: CPU: 0 PID: 9 at net/core/dev.c:1928 call_netdevice_notifiers_info

2023-03-20 Thread Lorenzo Bianconi
> Greeting's > > Warning is seen while booting kernels from 6.3.0-rc3-next-20230317 on my > powerpc Power 10 LPAR > > Boots fine without warnings when below patch is reverted > > commit 4d5ab0ad964df178beba031b89429a601893ff61 > Author: Lorenzo Bianconi > Date: Thu Mar 9 13:25:31 2023 +0100

Re: [PATCH 2/2] ASoC: fsl: Specify driver name in ASoC card

2023-03-20 Thread Shengjiu Wang
On Thu, Mar 16, 2023 at 8:36 PM Alexander Stein < alexander.st...@ew.tq-group.com> wrote: > Set the snd_soc_card driver name which fixes the warning: > fsl-asoc-card sound: ASoC: driver name too long 'imx-audio-tlv320aic32x4' > -> 'imx-audio-tlv32' > > Signed-off-by: Alexander Stein > Acked-by:

Re: [PATCH 1/2] ASoC: fsl: define a common DRIVER_NAME

2023-03-20 Thread Shengjiu Wang
On Thu, Mar 16, 2023 at 8:36 PM Alexander Stein < alexander.st...@ew.tq-group.com> wrote: > Instead of copying the driver name manually, use a common define. > No functional change. > > Signed-off-by: Alexander Stein > Acked-by: Shengjiu Wang Best regards wang shengjiu > --- >

Re: [kvm-unit-tests v2 09/10] powerpc: Support powernv machine with QEMU TCG

2023-03-20 Thread Nicholas Piggin
On Mon Mar 20, 2023 at 7:47 PM AEST, Cédric Le Goater wrote: > Hello Nick, > > On 3/20/23 08:03, Nicholas Piggin wrote: > > This is a basic first pass at powernv support using OPAL (skiboot) > > firmware. > > > > The ACCEL is a bit clunky, now defaulting to tcg for powernv machine. > > It also

Re: [PATCH 1/2] ASoC: fsl: define a common DRIVER_NAME

2023-03-20 Thread Mark Brown
On Thu, 16 Mar 2023 13:36:10 +0100, Alexander Stein wrote: > Instead of copying the driver name manually, use a common define. > No functional change. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: fsl: define a common

[linux-next:master] BUILD REGRESSION 73f2c2a7e1d2b31fdd5faa6dfa151c437a6c0a5a

2023-03-20 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 73f2c2a7e1d2b31fdd5faa6dfa151c437a6c0a5a Add linux-next specific files for 20230320 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202303081807.lblwkmpx-...@intel.com https

Re: powerpc/pseries: Fix exception handling in pSeries_reconfig_add_node()

2023-03-20 Thread Nathan Lynch
Markus Elfring writes: > The label “out_err” was used to jump to another pointer check despite of > the detail in the implementation of the function > “pSeries_reconfig_add_node” > that it was determined already that the corresponding variable contained > a null pointer

[PATCH 1/2] serial: ucc_uart: Use uart_circ_empty()

2023-03-20 Thread Ilpo Järvinen
Use uart_circ_empty() rather than open coding it. Signed-off-by: Ilpo Järvinen --- drivers/tty/serial/ucc_uart.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c index 32c7a5b43f8e..e6bd1256a4e7 100644 ---

Re: [PATCH v2] soc: fsl: qe: remove unused qe_ic_from_irq function

2023-03-20 Thread Christophe Leroy
Le 20/03/2023 à 13:52, Tom Rix a écrit : > clang with W=1 reports > drivers/soc/fsl/qe/qe_ic.c:235:29: error: unused function >'qe_ic_from_irq' [-Werror,-Wunused-function] > static inline struct qe_ic *qe_ic_from_irq(unsigned int virq) > ^ > The use of this

[PATCH v6 3/4] EISA: Convert to use pci_bus_for_each_resource_p()

2023-03-20 Thread Andy Shevchenko
The pci_bus_for_each_resource_p() hides the iterator loop since it may be not used otherwise. With this, we may drop that iterator variable definition. Signed-off-by: Andy Shevchenko Reviewed-by: Krzysztof Wilczyński --- drivers/eisa/pci_eisa.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v6 0/4] Add pci_dev_for_each_resource() helper and update users

2023-03-20 Thread Andy Shevchenko
Provide two new helper macros to iterate over PCI device resources and convert users. Looking at it, refactor existing pci_bus_for_each_resource() and convert users accordingly. Changelog v6: - dropped unused variable in PPC code (LKP) Changelog v5: - renamed loop variable to minimize the clash

[PATCH v6 4/4] pcmcia: Convert to use pci_bus_for_each_resource_p()

2023-03-20 Thread Andy Shevchenko
The pci_bus_for_each_resource_p() hides the iterator loop since it may be not used otherwise. With this, we may drop that iterator variable definition. Signed-off-by: Andy Shevchenko Reviewed-by: Krzysztof Wilczyński Acked-by: Dominik Brodowski --- drivers/pcmcia/rsrc_nonstatic.c | 9

[PATCH v6 1/4] PCI: Introduce pci_dev_for_each_resource()

2023-03-20 Thread Andy Shevchenko
From: Mika Westerberg Instead of open-coding it everywhere introduce a tiny helper that can be used to iterate over each resource of a PCI device, and convert the most obvious users into it. While at it drop doubled empty line before pdev_sort_resources(). No functional changes intended.

[PATCH v6 2/4] PCI: Split pci_bus_for_each_resource_p() out of pci_bus_for_each_resource()

2023-03-20 Thread Andy Shevchenko
Refactor pci_bus_for_each_resource() in the same way as it's done in pci_dev_for_each_resource() case. This will allow to hide iterator inside the loop, where it's not used otherwise. No functional changes intended. Signed-off-by: Andy Shevchenko Reviewed-by: Krzysztof Wilczyński ---

[next-20230317][PPC/MLX5][bisected 4d5ab0a] Boot WARNING: CPU: 0 PID: 9 at net/core/dev.c:1928 call_netdevice_notifiers_info

2023-03-20 Thread Abdul Haleem
Greeting's Warning is seen while booting kernels from 6.3.0-rc3-next-20230317 on my powerpc Power 10 LPAR Boots fine without warnings when below patch is reverted commit 4d5ab0ad964df178beba031b89429a601893ff61 Author: Lorenzo Bianconi Date: Thu Mar 9 13:25:31 2023 +0100 net/mlx5e:

[PATCH v2] soc: fsl: qe: remove unused qe_ic_from_irq function

2023-03-20 Thread Tom Rix
clang with W=1 reports drivers/soc/fsl/qe/qe_ic.c:235:29: error: unused function 'qe_ic_from_irq' [-Werror,-Wunused-function] static inline struct qe_ic *qe_ic_from_irq(unsigned int virq) ^ The use of this function was removed with commit d7c2878cfcfa ("soc: fsl: qe:

Re: [kvm-unit-tests v2 09/10] powerpc: Support powernv machine with QEMU TCG

2023-03-20 Thread Cédric Le Goater
Hello Nick, On 3/20/23 08:03, Nicholas Piggin wrote: This is a basic first pass at powernv support using OPAL (skiboot) firmware. The ACCEL is a bit clunky, now defaulting to tcg for powernv machine. It also does not yet run in the run_tests.sh batch process, more work is needed to exclude

Re: [PATCH] powerpc/pseries/vas: Ignore VAS update for DLPAR if copy/paste is not enabled

2023-03-20 Thread Haren Myneni
On Tue, 2023-03-07 at 20:55 -0600, Nathan Lynch wrote: > Haren Myneni writes: > > The hypervisor supports user-mode NX from Power10. > > pseries_vas_dlpar_cpu() > > is called from lparcfg_write() to update VAS windows for DLPAR CPU > > event > > and the kernel gets -ENOTSUPP for HCALLs if the

Re: [PATCH] soc: fsl: qe: remove unused qe_ic_from_irq function

2023-03-20 Thread Christophe Leroy
Le 19/03/2023 à 16:37, Tom Rix a écrit : > clang with W=1 reports > drivers/soc/fsl/qe/qe_ic.c:235:29: error: unused function >'qe_ic_from_irq' [-Werror,-Wunused-function] > static inline struct qe_ic *qe_ic_from_irq(unsigned int virq) > ^ > This function is not

[kvm-unit-tests v2 10/10] powerpc/sprs: Test hypervisor registers on powernv machine

2023-03-20 Thread Nicholas Piggin
This enables HV privilege registers to be tested with the powernv machine. Signed-off-by: Nicholas Piggin --- powerpc/sprs.c | 31 --- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/powerpc/sprs.c b/powerpc/sprs.c index dd83dac..a7878ff 100644 ---

[kvm-unit-tests v2 09/10] powerpc: Support powernv machine with QEMU TCG

2023-03-20 Thread Nicholas Piggin
This is a basic first pass at powernv support using OPAL (skiboot) firmware. The ACCEL is a bit clunky, now defaulting to tcg for powernv machine. It also does not yet run in the run_tests.sh batch process, more work is needed to exclude certain tests (e.g., rtas) and adjust parameters (e.g.,

[kvm-unit-tests v2 08/10] powerpc: Discover runtime load address dynamically

2023-03-20 Thread Nicholas Piggin
The next change will load the kernels at different addresses depending on test options, so this needs to be reverted back to dynamic discovery. Signed-off-by: Nicholas Piggin --- powerpc/cstart64.S | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git

[kvm-unit-tests v2 07/10] powerpc/spapr_vpa: Add basic VPA tests

2023-03-20 Thread Nicholas Piggin
The VPA is a(n optional) memory structure shared between the hypervisor and operating system, defined by PAPR. This test defines the structure and adds registration, deregistration, and a few simple sanity tests. Signed-off-by: Nicholas Piggin --- lib/linux/compiler.h| 2 +

[kvm-unit-tests v2 06/10] powerpc/sprs: Specify SPRs with data rather than code

2023-03-20 Thread Nicholas Piggin
A significant rework that builds an array of 'struct spr', where each element describes an SPR. This makes various metadata about the SPR like name and access type easier to carry and use. Hypervisor privileged registers are described despite not being used at the moment for completeness, but

[kvm-unit-tests v2 05/10] powerpc: Indirect SPR accessor functions

2023-03-20 Thread Nicholas Piggin
Make overly-clever SPR accessor functions that allow a non-constant SPR number to be specified. This will be used to restructure test in the next change. Signed-off-by: Nicholas Piggin --- powerpc/sprs.c | 63 ++ 1 file changed, 54 insertions(+),

[kvm-unit-tests v2 04/10] powerpc: Add ISA v3.1 (POWER10) support to SPR test

2023-03-20 Thread Nicholas Piggin
This is a very basic detection that does not include all new SPRs. Signed-off-by: Nicholas Piggin --- powerpc/sprs.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/powerpc/sprs.c b/powerpc/sprs.c index ba4ddee..6ee6dba 100644 --- a/powerpc/sprs.c +++

[kvm-unit-tests v2 03/10] powerpc: abstract H_CEDE calls into a sleep functions

2023-03-20 Thread Nicholas Piggin
This consolidates several implementations, and it no longer leaves MSR[EE] enabled after the decrementer interrupt is handled, but rather disables it on return. The handler no longer allows a continuous ticking, but rather dec has to be re-armed and EE re-enabled (e.g., via H_CEDE hcall) each

[kvm-unit-tests v2 02/10] powerpc: add local variant of SPR test

2023-03-20 Thread Nicholas Piggin
This adds the non-migration variant of the SPR test to the matrix, which can be simpler to run and debug. Reviewed-by: Thomas Huth Signed-off-by: Nicholas Piggin --- powerpc/unittests.cfg | 4 1 file changed, 4 insertions(+) diff --git a/powerpc/unittests.cfg b/powerpc/unittests.cfg

[kvm-unit-tests v2 01/10] MAINTAINERS: Update powerpc list

2023-03-20 Thread Nicholas Piggin
KVM development on powerpc has moved to the Linux on Power mailing list, as per linux.git commit 19b27f37ca97d ("MAINTAINERS: Update powerpc KVM entry"). Signed-off-by: Nicholas Piggin --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS

[kvm-unit-tests v2 00/10] powerpc: updates, P10, PNV support

2023-03-20 Thread Nicholas Piggin
Since v1 series, I fixed the sleep API and implementation in patch 2 as noted by Thomas. Added usleep and msleep variants to match [um]delay we already have. Also some minor tidy ups and fixes mainly with reporting format in the sprs test rework. And added PowerNV support to the harness with the

CPU Hotplug optimization: offcputime analysis

2023-03-20 Thread Aboorva Devarajan
CPU Hotplug smt=off operation on a maximum configuration ppc64le system with 1920 logical CPUs takes more than 59 minutes to complete. Several attempts made to reduce the time consumption of CPU hotplug operation is discussed in this thread below: