Hello Baoquan,
On 29/02/24 19:21, Baoquan He wrote:
Hi Sourabh,
On 02/26/24 at 02:11pm, Sourabh Jain wrote:
Commit 247262756121 ("crash: add generic infrastructure for crash
hotplug support") added a generic infrastructure that allows
architectures to selectively update the kdump image
Greetings,
This is tied to gcc version. Build failure is seen while using gcc-8.5.x
On 2/29/24 20:17, Jakub Kicinski wrote:
On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote:
I do not see other solution than this, otherwise we have to add more
pollution to include/linux/netdevice.h
Right
> On 01-Mar-2024, at 3:48 AM, Michael Ellerman wrote:
>
> Sachin Sant writes:
>> Powerpc specific selftests (specifically powerpc/primitives) included in
>> linux-next
>> tree fails to build with following error
>>
>> gcc -std=gnu99 -O2 -Wall -Wer
John Paul Adrian Glaubitz writes:
> Hi Michael,
>
> On Thu, 2024-02-29 at 17:42 +1100, Michael Ellerman wrote:
>> > There seems to be a regression in the kernel which affects PowerPC 970
>> > machines,
>> > i.e. PowerMac G5 CPUs. The issue needs to be bisected and reported
>> > upstream.
>>
>>
Sachin Sant writes:
>> On 29-Feb-2024, at 7:52 AM, Michael Ellerman wrote:
>> Tasmiya Nalatwad writes:
>>> Greetings,
>>>
>>> [netdev] Build failure on powerpc
>>> latest netdev 6.8.0-rc5-auto-g1ce7d306ea63 fails to build on powerpc
>>> below traces
>>
>> Please include the defconfig you're
Andy Shevchenko writes:
> On Thu, Feb 29, 2024 at 3:53 PM Sachin Sant wrote:
>>
>> Powerpc specific selftests (specifically powerpc/primitives) included in
>> linux-next
>> tree fails to build with following error
>>
>> gcc -std=gnu99 -O2 -Wall -Wer
Sachin Sant writes:
> Powerpc specific selftests (specifically powerpc/primitives) included in
> linux-next
> tree fails to build with following error
>
> gcc -std=gnu99 -O2 -Wall -Werror
> -DGIT_VERSION='"next-20240229-0-gf303a3e2bcfb-dirty"'
> -I/home/
Apply 'dbi' as the primary name for dbi_base register space in line with
Designware common binding. Attempt resource acquisition using 'dbi' first
via platform_get_resource_byname(). If encountering older device tree
files, gracefully fallback to 'regs', issuing a warning message.
Signed-off-by:
On Thu, Feb 29, 2024 at 11:25:21PM +1100, Michael Ellerman wrote:
> From: Christophe Leroy
Acked-by: Segher Boessenkool
Segher
On Thu, Feb 29, 2024 at 11:25:20PM +1100, Michael Ellerman wrote:
> With the addition of the machine directives, these are no longer simple
> 1-2 liner macros. So modernise them to be static inlines and use named
> asm parameters.
>
> Signed-off-by: Michael Ellerman
You got rid of the
On Thu, Feb 29, 2024 at 11:25:18PM +1100, Michael Ellerman wrote:
> There are multiple decodings for the "dcbt" mnemonic, so the assembler
> has to pick one.
>
> That requires passing -many to the assembler, which is not recommended.
>
> Without -many the clang 14 / binutils 2.38 build fails
On Thu, Feb 29, 2024 at 3:53 PM Sachin Sant wrote:
>
> Powerpc specific selftests (specifically powerpc/primitives) included in
> linux-next
> tree fails to build with following error
>
> gcc -std=gnu99 -O2 -Wall -Werror
> -DGIT_VERSION='"next-20240229-0-gf303a3e2bcfb
Le 29/02/2024 à 02:09, Erhard Furtner a écrit :
> On Mon, 12 Dec 2022 14:31:35 +1000
> "Nicholas Piggin" wrote:
>
>> On Thu Dec 1, 2022 at 7:44 AM AEST, Erhard F. wrote:
>>> Getting this at boot sometimes, but not always (PowerMac G4 DP, kernel
>>> 6.0.9):
>>>
>>> [...]
>>> Freeing unused
Hi Andy,
On Thu, 29 Feb 2024 17:20:59 +0200
Andy Shevchenko wrote:
> On Thu, Feb 29, 2024 at 03:15:52PM +0100, Herve Codina wrote:
> > QMC channels support runtime timeslots changes but nothing is done at
> > the QMC HDLC driver to handle these changes.
> >
> > Use existing IFACE ioctl in
On Thu, Feb 29, 2024 at 10:41:08PM +1100, Michael Ellerman wrote:
> 32-bit powerpc kernels can be built for one of 5 sub-arches, see
> Kconfig.cputype:
>
> PPC_BOOK3S_32: "512x/52xx/6xx/7xx/74xx/82xx/83xx/86xx"
> PPC_85xx: "Freescale 85xx"
> PPC_8xx: "Freescale 8xx"
> 40x: "AMCC 40x"
>
On Thu, Feb 29, 2024 at 03:15:48PM +0100, Herve Codina wrote:
> Hi,
>
> This series introduces the QMC HDLC support.
>
> Patches were previously sent as part of a full feature series and were
> previously reviewed in that context:
> "Add support for QMC HDLC, framer infrastructure and PEF2256
On Thu, Feb 29, 2024 at 03:15:52PM +0100, Herve Codina wrote:
> QMC channels support runtime timeslots changes but nothing is done at
> the QMC HDLC driver to handle these changes.
>
> Use existing IFACE ioctl in order to configure the timeslots to use.
...
> + bitmap_scatter(ts_mask, map,
On Thu, Feb 29, 2024 at 03:15:51PM +0100, Herve Codina wrote:
> From: Andy Shevchenko
>
> These helpers scatters or gathers a bitmap with the help of the mask
> position bits parameter.
>
> bitmap_scatter() does the following:
> src: 01011010
> ||
>
On Thu, Feb 29, 2024 at 03:15:49PM +0100, Herve Codina wrote:
> The QMC HDLC driver provides support for HDLC using the QMC (QUICC
> Multichannel Controller) to transfer the HDLC data.
...
+ array_size.h
+ bug.h
> +#include
> +#include
+ device.h
+ err.h
> +#include
> +#include
>
On Thu, Feb 29, 2024 at 3:53 PM Eric Dumazet wrote:
>
> On Thu, Feb 29, 2024 at 3:47 PM Jakub Kicinski wrote:
> >
> > On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote:
> > > I do not see other solution than this, otherwise we have to add more
> > > pollution to include/linux/netdevice.h
> >
On Thu, Feb 29, 2024 at 3:47 PM Jakub Kicinski wrote:
>
> On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote:
> > I do not see other solution than this, otherwise we have to add more
> > pollution to include/linux/netdevice.h
>
> Right :(
>
> > diff --git a/include/linux/netdevice.h
On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote:
> I do not see other solution than this, otherwise we have to add more
> pollution to include/linux/netdevice.h
Right :(
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index
>
Add framer support in the fsl_qmc_hdlc driver in order to be able to
signal carrier changes to the network stack based on the framer status
Also use this framer to provide information related to the E1/T1 line
interface on IF_GET_IFACE and configure the line interface according to
IF_IFACE_{E1,T1}
QMC channels support runtime timeslots changes but nothing is done at
the QMC HDLC driver to handle these changes.
Use existing IFACE ioctl in order to configure the timeslots to use.
Signed-off-by: Herve Codina
Reviewed-by: Christophe Leroy
Acked-by: Jakub Kicinski
---
From: Andy Shevchenko
These helpers scatters or gathers a bitmap with the help of the mask
position bits parameter.
bitmap_scatter() does the following:
src: 01011010
||
+--+|
| ++
| |++|||
| ||
After contributing the driver, add myself as the maintainer for the
Freescale QMC HDLC driver.
Signed-off-by: Herve Codina
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8d1052fa6a69..15cd3a8e5866 100644
--- a/MAINTAINERS
+++
The QMC HDLC driver provides support for HDLC using the QMC (QUICC
Multichannel Controller) to transfer the HDLC data.
Signed-off-by: Herve Codina
Reviewed-by: Christophe Leroy
Acked-by: Jakub Kicinski
---
drivers/net/wan/Kconfig| 12 +
drivers/net/wan/Makefile | 1 +
Hi,
This series introduces the QMC HDLC support.
Patches were previously sent as part of a full feature series and were
previously reviewed in that context:
"Add support for QMC HDLC, framer infrastructure and PEF2256 framer" [1]
In order to ease the merge, the full feature series has been
On Thu, 29 Feb 2024 15:58:06 +0200
Andy Shevchenko wrote:
> On Thu, Feb 29, 2024 at 01:56:05PM +0100, Herve Codina wrote:
> > On Thu, 22 Feb 2024 17:49:40 +0200
> > Andy Shevchenko wrote:
> > > On Thu, Feb 22, 2024 at 03:22:18PM +0100, Herve Codina wrote:
>
> ...
>
> > I've got an issue
On Thu, Feb 29, 2024 at 01:56:05PM +0100, Herve Codina wrote:
> On Thu, 22 Feb 2024 17:49:40 +0200
> Andy Shevchenko wrote:
> > On Thu, Feb 22, 2024 at 03:22:18PM +0100, Herve Codina wrote:
...
> I've got an issue with guard(spinlock_irqsave).
No, you got an issue with sparse.
> I have the
Powerpc specific selftests (specifically powerpc/primitives) included in
linux-next
tree fails to build with following error
gcc -std=gnu99 -O2 -Wall -Werror
-DGIT_VERSION='"next-20240229-0-gf303a3e2bcfb-dirty"'
-I/home/sachin/linux-next/tools/testing/selftests/powerpc/include
-I/h
Hi Sourabh,
On 02/26/24 at 02:11pm, Sourabh Jain wrote:
> Commit 247262756121 ("crash: add generic infrastructure for crash
> hotplug support") added a generic infrastructure that allows
> architectures to selectively update the kdump image component during CPU
> or memory add/remove events
> On 29-Feb-2024, at 3:07 PM, Madhavan Srinivasan wrote:
>
> When running `make -C powerpc/pmu run_tests` from top level selftests
> directory, currently this error is being reported
>
> make: Entering directory
> '/home/maddy/linux/tools/testing/selftests/powerpc/pmu'
> Makefile:40:
> On 29-Feb-2024, at 7:52 AM, Michael Ellerman wrote:
>
> Tasmiya Nalatwad writes:
>> Greetings,
>>
>> [netdev] Build failure on powerpc
>> latest netdev 6.8.0-rc5-auto-g1ce7d306ea63 fails to build on powerpc
>> below traces
>
> Please include the defconfig you're building, and the
Hello Mani,
On Sat, Feb 24, 2024 at 12:24:16PM +0530, Manivannan Sadhasivam wrote:
> All of the APIs are missing the Kernel-doc comments. Hence, add them.
>
> Signed-off-by: Manivannan Sadhasivam
> ---
> drivers/pci/controller/dwc/pcie-designware-ep.c | 92
> +
> 1
Hi Andy,
On Thu, 22 Feb 2024 17:49:40 +0200
Andy Shevchenko wrote:
> On Thu, Feb 22, 2024 at 03:22:18PM +0100, Herve Codina wrote:
> > Add framer support in the fsl_qmc_hdlc driver in order to be able to
> > signal carrier changes to the network stack based on the framer status
> > Also use
On Sat, Feb 24, 2024 at 12:24:09PM +0530, Manivannan Sadhasivam wrote:
> For DWC glue drivers supporting PERST# (currently Qcom and Tegra194), some
> of the DWC resources like eDMA should be cleaned up during the PERST#
> assert time.
>
> So let's introduce a dw_pcie_ep_cleanup() API that could
Running event
hv_gpci/dispatch_timebase_by_processor_processor_time_in_timebase_cycles,phys_processor_idx=0/
in one of the system throws below error:
---Logs---
# perf list | grep
hv_gpci/dispatch_timebase_by_processor_processor_time_in_timebase_cycles
From: Christophe Leroy
cpu-as-y is there to force assembler building options. But there is no
need for that. GCC is passed the necessary options and it automatically
pass the appropriate option to GAS.
GCC is given -maltivec when relevant, so no need for -Wa,-maltivec
either.
And -Wa,-many is
There's an almost identical code sequence to specify load/store access
hints in __copy_tofrom_user_power7(), copypage_power7() and
memcpy_power7().
Move the sequence into a common macro, which is passed the registers to
use as they differ slightly.
There also needs to be a copy in the selftests,
With the addition of the machine directives, these are no longer simple
1-2 liner macros. So modernise them to be static inlines and use named
asm parameters.
Signed-off-by: Michael Ellerman
---
arch/powerpc/include/asm/reg_fsl_emb.h | 32 +-
1 file changed, 21
Binutils 2.38 complains about the use of mfpmr when building
ppc6xx_defconfig:
CC arch/powerpc/kernel/pmc.o
{standard input}: Assembler messages:
{standard input}:45: Error: unrecognized opcode: `mfpmr'
{standard input}:56: Error: unrecognized opcode: `mtpmr'
This is because by
There are multiple decodings for the "dcbt" mnemonic, so the assembler
has to pick one.
That requires passing -many to the assembler, which is not recommended.
Without -many the clang 14 / binutils 2.38 build fails with:
arch/powerpc/kernel/exceptions-64s.S:2976: Error: junk at end of line:
On Thu, Feb 29, 2024 at 01:49:58PM +1000, Nicholas Piggin wrote:
> On Thu Feb 29, 2024 at 1:04 AM AEST, Andrew Jones wrote:
> > Calculating the offset of an address is image specific, which is
> > architecture specific. Until now, all architectures and architecture
> > configurations which select
simple_realloc() frees the original buffer (ptr) even if the
reallocation failed.
Fix it to behave like standard realloc() and only free the original
buffer if the reallocation succeeded.
Signed-off-by: Michael Ellerman
---
arch/powerpc/boot/simple_alloc.c | 5 +++--
1 file changed, 3
socrates_gc_mode is defined at the top-level but then only used inside
an #ifdef CONFIG_FB_MB862XX_LIME, leading to an error with some configs:
drivers/video/fbdev/mb862xx/mb862xxfbdrv.c:36:31: error: ‘socrates_gc_mode’
defined but not used
36 | static struct mb862xx_gc_mode
On Thu, Feb 29, 2024 at 01:31:52PM +1000, Nicholas Piggin wrote:
> On Thu Feb 29, 2024 at 1:04 AM AEST, Andrew Jones wrote:
...
> > diff --git a/lib/stack.h b/lib/stack.h
> > index 10fc2f793354..6edc84344b51 100644
> > --- a/lib/stack.h
> > +++ b/lib/stack.h
> > @@ -11,17 +11,27 @@
> > #include
On 29/02/2024 08:55, Eric Dumazet wrote:
On Thu, Feb 29, 2024 at 9:04 AM Tasmiya Nalatwad
wrote:
Greetings,
I have tried the patch provided below. Moving struct to file
"net/core/rtnetlink.c" is not resolving the problem. Please find the
below traces.
--- Traces ---
In file included from
These functions can all be static, make them so, which also fixes no
previous prototype warnings.
Signed-off-by: Michael Ellerman
---
arch/powerpc/platforms/85xx/bsc913x_qds.c | 2 +-
arch/powerpc/platforms/85xx/bsc913x_rdb.c | 2 +-
arch/powerpc/platforms/85xx/ge_imp3a.c| 2 +-
3 files
32-bit powerpc kernels can be built for one of 5 sub-arches, see
Kconfig.cputype:
PPC_BOOK3S_32: "512x/52xx/6xx/7xx/74xx/82xx/83xx/86xx"
PPC_85xx: "Freescale 85xx"
PPC_8xx: "Freescale 8xx"
40x: "AMCC 40x"
44x: "AMCC 44x, 46x or 47x"
By default none of these are built for a plain
Latest changes suggested below works, and the issue is not seen.
Tested-by: Tasmiya Nalatwad
On 2/29/24 14:25, Eric Dumazet wrote:
On Thu, Feb 29, 2024 at 9:04 AM Tasmiya Nalatwad
wrote:
Greetings,
I have tried the patch provided below. Moving struct to file
"net/core/rtnetlink.c" is not
Hello Mani,
On Sat, Feb 24, 2024 at 12:24:13PM +0530, Manivannan Sadhasivam wrote:
> "core_init_notifier" flag is set by the glue drivers requiring refclk from
> the host to complete the DWC core initialization. Also, those drivers will
> send a notification to the EPF drivers once the
Build breaks when executing make with run_tests for sub-folders
under powerpc. This is because, CFLAGS and GIT_VERSION macros are
defined in Makefile of toplevel powerpc folder.
make: Entering directory '/home/maddy/linux/tools/testing/selftests/powerpc/mm'
gcc hugetlb_vs_thp_test.c
When running `make -C powerpc/pmu run_tests` from top level selftests
directory, currently this error is being reported
make: Entering directory '/home/maddy/linux/tools/testing/selftests/powerpc/pmu'
Makefile:40: warning: overriding recipe for target 'emit_tests'
../../lib.mk:111: warning:
In some powerpc/ sub-folder Makefiles, CFLAGS are
defined before lib.mk include. Clean it up by
re-ordering it to follow after the mk include.
This is needed to support sub-folders in powerpc/
buildable on its own.
Signed-off-by: Madhavan Srinivasan
---
.../selftests/powerpc/benchmarks/Makefile
Thanks all for the reply.
On 2024/2/29 14:18, Michael Ellerman wrote:
Aneesh Kumar K.V writes:
Michael Ellerman writes:
Kunwu Chan writes:
On 2024/2/26 18:49, Michael Ellerman wrote:
Kunwu Chan writes:
This part was commented from commit 6d492ecc6489
("powerpc/THP: Add code to handle
On Thu, Feb 29, 2024 at 9:04 AM Tasmiya Nalatwad
wrote:
>
> Greetings,
>
> I have tried the patch provided below. Moving struct to file
> "net/core/rtnetlink.c" is not resolving the problem. Please find the
> below traces.
>
> --- Traces ---
>
> In file included from ./include/linux/rbtree.h:24,
From: Peter Xu
They're not used anymore, drop all of them.
Signed-off-by: Peter Xu
---
arch/arm/include/asm/pgtable-2level.h| 1 -
arch/arm/include/asm/pgtable-3level.h| 1 -
arch/powerpc/include/asm/book3s/64/pgtable.h | 4 +---
arch/powerpc/include/asm/pgtable.h
From: Peter Xu
pud_large() is always defined as pud_leaf(). Merge their usages. Chose
pud_leaf() because pud_leaf() is a global API, while pud_large() is not.
Signed-off-by: Peter Xu
---
arch/powerpc/mm/book3s64/pgtable.c | 2 +-
arch/s390/boot/vmem.c | 2 +-
From: Peter Xu
pmd_large() is always defined as pmd_leaf(). Merge their usages. Chose
pmd_leaf() because pmd_leaf() is a global API, while pmd_large() is not.
Signed-off-by: Peter Xu
---
arch/arm/mm/dump.c | 4 ++--
arch/powerpc/mm/book3s64/pgtable.c | 2 +-
From: Peter Xu
pud_leaf() has a fallback macro defined in include/linux/pgtable.h already.
Drop the extra two for x86.
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: Borislav Petkov
Cc: Dave Hansen
Cc: x...@kernel.org
Signed-off-by: Peter Xu
---
arch/x86/include/asm/pgtable.h | 1 -
From: Peter Xu
p4d_large() is always defined as p4d_leaf(). Merge their usages. Chose
p4d_leaf() because p4d_leaf() is a global API, while p4d_large() is not.
Only x86 has p4d_leaf() defined as of now. So it also means after this
patch we removed all p4d_large() usages.
Cc: Thomas Gleixner
From: Peter Xu
They're the same macros underneath. Drop pXd_is_leaf(), instead always use
pXd_leaf().
At the meantime, instead of renames, drop the pXd_is_leaf() fallback
definitions directly in arch/powerpc/include/asm/pgtable.h. because similar
fallback macros for pXd_leaf() are already
From: Peter Xu
The two definitions are the same. The only difference is that pXd_large()
is only defined with THP selected, and only on book3s 64bits.
Instead of implementing it twice, make pXd_large() a macro to pXd_leaf().
Define it unconditionally just like pXd_leaf(). This helps to
From: Peter Xu
[based on latest akpm/mm-unstable, commit 1274e7646240]
v2:
- Added patch "mm/ppc: Replace pXd_is_leaf() with pXd_leaf()" [Christophe]
- Added patch "mm/x86: Drop two unnecessary pud_leaf() definitions" [syzbot]
- Touched up two more comments which also referenced pmd_large()
Hello
On 29/02/24 12:58, Baoquan He wrote:
On 02/26/24 at 02:11pm, Sourabh Jain wrote:
..snip...
diff --git a/kernel/crash_core.c b/kernel/crash_core.c
index 70fa8111a9d6..630c4fd7ea39 100644
--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c
@@ -496,7 +496,7 @@ static
On 29/02/24 13:41, Baoquan He wrote:
On 02/26/24 at 02:11pm, Sourabh Jain wrote:
Move the following functions form kexec/{file_load_64.c => ranges.c} and
make them public so that components other KEXEC_FILE can also use these
^
Hello Baoquan,
On 29/02/24 12:58, Baoquan He wrote:
On 02/26/24 at 02:11pm, Sourabh Jain wrote:
..snip...
diff --git a/kernel/crash_core.c b/kernel/crash_core.c
index 70fa8111a9d6..630c4fd7ea39 100644
--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c
@@ -496,7 +496,7 @@ static
Hi Michael,
On Thu, 2024-02-29 at 17:42 +1100, Michael Ellerman wrote:
> > There seems to be a regression in the kernel which affects PowerPC 970
> > machines,
> > i.e. PowerMac G5 CPUs. The issue needs to be bisected and reported upstream.
>
> I have a quad G5 that is booting mainline happily.
On 02/26/24 at 02:11pm, Sourabh Jain wrote:
> Move the following functions form kexec/{file_load_64.c => ranges.c} and
> make them public so that components other KEXEC_FILE can also use these
^
'than' missed?
>
Greetings,
I have tried the patch provided below. Moving struct to file
"net/core/rtnetlink.c" is not resolving the problem. Please find the
below traces.
--- Traces ---
In file included from ./include/linux/rbtree.h:24,
from ./include/linux/mm_types.h:11,
On Wed, 21 Feb 2024 13:37:10 +0100,
Richard Fitzgerald wrote:
>
> snd_soc_card_get_kcontrol() must be holding a read lock on
> card->controls_rwsem while walking the controls list.
>
> Compare with snd_ctl_find_numid().
>
> The existing function is renamed snd_soc_card_get_kcontrol_locked()
>
On 29/02/24 11:26, Baoquan He wrote:
On 02/29/24 at 10:35am, Sourabh Jain wrote:
Hello Baoquan,
Do you have any comments or suggestions for this patch series, especially
for this patch?
Have applied this series and reviewing, will ack or add comment if any
concern. Thanks.
Thanks,
73 matches
Mail list logo
