Re: [PATCH 12/19] thermal: cpuidle_cooling: Adjust includes to remove of_device.h

2023-04-01 Thread Daniel Lezcano
of_device.h. Signed-off-by: Rob Herring --- Please ack and I will take the series via the DT tree. Acked-by: Daniel Lezcano -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.c

Re: [PATCH 11/19] clocksource: ingenic: Add explicit include for cpuhotplug.h

2023-04-01 Thread Daniel Lezcano
of function ‘cpuhp_setup_state’ The of_platform.h header is not necessary either, so it and of_address.h can be dropped. Signed-off-by: Rob Herring --- Please ack and I will take the series via the DT tree. --- Acked-by: Daniel Lezcano -- <http://www.linaro.org/> Linaro.org │ Open source so

Re: [PATCH v3 0/2] Selftest for cpuidle latency measurement

2020-07-21 Thread Daniel Lezcano
On 21/07/2020 14:42, Pratik Rajesh Sampat wrote: > v2: https://lkml.org/lkml/2020/7/17/369 > Changelog v2-->v3 > Based on comments from Gautham R. Shenoy adding the following in the > selftest, > 1. Grepping modules to determine if already loaded > 2. Wrapper to enable/disable states > 3.

Re: [PATCH -next] cpuidle/pseries: Make symbol 'pseries_idle_driver' static

2020-07-16 Thread Daniel Lezcano
On 16/07/2020 14:56, Michael Ellerman wrote: > On Tue, 14 Jul 2020 22:24:24 +0800, Wei Yongjun wrote: >> The sparse tool complains as follows: >> >> drivers/cpuidle/cpuidle-pseries.c:25:23: warning: >> symbol 'pseries_idle_driver' was not declared. Should it be static? >> >> 'pseries_idle_driver'

Re: [PATCH] clocksource/drivers/timer-microchip-pit64b: Select CONFIG_TIMER_OF

2020-04-27 Thread Daniel Lezcano
On 26/04/2020 14:43, Michael Ellerman wrote: > This driver is an OF driver, it depends on OF, and uses > TIMER_OF_DECLARE, so it should select CONFIG_TIMER_OF. > > Without CONFIG_TIMER_OF enabled this can lead to warnings such as: > > powerpc-linux-ld: warning: orphan section

Re: [PATCH v10 14/18] drivers/clocksource: timer-fsl-ftm: use common header for FlexTimer #defines

2019-04-25 Thread Daniel Lezcano
On 02/04/2019 08:30, William Breathitt Gray wrote: > From: Patrick Havelange > > Common #defines have been moved to "linux/fsl/ftm.h". Thus making use of > this file. > Also FTM_SC_CLK_SHIFT has been renamed to FTM_SC_CLK_MASK_SHIFT. > > Reviewed-by: Esben Haabendal > Signed-off-by: Patrick

Re: [PATCH v2 3/7] drivers/clocksource: timer-fsl-ftm: use common header for FlexTimer #defines

2019-04-11 Thread Daniel Lezcano
On 06/03/2019 12:12, Patrick Havelange wrote: > Common #defines have been moved to "linux/fsl/ftm.h". Thus making use of > this file. > Also FTM_SC_CLK_SHIFT has been renamed to FTM_SC_CLK_MASK_SHIFT. > > Signed-off-by: Patrick Havelange > Reviewed-by: Esben Haabenda

Re: [PATCH 1/2] cpuidle : auto-promotion for cpuidle states

2019-04-04 Thread Daniel Lezcano
Hi Abhishek, thanks for taking the time to test the different scenario and give us the numbers. On 01/04/2019 07:11, Abhishek wrote: > > > On 03/22/2019 06:56 PM, Daniel Lezcano wrote: >> On 22/03/2019 10:45, Rafael J. Wysocki wrote: >>> On Fri, Mar 22, 2019

Re: [PATCH 1/2] cpuidle : auto-promotion for cpuidle states

2019-03-22 Thread Daniel Lezcano
On 22/03/2019 10:45, Rafael J. Wysocki wrote: > On Fri, Mar 22, 2019 at 8:31 AM Abhishek Goel > wrote: >> >> Currently, the cpuidle governors (menu /ladder) determine what idle state >> an idling CPU should enter into based on heuristics that depend on the >> idle history on that CPU. Given that

Re: [PATCH 3/8] drivers/clocksource: timer-fsl-ftm: use common header for FlexTimer #defines

2019-02-18 Thread Daniel Lezcano
On 18/02/2019 15:03, Patrick Havelange wrote: Changelog please > Signed-off-by: Patrick Havelange > Reviewed-by: Esben Haabendal > --- > drivers/clocksource/timer-fsl-ftm.c | 15 ++- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git

Re: [RFC/PATCH 1/2] cpuidle: Allow idle-states to be disabled at start

2016-08-25 Thread Daniel Lezcano
On 08/25/2016 03:46 PM, Balbir Singh wrote: > > > On 25/08/16 01:06, Daniel Lezcano wrote: >> On 08/24/2016 04:48 PM, Balbir Singh wrote: >>> >>> >>> On 25/08/16 00:44, Daniel Lezcano wrote: >>>> On 08/19/2016 12:26 AM, Gauth

Re: [RFC/PATCH 1/2] cpuidle: Allow idle-states to be disabled at start

2016-08-24 Thread Daniel Lezcano
On 08/24/2016 04:48 PM, Balbir Singh wrote: > > > On 25/08/16 00:44, Daniel Lezcano wrote: >> On 08/19/2016 12:26 AM, Gautham R. Shenoy wrote: >>> From: "Gautham R. Shenoy" <e...@linux.vnet.ibm.com> >>> >>> Currently all the idle states

Re: [RFC/PATCH 1/2] cpuidle: Allow idle-states to be disabled at start

2016-08-24 Thread Daniel Lezcano
On 08/19/2016 12:26 AM, Gautham R. Shenoy wrote: > From: "Gautham R. Shenoy" > > Currently all the idle states registered by a cpu-idle driver are > enabled by default. This patch adds a mechanism which allows the > driver to hint if an idle-state should start in a

Re: [PATCH v5] cpuidle: Fix last_residency division

2016-07-01 Thread Daniel Lezcano
e_us_delta. Reported-by: Anton Blanchard <an...@samba.org> Bisected-by: Shilpasri G Bhat <shilpa.b...@linux.vnet.ibm.com> Signed-off-by: Shreyas B. Prabhu <shre...@linux.vnet.ibm.com> --- Acked-by: Daniel Lezcano <daniel.lezc...@linaro.org> -- <http://www.linaro.or

Re: [PATCH v4] cpuidle: Fix last_residency division

2016-07-01 Thread Daniel Lezcano
On 06/30/2016 05:37 PM, Nicolas Pitre wrote: On Thu, 30 Jun 2016, Daniel Lezcano wrote: [ ... ] + if (likely(nsec < DIV_APPROXIMATION_THRESHOLD)) { + u32 usec = nsec; + + usec += usec >> 5; + usec = usec >> 10; + +

Re: [PATCH v4] cpuidle: Fix last_residency division

2016-06-30 Thread Daniel Lezcano
On 06/30/2016 04:34 PM, Shreyas B. Prabhu wrote: Snooze is a poll idle state in powernv and pseries platforms. Snooze has a timeout so that if a cpu stays in snooze for more than target residency of the next available idle state, then it would exit thereby giving chance to the cpuidle governor

Re: [PATCH v3] cpuidle: Fix last_residency division

2016-06-29 Thread Daniel Lezcano
On 06/29/2016 09:06 AM, Shreyas B. Prabhu wrote: Snooze is a poll idle state in powernv and pseries platforms. Snooze has a timeout so that if a cpu stays in snooze for more than target residency of the next available idle state, then it would exit thereby giving chance to the cpuidle governor

Re: [PATCH v2] cpuidle: Fix last_residency division

2016-06-24 Thread Daniel Lezcano
On 06/24/2016 11:00 AM, David Laight wrote: From: Shreyas B. Prabhu Sent: 24 June 2016 09:24 Snooze is a poll idle state in powernv and pseries platforms. Snooze has a timeout so that if a cpu stays in snooze for more than target residency of the next available idle state, then it would exit

Re: [PATCH] cpuidle/powernv: Fix snooze timeout

2016-06-23 Thread Daniel Lezcano
On 06/23/2016 03:35 PM, Shreyas B Prabhu wrote: On 06/23/2016 03:31 PM, Daniel Lezcano wrote: On 06/23/2016 11:28 AM, Balbir Singh wrote: [ ... ] cpuidle_enter_state() { [...] time_start = local_clock(); [enter idle state] time_end = local_clock

Re: [PATCH] cpuidle/powernv: Fix snooze timeout

2016-06-23 Thread Daniel Lezcano
On 06/23/2016 11:28 AM, Balbir Singh wrote: [ ... ] cpuidle_enter_state() { [...] time_start = local_clock(); [enter idle state] time_end = local_clock(); /* * local_clock() returns the time in nanosecond, let's shift * by 10 (divide

Re: [PATCH v6 10/11] cpuidle/powernv: Add support for POWER ISA v3 idle states

2016-06-13 Thread Daniel Lezcano
CR value. > > This patch adds support for this new mechanism in cpuidle powernv driver. > > Cc: Rafael J. Wysocki <rafael.j.wyso...@intel.com> > Cc: Daniel Lezcano <daniel.lezc...@linaro.org> > Cc: Rob Herring <robh...@kernel.org> > Cc: Lorenzo Pieralisi <

Re: [PATCH v6 09/11] cpuidle/powernv: Use CPUIDLE_STATE_MAX instead of MAX_POWERNV_IDLE_STATES

2016-06-13 Thread Daniel Lezcano
On Wed, Jun 08, 2016 at 11:54:29AM -0500, Shreyas B. Prabhu wrote: > Use cpuidle's CPUIDLE_STATE_MAX macro instead of powernv specific > MAX_POWERNV_IDLE_STATES. > > Cc: Rafael J. Wysocki <rafael.j.wyso...@intel.com> > Cc: Daniel Lezcano <daniel.lezc...@linaro.org> >

Re: [PATCH v4 09/10] cpuidle/powernv: Add support for POWER ISA v3 idle states

2016-05-30 Thread Daniel Lezcano
in cpuidle powernv driver. Cc: Rafael J. Wysocki <rafael.j.wyso...@intel.com> Cc: Daniel Lezcano <daniel.lezc...@linaro.org> Cc: linux...@vger.kernel.org Cc: Michael Ellerman <m...@ellerman.id.au> Cc: Paul Mackerras <pau...@ozlabs.org> Cc: linuxppc-dev@lists.ozlabs.org Reviewed-

[PATCH 65/74] powerpc/time: Migrate to new 'set-state' interface

2015-08-10 Thread Daniel Lezcano
...@linaro.org Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/powerpc/kernel/time.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c index 4392250..1be1092 100644 --- a/arch/powerpc

Re: [PATCH 0/3] cpuidle: updates related to tick_broadcast_enter() failures

2015-05-12 Thread Daniel Lezcano
On 05/12/2015 01:31 AM, Rafael J. Wysocki wrote: On Monday, May 11, 2015 07:40:41 PM Daniel Lezcano wrote: On 05/10/2015 01:15 AM, Rafael J. Wysocki wrote: On Saturday, May 09, 2015 10:33:05 PM Rafael J. Wysocki wrote: On Saturday, May 09, 2015 10:11:41 PM Rafael J. Wysocki wrote

Re: [PATCH 0/3] cpuidle: updates related to tick_broadcast_enter() failures

2015-05-12 Thread Daniel Lezcano
On 05/12/2015 03:23 PM, Rafael J. Wysocki wrote: On Tuesday, May 12, 2015 10:41:35 AM Daniel Lezcano wrote: On 05/12/2015 01:31 AM, Rafael J. Wysocki wrote: On Monday, May 11, 2015 07:40:41 PM Daniel Lezcano wrote: On 05/10/2015 01:15 AM, Rafael J. Wysocki wrote: On Saturday, May 09, 2015 10

Re: [PATCH 0/3] cpuidle: updates related to tick_broadcast_enter() failures

2015-05-11 Thread Daniel Lezcano
On 05/10/2015 01:15 AM, Rafael J. Wysocki wrote: On Saturday, May 09, 2015 10:33:05 PM Rafael J. Wysocki wrote: On Saturday, May 09, 2015 10:11:41 PM Rafael J. Wysocki wrote: On Saturday, May 09, 2015 11:19:16 AM Preeti U Murthy wrote: Hi Rafael, On 05/08/2015 07:48 PM, Rafael J. Wysocki

Re: [PATCH] cpuidle: add freescale e500 family porcessors idle support

2014-04-03 Thread Daniel Lezcano
On 04/03/2014 05:20 AM, dongsheng.w...@freescale.com wrote: Hi Daniel, Thanks for your review. I will fix your comments. BTW, fix Rafael's email. :) +#include linux/cpu.h +#include linux/cpuidle.h +#include linux/init.h +#include linux/kernel.h +#include linux/notifier.h + +#include

Re: [PATCH] cpuidle: add freescale e500 family porcessors idle support

2014-04-03 Thread Daniel Lezcano
On 04/03/2014 10:03 AM, dongsheng.w...@freescale.com wrote: -Original Message- From: Daniel Lezcano [mailto:daniel.lezc...@linaro.org] Sent: Thursday, April 03, 2014 2:29 PM To: Wang Dongsheng-B40534; Wood Scott-B07421 Cc: r...@rjwysocki.net; Li Yang-Leo-R58472; Jin Zhengxiong-R64188

Re: [PATCH] cpuidle: add freescale e500 family porcessors idle support

2014-04-02 Thread Daniel Lezcano
On 04/01/2014 10:33 AM, Dongsheng Wang wrote: From: Wang Dongsheng dongsheng.w...@freescale.com Add cpuidle support for e500 family, using cpuidle framework to manage various low power modes. The new implementation will remain compatible with original idle method. I have done test about power

Re: [PATCH] cpuidle: add freescale e500 family porcessors idle support

2014-04-02 Thread Daniel Lezcano
On 04/02/2014 11:36 AM, Daniel Lezcano wrote: On 04/01/2014 10:33 AM, Dongsheng Wang wrote: From: Wang Dongsheng dongsheng.w...@freescale.com Add cpuidle support for e500 family, using cpuidle framework to manage various low power modes. The new implementation will remain compatible

Re: [PATCH V4 2/3] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-02-11 Thread Daniel Lezcano
On 02/07/2014 09:06 AM, Preeti U Murthy wrote: From: Thomas Gleixner t...@linutronix.de On some architectures, in certain CPU deep idle states the local timers stop. An external clock device is used to wakeup these CPUs. The kernel support for the wakeup of these CPUs is provided by the tick

Re: [PATCH V4 2/3] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-02-11 Thread Daniel Lezcano
On 02/11/2014 04:58 PM, Thomas Gleixner wrote: On Tue, 11 Feb 2014, Daniel Lezcano wrote: On 02/07/2014 09:06 AM, Preeti U Murthy wrote: Setting the smp affinity on the earliest timer should be handled automatically with the CLOCK_EVT_FEAT_DYNIRQ flag. Did you look at using this flag ? How

Re: [PATCH V4 2/3] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-02-11 Thread Daniel Lezcano
On 02/11/2014 05:09 PM, Preeti U Murthy wrote: Hi Daniel, Thank you very much for the review. On 02/11/2014 03:46 PM, Daniel Lezcano wrote: On 02/07/2014 09:06 AM, Preeti U Murthy wrote: From: Thomas Gleixner t...@linutronix.de On some architectures, in certain CPU deep idle states

Re: [PATCH 2/2] ARM64: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Daniel Lezcano
On 6 February 2014 14:16, Nicolas Pitre nicolas.pi...@linaro.org wrote: The core idle loop now takes care of it. Signed-off-by: Nicolas Pitre n...@linaro.org Acked-by: Daniel Lezcano daniel.lezc...@linaro.org ___ Linuxppc-dev mailing list Linuxppc

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Daniel Lezcano
Hi Nico, On 6 February 2014 14:16, Nicolas Pitre nicolas.pi...@linaro.org wrote: The core idle loop now takes care of it. Signed-off-by: Nicolas Pitre n...@linaro.org --- arch/powerpc/platforms/powernv/setup.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff

Re: [PATCH v2 1/6] idle: move the cpuidle entry point to the generic idle loop

2014-01-30 Thread Daniel Lezcano
with what cpuidle is doing and not delegate such interaction to arch code. Architectures implementing arch_cpu_idle() should simply enter a cheap idle mode in the absence of a proper cpuidle driver. Signed-off-by: Nicolas Pitre n...@linaro.org Acked-by: Daniel Lezcano daniel.lezc...@linaro.org

Re: [PATCH v2 1/6] idle: move the cpuidle entry point to the generic idle loop

2014-01-30 Thread Daniel Lezcano
On 01/30/2014 05:07 PM, Nicolas Pitre wrote: On Thu, 30 Jan 2014, Daniel Lezcano wrote: On 01/30/2014 06:28 AM, Nicolas Pitre wrote: On Thu, 30 Jan 2014, Preeti U Murthy wrote: Hi Nicolas, On 01/30/2014 02:01 AM, Nicolas Pitre wrote: On Wed, 29 Jan 2014, Nicolas Pitre wrote: In order

Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-28 Thread Daniel Lezcano
On 01/24/2014 11:21 AM, Preeti U Murthy wrote: On 01/24/2014 02:38 PM, Daniel Lezcano wrote: On 01/23/2014 12:15 PM, Preeti U Murthy wrote: Hi Daniel, Thank you for the review. [ ... ] --- drivers/cpuidle/cpuidle.c | 15 + drivers/cpuidle/governors/ladder.c | 101

Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Daniel Lezcano
. when FIQs are actually used. Signed-off-by: Nicolas Pitre n...@linaro.org Reviewed-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/kernel/process.c | 5 - arch/arm/kernel/setup.c | 7 +++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/arch/arm/kernel

Re: [PATCH 2/9] ARM64: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Daniel Lezcano
that FIQs are not currently used on ARM64. Signed-off-by: Nicolas Pitre n...@linaro.org Reviewed-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm64/kernel/process.c | 5 - arch/arm64/kernel/setup.c | 7 +++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 3/9] idle: no more arch_cpu_idle_prepare() users

2014-01-27 Thread Daniel Lezcano
On 01/27/2014 07:08 AM, Nicolas Pitre wrote: ... so we can get rid of it entirely. Signed-off-by: Nicolas Pitre n...@linaro.org Acked-by: Daniel Lezcano daniel.lezc...@linaro.org --- include/linux/cpu.h | 1 - kernel/cpu/idle.c | 2 -- 2 files changed, 3 deletions(-) diff --git

Re: [PATCH 4/9] idle: move the cpuidle entry point to the generic idle loop

2014-01-27 Thread Daniel Lezcano
x86_idle But I guess it is acceptable as it is fixed with the next patches of the serie. Acked-by: Daniel Lezcano daniel.lezc...@linaro.org --- kernel/cpu/idle.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/cpu/idle.c b/kernel/cpu/idle.c index

Re: [PATCH 5/9] ARM: remove redundant cpuidle_idle_call()

2014-01-27 Thread Daniel Lezcano
On 01/27/2014 07:08 AM, Nicolas Pitre wrote: The core idle loop now takes care of it. Signed-off-by: Nicolas Pitre n...@linaro.org Acked-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/kernel/process.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions

Re: [PATCH 6/9] PPC: remove redundant cpuidle_idle_call()

2014-01-27 Thread Daniel Lezcano
On 01/27/2014 07:08 AM, Nicolas Pitre wrote: The core idle loop now takes care of it. However a few things need checking: - Invocation of cpuidle_idle_call() in pseries_lpar_idle() happened through arch_cpu_idle() and was therefore always preceded by a call to ppc64_runlatch_off(). To

Re: [PATCH 7/9] SH: remove redundant cpuidle_idle_call()

2014-01-27 Thread Daniel Lezcano
On 01/27/2014 07:08 AM, Nicolas Pitre wrote: The core idle loop now takes care of it. Signed-off-by: Nicolas Pitre n...@linaro.org Acked-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/sh/kernel/idle.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/sh

Re: [PATCH 8/9] X86: remove redundant cpuidle_idle_call()

2014-01-27 Thread Daniel Lezcano
On 01/27/2014 07:08 AM, Nicolas Pitre wrote: The core idle loop now takes care of it. Signed-off-by: Nicolas Pitre n...@linaro.org Acked-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/x86/kernel/process.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch

Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Daniel Lezcano
On 01/27/2014 06:21 PM, Russell King - ARM Linux wrote: On Mon, Jan 27, 2014 at 06:12:53PM +0100, Daniel Lezcano wrote: On 01/27/2014 05:07 PM, Russell King - ARM Linux wrote: On Mon, Jan 27, 2014 at 09:22:55AM +0100, Daniel Lezcano wrote: On 01/27/2014 07:08 AM, Nicolas Pitre wrote: ARM

Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Daniel Lezcano
On 01/27/2014 05:07 PM, Russell King - ARM Linux wrote: On Mon, Jan 27, 2014 at 09:22:55AM +0100, Daniel Lezcano wrote: On 01/27/2014 07:08 AM, Nicolas Pitre wrote: ARM and ARM64 are the only two architectures implementing arch_cpu_idle_prepare() simply to call local_fiq_enable(). We have

Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-24 Thread Daniel Lezcano
On 01/23/2014 12:15 PM, Preeti U Murthy wrote: Hi Daniel, Thank you for the review. On 01/22/2014 01:59 PM, Daniel Lezcano wrote: On 01/17/2014 05:33 AM, Preeti U Murthy wrote: diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index a55e68f..831b664 100644 --- a/drivers

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread Daniel Lezcano
On 01/23/2014 08:12 AM, Yijing Wang wrote: Currently, clocksource_register() and __clocksource_register_scale() functions always return 0, it's pointless, make functions void. And remove the dead code that check the clocksource_register_hz() return value. Signed-off-by: Yijing Wang

Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-22 Thread Daniel Lezcano
On 01/17/2014 05:33 AM, Preeti U Murthy wrote: The cpuidle governors today are not handling scenarios where no idle state can be chosen. Such scenarios coud arise if the user has disabled all the idle states at runtime or the latency requirement from the cpus is very strict. The menu governor

Re: [PATCH v2 1/9] ARM: EXYNOS: cpuidle: fix AFTR mode check

2013-12-20 Thread Daniel Lezcano
-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Daniel Lezcano daniel.lezc...@linaro.org Cc: Kukjin Kim kgene@samsung.com --- arch/arm/mach-exynos/cpuidle.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions

Re: [PATCH v2 9/9] cpuidle: remove state_count field from struct cpuidle_device

2013-12-20 Thread Daniel Lezcano
On 12/20/2013 07:47 PM, Bartlomiej Zolnierkiewicz wrote: dev-state_count is now always equal to drv-state_count so it can be removed. Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Daniel Lezcano daniel.lezc

Re: [PATCH v2 8/9] intel_idle: use the common cpuidle_[un]register() routines

2013-12-20 Thread Daniel Lezcano
systems can hotplug a cpu at runtime after the kernel has booted case. Reviewed-by: Daniel Lezcano daniel.lezc...@linaro.org Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Len Brown l...@kernel.org --- drivers/idle

Re: [PATCH v2 7/9] intel_idle: remove superfluous dev-state_count initialization

2013-12-20 Thread Daniel Lezcano
b.zolnier...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Len Brown l...@kernel.org Reviewed-by: Daniel Lezcano daniel.lezc...@linaro.org --- drivers/idle/intel_idle.c | 29 - 1 file changed, 29 deletions(-) diff --git a/drivers/idle

Re: [PATCH v2 6/9] intel_idle: do C1E promotion disable quirk for hotplugged CPUs

2013-12-20 Thread Daniel Lezcano
to intel_idle_cpu_init() (which is also called during CPU_ONLINE operation). Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Len Brown l...@kernel.org Reviewed-by: Daniel Lezcano daniel.lezc...@linaro.org --- drivers/idle

Re: [PATCH V7 2/7] pseries/cpuidle: Use cpuidle_register() for initialisation.

2013-11-06 Thread Daniel Lezcano
-by: Daniel Lezcano daniel.lezc...@linaro.org --- drivers/cpuidle/cpuidle-ibm-power.c | 80 +-- 1 file changed, 12 insertions(+), 68 deletions(-) diff --git a/drivers/cpuidle/cpuidle-ibm-power.c b/drivers/cpuidle/cpuidle-ibm-power.c index a166e38..faf8cc1 100644

Re: [PATCH V7 3/7] pseries/cpuidle: Make pseries_idle backend driver a non-module.

2013-11-06 Thread Daniel Lezcano
. This patch is removes all the module related code. Signed-off-by: Deepthi Dharwar deep...@linux.vnet.ibm.com Acked-by: Daniel Lezcano daniel.lezc...@linaro.org --- drivers/cpuidle/cpuidle-ibm-power.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers

Re: [PATCH V7 4/7] pseries/cpuidle: Remove MAX_IDLE_STATE macro.

2013-11-06 Thread Daniel Lezcano
Acked-by: Daniel Lezcano daniel.lezc...@linaro.org --- drivers/cpuidle/cpuidle-ibm-power.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/cpuidle/cpuidle-ibm-power.c b/drivers/cpuidle/cpuidle-ibm-power.c index 8c9e42c..e81c207 100644

Re: [PATCH V7 5/7] POWER/cpuidle: Generic POWER CPUIDLE driver supporting PSERIES.

2013-11-06 Thread Daniel Lezcano
-by: Deepthi Dharwar deep...@linux.vnet.ibm.com Acked-by: Daniel Lezcano daniel.lezc...@linaro.org ... but I am wondering if 'power' name is not confusing with power management and if 'powerpc' would suit better. --- drivers/cpuidle/cpuidle-ibm-power.c | 32 1 file

Re: [PATCH V7 6/7] POWER/cpuidle: Enable powernv cpuidle support.

2013-11-06 Thread Daniel Lezcano
On 10/29/2013 12:01 PM, Deepthi Dharwar wrote: The following patch extends the current power backend idle driver to the powernv platform. Signed-off-by: Deepthi Dharwar deep...@linux.vnet.ibm.com Acked-by: Daniel Lezcano daniel.lezc...@linaro.org --- drivers/cpuidle/cpuidle-ibm-power.c

Re: [PATCH V7 7/7] powernv/cpuidle: Enable idle powernv cpu to call into the cpuidle framework.

2013-11-06 Thread Daniel Lezcano
On 10/29/2013 12:02 PM, Deepthi Dharwar wrote: This patch enables idle cpu on the powernv platform to hook on to the cpuidle framework, if available, else call on to default idle platform code. Signed-off-by: Deepthi Dharwar deep...@linux.vnet.ibm.com Acked-by: Daniel Lezcano daniel.lezc

Re: [PATCH] cpuidle: fix unremovable issue for module driver

2013-07-30 Thread Daniel Lezcano
On 07/30/2013 08:55 AM, Dongsheng Wang wrote: From: Wang Dongsheng dongsheng.w...@freescale.com After __cpuidle_register_device, the cpu incs are added up, but decs are not, thus the module refcount is not match. So the module exit function can not be executed when we do remove operation.

Re: [PATCH] cpuidle: add freescale e500 family porcessors idle support

2013-07-30 Thread Daniel Lezcano
On 07/30/2013 09:00 AM, Dongsheng Wang wrote: From: Wang Dongsheng dongsheng.w...@freescale.com Add cpuidle support for e500 family, using cpuidle framework to manage various low power modes. The new implementation will remain compatible with original idle method. Initially, this supports

Re: [PATCH] cpuidle: fix unremovable issue for module driver

2013-07-30 Thread Daniel Lezcano
On 07/30/2013 12:48 PM, Wang Dongsheng-B40534 wrote: -Original Message- From: Daniel Lezcano [mailto:daniel.lezc...@linaro.org] Sent: Tuesday, July 30, 2013 5:28 PM To: Wang Dongsheng-B40534 Cc: r...@sisk.pl; linux...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org Subject: Re

Re: [PATCH 2/3] cpuidle/powernv: Enable idle powernv cpu to call into the cpuidle framework.

2013-07-29 Thread Daniel Lezcano
On 07/29/2013 04:27 PM, Deepthi Dharwar wrote: On 07/27/2013 10:59 AM, Daniel Lezcano wrote: On 07/23/2013 11:01 AM, Deepthi Dharwar wrote: This patch enables idle powernv cpu to hook on to the cpuidle framework, if available, else call on to default idle platform code. Why do you need

Re: [linux-pm] [PATCH 1/3] cpuidle/powernv: cpuidle backend driver for powernv

2013-07-29 Thread Daniel Lezcano
On 07/29/2013 04:39 PM, Deepthi Dharwar wrote: Hi Daniel, On 07/27/2013 10:57 AM, Daniel Lezcano wrote: On 07/23/2013 11:01 AM, Deepthi Dharwar wrote: This patch implements a back-end cpuidle driver for powernv calling power7_nap and snooze idle states. This can be extended by adding more

Re: [linux-pm] [PATCH 1/3] cpuidle/powernv: cpuidle backend driver for powernv

2013-07-26 Thread Daniel Lezcano
On 07/23/2013 11:01 AM, Deepthi Dharwar wrote: This patch implements a back-end cpuidle driver for powernv calling power7_nap and snooze idle states. This can be extended by adding more idle states in the future to the existing framework. Signed-off-by: Deepthi Dharwar

Re: [PATCH 2/3] cpuidle/powernv: Enable idle powernv cpu to call into the cpuidle framework.

2013-07-26 Thread Daniel Lezcano
On 07/23/2013 11:01 AM, Deepthi Dharwar wrote: This patch enables idle powernv cpu to hook on to the cpuidle framework, if available, else call on to default idle platform code. Why do you need to do that ? Signed-off-by: Deepthi Dharwar deep...@linux.vnet.ibm.com ---

Re: [PATCH] cpuidle: Measure idle state durations with monotonic clock

2012-11-15 Thread Daniel Lezcano
residency values are applied correctly even though they should not appear anymore. Signed-off-by: Julius Werner jwer...@chromium.org Tested on a Core 2 Duo (processor_idle driver). Tested-by: Daniel Lezcano daniel.lezc...@linaro.org Acked-by: Daniel Lezcano daniel.lezc...@linaro.org

Re: [PATCH] cpuidle: Measure idle state durations with monotonic clock

2012-11-14 Thread Daniel Lezcano
On 11/14/2012 10:06 AM, Deepthi Dharwar wrote: On 11/14/2012 03:22 AM, Julius Werner wrote: Many cpuidle drivers measure their time spent in an idle state by reading the wallclock time before and after idling and calculating the difference. This leads to erroneous results when the wallclock

Re: [PATCH] cpuidle: Measure idle state durations with monotonic clock

2012-11-14 Thread Daniel Lezcano
On 11/13/2012 10:52 PM, Julius Werner wrote: Many cpuidle drivers measure their time spent in an idle state by reading the wallclock time before and after idling and calculating the difference. This leads to erroneous results when the wallclock time gets updated by another processor in the