On 5/20/24 16:04, Michael Ellerman wrote:
> Greg Kroah-Hartman writes:
>> Description
>> ===
>>
>> In the Linux kernel, the following vulnerability has been resolved:
>>
>> powerpc/ps3_defconfig: Disable PPC64_BIG_ENDIAN_ELF_ABI_V2
>>
>> Commit 8c5fa3b5c4df ("powerpc/64: Make ELFv2 the
Signed-off-by: Geoff Levand
diff --git a/arch/powerpc/platforms/ps3/device-init.c
b/arch/powerpc/platforms/ps3/device-init.c
index 878bc160246e..b18e1c92e554 100644
--- a/arch/powerpc/platforms/ps3/device-init.c
+++ b/arch/powerpc/platforms/ps3/device-init.c
@@ -770,49 +770,51 @@ static struct
Signed-off-by: Geoff Levand
diff --git a/arch/powerpc/platforms/ps3/device-init.c
b/arch/powerpc/platforms/ps3/device-init.c
index 878bc160246e..03292869e6a1 100644
--- a/arch/powerpc/platforms/ps3/device-init.c
+++ b/arch/powerpc/platforms/ps3/device-init.c
@@ -770,49 +770,51 @@ static struct
On 3/23/24 05:24, Arnd Bergmann wrote:
> On Fri, Mar 22, 2024, at 09:34, Geoff Levand wrote:
>> On 3/21/24 17:32, Geert Uytterhoeven wrote:
>>> --- a/arch/powerpc/platforms/ps3/device-init.c
>>>> +++ b/arch/powerpc/platforms/ps3/device-init.c
>>>> @@
On 3/21/24 17:32, Geert Uytterhoeven wrote:
> --- a/arch/powerpc/platforms/ps3/device-init.c
>> +++ b/arch/powerpc/platforms/ps3/device-init.c
>> @@ -770,7 +770,7 @@ static struct task_struct *probe_task;
>>
>> static int ps3_probe_thread(void *data)
>> {
>> - struct
Hi Geert,
On 3/21/24 17:32, Geert Uytterhoeven wrote:
>> static int ps3_probe_thread(void *data)
>> {
>> - struct ps3_notification_device dev;
>> + static struct ps3_notification_device dev;
>> int res;
>> unsigned int irq;
>> u64 lpar;
>
> Making it static
> {
> - struct ps3_notification_device dev;
> + static struct ps3_notification_device dev;
> int res;
> unsigned int irq;
> u64 lpar;
Seems fine.
Acked-by: Geoff Levand
ractice.
> But to be on the safe side this patch assumes that it can and aims to
> avoid the dereference in the case where tx_chain->tail->skb may be NULL.
After 17+ years I never hit this, and never heard of anyone hitting it...
> Flagged by Smatch.
> Compile tested only.
Thanks for 'fixing' this.
Acked-by: Geoff Levand
f errors
> *
> * the card and net_device structures are linked to each other
> */
> -#define GELIC_ALIGN (32)
> static struct gelic_card *gelic_alloc_card_net(struct net_device **netdev)
> {
> struct gelic_card *card;
>
Looks good. Thanks for taking care of it.
Acked-by: Geoff Levand
On 2/22/24 03:32, Dan Carpenter wrote:
> This driver is PPC so I have never looked at the code before. I noticed
> another issue that was introduced last December in commit 3ce4f9c3fbb3
> ("net/ps3_gelic_net: Add gelic_descr structures").
>
> net/ethernet/toshiba/ps3_gelic_net.c
...
>375
for mode parsing")
> Signed-off-by: Randy Dunlap
> Cc: Michael Ellerman
> Cc: Nicholas Piggin
> Cc: Christophe Leroy
> Cc: Aneesh Kumar K.V
> Cc: Naveen N. Rao
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: Thomas Zimmermann
> Cc: Geoff Levand
> ---
> arc
struct bus_type ps3_system_bus_type = {
> +static const struct bus_type ps3_system_bus_type = {
> .name = "ps3_system_bus",
> .match = ps3_system_bus_match,
> .uevent = ps3_system_bus_uevent,
Seems fine.
Acked-by: Geoff Levand
Hi,
On 1/25/24 15:46, Christophe Leroy wrote:
> Hi,
>
> Le 24/01/2024 à 09:41, sambat goson a écrit :
>>
>> Hi,
>> I've just test it and find below code not proper in function
>> "gelic_descr_prepare_rx", line 398.
>> it causes error as my attached file.
>>
>> descr->skb =
The PS3 hcall assembly code makes ad-hoc stack frames that don't have
a back-chain pointer or meet other requirements like minimum frame size.
This probably confuses stack unwinders. Give all hcalls a real stack
frame.
Signed-off-by: Nicholas Piggin
Signed-off-by: Geoff Levand
---
arch/powerpc
Patches provided by Nicholas Piggin enable PS3
support for ELFv2.
Signed-off-by: Geoff Levand
---
arch/powerpc/configs/ps3_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/configs/ps3_defconfig
b/arch/powerpc/configs/ps3_defconfig
index aa8bb0208bcc..2b175ddf82f0
Stack-passed parameters begin at a different offset in the caller's
stack in the ELFv2 ABI.
Reported-by: Geoff Levand
Fixes: 8c5fa3b5c4df ("powerpc/64: Make ELFv2 the default for big-endian builds")
Signed-off-by: Nicholas Piggin
Signed-off-by: Geoff Levand
---
arch/powerpc/i
The LRSAVE constant is required for assembly compiled for both 32-bit
and 64-bit, because the value differs there. PS3 is 64-bit only so
this is a noop, but it is nice to abstract stack frame offsets.
Signed-off-by: Nicholas Piggin
Signed-off-by: Geoff Levand
---
arch/powerpc/platforms/ps3
changes up to 983836405df1b6001a2262972fb32d1aee97d6f5:
Revert "powerpc/ps3_defconfig: Disable PPC64_BIG_ENDIAN_ELF_ABI_V2"
(2024-01-19 17:53:48 +0900)
--------
Geoff Levand (1):
Revert "powerpc/ps3_def
Hi Nick,
On 12/27/23 18:50, Geoff Levand wrote:
>> Nicholas Piggin (3):
>> powerpc/ps3: Fix lv1 hcall assembly for ELFv2 calling convention
>> powerpc/ps3: lv1 hcall code use symbolic constant for LR save offset
>> powerpc/ps3: Make real stack frames for LV1 hcalls
Hi,
On 12/27/23 16:24, Nicholas Piggin wrote:
> This (hopefully) fixes the ELFv2 bug that Geoff reported, with patch
> 1. And a couple of other possible improvements I noticed.
>
> I don't have a PS3 setup[*] so I have only compile tested these, I'm
> sorry.
>
> [*] Is RPCS3 usable for this
Hi Michael,
On 12/27/23 10:27, Michael Ellerman wrote:
> Geoff Levand writes:
>> Commit 8c5fa3b5c4df3d071dab42b04b971df370d99354 (powerpc/64: Make ELFv2 the
>> default for big-endian builds), merged in Linux-6.5-rc1 changes the calling
>> ABI
>> in a way that is in
]
Call Trace:
[c23039e0] [c100ebfc] ps3_create_spu+0xc4/0x2b0
(unreliable)
[c2303ab0] [c100d4c4] create_spu+0xcc/0x3c4
[c2303b40] [c100eae4] ps3_enumerate_spus+0xa4/0xf8
Signed-off-by: Geoff Levand
---
arch/powerpc
ere processing the requested notification events. */
> do {
> try_to_freeze();
Seems like a reasonable addition.
Signed-off-by: Geoff Levand
| 1 +
> drivers/net/ethernet/toshiba/ps3_gelic_net.h | 6 --
> 3 files changed, 7 insertions(+), 6 deletions(-)
Seems good to me. I'll test it next chance I get.
Signed-off-by: Geoff Levand
On 10/12/23 17:41, Johannes Berg wrote:
> But seriously - is it worth to try to keep a wireless driver for it if
> we don't even know anyone using a PS3 at all?
There is still a considerable user base for the PS3, so we
must keep the ps3-gelic-wireless driver.
-Geoff
rd;
>
> netdev = alloc_etherdev(struct_size(card, darray,
> - tx_descriptors + rx_descriptors));
> + size_add(tx_descriptors,
> rx_descriptors)));
> if (!netdev)
> return NULL;
>
Looks good to me. Thanks for your fix-up.
Signed-off-by: Geoff Levand
+++ b/arch/powerpc/platforms/ps3/repository.c
> @@ -73,9 +73,9 @@ static void _dump_node(unsigned int lpar_id, u64 n1, u64
> n2, u64 n3, u64 n4,
I tested this on PS3 and it seems to be working OK.
Tested-by: Geoff Levand
t.c | 8 +---
> 1 file changed, 1 insertion(+), 7 deletions(-)
I tested this on PS3 and it seems to be working OK.
Thanks for your contribution.
Tested-by: Geoff Levand
Hi,
On 2/13/23 03:29, Thomas Zimmermann wrote:
> Am 12.02.23 um 17:53 schrieb Geoff Levand:
>> On 2/9/23 05:55, Thomas Zimmermann wrote:
>>> Get the kernel's global video= parameter with fb_get_option(). Done
>>> to unexport the internal fbdev state fb_mode_config
Hi Thomas,
On 2/9/23 05:55, Thomas Zimmermann wrote:
> Get the kernel's global video= parameter with fb_get_option(). Done
> to unexport the internal fbdev state fb_mode_config. No functional
> changes.
>
> Signed-off-by: Thomas Zimmermann
> ---
> drivers/ps3/ps3av.c | 11 +--
> 1 file
>
> dma_free_coherent(>core,
> PAGE_SIZE,
Looks OK for PS3.
Acked-by: Geoff Levand
On 1/16/23 23:26, Christophe Leroy wrote:
> Le 16/01/2023 à 21:08, Geoff Levand a écrit :
>>
>> As mentioned, I'd really like to keep PS3 included in ppc64_defconfig. My
>> original patch that basically just ignores the call to
>> mmu_hash_ops.updateboltedpp allows that
evice with ext4,
copy files to it, run fsck, etc.
Thanks for your effort.
Tested-by: Geoff Levand
Hi,
On 1/15/23 16:06, Michael Ellerman wrote:
> Geoff Levand writes:
>> On 1/9/23 09:41, Christophe Leroy wrote:
>>>
>>>
>>> Le 03/01/2023 à 18:51, Geoff Levand a écrit :
>>>> Commit fdacae8a84024474afff234bdd1dbe19ad597a10 (powerpc: Activate
to
HVC_N_INBUF.
Typical usage in the backend source file would be:
#define HVC_N_OUTBUF 32
#define HVC_N_INBUF 32
#include "hvc_console.h"
Signed-off-by: Geoff Levand
---
Hi,
With this patch the buffer sizes are set by defining preprocessor macros before
including the hvc
Hi Christophe,
On 1/9/23 09:41, Christophe Leroy wrote:
>
>
> Le 03/01/2023 à 18:51, Geoff Levand a écrit :
>> Commit fdacae8a84024474afff234bdd1dbe19ad597a10 (powerpc: Activate
>> CONFIG_STRICT_KERNEL_RWX by default) causes ps3_hpte_updateboltedpp()
>> to be called.
Commit fdacae8a84024474afff234bdd1dbe19ad597a10 (powerpc: Activate
CONFIG_STRICT_KERNEL_RWX by default) causes ps3_hpte_updateboltedpp()
to be called. Change the panic statment in ps3_hpte_updateboltedpp()
to a pr_info statement so that bootup can continue.
Signed-off-by: Geoff Levand
---
arch
Refresh ps3_defconfig for v6.2.
Signed-off-by: Geoff Levand
---
arch/powerpc/configs/ps3_defconfig | 39 +-
1 file changed, 17 insertions(+), 22 deletions(-)
diff --git a/arch/powerpc/configs/ps3_defconfig
b/arch/powerpc/configs/ps3_defconfig
index 0a1b42c4f26a
/kernel/git/geoff/ps3-linux.git
for-merge-powerpc-2
for you to fetch changes up to 99e87549b17feca3494e9df6f4def04a9ec7c042:
powerpc/ps3: Refresh ps3_defconfig (2023-01-03 09:42:16 -0800)
Geoff Levand (2):
powerpc/ps3: Change
Hi Rob,
On 1/2/23 18:03, Rob Herring wrote:
> On Mon, Jan 2, 2023 at 1:41 PM Geoff Levand wrote:
>> --- a/arch/powerpc/kernel/prom.c
>> +++ b/arch/powerpc/kernel/prom.c
>> @@ -761,7 +761,7 @@ void __init early_init_devtree(void *params)
>> DBG(" ->
Refresh ps3_defconfig for v6.2.
Signed-off-by: Geoff Levand
---
arch/powerpc/configs/ps3_defconfig | 39 +-
1 file changed, 17 insertions(+), 22 deletions(-)
diff --git a/arch/powerpc/configs/ps3_defconfig
b/arch/powerpc/configs/ps3_defconfig
index 0a1b42c4f26a
)
Geoff Levand (3):
powerpc: Fix processing of CONFIG_CMDLINE
powerpc/ps3: Change updateboltedpp panic to info
powerpc/ps3: Refresh ps3_defconfig
arch/powerpc/configs/ps3_defconfig | 39
Commit fdacae8a84024474afff234bdd1dbe19ad597a10 (powerpc: Activate
CONFIG_STRICT_KERNEL_RWX by default) causes ps3_hpte_updateboltedpp()
to be called. Change the panic statment in ps3_hpte_updateboltedpp()
to a pr_info statement so that bootup can continue.
Signed-off-by: Geoff Levand
---
arch
).
The early_init_dt_scan routine calls into early_init_dt_verify and then
early_init_dt_scan_nodes. The powerpc startup routine early_init_devtree
currently has a call to early_init_dt_verify. This change replaces that
early_init_dt_verify call to a call to early_init_dt_scan.
Signed-off-by: Geoff Levand
---
arch
ps3.h | 4
> arch/powerpc/platforms/ps3/system-bus.c | 2 +-
> 2 files changed, 1 insertion(+), 5 deletions(-)
I tested this applied to v6.1-rc6 and it seems to be OK. Thanks
for submitting.
Acked-by: Geoff Levand
ve them.
I did a test build with this patch applied to v6.0-rc5 and had no errors.
Acked-by: Geoff Levand
ERSION, sizeof(drvinfo->version));
> + strscpy(drvinfo->fw_version, "no information",
> sizeof(drvinfo->fw_version));
> - strlcpy(drvinfo->bus_info, pci_name(card->pdev),
> + strscpy(drvinfo->bus_info, pci_name(card->pdev),
> sizeof(drvinfo->bus_info));
> }
Seems OK for both ps3_gelic_net and spider_net_ethtool.
Acked-by: Geoff Levand
+ strscpy(gendisk->disk_name, DEVICE_NAME, sizeof(gendisk->disk_name));
> set_capacity(gendisk, priv->size >> 9);
> blk_queue_max_segments(gendisk->queue, BLK_MAX_SEGMENTS);
> blk_queue_max_segment_size(gendisk->queue, BLK_MAX_SEGMENT_SIZE);
Seems OK for ps3vram.
Acked-by: Geoff Levand
netif_napi_add(netdev, >napi,
> -spider_net_poll, SPIDER_NET_NAPI_WEIGHT);
> +spider_net_poll, NAPI_POLL_WEIGHT);
This seems fine. Both SPIDER_NET_NAPI_WEIGHT and NAPI_POLL_WEIGHT
are defined as 64. Thanks for your contribution.
Acked-by: Geoff Levand
Hi Paul,
On 2/13/22 22:55, Paul Menzel wrote:
> Currently, `git status` lists the file as untracked by git, so tell git
> to ignore it.
Thanks for your contribution.
Acked-by: Geoff Levand
nfig. Thanks
for your contribution.
Acked-by: Geoff Levand
is change will be OK.
Acked-by: Geoff Levand
handling branch
on PS3 and the ps3disk changes seem to be working OK.
Tested-by: Geoff Levand
Hi Luis,
On 10/18/21 9:15 AM, Luis Chamberlain wrote:
> On Sun, Oct 17, 2021 at 08:26:33AM -0700, Geoff Levand wrote:
>> Hi Luis,
>>
>> On 10/15/21 4:52 PM, Luis Chamberlain wrote:
>>> This patch set consists of al the straggler drivers for which we have
>>
Hi Luis,
On 10/15/21 4:52 PM, Luis Chamberlain wrote:
> This patch set consists of al the straggler drivers for which we have
> have no patch reviews done for yet. I'd like to ask for folks to please
> consider chiming in, specially if you're the maintainer for the driver.
> Additionally if you
Hi Christophe,
On 8/27/21 6:34 PM, Geoff Levand wrote:
> On 8/27/21 12:56 PM, Christophe JAILLET wrote:
>> It has *not* been compile tested because I don't have the needed
>> configuration or cross-compiler.
>
> The powerpc ppc64_defconfig has CONFIG_SPIDER_NET set. My
>
Hi Christophe,
On 8/27/21 12:56 PM, Christophe JAILLET wrote:
> It has *not* been compile tested because I don't have the needed
> configuration or cross-compiler.
The powerpc ppc64_defconfig has CONFIG_SPIDER_NET set. My
tdd-builder Docker image has the needed gcc-powerpc-linux-gnu
cross
In an effort to make the PS3 gelic driver easier to maintain, add a
local variable dev to those routines that use the device structure that
makes the use the device structure more consistent.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 340
Add new helper routine gelic_work_to_card that converts a work_struct
to a gelic_card.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers
In an effort to make the PS3 gelic driver easier to maintain, rename
the gelic_card_init_chain parameter 'no' to 'descr_count'.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net
Put the common code for unmaping a link into its own routine,
gelic_unmap_link, and add some debugging checks.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 23 +++-
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/drivers/net
In an effort to make the PS3 gelic driver easier to maintain, cleanup the
the driver source file formatting to be more consistent.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 379 ++-
1 file changed, 193 insertions(+), 186 deletions(-)
diff
errors like these, and also other randomly occurring errors:
IP-Config: Complete:
DMA-API: ps3_gelic_driver sb_05: device driver failed to check map error
WARNING: CPU: 0 PID: 0 at kernel/dma/debug.c:1027 .check_unmap+0x888/0x8dc
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba
hardware device. struct gelic_chain_link holds variables used to manage
the driver's linked list of gelic descr structures.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 133 ++-
drivers/net/ethernet/toshiba/ps3_gelic_net.h | 24 ++--
2 files changed
Add a new preprocessor macro BUG_ON_DEBUG, that expands to BUG_ON when
the preprocessor macro DEBUG is defined, or to WARN_ON when DEBUG is not
defined. Also, replace all occurrences of BUG_ON with BUG_ON_DEBUG.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 13
-0700)
Geoff Levand (10):
net/ps3_gelic: Add gelic_descr structures
net/ps3_gelic: Use local dev variable
net/ps3_gelic: Format cleanups
net/ps3_gelic: Add new macro BUG_ON_DEBUG
net/ps3_gelic: Add vlan_id
In an effort to make the PS3 gelic driver easier to maintain, change the
gelic_card_enable_rxdmac routine to use the optimizer to remove
debug code.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 19 +--
1 file changed, 9 insertions(+), 10
In an effort to make the PS3 gelic driver easier to maintain, add
a definition for the vlan_id structure.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/toshiba
Hi Christophe,
On 7/11/21 7:03 AM, Christophe Leroy wrote:
>
> Your patch has a lot of cosmetic changes. Several of them are just wrong. The
> other ones belong to another patch. This patch should focus only on the
> changes it targets.
>
> Your patch is way too big and addresses several
-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 573 +++
drivers/net/ethernet/toshiba/ps3_gelic_net.h | 24 +-
2 files changed, 341 insertions(+), 256 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet/toshiba
General source cleanups and improved logging messages.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 395 ++-
1 file changed, 216 insertions(+), 179 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet
/linux/kernel/git/geoff/ps3-linux.git
for-merge-dma-net
for you to fetch changes up to ffb7b2f4ac085986f563131e3851e07393cd514f:
net/ps3_gelic: Cleanups, improve logging (2021-07-10 20:42:42 -0700)
Geoff Levand (2):
net
ev)
> __func__, __LINE__, drv->core.name);
>
> pr_debug(" <- %s:%d: %s\n", __func__, __LINE__, dev_name(>core));
> - return 0;
> }
PS3 part looks fine.
Acked-by: Geoff Levand
On 7/4/21 2:38 AM, Colin King wrote:
> - Enables more verbose log mesages for LV1 hypercall results.
> + Enables more verbose log messages for LV1 hypercall results.
Looks good. Thanks.
Acked by: Geoff Levand
patch set applied to v5.13-rc6 on PS3 and it seemed to be
working OK.
I did some rsync's, some dd's, some fsck's, etc. If you have anything
you could suggest that you think would exercise your changes I could
try that also.
Tested-by: Geoff Levand
your alloc_disk-part2 branch on PS3, and it seemed to be working OK.
Tested-by: Geoff Levand
Add a new sysfs entry /sys/firmware/ps3/fw-version that exports
the PS3's firmware version.
The firmware version is available through an LV1 hypercall, and we've
been printing it to the boot log, but haven't provided an easy way for
user utilities to get it.
Signed-off-by: Geoff Levand
)
Geoff Levand (2):
powerpc/ps3: Add firmware version to sysfs
powerpc/ps3: Re-align DTB in image
arch/powerpc/boot/zImage.ps3.lds.S | 2 +-
arch/powerpc/platforms/ps3/setup.c | 43 +++---
2 files changed, 41 insertions(+), 4 deletions
Change the PS3 linker script to align the DTB at 8 bytes,
the same alignment as that of the of the 'generic' powerpc
linker script.
Signed-off-by: Geoff Levand
---
arch/powerpc/boot/zImage.ps3.lds.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/zImage.ps3
Hi Michael,
On 6/2/21 10:38 PM, Michael Ellerman wrote:
> Geoff Levand writes:
>> Hi,
>>
>> This is a set of patches that fix various DMA related problems in the PS3
>> device drivers, and add better error checking and improved message logging.
>>
>>
to this new variable.
Fixes runtime errors like these:
ps3_system_bus_match:349: dev=8.0(sb_01), drv=8.0(ps3flash): match
WARNING: CPU: 0 PID: 1 at kernel/dma/mapping.c:151
.dma_map_page_attrs+0x34/0x1e0
ps3flash sb_01: ps3stor_setup:193: map DMA region failed
Signed-off-by: Geoff Levand
To aid debugging PS3 boot problems change the log level
of several PS3 device errors from pr_debug to pr_warn.
Signed-off-by: Geoff Levand
---
arch/powerpc/platforms/ps3/system-bus.c | 9 +
drivers/ps3/ps3-vuart.c | 2 +-
drivers/ps3/ps3av.c | 22
To aid debugging, add a new PS3 kernel config option
PS3_VERBOSE_RESULT that, when enabled, will print more
verbose messages for the result of LV1 hypercalls.
Signed-off-by: Geoff Levand
---
arch/powerpc/include/asm/ps3.h | 2 +-
arch/powerpc/platforms/ps3/Kconfig | 9 +
2 files
to 562d0c9ea0100a30c3b186bcc7adb34b0bbd2cd7:
powerpc/ps3: Add dma_mask to ps3_dma_region (2021-06-01 12:27:43 -0700)
Geoff Levand (3):
powerpc/ps3: Add CONFIG_PS3_VERBOSE_RESULT option
powerpc/ps3: Warn on PS3 device errors
for you to fetch changes up to c944a7aa07cbe1893a2426cfd6ed506bc6aebbbc:
net/ps3_gelic: Cleanups, improve logging (2021-06-03 11:47:01 -0700)
Geoff Levand (2):
net/ps3_gelic: Add gelic_descr structures
net/ps3_gelic
-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 573 +++
drivers/net/ethernet/toshiba/ps3_gelic_net.h | 24 +-
2 files changed, 341 insertions(+), 256 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet/toshiba
General source cleanups and improved logging messages.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 395 ++-
1 file changed, 216 insertions(+), 179 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet
To aid debugging PS3 boot problems change the log level
of several PS3 device errors from pr_debug to pr_warn.
Signed-off-by: Geoff Levand
---
arch/powerpc/platforms/ps3/system-bus.c | 9 +
drivers/ps3/ps3-vuart.c | 2 +-
drivers/ps3/ps3av.c | 22
To aid debugging, add a new PS3 kernel config option
PS3_VERBOSE_RESULT that, when enabled, will print more
verbose messages for the result of LV1 hypercalls.
Signed-off-by: Geoff Levand
---
arch/powerpc/include/asm/ps3.h | 2 +-
arch/powerpc/platforms/ps3/Kconfig | 9 +
2 files
-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 573 +++
drivers/net/ethernet/toshiba/ps3_gelic_net.h | 24 +-
2 files changed, 341 insertions(+), 256 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet/toshiba
to this new variable.
Fixes runtime errors like these:
ps3_system_bus_match:349: dev=8.0(sb_01), drv=8.0(ps3flash): match
WARNING: CPU: 0 PID: 1 at kernel/dma/mapping.c:151
ps3flash sb_01: ps3stor_setup:193: map DMA region failed
Signed-off-by: Geoff Levand
---
arch/powerpc/include/asm/ps3.h
to 4adcfc9735bf8d1987d2bc82e914be154f2ffad8:
net/ps3_gelic: Cleanups, improve logging (2021-06-01 12:27:43 -0700)
Geoff Levand (5):
powerpc/ps3: Add CONFIG_PS3_VERBOSE_RESULT option
powerpc/ps3: Warn on PS3 device errors
powerpc/ps3: Add dma_mask
General source cleanups and improved logging messages.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 395 ++-
1 file changed, 216 insertions(+), 179 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet
Hi,
On 5/20/21 5:20 AM, Michael Ellerman wrote:
> Zhen Lei writes:
>> When call ps3_start_probe_thread() failed, further initialization should
>> be stopped and the returned error code should be propagated.
...
>> --- a/arch/powerpc/platforms/ps3/device-init.c
>>
>> result =
On 3/23/21 1:55 AM, caizhichao wrote:
> From: caizhichao
>
> vaules -> values
>
> Signed-off-by: caizhichao
> ---
> sound/ppc/snd_ps3_reg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Seems fine. Thanks for your contribution.
Acked-by: Geoff Levand
)
Geoff Levand (2):
powerpc/ps3: Add firmware version to proc
powerpc/ps3: Re-align DTB in image
arch/powerpc/boot/zImage.ps3.lds.S | 2 +-
arch/powerpc/platforms/ps3/setup.c | 62 --
2
Add a new proc FS entry /proc/ps3/firmware-version that exports the
PS3's firmware version.
The firmware version is available through an LV1 hypercall, and we've
been printing it to the boot log, but haven't provided an easy way for
user utilities to get it.
Signed-off-by: Geoff Levand
Change the PS3 linker script to align the DTB at 8 bytes,
the same alignment as that of the of the 'generic' powerpc
linker script.
Signed-off-by: Geoff Levand
---
arch/powerpc/boot/zImage.ps3.lds.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/zImage.ps3
Change the Spidernet network driver from supported to
maintained, add the linuxppc-dev ML, and add myself as
a 'maintainer'.
Cc: Ishizaki Kou
Signed-off-by: Geoff Levand
---
MAINTAINERS | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index
Li
> ---
> arch/powerpc/platforms/ps3/system-bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks for your patch, it looks good.
Acked-by: Geoff Levand
-Geoff
1 - 100 of 541 matches
Mail list logo
