Re: [PATCH v5.10 v2 RESEND] powerpc: Avoid nmi_enter/nmi_exit in real mode interrupt.

2024-08-13 Thread Greg KH
On Tue, Aug 13, 2024 at 11:33:44AM +, Jinjie Ruan wrote: > From: Mahesh Salgaonkar > > [ Upstream commit 0db880fc865ffb522141ced4bfa66c12ab1fbb70 ] > > nmi_enter()/nmi_exit() touches per cpu variables which can lead to kernel > crash when invoked during real mode interrupt handling (e.g. ear

Re: [PATCH v5.10 v2] powerpc: Avoid nmi_enter/nmi_exit in real mode interrupt.

2024-08-13 Thread Greg KH
On Tue, Aug 06, 2024 at 07:16:16AM +, Jinjie Ruan wrote: > From: Mahesh Salgaonkar > > [ Upstream commit 0db880fc865ffb522141ced4bfa66c12ab1fbb70 ] > > nmi_enter()/nmi_exit() touches per cpu variables which can lead to kernel > crash when invoked during real mode interrupt handling (e.g. ear

Re: [PATCH v4] cxl: Fix possible null pointer dereference in read_handle()

2024-07-14 Thread Greg KH
On Mon, Jul 15, 2024 at 10:54:42AM +0800, Ma Ke wrote: > In read_handle(), of_get_address() may return NULL if getting address and > size of the node failed. When of_read_number() uses prop to handle > conversions between different byte orders, it could lead to a null pointer > dereference. Add NUL

Re: [PATCH v3] cxl: Fix possible null pointer dereference in read_handle()

2024-07-14 Thread Greg KH
On Sun, Jul 14, 2024 at 08:14:04PM +0800, Ma Ke wrote: > In read_handle(), of_get_address() may return NULL which is later > dereferenced. Fix this by adding NULL check. > > Based on our customized static analysis tool, extract vulnerability > features[1], then match similar vulnerability features

Re: [PATCH v2] cxl: Fix possible null pointer dereference in read_handle()

2024-07-10 Thread Greg KH
On Wed, Jul 10, 2024 at 06:33:52PM +0800, Ma Ke wrote: > In read_handle(), of_get_address() may return NULL which is later > dereferenced. Fix this by adding NULL check. > > Cc: sta...@vger.kernel.org > Fixes: 14baf4d9c739 ("cxl: Add guest-specific code") > Signed-off-by: Ma Ke > --- > Changes in

Re: [PATCH] cxl: Fix possible null pointer dereference in read_handle()

2024-07-09 Thread Greg KH
On Tue, Jul 09, 2024 at 09:17:54PM +0800, Ma Ke wrote: > In read_handle() of_get_address() may return NULL which is later > dereferenced. Fix this bug by adding NULL check. > > Cc: sta...@vger.kernel.org > Fixes: 14baf4d9c739 ("cxl: Add guest-specific code") > Signed-off-by: Ma Ke > --- > driver

Re: [PATCH v5.10] powerpc/uaccess: Fix build errors seen with GCC 13/14

2024-06-17 Thread Greg KH
On Fri, Jun 14, 2024 at 09:27:14PM +1000, Michael Ellerman wrote: > commit 2d43cc701b96f910f50915ac4c2a0cae5deb734c upstream. > > Building ppc64le_defconfig with GCC 14 fails with assembler errors: > All backports now queued up,t hanks! greg k-h

Re: Please backport 2d43cc701b96 to v6.9 and v6.6

2024-06-14 Thread Greg KH
On Fri, Jun 14, 2024 at 05:54:50PM +1000, Michael Ellerman wrote: > Hi stable team, > > Can you please backport: > 2d43cc701b96 ("powerpc/uaccess: Fix build errors seen with GCC 13/14") > > To v6.9 and v6.6. > > It was marked for backporting, but hasn't been picked up AFAICS. I'm not > sure if

Re: Xorg doesn't start and some other issues with the RC1 of kernel 6.10

2024-05-31 Thread Greg KH
On Fri, May 31, 2024 at 12:16:50PM +0200, Greg KH wrote: > On Fri, May 31, 2024 at 12:02:15PM +0200, Greg KH wrote: > > On Fri, May 31, 2024 at 11:19:34AM +0200, Thorsten Leemhuis wrote: > > > On 31.05.24 11:03, Michael Ellerman wrote: > > > > Michael Ellerman write

Re: Xorg doesn't start and some other issues with the RC1 of kernel 6.10

2024-05-31 Thread Greg KH
On Fri, May 31, 2024 at 12:02:15PM +0200, Greg KH wrote: > On Fri, May 31, 2024 at 11:19:34AM +0200, Thorsten Leemhuis wrote: > > On 31.05.24 11:03, Michael Ellerman wrote: > > > Michael Ellerman writes: > > >> Christian Zigotzky writes: > > >>>

Re: Xorg doesn't start and some other issues with the RC1 of kernel 6.10

2024-05-31 Thread Greg KH
On Fri, May 31, 2024 at 11:19:34AM +0200, Thorsten Leemhuis wrote: > On 31.05.24 11:03, Michael Ellerman wrote: > > Michael Ellerman writes: > >> Christian Zigotzky writes: > >>> On 28.05.24 22:00, Christian Zigotzky wrote: > Hi All, > > Xorg doesn't start anymore since the RC1 of

Re: [PATCH] arch/powerpc/kvm: Fix doorbell emulation by adding DPDES support

2024-05-30 Thread Greg KH
On Fri, May 31, 2024 at 10:54:58AM +0530, Gautam Menghani wrote: > Hello, > > Please review this patch and let me know if any changes are needed. There already was review comments on it, why ignore them?

Re: [PATCH V2] tty: hvc: hvc_opal: eliminate uses of of_node_put()

2024-05-03 Thread Greg KH
On Fri, May 03, 2024 at 04:52:15PM +0300, Lu Dai wrote: > Make use of the __free() cleanup handler to automatically free nodes > when they get out of scope. > > Remove the need for a 'goto' as an effect. > > Signed-off-by: Lu Dai > --- > Changes since v1: > Move the assignment of 'opal' to its d

Re: [PATCH] tty: hvc: hvc_opal: eliminate uses of of_node_put()

2024-05-03 Thread Greg KH
On Fri, May 03, 2024 at 02:43:30PM +0300, Lu Dai wrote: > Make use of the __free() cleanup handler to automatically free nodes > when they get out of scope. > > Removes the need for a 'goto' as an effect. > > Signed-off-by: Lu Dai > --- > drivers/tty/hvc/hvc_opal.c | 9 +++-- > 1 file chang

Re: [PATCH v2] tty: hvc: wakeup hvc console immediately when needed

2024-04-15 Thread Greg KH
On Mon, Apr 15, 2024 at 03:26:17PM +0800, li.ha...@zte.com.cn wrote: > From: Li Hao > > Cancel the do_wakeup flag in hvc_struct, and change it to immediately > wake up tty when hp->n_outbuf is 0 in hvc_push(). > > When we receive a key input character, the interrupt handling function > hvc_handl

Re: linux-next: duplicate patch in the driver-core.current tree

2024-04-11 Thread Greg KH
On Fri, Apr 12, 2024 at 02:36:25PM +1000, Michael Ellerman wrote: > Stephen Rothwell writes: > > Hi all, > > > > The following commit is also in the powerpc-fixes tree as a different > > commit (but the same patch): > > > > 156539fd6501 ("Documentation: embargoed-hardware-issues.rst: Add myself

Re: [PATCH] tty: hvc: wakeup hvc console immediately when needed

2024-04-11 Thread Greg KH
On Fri, Apr 12, 2024 at 11:38:48AM +0800, li.ha...@zte.com.cn wrote: > From: Li Hao > > Cancel the do_wakeup flag in hvc_struct, and change it to immediately > wake up tty when hp->n_outbuf is 0 in hvc_push(). > > When we receive a key input character, the interrupt handling function > hvc_handl

Re: [PATCH] tty: hvc: wakeup hvc console immediately when needed

2024-04-11 Thread Greg KH
On Thu, Apr 11, 2024 at 09:50:17PM +0800, li.ha...@zte.com.cn wrote: > From: Li Hao > > Cancel the do_wakeup flag in hvc_struct, and change it to immediately > wake up tty when hp->n_outbuf is 0 in hvc_push(). > > When we receive a key input character, the interrupt handling function > hvc_handl

Re: FAILED: Patch "powerpc: xor_vmx: Add '-mhard-float' to CFLAGS" failed to apply to 5.10-stable tree

2024-03-29 Thread Greg KH
On Wed, Mar 27, 2024 at 08:16:13AM -0700, Nathan Chancellor wrote: > On Wed, Mar 27, 2024 at 08:20:07AM -0400, Sasha Levin wrote: > > The patch below does not apply to the 5.10-stable tree. > > If someone wants it applied there, or to any other stable or longterm > > tree, then please email the bac

Re: [PATCH 4/9] USB: Convert from tasklet to BH workqueue

2024-03-27 Thread Greg KH
On Wed, Mar 27, 2024 at 04:03:09PM +, Allen Pais wrote: > The only generic interface to execute asynchronously in the BH context is > tasklet; however, it's marked deprecated and has some design flaws. To > replace tasklets, BH workqueue support was recently added. A BH workqueue > behaves simi

Re: [PATCH 4.19] powerpc: Use always instead of always-y in for crtsavres.o

2024-01-26 Thread Greg KH
On Fri, Jan 26, 2024 at 10:36:31AM -0700, Nathan Chancellor wrote: > This commit is for linux-4.19.y only, it has no direct upstream > equivalent. > > Prior to commit 5f2fb52fac15 ("kbuild: rename hostprogs-y/always to > hostprogs/always-y"), always-y did not exist, making the backport of > mainli

Re: [PATCH] NUMA: Early use of cpu_to_node() returns 0 instead of the correct node id

2024-01-18 Thread Greg KH
On Fri, Jan 19, 2024 at 11:32:27AM +0800, Huang Shijie wrote: > During the kernel booting, the generic cpu_to_node() is called too early in > arm64, powerpc and riscv when CONFIG_NUMA is enabled. > > There are at least four places in the common code where > the generic cpu_to_node() is called befo

Re: [PATCH] init: refactor the generic cpu_to_node for NUMA

2024-01-18 Thread Greg KH
On Thu, Jan 18, 2024 at 11:14:12AM +0800, Huang Shijie wrote: > (0) We list the ARCHs which support the NUMA: >arm64, loongarch, powerpc, riscv, >sparc, mips, s390, x86, I do not understand this format, what are you saying here? Have you read the kernel documentation for how to wr

Re: linux-next: duplicate patches in the char-misc tree

2023-11-29 Thread Greg KH
On Wed, Nov 29, 2023 at 12:24:05PM +1100, Stephen Rothwell wrote: > Hi all, > > The following commits are also in the powerpc tree as different commits > (but the same patches): > > bc1183a63057 ("misc: ocxl: main: Remove unnecessary ‘0’ values from rc") > 29eb0dc7bd1e ("misc: ocxl: link: Rem

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-28 Thread Greg KH
On Tue, Nov 28, 2023 at 08:05:26AM +, Greg KH wrote: > On Mon, Nov 27, 2023 at 11:27:07AM -0800, Matthew Maurer wrote: > > > > > > > > > > > With regards to future directions that likely won't work for > > > > > > loosening it: > &

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-28 Thread Greg KH
On Mon, Nov 27, 2023 at 11:27:07AM -0800, Matthew Maurer wrote: > > > > > > > > > With regards to future directions that likely won't work for > > > > > loosening it: > > > > > Unfortunately, the .rmeta format itself is not stable, so I wouldn't > > > > > want to > > > > > teach genksyms to open

Re: linux-next: duplicate patch in the tty tree

2023-11-27 Thread Greg KH
On Mon, Nov 27, 2023 at 11:57:18AM +1100, Stephen Rothwell wrote: > Hi all, > > The following commit is also in the powerpc tree as a different commit > (but the same patch): > > aa46b225ebbf ("tty: hvc: hvc_opal: Convert to platform remove callback > returning void") > > This is commit > >

Re: Please backport feea65a338e5 ("powerpc/powernv: Fix fortify source warnings in opal-prd.c")

2023-11-24 Thread Greg KH
On Mon, Nov 20, 2023 at 10:20:13AM +1100, Michael Ellerman wrote: > Hi, > > Please backport feea65a338e5 ("powerpc/powernv: Fix fortify source > warnings in opal-prd.c") to the 6.5, 6.1, 5.15, 5.10 stable trees. Now queued up, thanks. greg k-h

Re: [PATCH 00/17] tty: small cleanups and fixes

2023-11-23 Thread Greg KH
On Tue, Nov 21, 2023 at 10:22:41AM +0100, Jiri Slaby (SUSE) wrote: > This is a series to fix/clean up some obvious issues I revealed during > u8+size_t conversions (to be posted later). I applied most of these except the last few, as I think you were going to reorder them, right? thanks, greg k-

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-23 Thread Greg KH
On Thu, Nov 23, 2023 at 08:38:45PM +0900, Masahiro Yamada wrote: > On Thu, Nov 23, 2023 at 6:05 PM Greg KH wrote: > > > > On Wed, Nov 22, 2023 at 01:04:09PM -0800, Matthew Maurer wrote: > > > > So, even if you enable CONFIG_MODVERSIONS, > > > > nothin

Re: [PATCH v1] powerpc: Add PVN support for HeXin C2000 processor

2023-11-23 Thread Greg KH
On Thu, Nov 23, 2023 at 05:36:11PM +0800, Zhao Ke wrote: > HeXin Tech Co. has applied for a new PVN from the OpenPower Community > for its new processor C2000. The OpenPower has assigned a new PVN > and this newly assigned PVN is 0x0066, add pvr register related > support for this PVN. > > Signed-

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-23 Thread Greg KH
On Wed, Nov 22, 2023 at 01:04:09PM -0800, Matthew Maurer wrote: > > So, even if you enable CONFIG_MODVERSIONS, > > nothing is checked for Rust. > > Genksyms computes a CRC from "int foo", and > > the module subsystem confirms it is a "int" > > variable. > > > > We know this check always succeeds. >

Re: [PATCH v2 2/5] modules: Refactor + kdoc elf_validity_cached_copy

2023-11-18 Thread Greg KH
On Sat, Nov 18, 2023 at 02:54:43AM +, Matthew Maurer wrote: > Functionality is almost identical, just structured for better > documentation and readability. Changes: > > * Section names are checked for *all* non-SHT_NULL sections, not just > SHF_ALLOC sections. We have code that accesses sec

Re: [PATCH v2 1/5] export_report: Rehabilitate script

2023-11-18 Thread Greg KH
On Sat, Nov 18, 2023 at 02:54:42AM +, Matthew Maurer wrote: > * modules.order has .o files when in a build dir, support this > * .mod.c source layout has changed, update regexes to match > * Add a stage 3, to be more robust against additional .mod.c content When you have to list different thin

Re: [PATCH 10/10] [RFC] wifi: remove ipw2100/ipw2200 drivers

2023-10-27 Thread Greg KH
On Thu, Oct 26, 2023 at 12:41:27PM +0300, Kalle Valo wrote: > For example, I see lots of dead code under '#ifdef NOT_YET' and '#if 0', > removing those is a good a start. Also converting the ugly debug_level > procfs file to something more modern would be nice, maybe using just > dev_dbg() throught

Re: linux-next: manual merge of the tty tree with the powerpc tree

2023-08-22 Thread Greg KH
On Fri, Aug 18, 2023 at 02:58:26PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the tty tree got a conflict in: > > arch/powerpc/include/asm/fs_pd.h > > between commits: > > e6e077cb2aa4 ("powerpc/include: Declare mpc8xx_immr in 8xx_immap.h") > fecc436a97af ("p

Re: Fwd: Memory corruption in multithreaded user space program while calling fork

2023-07-05 Thread Greg KH
On Wed, Jul 05, 2023 at 10:51:57AM +0200, Linux regression tracking (Thorsten Leemhuis) wrote: > On 05.07.23 09:08, Greg KH wrote: > > On Tue, Jul 04, 2023 at 01:22:54PM -0700, Suren Baghdasaryan wrote: > >> On Tue, Jul 4, 2023 at 9:18 AM Andrew Morton > >> wrote: >

Re: Fwd: Memory corruption in multithreaded user space program while calling fork

2023-07-05 Thread Greg KH
On Tue, Jul 04, 2023 at 01:22:54PM -0700, Suren Baghdasaryan wrote: > On Tue, Jul 4, 2023 at 9:18 AM Andrew Morton > wrote: > > > > On Tue, 4 Jul 2023 09:00:19 +0100 Greg KH > > wrote: > > > > > > > > > Thanks! I'll investigate this lat

Re: Fwd: Memory corruption in multithreaded user space program while calling fork

2023-07-04 Thread Greg KH
On Tue, Jul 04, 2023 at 12:45:39AM -0700, Suren Baghdasaryan wrote: > On Mon, Jul 3, 2023 at 11:44 AM Greg KH wrote: > > > > On Mon, Jul 03, 2023 at 11:27:19AM -0700, Suren Baghdasaryan wrote: > > > On Mon, Jul 3, 2023 at 11:08 AM Suren Baghdasaryan > > > wro

Re: Fwd: Memory corruption in multithreaded user space program while calling fork

2023-07-03 Thread Greg KH
On Mon, Jul 03, 2023 at 11:27:19AM -0700, Suren Baghdasaryan wrote: > On Mon, Jul 3, 2023 at 11:08 AM Suren Baghdasaryan wrote: > > > > On Mon, Jul 3, 2023 at 2:53 AM Linux regression tracking (Thorsten > > Leemhuis) wrote: > > > > > > On 02.07.23 14:27, Bagas Sanjaya wrote: > > > > I notice a re

Re: [PATCH] powerpc: fix debugfs_create_dir error checking

2023-05-28 Thread Greg KH
On Sun, May 28, 2023 at 01:16:44PM +0530, mirim...@outlook.com wrote: > From: Immad Mir > > The debugfs_create_dir returns ERR_PTR incase of an error and the > correct way of checking it by using the IS_ERR inline function, and > not the simple null comparision. This patch fixes this. > > Sugges

Re: Symbol cpu_feature_keys should be exported to all modules on powerpc

2023-02-28 Thread Greg KH
On Tue, Feb 28, 2023 at 04:18:12PM +0800, 王昊然 wrote: > Just like symbol 'mmu_feature_keys'[1], 'cpu_feature_keys' was referenced > indirectly by many inline functions; any GPL-incompatible modules using such > a function will be potentially broken due to 'cpu_feature_keys' being > exported as GPL-o

Re: [PATCH v2] usb: fix some spelling mistakes in comment of gadget

2023-02-16 Thread Greg KH
On Wed, Feb 15, 2023 at 05:35:35PM -0800, Zhou nan wrote: > usb: Fix spelling mistake in comments of gadget. > > Signed-off-by: Zhou nan > --- Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to t

Re: [PATCH] usb: fix some spelling mistakes in comment

2023-02-15 Thread Greg KH
On Wed, Feb 15, 2023 at 12:43:24AM -0800, Zhou nan wrote: > Fix typos in comment. > > Signed-off-by: Zhou nan > --- > drivers/usb/gadget/udc/fsl_udc_core.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c > b/drivers/usb/gad

Re: [PATCH v2 3/6] hvcs: Use driver groups to manage driver attributes

2023-02-02 Thread Greg KH
On Thu, Feb 02, 2023 at 04:28:01PM -0600, Brian King wrote: > Rather than manually creating attributes for the hvcs driver, > let the driver core do this for us. This also fixes some hotplug > remove issues and ensures that cleanup of these attributes > is done in the right order. > > Signed-off-b

Re: [PATCH v2 1/6] hvcs: Fix hvcs port reference counting

2023-02-02 Thread Greg KH
On Thu, Feb 02, 2023 at 04:27:59PM -0600, Brian King wrote: > The hvcs driver only ever gets two references to the port. One > at initialization time, and one at install time. Remove the code > that was trying to do multiple port puts for each open, which > would result in more puts than gets. > >

Re: [PATCH v2 2/6] hvcs: Use dev_groups to manage hvcs device attributes

2023-02-02 Thread Greg KH
On Thu, Feb 02, 2023 at 04:28:00PM -0600, Brian King wrote: > Use the dev_groups functionality to manage the attribute groups > for hvcs devices. This simplifies the code and also eliminates > errors coming from kernfs when attempting to remove a console > device that is in use. > > Signed-off-by:

Re: [PATCH 2/6] hvcs: Remove sysfs file prior to vio unregister

2023-02-01 Thread Greg KH
On Wed, Feb 01, 2023 at 01:57:39PM -0600, Brian King wrote: > This moves the removal of the rescan sysfs attribute to occur > before the call to unregister the vio to ensure the removal > does not fail due to the vio driver already being freed. > > Signed-off-by: Brian King > --- > drivers/tty/h

Re: [PATCH 3/6] hvcs: Remove sysfs group earlier

2023-02-01 Thread Greg KH
On Wed, Feb 01, 2023 at 01:57:40PM -0600, Brian King wrote: > Cleanup the sysfs group earlier in remove. This eliminates > errors coming from kernfs when attempting to remove a console > device that is in use. > > Signed-off-by: Brian King > --- > drivers/tty/hvc/hvcs.c | 4 ++-- > 1 file change

Re: [PATCH 6/6] powerpc/pseries: Implement secvars for dynamic secure boot

2022-12-28 Thread Greg KH
On Wed, Dec 28, 2022 at 06:29:43PM +1100, Russell Currey wrote: > The pseries platform can support dynamic secure boot (i.e. secure boot > using user-defined keys) using variables contained with the PowerVM LPAR > Platform KeyStore (PLPKS). Using the powerpc secvar API, expose the > relevant varia

Re: [PATCH] [Backport for 4.14] perf script python: Remove explicit shebang from tests/attr.c

2022-12-19 Thread Greg KH
On Mon, Dec 19, 2022 at 12:21:47PM +, Christophe Leroy wrote: > > > Le 19/12/2022 à 13:18, Greg KH a écrit : > > On Fri, Dec 16, 2022 at 12:38:12PM +0100, Christophe Leroy wrote: > >> From: Tony Jones > >> > >> [Upstream commit d72eadbc1d2866f

Re: [PATCH] [Backport for 4.14] perf script python: Remove explicit shebang from tests/attr.c

2022-12-19 Thread Greg KH
On Fri, Dec 16, 2022 at 12:38:12PM +0100, Christophe Leroy wrote: > From: Tony Jones > > [Upstream commit d72eadbc1d2866fc047edd4535ffb0298fe240be] > > tests/attr.c invokes attr.py via an explicit invocation of Python > ($PYTHON) so there is therefore no need for an explicit shebang. > > Also m

Re: [PATCH] [REBASED for 4.14] once: add DO_ONCE_SLOW() for sleepable contexts

2022-12-14 Thread Greg KH
On Tue, Dec 13, 2022 at 01:22:40PM +0100, Christophe Leroy wrote: > From: Eric Dumazet > > [ Upstream commit 62c07983bef9d3e78e71189441e1a470f0d1e653 ] > > Christophe Leroy reported a ~80ms latency spike > happening at first TCP connect() time. > > This is because __inet_hash_connect() uses get

Re: [PATCH 2/6] macio: Make remove callback of macio driver void returned

2022-12-05 Thread Greg KH
On Mon, Dec 05, 2022 at 11:36:40PM +0800, Dawei Li wrote: > Commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. > > This chan

Re: [PATCH 6/6] soundbus: make remove callback of soundbus driver void returned

2022-12-05 Thread Greg KH
On Mon, Dec 05, 2022 at 11:36:44PM +0800, Dawei Li wrote: > Since commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. > > Thi

Re: [PATCH 5/6] ac97: make remove callback of ac97 driver void returned

2022-12-05 Thread Greg KH
On Mon, Dec 05, 2022 at 11:36:43PM +0800, Dawei Li wrote: > Since commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. > > Thi

Re: [PATCH 4/6] xen: make remove callback of xen driver void returned

2022-12-05 Thread Greg KH
On Mon, Dec 05, 2022 at 11:36:42PM +0800, Dawei Li wrote: > Since commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. Please

Re: [PATCH 0/6] Make remove() of any bus based driver void returned

2022-12-05 Thread Greg KH
On Mon, Dec 05, 2022 at 11:36:38PM +0800, Dawei Li wrote: > For bus-based driver, device removal is implemented as: > device_remove() => bus->remove() => driver->remove() > > Driver core needs no feedback from bus driver about the result of > remove callback. In which case, commit fc7a6209d571 ("b

Re: [PATCH] powerpc/boot: Convert more files to use SPDX tags

2022-08-19 Thread Greg KH
On Fri, Aug 19, 2022 at 09:04:30PM +1000, Michael Ellerman wrote: > These files are all plain GPL 2.0, with a second sentence about being > licensed as-is. > > Similar to the rule in commit 577b61cee5b2 ("treewide: Replace GPLv2 > boilerplate/reference with SPDX - gpl-2.0_398.RULE"). > > Signed-o

Re: [PATCH] [backport for 4.14] powerpc/ptdump: Fix display of RW pages on FSL_BOOK3E

2022-08-19 Thread Greg KH
On Tue, Aug 16, 2022 at 10:45:29AM +0200, Christophe Leroy wrote: > [ Upstream commit dd8de84b57b02ba9c1fe530a6d916c0853f136bd ] > > On FSL_BOOK3E, _PAGE_RW is defined with two bits, one for user and one > for supervisor. As soon as one of the two bits is set, the page has > to be display as RW. B

Re: [PATCH] macintosh:fix oob read in do_adb_query function

2022-07-13 Thread Greg KH
On Wed, Jul 13, 2022 at 11:37:34PM +0800, Ning Qiang wrote: > In do_adb_query function of drivers/macintosh/adb.c, req->data is copy > form userland. the parameter "req->data[2]" is Missing check, the > array size of adb_handler[] is 16, so "adb_handler[ > req->data[2]].original_address" and "adb_

Re: [PATCH] macintosh:fix oob read in do_adb_query function

2022-07-13 Thread Greg KH
On Wed, Jul 13, 2022 at 09:40:37PM +0800, NAME wrote: > From: sohu0106 For obvious reasons, we need a real name here, and in the signed-off-by line. > In do_adb_query function of drivers/macintosh/adb.c, > req->data is copy form userland. The parameter > "req->data[2]" is Missing check, the arra

Re: [linux-next:master] BUILD REGRESSION 088b9c375534d905a4d337c78db3b3bfbb52c4a0

2022-07-07 Thread Greg KH
org, net...@vger.kernel.org, k...@vger.kernel.org, da...@lists.linux.dev, linux...@kvack.org, accessrunner-gene...@lists.sourceforge.net, linux1394-de...@lists.sourceforge.net, linux-l...@vger.kernel.org, rds-de...@oss.oracle.com, linux-...@vger.kernel.org, d...@vger.kernel.org, intel-wired-...

Re: [PATCH] cxl: drop unexpected word "the" in the comments

2022-07-01 Thread Greg KH
On Thu, Jun 30, 2022 at 11:10:13AM +1000, Andrew Donnellan wrote: > On Wed, 2022-06-29 at 22:15 +1000, Michael Ellerman wrote: > > On Tue, 21 Jun 2022 20:53:21 +0800, Jiang Jian wrote: > > > there is an unexpected word "the" in the comments that need to be > > > dropped > > > > > > file: drivers/m

Re: [PATCH v4.9] kexec_file: drop weak attribute from arch_kexec_apply_relocations[_add]

2022-06-30 Thread Greg KH
On Tue, Jun 28, 2022 at 09:12:48PM +0530, Naveen N. Rao wrote: > commit 3e35142ef99fe6b4fe5d834ad43ee13cca10a2dc upstream. > > Since commit d1bcae833b32f1 ("ELF: Don't generate unused section > symbols") [1], binutils (v2.36+) started dropping section symbols that > it thought were unused. This i

Re: [PATCH v5.18] powerpc/ftrace: Remove ftrace init tramp once kernel init is complete

2022-06-30 Thread Greg KH
On Mon, Jun 27, 2022 at 11:09:29PM +0530, Naveen N. Rao wrote: > commit 84ade0a6655bee803d176525ef457175cbf4df22 upstream. > > Stop using the ftrace trampoline for init section once kernel init is > complete. > > Fixes: 67361cf8071286 ("powerpc/ftrace: Handle large kernel configs") > Cc: sta...@v

Re: [PATCH RFC] drivers/usb/ehci-fsl: Fix interrupt setup in host mode.

2022-06-21 Thread Greg KH
On Tue, Jun 21, 2022 at 11:09:41PM +0100, Darren Stevens wrote: > In patch a1a2b7125e1079 (Drop static setup of IRQ resource from DT > core) we stopped platform_get_resource() from returning the IRQ, as all > drivers were supposed to have switched to platform_get_irq() > Unfortunately the Freescale

Re: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation

2022-06-14 Thread Greg KH
On Tue, Jun 14, 2022 at 07:53:46AM +, Wenhu Wang wrote: > >> >> + > >> >> +struct mpc85xx_l2ctlr { > >> >> + u32 ctl;/* 0x000 - L2 control */ > >> > > >> >What is the endian of these u32 values? You map them directly to > >> >memory, so they must be specified some way, righ

Re: 回复: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation

2022-06-13 Thread Greg KH
On Tue, Jun 14, 2022 at 06:09:35AM +, Wenhu Wang wrote: > Hi Greg, thanks for the comments. > The questions are replied specifically below. > I have figured out and tested the patch v2, which is to be posted later. > >发件人: Greg KH > >发送时间: 2022年6月9日 21:17 >

Re: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation

2022-06-09 Thread Greg KH
On Thu, Jun 09, 2022 at 03:28:55AM -0700, Wang Wenhu wrote: > The l2-cache could be optionally configured as SRAM partly or fully. > Users can make use of it as a block of independent memory that offers > special usage, such as for debuging or other cratical status info > storage which keeps consis

Re: [PATCH for v5.15] perf symbol: Remove arch__symbols__fixup_end()

2022-05-03 Thread Greg KH
On Mon, May 02, 2022 at 05:37:36PM -0700, Namhyung Kim wrote: > Now the generic code can handle kallsyms fixup properly so no need to > keep the arch-functions anymore. > > Signed-off-by: Namhyung Kim > Acked-by: Ian Rogers > Cc: Heiko Carstens > Cc: Ingo Molnar > Cc: Jiri Olsa > Cc: John Gar

Re: [PATCH v4.19 0/2] Custom backports for powerpc SLB issues

2022-04-29 Thread Greg KH
On Thu, Apr 28, 2022 at 10:41:48PM +1000, Michael Ellerman wrote: > Hi Greg, > > Here are two custom backports to v4.19 for some powerpc issues we've > discovered. > Both were fixed upstream as part of a large non-backportable rewrite. Other > stable > kernel versions are not affected. > > chee

Re: [PATCH v5 05/10] serial: termbits: ADDRB to indicate 9th bit addressing mode

2022-04-26 Thread Greg KH
On Tue, Apr 26, 2022 at 05:01:31PM +0300, Ilpo Järvinen wrote: > One additional thing below I missed on the first read. > > On Tue, 26 Apr 2022, Ilpo Järvinen wrote: > > On Tue, 26 Apr 2022, Greg KH wrote: > > > > > On Tue, Apr 26, 2022 at 03:24:43PM +0300, Ilpo Jär

Re: [PATCH v5 06/10] serial: General support for multipoint addresses

2022-04-26 Thread Greg KH
On Tue, Apr 26, 2022 at 04:36:49PM +0300, Ilpo Järvinen wrote: > On Tue, 26 Apr 2022, Greg KH wrote: > > > On Tue, Apr 26, 2022 at 03:24:44PM +0300, Ilpo Järvinen wrote: > > > Add generic support for serial multipoint addressing. Two new ioctls > > > are added. TIO

Re: [PATCH v5 06/10] serial: General support for multipoint addresses

2022-04-26 Thread Greg KH
On Tue, Apr 26, 2022 at 03:24:44PM +0300, Ilpo Järvinen wrote: > Add generic support for serial multipoint addressing. Two new ioctls > are added. TIOCSADDR is used to indicate the destination/receive > address. TIOCGADDR returns the current address in use. The driver > should implement set_addr an

Re: [PATCH v5 05/10] serial: termbits: ADDRB to indicate 9th bit addressing mode

2022-04-26 Thread Greg KH
On Tue, Apr 26, 2022 at 03:24:43PM +0300, Ilpo Järvinen wrote: > Add ADDRB to termbits to indicate 9th bit addressing mode. This change > is necessary for supporting devices with RS485 multipoint addressing > [*]. A later patch in the patch series adds support for Synopsys > Designware UART capable

Re: [PATCH] [Rebased for 5.4] powerpc/kasan: Fix early region not updated correctly

2022-04-04 Thread Greg KH
On Sun, Apr 03, 2022 at 03:49:43PM +0200, Christophe Leroy wrote: > From: Chen Jingwen > > This is backport for 5.4 > > Upstream commit dd75080aa8409ce10d50fb58981c6b59bf8707d3 Now queued up, thanks. greg k-h

Re: [PATCH] [Rebased for 5.4] powerpc/kasan: Fix early region not updated correctly

2022-04-03 Thread Greg KH
On Sun, Apr 03, 2022 at 11:54:55AM +, Christophe Leroy wrote: > > > Le 03/04/2022 à 12:25, Greg KH a écrit : > > On Sat, Apr 02, 2022 at 06:13:31PM +0200, Christophe Leroy wrote: > >> From: Chen Jingwen > >> > >> This is

Re: [PATCH] [Rebased for 5.4] powerpc/kasan: Fix early region not updated correctly

2022-04-03 Thread Greg KH
On Sat, Apr 02, 2022 at 06:13:31PM +0200, Christophe Leroy wrote: > From: Chen Jingwen > > This is backport for 5.4 > > Upstream commit 5647a94a26e352beed61788b46e035d9d12664cd This is not a commit in Linus's tree :(

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread Greg KH
On Tue, Mar 01, 2022 at 06:40:04PM +0100, Jakob Koschel wrote: > > > > On 1. Mar 2022, at 18:36, Greg KH wrote: > > > > On Tue, Mar 01, 2022 at 12:28:15PM +0100, Jakob Koschel wrote: > >> > >> > >>> On 1. Mar 2022, at 01:41, Linus Torval

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread Greg KH
On Tue, Mar 01, 2022 at 12:28:15PM +0100, Jakob Koschel wrote: > > > > On 1. Mar 2022, at 01:41, Linus Torvalds > > wrote: > > > > On Mon, Feb 28, 2022 at 1:47 PM Jakob Koschel > > wrote: > >> > >> The goal of this is to get compiler warnings right? This would indeed be > >> great. > > >

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread Greg KH
On Mon, Feb 28, 2022 at 01:06:57PM +0100, Jakob Koschel wrote: > > > > On 28. Feb 2022, at 12:20, Greg KH wrote: > > > > On Mon, Feb 28, 2022 at 12:08:18PM +0100, Jakob Koschel wrote: > >> If the list does not contain the expected element, the value of > &g

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Greg KH
On Mon, Feb 28, 2022 at 12:08:18PM +0100, Jakob Koschel wrote: > If the list does not contain the expected element, the value of > list_for_each_entry() iterator will not point to a valid structure. > To avoid type confusion in such case, the list iterator > scope will be limited to list_for_each_e

Re: [PATCH 03/14] nds32: fix access_ok() checks in get/put_user

2022-02-15 Thread Greg KH
On Tue, Feb 15, 2022 at 10:18:15AM +0100, Arnd Bergmann wrote: > On Mon, Feb 14, 2022 at 6:01 PM Christoph Hellwig wrote: > > > > On Mon, Feb 14, 2022 at 05:34:41PM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > The get_user()/put_user() functions are meant to check for > > > a

Re: [PATCH] Styleguide fix: Removed un-needed whitespaces and formatting errors in drivers/tty

2022-02-06 Thread Greg KH
On Mon, Feb 07, 2022 at 12:33:07AM +0530, Ankit Kumar Pandey wrote: > There were lot of styleguide errors raised by checkpatch.pl against > drivers/tty/* which I have fixed. There is zero code change apart from > changes related to styleguide. checkpatch.pl returns 0 error for > style guide now. >

Re: [PATCH v2 3/3] vstatus: Display an informational message when the VSTATUS character is pressed or TIOCSTAT ioctl is called.

2022-02-06 Thread Greg KH
On Sun, Feb 06, 2022 at 07:48:54AM -0800, Walt Drummond wrote: > When triggered by pressing the VSTATUS key or calling the TIOCSTAT > ioctl, the n_tty line discipline will display a message on the user's > tty that provides basic information about the system and an > 'interesting' process in the cu

Re: [PATCH v2 2/3] status: Add user space API definitions for VSTATUS, NOKERNINFO and TIOCSTAT

2022-02-06 Thread Greg KH
On Sun, Feb 06, 2022 at 07:48:53AM -0800, Walt Drummond wrote: > Add definitions for the VSTATUS control character, and the NOKERNINFO > local control flag in the termios struct, and add an ioctl number for > the ioctl TIOCSTAT. Also add a default VSTATUS character (Ctrl-T) > default valuses in te

Re: [PATCH v7 0/5] Allow guest access to EFI confidential computing secret area

2022-02-02 Thread Greg KH
On Wed, Feb 02, 2022 at 08:04:01AM +, Matthew Garrett wrote: > On Wed, Feb 02, 2022 at 08:22:03AM +0100, Ard Biesheuvel wrote: > > On Wed, 2 Feb 2022 at 08:10, Matthew Garrett wrote: > > > Which other examples are you thinking of? I think this conversation may > > > have accidentally become co

Re: [PATCH v7 0/5] Allow guest access to EFI confidential computing secret area

2022-02-01 Thread Greg KH
On Wed, Feb 02, 2022 at 06:54:43AM +, Matthew Garrett wrote: > On Wed, Feb 02, 2022 at 07:10:02AM +0100, Greg KH wrote: > > On Wed, Feb 02, 2022 at 04:01:57AM +, Matthew Garrett wrote: > > > We're talking about things that have massively different semantics.

Re: [PATCH v7 0/5] Allow guest access to EFI confidential computing secret area

2022-02-01 Thread Greg KH
On Wed, Feb 02, 2022 at 04:01:57AM +, Matthew Garrett wrote: > On Tue, Feb 01, 2022 at 09:24:50AM -0500, James Bottomley wrote: > > On Tue, 2022-02-01 at 14:50 +0100, Greg KH wrote: > > > You all need to work together to come up with a unified place for > > > this

Re: [PATCH v7 0/5] Allow guest access to EFI confidential computing secret area

2022-02-01 Thread Greg KH
On Tue, Feb 01, 2022 at 09:24:50AM -0500, James Bottomley wrote: > [cc's added] > On Tue, 2022-02-01 at 14:50 +0100, Greg KH wrote: > > On Tue, Feb 01, 2022 at 12:44:08PM +, Dov Murik wrote: > [...] > > > # ls -la /sys/kernel/security/coco/efi_secret > > >

Re: [RFC PATCH 0/2] powerpc/pseries: add support for local secure storage called Platform Keystore(PKS)

2022-02-01 Thread Greg KH
On Mon, Jan 24, 2022 at 11:25:17AM +1100, Daniel Axtens wrote: > Hi Greg, > > > Ok, this is like the 3rd or 4th different platform-specific proposal for > > this type of functionality. I think we need to give up on > > platform-specific user/kernel apis on this (random sysfs/securityfs > > files

Re: [PATCH 0/3] status: TTY status message request

2022-01-26 Thread Greg KH
On Mon, Jan 17, 2022 at 08:42:57PM -0800, Walt Drummond wrote: > This patchset adds TTY status message request feature to the n_tty > line dicipline. This feature prints a brief message containing basic > system and process group information to a user's TTY in response to a > new control character

Re: [RFC PATCH 0/2] powerpc/pseries: add support for local secure storage called Platform Keystore(PKS)

2022-01-21 Thread Greg KH
On Fri, Jan 21, 2022 at 07:56:35PM -0500, Nayna Jain wrote: > PowerVM provides an isolated Platform Keystore(PKS) storage allocation > for each partition with individually managed access controls to store > sensitive information securely. Linux Kernel can access this storage by > interfacing with h

Re: [PATCH stable 4.19 1/1] arch: pgtable: define MAX_POSSIBLE_PHYSMEM_BITS where needed

2021-11-04 Thread Greg KH
On Wed, Nov 03, 2021 at 01:56:56PM -0700, Florian Fainelli wrote: > From: Arnd Bergmann > > [ Upstream commit cef397038167ac15d085914493d6c86385773709 ] > > Stefan Agner reported a bug when using zsram on 32-bit Arm machines > with RAM above the 4GB address boundary: > > Unable to handle kern

Re: [PATCH v11 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-25 Thread Greg KH
On Tue, Oct 26, 2021 at 02:11:51PM +0800, Xianting Tian wrote: > > 在 2021/10/26 下午2:10, Greg KH 写道: > > On Tue, Oct 26, 2021 at 02:02:21PM +0800, Xianting Tian wrote: > > > 在 2021/10/26 下午1:10, Jiri Slaby 写道: > > > > On 15. 10. 21, 4:46, Xianting Tian wrote: >

Re: [PATCH v11 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-25 Thread Greg KH
On Tue, Oct 26, 2021 at 02:02:21PM +0800, Xianting Tian wrote: > 在 2021/10/26 下午1:10, Jiri Slaby 写道: > > On 15. 10. 21, 4:46, Xianting Tian wrote: > > > @@ -151,9 +142,11 @@ static uint32_t vtermnos[MAX_NR_HVC_CONSOLES] = > > >   static void hvc_console_print(struct console *co, const char *b, > >

Re: Stable backport request

2021-10-24 Thread Greg KH
On Sun, Oct 24, 2021 at 09:21:09AM +1100, Michael Ellerman wrote: > Hi Greg, > > Please backport the following commit to v5.4 and v5.10: > > 73287caa9210ded6066833195f4335f7f688a46b > ("powerpc64/idle: Fix SP offsets when saving GPRs") > > > And please backport the following commits to v5.4

Re: [PATCH v11 0/3] make hvc pass dma capable memory to its backend

2021-10-21 Thread Greg KH
On Fri, Oct 15, 2021 at 10:46:55AM +0800, Xianting Tian wrote: > Dear all, > > This patch series make hvc framework pass DMA capable memory to > put_chars() of hvc backend(eg, virtio-console), and revert commit > c4baad5029 ("virtio-console: avoid DMA from stack”) Thanks for sticking with this, l

Re: [PATCH v11 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-20 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

  1   2   3   4   5   6   >