Re: [PATCH] tools/perf: Handle perftool-testsuite_probe testcases fail when kernel debuginfo is not present

2024-06-20 Thread James Clark
On 18/06/2024 11:44, James Clark wrote: > > > On 17/06/2024 17:47, Athira Rajeev wrote: >> >> >>> On 17 Jun 2024, at 8:30 PM, James Clark wrote: >>> >>> >>> >>> On 17/06/2024 13:21, Athira Rajeev wrote: >>>&g

Re: [PATCH] tools/perf: Handle perftool-testsuite_probe testcases fail when kernel debuginfo is not present

2024-06-18 Thread James Clark
On 17/06/2024 17:47, Athira Rajeev wrote: > > >> On 17 Jun 2024, at 8:30 PM, James Clark wrote: >> >> >> >> On 17/06/2024 13:21, Athira Rajeev wrote: >>> Running "perftool-testsuite_probe" fails as below: >>> >>> .

Re: [PATCH] tools/perf: Handle perftool-testsuite_probe testcases fail when kernel debuginfo is not present

2024-06-17 Thread James Clark
On 17/06/2024 13:21, Athira Rajeev wrote: > Running "perftool-testsuite_probe" fails as below: > > ./perf test -v "perftool-testsuite_probe" > 83: perftool-testsuite_probe : FAILED > > There are three fails: > > 1. Regexp not found: "\s*probe:inode_permission(?:_\d+)?\s+\(on >

Re: [PATCH V2 2/3] tools/perf: Use is_perf_pid_map_name helper function to check dso's of pattern /tmp/perf-%d.map

2024-06-17 Thread James Clark
On 17/06/2024 14:03, Athira Rajeev wrote: > commit 80d496be89ed ("perf report: Add support for profiling JIT > generated code") added support for profiling JIT generated code. > This patch handles dso's of form "/tmp/perf-$PID.map". > > Some of the references doesn't check exactly for same

Re: [PATCH V4] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf

2023-11-27 Thread James Clark
O_SHELLCHECK, cleaning and with and without shellcheck installed etc. Reviewed-by: James Clark > $ for F in $(find tests/shell/ -perm -o=x -name '*.sh'); do shellcheck > -S warning $F; done > > Condition for shellcheck is added in Makefile.perf to avoid build > breakage in the

Re: [PATCH V3] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf

2023-10-23 Thread James Clark
On 13/10/2023 08:36, Athira Rajeev wrote: > Add rule in new Makefile "tests/Makefile.tests" for running > shellcheck on shell test scripts. This automates below shellcheck > into the build. > > $ for F in $(find tests/shell/ -perm -o=x -name '*.sh'); do shellcheck > -S warning $F; done

Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-10-05 Thread James Clark
quit) > trcdevarch=$(cat ${cs_etm_path}/mgmt/trcdevarch) > archhver=$((($trcdevarch >> 12) & 0xf)) > archpart=$(($trcdevarch & 0xfff)) > > - if [ $archhver -eq 5 -a "$(printf "0x%X\n" $archpart)" = "0xA13" ] ; > then > + if [ $archhver -eq 5 ] && [ "$(printf "0x%X\n" $archpart)" = "0xA13" ] > ; then > echo "ete" > else > echo "etm" Reviewed-by: James Clark

Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-10-05 Thread James Clark
On 05/10/2023 06:02, Namhyung Kim wrote: > On Thu, Sep 28, 2023 at 9:11 PM Athira Rajeev > wrote: >> >> Running shellcheck on tests/shell/test_arm_coresight.sh >> throws below warnings: >> >> In tests/shell/test_arm_coresight.sh line 15: >> cs_etm_path=$(find

Re: [PATCH 13/22] tools/perf/tests: Fix shellcheck warning for coresight.sh shell script

2023-06-27 Thread James Clark
On 21/06/2023 09:30, Athira Rajeev wrote: > From: Kajol Jain > > Running shellcheck on coresight.sh throws below warning: > > In lib/coresight.sh line 1: > ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a > shebang or a 'shell' directive. > > In lib/coresight.sh

Re: [PATCH] tools/perf: Fix aggr_printout to display cpu field irrespective of core value

2022-09-29 Thread James Clark
On 29/09/2022 09:49, Athira Rajeev wrote: > > >> On 28-Sep-2022, at 9:05 PM, James Clark wrote: >> >> >> > > Hi James, > > Thanks for looking at the patch and sharing review comments. > >> On 13/09/2022 12:57, Athira Rajeev wrote:

Re: [PATCH] tools/perf: Fix aggr_printout to display cpu field irrespective of core value

2022-09-28 Thread James Clark
On 13/09/2022 12:57, Athira Rajeev wrote: > perf stat includes option to specify aggr_mode to display > per-socket, per-core, per-die, per-node counter details. > Also there is option -A ( AGGR_NONE, -no-aggr ), where the > counter values are displayed for each cpu along with "CPU" > value in

Re: [PATCH] perf vendor events power10: Add metric events json file for power10 platform

2021-10-08 Thread James Clark
On 06/10/2021 08:31, Kajol Jain wrote: > Add pmu metric json file for power10 platform. > > Signed-off-by: Kajol Jain > --- > .../arch/powerpc/power10/metrics.json | 772 ++ I checked this with the new strict JSON parser from "[PATCH 0/3] perf tools: Enable strict