Re: [PATCH] natsemi: fix for PPC 44x platforms

2008-04-12 Thread Jeff Garzik
Sergei Shtylyov wrote: The driver stores the the PCI resource address into 'unsigned long' variable before calling ioremap() on it. This warrants kernel oops when the registers are accessed on PPC 44x platforms which (being 32-bit) have PCI memory space mapped beyond 4 GB. The arch/ppc/ kernel h

Re: [PATCH] fs_enet: Don't call NAPI functions when NAPI is not used.

2008-04-11 Thread Jeff Garzik
Laurent Pinchart wrote: fs_enet_close() calls napi_disable() unconditionally. This patch skips the call when use_napi isn't set. Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/

Re: [patch] PS3: Fix gelic net module dependency

2008-04-09 Thread Jeff Garzik
' ps3_gelic_net.c:1337: undefined reference to `.ps3_sys_manager_set_wol' CC: Masakazu Mokuno <[EMAIL PROTECTED]> CC: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Geoff Levand <[EMAIL PROTECTED]> --- Hi Paul, This fixes an error introduced in my 2.6.26 WOL patches now queued i

Re: [PATCH 1/2] ibm_newemac: PowerPC 440GX EMAC PHY clock workaround

2008-03-28 Thread Jeff Garzik
Valentine Barshak wrote: The PowerPC 440GX Taishan board fails to reset EMAC3 (reset timeout error) if there's no link. Because of that it fails to find PHY chip. The older ibm_emac driver had a workaround for that: the EMAC_CLK_INTERNAL/EMAC_CLK_EXTERNAL macros, which toggle the Ethernet Clock

Re: [PATCH 2/2 v2] pasemi_mac: Netpoll support

2008-03-28 Thread Jeff Garzik
Olof Johansson wrote: Add netpoll support to allow use of netconsole. Signed-off-by: Nate Case <[EMAIL PROTECTED]> Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- Changed the interrupt handler arguments as found by Valentine. Will push through powerpc.git with Jeff's ACKs (that were

Re: [PATCH] ibm_newemac: emac_tx_csum typo fix

2008-03-28 Thread Jeff Garzik
Valentine Barshak wrote: Move the "&& skb->ip_summed == CHECKSUM_PARTIAL" part out of emac_has_feature parameters. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -pruN linux-2.6.orig/dri

Re: [PATCH] Make pasemi_mac.c depend on PPC_PASEMI to prevent link errors

2008-03-28 Thread Jeff Garzik
Michael Ellerman wrote: drivers/net/pasemi_mac.c is enabled by CONFIG_PASEMI_MAC, which depends on PPC64 && PCI. However pasemi_mac.c uses several routines that are only built when PPC_PASEMI is selected. This can lead to an unbuildable config: ERROR: ".pasemi_dma_start_chan" [drivers/net/pasem

Re: [patch 6/6] PS3: Gelic network driver Wake-on-LAN support

2008-03-28 Thread Jeff Garzik
Geoff Levand wrote: From: Masakazu Mokuno <[EMAIL PROTECTED]> Add Wake-on-LAN support to the PS3 Gelic network driver. Other OS WOL support was introduced in PS3 system firmware 2.20. Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]> Signed-off-by: Geoff Levand <[EMAIL PROTECTED]> --- drivers

Re: [PATCH 3/3] sata_fsl: reduce compatibility to fsl,pq-sata

2008-03-28 Thread Jeff Garzik
Kumar Gala wrote: On Mar 28, 2008, at 10:51 AM, Kim Phillips wrote: as prescribed in Documentation/powerpc/booting-without-of.txt. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> --- Jeff, I'll take this via the powerpc tree if you don

Re: [PATCH 0/2] Two more pasemi_mac patches for 2.6.26

2008-03-27 Thread Jeff Garzik
Olof Johansson wrote: On Wed, Mar 26, 2008 at 12:12:30AM -0400, Jeff Garzik wrote: Olof Johansson wrote: Hi Jeff, The below two patches go on top of the previous patches that were acked by you but applied to pasemi.git for feed up through powerpc.git. One is a couple of fixes for various

Re: [PATCH 0/2] Two more pasemi_mac patches for 2.6.26

2008-03-25 Thread Jeff Garzik
Olof Johansson wrote: Hi Jeff, The below two patches go on top of the previous patches that were acked by you but applied to pasemi.git for feed up through powerpc.git. One is a couple of fixes for various corner cases in the jumbo support configuration. The second is addition of netpoll suppor

Re: [PATCH] ehea: Fix IPv6 support

2008-03-25 Thread Jeff Garzik
Thomas Klein wrote: Indicate that HEA calculates IPv4 checksums only Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h --- linux-2.6.25-rc6/drivers/net/ehea/ehea.h2008-03-17 00:32:14.00

Re: [PATCH] net: NEWEMAC: Support for Pause packets in EMAC driver

2008-03-17 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: http://marc.info/?l=linux-netdev&m=120449748701492&w=2 I sent it to Ben with netdev on CC because you asked the various people sending NEWEMAC patches to you to find a single person. So from now on, what are we going to do? It seems we're playing net maintainer ru

Re: [PATCH] net: NEWEMAC: Support for Pause packets in EMAC driver

2008-03-17 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: There's also the section mismatch patch I sent you. I don't care who's tree they go through, but I'd need to know either way so keep me in the loop please. Jeff, do you mind if we get those patches through the powerpc tree ? EMAC is very powerpc specific and these

Re: [PATCH] net: NEWEMAC: Add compatible "ibm,tah" to tah matching table

2008-03-17 Thread Jeff Garzik
Stefan Roese wrote: Add "ibm,tah" to the compatible matching table of the ibm_newemac tah driver. The type "tah" is still preserved for compatibility reasons. New dts files should use the compatible property though. Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/tah

Re: [PATCH] net: NEWEMAC: Support for Pause packets in EMAC driver

2008-03-17 Thread Jeff Garzik
Stefan Roese wrote: From: Pravin M. Bathija <[EMAIL PROTECTED]> Problem Description and Fix --- When a pause packet(with destination as reserved Multicast address) is received by the EMAC hardware to control the flow of frames being transmitted by it, it is dropped by the

Re: [PATCH] ehea: Fix missing Kconfig dependency

2008-03-05 Thread Jeff Garzik
Thomas Klein wrote: > Fixed Kconfig: ehea driver requires sparse mem > > Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> > > --- > diff -Nurp linux-2.6.25-rc3.org/drivers/net/Kconfig > linux-2.6.25-rc3/drivers/net/Kconfig > --- linux-2.6.25-rc3.org/drivers/net/Kconfig 2008-02-24 22:25:54.00

Re: [patch 0/6] pasemi_mac updates for 2.6.26

2008-02-26 Thread Jeff Garzik
Olof Johansson wrote: > On Tue, Feb 26, 2008 at 08:49:58PM +1100, Paul Mackerras wrote: >> Olof Johansson writes: >> >>> Here's a set of updates for pasemi_mac for 2.6.26. Some of them touch >>> the dma_lib in the platform code as well, but it's easier if it's all >>> merged through netdev to avoid

Re: [PATCH] sata_fsl: fix build with ATA_VERBOSE_DEBUG

2008-02-23 Thread Jeff Garzik
Anton Vorontsov wrote: > This patch fixes build and few warnings when ATA_VERBOSE_DEBUG > is defined: > > CC drivers/ata/sata_fsl.o > drivers/ata/sata_fsl.c: In function ‘sata_fsl_fill_sg’: > drivers/ata/sata_fsl.c:338: warning: format ‘%x’ expects type ‘unsigned int’, > but argument 3 has

Re: [PATCH] fs_enet: Don't call phy_mii_ioctl() in atomic context.

2008-02-20 Thread Jeff Garzik
Scott Wood wrote: > The lock acquisition in fs_ioctl() does not appear to actually be necessary, > and thus is simply removed. > > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> > --- > This fixes the following bug: > http://ozlabs.org/pipermail/linuxppc-dev/2008-February/051564.html > > drivers/

Re: [PATCH] ehea: add kdump support

2008-02-20 Thread Jeff Garzik
Thomas Klein wrote: > This patch adds kdump support to the ehea driver. As the firmware doesn't free > resource handles automatically, the driver has to run an as simple as possible > free resource function in case of a crash shutdown. The function iterates over > two arrays freeing all resource ha

Re: [PATCH 3/5 v3] Tsi108_eth: remove not needed code

2008-02-11 Thread Jeff Garzik
Alex Bounine wrote: > Code clean-up for tsi108_eth network driver. > This patch removes not needed dummy read and the corresponding comment. > The PHY logic requires two reads from the status register to get > current link status. This is done correctly inside mii_check_media(). > > Signed-off-by:

Re: [PATCH 1/5 v2] Tsi108_eth: add missing linking to driver data

2008-02-11 Thread Jeff Garzik
Alexandre Bounine wrote: > Bug fix for tsi108_eth network driver. > This patch adds missing linking to driver data. > > Signed-off-by: Alexandre Bounine <[EMAIL PROTECTED]> > --- > > diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c > linux-2.6.24-fix/drivers/net/tsi108_eth.c > --- linux-2.6.2

Re: [PATCH] net: NEWEMAC: Remove "rgmii-interface" from rgmii matching table

2008-02-11 Thread Jeff Garzik
Josh Boyer wrote: > On Wed, 6 Feb 2008 13:21:59 +0100 > Stefan Roese <[EMAIL PROTECTED]> wrote: > >> With the removal the the "rgmii-interface" device_type property from the >> dts files, the newemac driver needs an update to only rely on compatible >> property. >> >> Signed-off-by: Stefan Roese

Re: [PATCH 1/5] Tsi108_eth: add missing linking to driver data

2008-02-11 Thread Jeff Garzik
Alexandre Bounine wrote: > Bug fix for tsi108_eth network driver. > This patch adds missing linking to driver data. > > Signed-off-by: Alexandre Bounine <[EMAIL PROTECTED]> > --- > > diff -pNur linux-2.6.24/drivers/net/tsi108_eth.c > linux-2.6.24-fix/drivers/net/tsi108_eth.c > --- linux-2.6.2

Re: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources

2008-02-06 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > The e1000 driver stores the content of the PCI resources into > unsigned long's before ioremapping. This breaks on 32 bits > platforms that support 64 bits MMIO resources such as ppc 44x. > > This fixes it by removing those temporary variables and passing > directly

Re: [PATCH] net: NEWEMAC: Remove "rgmii-interface" from rgmii matching table

2008-02-06 Thread Jeff Garzik
Josh Boyer wrote: > On Thu, 31 Jan 2008 10:14:58 +1100 > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > >> On Wed, 2008-01-30 at 07:16 +0100, Stefan Roese wrote: >>> On Wednesday 16 January 2008, Josh Boyer wrote: On Wed, 16 Jan 2008 20:53:59 +1100 Benjamin Herrenschmidt <[EMAI

Re: [PATCH] [POWERPC] iSeries: fix section mismatch in iseries_veth

2008-02-05 Thread Jeff Garzik
Stephen Rothwell wrote: > WARNING: vmlinux.o(.text+0x25dca0): Section mismatch in reference from the > function .veth_probe() to the function .init.text:.veth_probe_one() > > Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> > --- > drivers/net/iseries_veth.c |2 +- > 1 files changed, 1 in

Re: [PATCH 1/5] ehea: fix ehea.h checkpatch complaints

2008-02-01 Thread Jeff Garzik
Jeff Garzik wrote: > Doug Maxey wrote: >> Cc: Jan-Bernd Themann <[EMAIL PROTECTED]> >> Signed-off-by: Doug Maxey <[EMAIL PROTECTED]> >> --- >> drivers/net/ehea/ehea.h|3 +++ >> drivers/net/ehea/ehea_hw.h |8 >> 2 files change

Re: [PATCH] ehea: fix sysfs link compile problem

2008-02-01 Thread Jeff Garzik
Jan-Bernd Themann wrote: > Due to changes in the struct device_driver there is no direct > access to its kobj any longer. The kobj was used to create > sysfs links between eHEA ethernet devices and the driver. > This patch removes the affected sysfs links to resolve > the build problems. > > Signe

Re: [PATCH for 2.6.25 1/2] [NET] ucc_geth: fix module removal

2008-02-01 Thread Jeff Garzik
Anton Vorontsov wrote: > - uccf should be set to NULL to not double-free memory on > subsequent calls; > - ind_hash_q and group_hash_q lists should be initialized in the > probe() function, instead of struct_init() (called by open()), > otherwise there will be an oops if ucc_geth_driver remov

Re: [PATCH 1/5] ehea: fix ehea.h checkpatch complaints

2008-02-01 Thread Jeff Garzik
Doug Maxey wrote: > Cc: Jan-Bernd Themann <[EMAIL PROTECTED]> > Signed-off-by: Doug Maxey <[EMAIL PROTECTED]> > --- > drivers/net/ehea/ehea.h|3 +++ > drivers/net/ehea/ehea_hw.h |8 > 2 files changed, 7 insertions(+), 4 deletions(-) applied 1-5 _

Re: [PATCH] [POWERPC][NET][SERIAL] UCCs: replace device-id with cell-index

2008-02-01 Thread Jeff Garzik
Anton Vorontsov wrote: > On Fri, Feb 01, 2008 at 09:32:38AM -0600, Kumar Gala wrote: >> On Feb 1, 2008, at 9:01 AM, Anton Vorontsov wrote: >> >>> It isn't used anywhere, so remove it. If we'll ever need something >>> like this, we'll use compatible property instead. >>> >>> Signed-off-by: Anton Vor

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

2008-01-30 Thread Jeff Garzik
Kumar Gala wrote: > > On Jan 30, 2008, at 11:09 AM, Jeff Garzik wrote: > >> Anton Vorontsov wrote: >>> On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote: >>>> Anton, >>>> >>>> it looks like the "TI AR7 CPMAC Ethernet s

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

2008-01-30 Thread Jeff Garzik
Anton Vorontsov wrote: > On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote: >> Anton, >> >> it looks like the "TI AR7 CPMAC Ethernet support" uses FIXED_PHY and >> was selecting FIXED_MII_100_FDX which is gone. >> >> Can you look into this. I get the following warning now: >> >> scripts

Re: [PATCH] [NET]: Remove PowerPC code from fec.c

2008-01-30 Thread Jeff Garzik
Jochen Friedrich wrote: > fec.c is only used on M68k Coldfire CPUs. Remove leftover > PowerPC code from this driver. > > Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> > --- > drivers/net/fec.c | 136 +--- > 1 files changed, 3 insertions(+), 1

Re: [PATCH] [POWERPC] pasemi: Move electra-ide to pata_of_platform

2008-01-15 Thread Jeff Garzik
Olof Johansson wrote: > Move electra-ide glue over to the new pata_of_platform framework, and > add the quirks needed to that driver. > > --- > > Applied with the rest of the patches to pasemi.git for-2.6.25 > > arch/powerpc/platforms/pasemi/electra_ide.c | 96 > -

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-12 Thread Jeff Garzik
Anton Vorontsov wrote: > Otherwise oops will happen if ethernet device has not been opened: > > Unable to handle kernel paging request for data at address 0x014c > Faulting instruction address: 0xc016f7f0 > Oops: Kernel access of bad area, sig: 11 [#1] > MPC85xx > NIP: c016f7f0 LR: c01722a0 CT

Re: [PATCH] [POWERPC] pasemi: export pasemi_dma_init()

2007-12-17 Thread Jeff Garzik
Olof Johansson wrote: > Forgot to export this one. Needed when pasemi_mac is compiled as a module. > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> > > --- > > Jeff, since the dma_lib stuff went up through netdev-2.6, please apply and > feed this one up with the rest. > > > Thanks, > > O

Re: [PATCH] [POWERPC] pasemi: export pasemi_dma_init()

2007-12-17 Thread Jeff Garzik
Olof Johansson wrote: > Forgot to export this one. Needed when pasemi_mac is compiled as a module. > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> > > --- > > Jeff, since the dma_lib stuff went up through netdev-2.6, please apply and > feed this one up with the rest. > > > Thanks, > > O

Re: [PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet

2007-12-17 Thread Jeff Garzik
Jochen Friedrich wrote: > This patch adds support to use the fixed-link property > of an ethernet node to fs_enet for the > CONFIG_PPC_CPM_NEW_BINDING case. > > Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> > --- > drivers/net/fs_enet/fs_enet-main.c |9 - > 1 files changed, 8 in

Re: [PATCH] [NET][POWERPC] ucc_geth: really fix section mismatch

2007-12-17 Thread Jeff Garzik
Anton Vorontsov wrote: > Commit ed7e63a51d46e835422d89c687b8a3e419a4212a has tried to fix > section mismatch: > > WARNING: vmlinux.o(.init.text+0x17278): Section mismatch: reference to > .exit.text:uec_mdio_exit (between 'ucc_geth_init' and 'uec_mdio_init') > > But that mismatch still happens. >

Re: [PATCH 8/8] gianfar: Magic Packet and suspend/resume support.

2007-12-14 Thread Jeff Garzik
Scott Wood wrote: > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> > --- > Jeff, can you ack this to go through Paul's tree > (assuming nothing wrong with it)? > > drivers/net/gianfar.c | 137 > - > drivers/net/gianfar.h | 13 +++- > driv

Re: [PATCH 2/2] ucc_geth: use rx-clock-name and tx-clock-name device tree properties

2007-12-13 Thread Jeff Garzik
Kumar Gala wrote: > > On Dec 3, 2007, at 3:17 PM, Timur Tabi wrote: > >> Updates the ucc_geth device driver to check the new rx-clock-name and >> tx-clock-name properties first. If present, it uses the new function >> qe_clock_source() to obtain the clock source. Otherwise, it checks the >> dep

Re: [PATCH 1/11] ibm_newemac: Add BCM5248 and Marvell 88E1111 PHY support

2007-12-07 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > From: Stefan Roese <[EMAIL PROTECTED]> > > This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. > These PHY chips are used on PowerPC 440EPx boards. > The PHY code is based on the previous work by Stefan Roese <[EMAIL PROTECTED]> > > Signed-o

Re: [PATCH] pata_of_platform: Move electra-ide support over to new framework

2007-12-04 Thread Jeff Garzik
Olof Johansson wrote: > [POWERPC] Move electra-ide support over to new pata_of_platform framework > > Move electra-ide glue over to the new pata_of_platform framework, and > add the quirks needed to that driver. > > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> > > --- > > I'll remove th

Re: [PATCH] gianfar driver: eliminate compiler warnings and unnecessary macros

2007-12-04 Thread Jeff Garzik
Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > This patch eliminates the warning of unused return values when the driver > registers it sysfs files. Now the driver will print an error if it is > unable to register the sysfs files. > > It also eliminates the macros used to wrap

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-04 Thread Jeff Garzik
Vitaly Bordug wrote: > With that patch fixed.c now fully emulates MDIO bus, thus no need > to duplicate PHY layer functionality. That, in turn, drastically > simplifies the code, and drops down line count. > > As an additional bonus, now there is no need to register MDIO bus > for each PHY, all em

Re: [PATCH] gianfar: fix compile warning

2007-12-04 Thread Jeff Garzik
Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > Eliminate an uninitialized variable warning. The code is correct, but > a pointer to the automatic variable 'addr' is passed to dma_alloc_coherent. > Since addr has never been initialized, and the compiler doesn't know > what dma_al

Re: [PATCH 2.6.24] pasemi_mac: Fix reuse of free'd skb

2007-12-04 Thread Jeff Garzik
Olof Johansson wrote: > Turns out we're freeing the skb when we detect CRC error, but we're > not clearing out info->skb. We could either clear it and have the stack > reallocate it, or just leave it and the rx ring refill code will reuse > the one that was allocated. > > Reusing a freed skb obvio

Re: [PATCH 0/3] OF-platform PATA driver

2007-12-01 Thread Jeff Garzik
Anton Vorontsov wrote: > Hi all, > > Here is the second spin of the OF-platform PATA driver and > related patches. > > Changes since RFC: > - nuked drivers/ata/pata_platform.h; > - powerpc bits: proper localbus node added. > > > Thanks for the previous review! This time I'm collecting acks, > d

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Jeff Garzik
Vitaly Bordug wrote: > With that patch fixed.c now fully emulates MDIO bus, thus no need > to duplicate PHY layer functionality. That, in turn, drastically > simplifies the code, and drops down line count. > > As an additional bonus, now there is no need to register MDIO bus > for each PHY, all em

Re: [PATCH] [1/12] pasemi_mac: RX/TX ring management cleanup

2007-12-01 Thread Jeff Garzik
Olof Johansson wrote: > pasemi_mac: RX/TX ring management cleanup > > Prepare a bit for supporting multiple TX queues by cleaning up some > of the ring management and shuffle things around a bit. > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> applied 1-12 ___

Re: [PATCH] Stop phy code from returning success to unknown ioctls.

2007-12-01 Thread Jeff Garzik
David Woodhouse wrote: > This kind of sucks, and prevents the Fedora installer from using the > device for network installs... > > [EMAIL PROTECTED] phy]# iwconfig eth0 > > Warning: Dri

Re: [PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c

2007-12-01 Thread Jeff Garzik
David Woodhouse wrote: > This helps to allow the Fedora installer to use the built-in Ethernet on > the Efika for a network install. > > Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> > > --- a/drivers/net/fec_mpc52xx.c > +++ b/drivers/net/fec_mpc52xx.c > @@ -971,6 +971,8 @@ mpc52xx_fec_probe

Re: [PATCH 1/3][RESEND] phylib: add PHY interface modes for internal delay for tx and rx only

2007-12-01 Thread Jeff Garzik
Kim Phillips wrote: > Allow phylib specification of cases where hardware needs to configure > PHYs for Internal Delay only on either RX or TX (not both). > > Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> > Tested-by: Anton Vorontsov <[EMAIL PROTECTED]> > Acked-by: Li Yang <[EMAIL PROTECTED]> > -

Re: [PATCH 1/2][2.6.24] ehea: Improve tx packets counting

2007-11-23 Thread Jeff Garzik
Thomas Klein wrote: > Using own tx_packets counter instead of firmware counters. > > Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> > > --- > drivers/net/ehea/ehea.h |2 +- > drivers/net/ehea/ehea_main.c |9 +++-- > 2 files changed, 8 insertions(+), 3 deletions(-) applies 1-2

Re: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources

2007-11-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > The e1000 driver stores the content of the PCI resources into > unsigned long's before ioremapping. This breaks on 32 bits > platforms that support 64 bits MMIO resources such as ppc 44x. > > This fixes it by removing those temporary variables and passing > directly

Re: [PATCH] ibm_newemac: Fix possible lockup on close

2007-11-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > It's a bad idea to call flush_scheduled_work from within a > netdev->stop because the linkwatch will occasionally take the > rtnl lock from a workqueue context, and thus that can deadlock. > > This reworks things a bit in that area to avoid the problem. > > Signed-

Re: [PATCH 0/8] ibm_newemac: Candidate patches for 2.6.25

2007-11-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > Here are the patches I have pending for EMAC. With some non-released > patches from Hugh Blemings, I get a taishan (440GX) booting now, > in addition to Ebony (440GP) and various 405GP boards. > > This is 2.6.25 material except for patch #1 which has already been >

Re: [PATCH 0/3] PowerPC: ibm_newemac minor fixes.

2007-11-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > On Fri, 2007-11-23 at 22:07 +0300, Valentine Barshak wrote: > >> These patches have some minor ibm_newemac fixes. > > All 3 patches look good, thanks. I'll sign them off and forward them > to Jeff in my next batch. > > Jeff, did you already pick up my previous dro

Re: [RFC][PATCH 0/3] OF-platform PATA driver

2007-11-23 Thread Jeff Garzik
Anton Vorontsov wrote: > Hi all, > > Here is the PATA Platform driver using OF infrastructure. > > Mostly it's just a wrapper around a bit modified pata_platform > driver. > > Patches are well split for the easier review: > > First one factors out platform_device specific bits and modifies > pa

Re: [PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

2007-11-19 Thread Jeff Garzik
Kim Phillips wrote: > On Mon, 5 Nov 2007 12:15:30 -0600 > Kim Phillips <[EMAIL PROTECTED]> wrote: > >> Hello all, >> >> the following patches fix RGMII timing for rev. 2.1 of the mpc8360, >> according to erratum #2 (erratum text included below). Basically the >> most intrusive part is the additio

Re: [PATCH 1/2] pasemi_mac: Don't set replace-source-address descriptor bits

2007-11-08 Thread Jeff Garzik
On Tue, Nov 06, 2007 at 10:20:39PM -0600, Olof Johansson wrote: > Don't use the "replace source address with local MAC address" bits, since > it causes problems on some variations of the hardware due to an erratum. > > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> applied 1-2 ___

Re: [PATCH] pegasos_eth.c: Fix compile error over MV643XX_ defines

2007-10-30 Thread Jeff Garzik
Dale Farnsworth wrote: > On Mon, Oct 29, 2007 at 05:27:29PM -0400, Luis R. Rodriguez wrote: >> This commit made an incorrect assumption: >> -- >> Author: Lennert Buytenhek <[EMAIL PROTECTED]> >> Date: Fri Oct 19 04:10:10 2007 +0200 >> >> mv643xx_eth: Move ethernet register definitions into p

Re: [PATCH v4.3] FEC - fast ethernet controller for mpc52xx

2007-10-29 Thread Jeff Garzik
Domen Puncer wrote: > On 26/10/07 07:18 -0700, Dale Farnsworth wrote: >> On Fri, Oct 26, 2007 at 01:59:09PM +0200, Domen Puncer wrote: >>> +static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id) >>> +{ >>> + struct net_device *dev = dev_id; >>> + struct mpc52xx_fec_priv *priv = netd

Re: [PATCH] ehea: add kexec support

2007-10-29 Thread Jeff Garzik
Jan-Bernd Themann wrote: > eHEA resources that are allocated via H_CALLs have a unique identifier each. > These identifiers are necessary to free the resources. A reboot notifier > is used to free all eHEA resources before the indentifiers get lost, i.e > before kexec starts a new kernel. > > Sign

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Jeff Garzik
Dale Farnsworth wrote: > IMO, it's still a requirement that we call dma_unmap_single() for > each call to dma_map_single(). Yep... ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Jeff Garzik
Domen Puncer wrote: > +static int mpc52xx_fec_alloc_rx_buffers(struct bcom_task *rxtsk) > +{ > + while (!bcom_queue_full(rxtsk)) { > + struct sk_buff *skb; > + struct bcom_fec_bd *bd; > + > + skb = dev_alloc_skb(FEC_RX_BUFFER_SIZE); > + if (skb ==

Re: [PATCH] ehea: fix port_napi_disable/enable

2007-10-25 Thread Jeff Garzik
Jan-Bernd Themann wrote: > napi_disable / napi_enable must be applied on all ehea queues. > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> applied ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxp

Re: [PATCH] Use of_get_next_child() in k2_sata_proc_info()

2007-10-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > On Wed, 2007-10-24 at 14:25 +1000, Michael Ellerman wrote: >> k2_sata_proc_info() uses its own hand-rolled loop to check a nodes >> children for a property, this is not safe WRT refcounting, so fix it >> to use of_get_next_child(). >> >> Signed-off-by: Michael Ellerm

Re: [PATCH] pasemi_mac: fix typo

2007-10-23 Thread Jeff Garzik
Olof Johansson wrote: > Add missing &: > > drivers/net/pasemi_mac.c: In function 'pasemi_mac_clean_rx': > drivers/net/pasemi_mac.c:553: warning: passing argument 1 of 'prefetch' > makes pointer from integer without a cast > > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> > > diff --git a/

Re: [PATCH] Fix build break in tsi108.c

2007-10-19 Thread Jeff Garzik
Olof Johansson wrote: > Fix build break: > > drivers/net/tsi108_eth.c: In function 'tsi108_init_one': > drivers/net/tsi108_eth.c:1633: error: expected ')' before 'dev' > drivers/net/tsi108_eth.c:1633: warning: too few arguments for format > make[2]: *** [drivers/net/tsi108_eth.o] Error 1 > > > S

Re: [PATCH] phy/bitbang: missing MODULE_LICENSE

2007-10-19 Thread Jeff Garzik
Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > Missing MODULE_LICENSE(), loading this module taints the kernel. > > Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> > --- > drivers/net/phy/mdio-bitbang.c |2 ++ > 1 file changed, 2 insertions(+) applied this and the NAPI_How

Re: [PATCH v3 0/4] FEC - fast ethernet controller for mpc52xx

2007-10-18 Thread Jeff Garzik
Grant Likely wrote: > On 10/15/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: >> Domen Puncer wrote: >>> Hello! >>> >>> If there are no objections, I would like to get this merged >>> when bestcomm goes in (any time now?). >>> >>> I

Re: [PATCH] fix EMAC driver for proper napi_synchronize API

2007-10-17 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > The EMAC driver "fix" was merged by mistake before the dust had settled on > the new napi synchronize interface (and before it got merged). The final > version of that function is spelled without underscores. > > Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECT

Re: [PATCH][NET] gianfar: fix obviously wrong #ifdef CONFIG_GFAR_NAPI placement

2007-10-17 Thread Jeff Garzik
Anton Vorontsov wrote: > Erroneous #ifdef introduced by 293c8513398657f6263fcdb03c87f2760cf61be4 > causing NAPI-less ethernet malfunctioning. > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> applied ___

Re: [PATCH] fs_enet: Update for API changes

2007-10-17 Thread Jeff Garzik
Scott Wood wrote: > This driver was recently broken by several changes for which this > driver was not (or was improperly) updated: > > 1. SET_MODULE_OWNER() was removed. > 2. netif_napi_add() was only being called when building with > the old CPM binding. > 3. The received/budget test was backwar

Re: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll

2007-10-16 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > net: Add __napi_synchronize() to sync with napi poll > > The EMAC driver which needs to handle multiple devices with one > NAPI instance implements its own per-channel disable bit. However, > when setting such a bit, it needs to synchronize with the poller > (that i

Re: [PATCH] net: Fix new EMAC driver for NAPI changes

2007-10-16 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > net: Fix new EMAC driver for NAPI changes > > This fixes the new EMAC driver for the NAPI updates. The previous patch > by Roland Dreier (already applied) to do that doesn't actually work. This > applies on top of it makes it work on my test Ebony machine. > > This

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-10-16 Thread Jeff Garzik
as this patch touches files that are the >>> > responsibility of three different maintainers. �Is it possible to >>> > split the patch into three, one for each maintainer (possibly by >>> > keeping both old and new interfaces around for a little while)? >>

Re: [PATCH v3 0/4] FEC - fast ethernet controller for mpc52xx

2007-10-15 Thread Jeff Garzik
Domen Puncer wrote: > Hello! > > If there are no objections, I would like to get this merged > when bestcomm goes in (any time now?). > > It's split into four parts: > 1 - device tree > 2 - small bestcomm change > 3 - the actual driver > 4 - phy part of the driver patches #3 and #4 need to be co

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-15 Thread Jeff Garzik
Josh Boyer wrote: > On Mon, 15 Oct 2007 14:53:26 -0400 > Jeff Garzik <[EMAIL PROTECTED]> wrote: >>>> Seems sane to me -- ACK -- but we have multiple people sending me >>>> patches for a single driver. That's normal for janitorial cleanups >>

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-15 Thread Jeff Garzik
Josh Boyer wrote: > On Mon, 15 Oct 2007 14:27:23 -0400 > Jeff Garzik <[EMAIL PROTECTED]> wrote: > >> Valentine Barshak wrote: >>> This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. >>> These PHY chips are used on PowerPC 440EPx b

Re: [PATCH v2] [POWERPC] ucc_geth: Fix build break introduced by commit 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0

2007-10-15 Thread Jeff Garzik
Emil Medve wrote: > drivers/net/ucc_geth.c: In function 'ucc_geth_rx': > drivers/net/ucc_geth.c:3483: error: 'dev' undeclared (first use in this > function) > drivers/net/ucc_geth.c:3483: error: (Each undeclared identifier is reported > only once > drivers/net/ucc_geth.c:3483: error: for each fun

Re: [PATCH 1/5] Update ibm_newemac to use dcr_host_t.base

2007-10-15 Thread Jeff Garzik
Michael Ellerman wrote: > Now that dcr_host_t contains the base address, we can use that in the > ibm_newemac code, rather than storing it separately. > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> > --- > drivers/net/ibm_newemac/mal.c |9 + > drivers/net/ibm_newemac/mal.h |

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-15 Thread Jeff Garzik
Valentine Barshak wrote: > This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. > These PHY chips are used on PowerPC 440EPx boards. > The PHY code is based on the previous work by Stefan Roese <[EMAIL PROTECTED]> > > Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> > Signed-

Re: [PATCH 1/1] libata: pata_pdc2027x PLL input clock fix

2007-10-14 Thread Jeff Garzik
Mikael Pettersson wrote: > On Thu, 16 Aug 2007 21:19:40 +0100, Alan Cox wrote: Unfortunately this breaks pata_pdc2027x on my PowerMac G3: >>> Did this ever get resolved? >> All went quiet so I assume its gone away ? > > -ENOTIME > > The regression is still there in 2.6.23-rc3 (I just checked

Re: [PATCH] ehea: use kernel event queue

2007-10-09 Thread Jeff Garzik
Jan-Bernd Themann wrote: > eHEA recovery and DLPAR functions are called seldomly. The eHEA workqueues > are replaced by the kernel event queue. > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> > > --- > The patch has been built against upstream git > > drivers/net/ehea/ehea.h |

Re: [PATCH RESEND] [11/11] pasemi_mac: enable iommu support

2007-10-03 Thread Jeff Garzik
Olof Johansson wrote: > pasemi_mac: enable iommu support > > Enable IOMMU support for pasemi_mac, but avoid using it on non-partitioned > systems for performance reasons. > > The user can override this by selecting the PPC_PASEMI_IOMMU_DMA_FORCE > configuration option. > > Signed-off-by: Olof Jo

Re: [PATCH] [9/11] pasemi_mac: clear out old errors on interface open

2007-10-03 Thread Jeff Garzik
Olof Johansson wrote: > On Wed, Oct 03, 2007 at 01:46:16PM -0400, Jeff Garzik wrote: >> Olof Johansson wrote: >>> pasemi_mac: clear out old errors on interface open >>> Clear out any pending errors when an interface is brought up. Since the >>> bits >>

Re: [PATCH] Fix typo in new EMAC driver.

2007-10-03 Thread Jeff Garzik
Valentine Barshak (by way of Josh Boyer <[EMAIL PROTECTED]>) wrote: > Fix an obvious typo in emac_xmit_finish. > > Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> > --- > drivers/net/ibm_newemac/core.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) applied ___

Re: [PATCH] [1/11] pasemi_mac: basic error checking

2007-10-03 Thread Jeff Garzik
Olof Johansson wrote: > pasemi_mac: basic error checking > > Add some rudimentary error checking to pasemi_mac. > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> applied 1-10 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.or

Re: [PATCH] [11/11] pasemi_mac: enable iommu support

2007-10-03 Thread Jeff Garzik
Olof Johansson wrote: > pasemi_mac: use buffer index pointer in clean_rx() > > Use the new features in B0 for buffer ring index on the receive side. This > means we no longer have to search in the ring for where the buffer > came from. > > Also cleanup the RX cleaning side a little, while I was a

Re: [PATCH] [9/11] pasemi_mac: clear out old errors on interface open

2007-10-03 Thread Jeff Garzik
Olof Johansson wrote: > pasemi_mac: clear out old errors on interface open > > Clear out any pending errors when an interface is brought up. Since the bits > are sticky, they might be from interface shutdown time after firmware has > used it, etc. > > Signed-off-by: Olof Johansson <[EMAIL PROTECT

Re: [PATCH] Fix typo in new EMAC driver.

2007-10-02 Thread Jeff Garzik
Josh Boyer wrote: > On Tue, 2 Oct 2007 16:01:07 +0400 > Valentine Barshak <[EMAIL PROTECTED]> wrote: > >> Fix an obvious typo in emac_xmit_finish. >> >> Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> > > Looks fine to me. Jeff, do you want to take this through netdev for > 2.6.24? sure...

Re: [PATCH] ehea: DLPAR memory add fix

2007-10-02 Thread Jeff Garzik
Jan-Bernd Themann wrote: > Due to stability issues in high load situations the HW queue handling > has to be changed. The HW queues are now stopped and restarted again instead > of destroying and allocating new HW queues. > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> applied ___

Re: [PATCH] ehea: DLPAR memory add fix

2007-10-01 Thread Jeff Garzik
Jan-Bernd Themann wrote: > Hi, > > On Monday 01 October 2007 16:44, Jeff Garzik wrote: >> Jan-Bernd Themann wrote: >>> Due to stability issues in high load situations the HW queue handling >>> has to be changed. The HW queues are now stopped and restarted ag

Re: [PATCH] ehea: DLPAR memory add fix

2007-10-01 Thread Jeff Garzik
Jan-Bernd Themann wrote: > Due to stability issues in high load situations the HW queue handling > has to be changed. The HW queues are now stopped and restarted again instead > of destroying and allocating new HW queues. > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> May I presume thi

Re: [PATCH 1/9] fs_enet: Whitespace cleanup.

2007-09-28 Thread Jeff Garzik
Scott Wood wrote: > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> > --- > drivers/net/fs_enet/fs_enet-main.c | 85 --- > drivers/net/fs_enet/fs_enet.h |4 +- > drivers/net/fs_enet/mac-fcc.c |1 - > drivers/net/fs_enet/mii-bitbang.c |3 - > d

<    1   2   3   >