vga_set_default_device(pdev);
> > + break;
> > + }
> > + }
> > + }
> > +
> > + if (!vga_default_device()) {
> > + vgadev = list_first_entry_or_null(&vga_list,
> > + struct vga_device, list);
> > + if (vgadev) {
> > + struct device *dev = &vgadev->pdev->dev;
> > + vgaarb_info(dev, "setting as boot device (VGA legacy
> > resources not available)\n");
> > + vga_set_default_device(pdev);
>
> Isn't 'pdev' NULL here? shouldn't it be vgadev->pdev instead?
>
That cannot not happen, though it isn't quite obvious.
'vgadev' will only be non-NULL, when the vga_list isn't empty and in
that case pdev has been set up in the list_for_each_entry() loop above.
Lothar Waßmann
mation in that
> case. If the message was specific (e.g. "can't save CLEAR_TT_BUFFER state"), I
> left it. This series saves ~4.5KB of "out of memory" permutations in .text and
> .rodata. For modified lines, (x == NULL) was replaced with (!NULL) as well.
s/!NULL/!x/
Lothar Waßmann
Hi,
> On Tue, Jan 12, 2016 at 4:13 PM, Lothar Waßmann
> wrote:
>
> > diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> > index 14dfdee..c128823 100644
> > --- a/sound/soc/fsl/Kconfig
> > +++ b/sound/soc/fsl/Kconfig
> > @@ -258,
Hi,
> Lothar Waßmann wrote:
> > - select SND_SOC_FSL_SSI
> > + select SND_SOC_FSL_SAI if SOC_IMX6UL
> > + select SND_SOC_FSL_SSI if SOC_IMX6Q || SOC_IMX6SL || SOC_IMX6SX
>
> I don't think this is compatible with a multiarch kernel.
>
Why? If more tha
Hi,
> On Tue, Jan 12, 2016 at 07:13:30PM +0100, Lothar Waßmann wrote:
>
> > i.MX6UL does not have the audio multiplexer (AUDMUX) like e.g. i.MX6Q,
> > but apart from that can use the same audio driver. Make audmux
> > optional for the imx-sgtl5000 driver, so it can be
i.MX6UL does not have the audio multiplexer (AUDMUX) like e.g. i.MX6Q,
but apart from that can use the same audio driver. Make audmux
optional for the imx-sgtl5000 driver, so it can be used on i.MX6UL
too. Also i.MX6UL requires use of the SAI interface rather than SSI.
Signed-off-by: Lothar
i.MX6UL does not provide an SSI interface like the other i.MX6 SoCs,
but only an SAI interface.
Select the appropriate interface(s) depending on the enabled SoC types.
Signed-off-by: Lothar Waßmann
---
sound/soc/fsl/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
This patchset adds support for the i.MX6UL SoC to the imx-sgtl5000
sound driver.
The first patch makes the audmux setup optional for the driver, since
i.MX6UL does not have this unit.
The second patch selects the SAI interface rather than the SSI
interface for the i.MX6UL SoC.
A patch to make the
Add the necessary clock to use the KPP interface on i.MX6UL.
Signed-off-by: Lothar Waßmann
---
drivers/clk/imx/clk-imx6ul.c | 1 +
include/dt-bindings/clock/imx6ul-clock.h | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers
remove whitespace before TAB.
Signed-off-by: Lothar Waßmann
---
drivers/clk/imx/clk-imx6ul.c | 62 ++---
include/dt-bindings/clock/imx6ul-clock.h | 146 +++
2 files changed, 104 insertions(+), 104 deletions(-)
diff --git a/drivers/clk/imx/clk
This patchset adds the clock which is necessary to operate the KPP
unit on i.MX6UL.
The first patch removes bogus whitespace before TABs in indentation.
The second patch adds the clock definition.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.o
, but you are altering code that may be run on a different machine
than VF610 in a multiarch kernel! You should have a RUNTIME check for
the machine type if you need to do machine type specific stuff.
Lothar Waßmann
--
___
Ka-Ro electronics G
Hi,
Xiubo Li wrote:
The subject has a wrong name for the codec "SGT1..." instead of
"SGTL...", which will make it difficult to search for this thread in
mail archives or in commit messages once this patches should be appli
> +#endif
>
This looks wrong to me, as this will disable the error for unsolicited
platforms in a multi arch kernel!
> static int ldo_regulator_remove(struct snd_soc_codec *codec)
> {
> return 0;
> }
> +
> #endif
>
Why do you add an extra empty line here?
Lothar W
> +#define SAI_TCR2 0x08
> +#define SAI_RCR2 0x88
> +#define SAI_CR2_SYNC BIT(30)
> +#define SAI_CR2_MSEL_MASK(0xff << 26)
> +#define SAI_CR2_MSEL_BUS 0
> +#define SAI_CR2_MSEL_MCLK1 BIT(26)
> +#define SAI_CR2_MSEL_MCLK2 BIT(27)
&g
c-mx51".
I personally hate the '!strcmp()' notation and prefer 'strcmp() == 0'
though they are technically equivalent. Using '==' makes it much
clearer to the reader what is intended.
!strcmp() lets one assume that it is true when the comparison fails,
though actually
16 matches
Mail list logo
