Re: [PATCH 1/2] powerpc/uaccess: Fix build errors seen with GCC 14

2024-05-21 Thread Nick Desaulniers
e "Y" constraint does not guarantee 4-byte alignment when prefixed > instructions are enabled. > > Unfortunately clang doesn't support the "Y" constraint so that has to be > behind an ifdef. Filed: https://github.com/llvm/llvm-project/issues/92939 -- Thanks, ~Nick Desaulniers

Re: [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b

2023-10-31 Thread Nick Desaulniers
7;re static > and always defined in xmon.c, but only called if either CONFIG_SMP or > CONFIG_DEBUG_FS. > > But they're certainly not related to controller/xilinx-xdma, so I'm > going to ignore them. > > Bjorn > > P.S. Nathan & Nick, I cc'd you because of this earlier report that > also mentioned grackle_set_stg(): > https://lore.kernel.org/lkml/202308121120.u2d3ypvt-...@intel.com/ -- Thanks, ~Nick Desaulniers

Re: [PATCH] scsi: ibmvfc: Use 'unsigned int' for single-bit bitfields in 'struct ibmvfc_host'

2023-10-10 Thread Nick Desaulniers
("scsi: ibmvfc: Use a bitfield for boolean flags") > Signed-off-by: Nathan Chancellor Thanks for the patch! Reviewed-by: Nick Desaulniers > --- > drivers/scsi/ibmvscsi/ibmvfc.h | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/dri

Re: [PATCH v7 1/3 RESEND] block:sed-opal: SED Opal keystore

2023-09-27 Thread Nick Desaulniers
On Wed, Sep 27, 2023 at 1:26 PM Greg Joyce wrote: > > On Wed, 2023-09-13 at 13:49 -0700, Nick Desaulniers wrote: > > On Wed, Sep 13, 2023 at 9:56 AM Nathan Chancellor > > wrote: > > > Hi Greg, > > > > > > On Fri, Sep 08, 2023 at 10:30:54AM

Re: [PATCH v7 1/3 RESEND] block:sed-opal: SED Opal keystore

2023-09-13 Thread Nick Desaulniers
en); #else static inline int sed_read_key(char *keyname, char *key, u_int *keylen) { return -EOPNOTSUPP; } static inline int sed_write_key(char *keyname, char *key, u_int keylen); return -EOPNOTSUPP; } #endif > > Is there any real reason to have a separate translation unit for these > two functions versus just having them living in sed-opal.c? Those two > object files share the same Kconfig dependency. I am happy to send a > patch if that is an acceptable approach. > > [1]: https://github.com/ClangBuiltLinux/linux/issues/981 > > Cheers, > Nathan > -- Thanks, ~Nick Desaulniers

[PATCH v2] reapply: powerpc/xmon: Relax frame size for clang

2023-08-28 Thread Nick Desaulniers
giuk7-...@intel.com/ Suggested-by: Nathan Chancellor Reviewed-by: Nathan Chancellor Signed-off-by: Nick Desaulniers --- Changes in v2: - Use ccflags-$(CONFIG_CC_IS_CLANG) as per Nathan. - Move that to be below the initial setting of ccflags-y as per Nathan. - Add Nathan's Suggested-by and Review

Re: [PATCH v3] powerpc/inst: add PPC_TLBILX_LPID

2023-08-03 Thread Nick Desaulniers
On Thu, Aug 3, 2023 at 11:47 AM Christophe Leroy wrote: > > > > Le 03/08/2023 à 20:33, Nick Desaulniers a écrit : > > Clang didn't recognize the instruction tlbilxlpid. This was fixed in > > clang-18 [0] then backported to clang-17 [1]. To support clang-16 and >

[PATCH v3] powerpc/inst: add PPC_TLBILX_LPID

2023-08-03 Thread Nick Desaulniers
ommit/0af7e5e54a8c7ac665773ac1ada328713e8338f5 [1] Reported-by: kernel test robot Closes: https://lore.kernel.org/llvm/202307211945.tspcyohh-...@intel.com/ Suggested-by: Michael Ellerman Signed-off-by: Nick Desaulniers --- Changes in v3: - left comment @ https://github.com/linuxppc/issues/issues/350#issuecomment-1664417212 - re

[PATCH v2] powerpc/inst: add PPC_TLBILX_LPID

2023-08-03 Thread Nick Desaulniers
ommit/0af7e5e54a8c7ac665773ac1ada328713e8338f5 [1] Reported-by: kernel test robot Closes: https://lore.kernel.org/llvm/202307211945.tspcyohh-...@intel.com/ Suggested-by: Michael Ellerman Signed-off-by: Nick Desaulniers --- Changes in v2: - add 2 missing tabs to PPC_RAW_TLBILX_LPID - Link to v1: https://lore.kernel.org/r/202

Re: [PATCH] powerpc/inst: add PPC_TLBILX_LPID

2023-08-03 Thread Nick Desaulniers
8 > [0] > Link: > https://github.com/llvm/llvm-project-release-prs/commit/0af7e5e54a8c7ac665773ac1ada328713e8338f5 > [1] > Reported-by: kernel test robot > Closes: https://lore.kernel.org/llvm/202307211945.tspcyohh-...@intel.com/ > Suggested-by: Michael Ellerman > Signed-o

Re: [PATCH] powerpc/ftrace: Disable ftrace on ppc32 if using clang

2023-06-09 Thread Nick Desaulniers
Link: https://github.com/llvm/llvm-project/issues/63220 Acked-by: Nick Desaulniers > --- > arch/powerpc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index bff5820b7cda14..d85e3cf4016d90 100644 >

Re: [PATCH v6 4/4] risc/purgatory: Add linker script

2023-05-01 Thread Nick Desaulniers
filter-out -fprofile-sample-use=% > -fprofile-use=%,$(KBUILD_CFLAGS)) > + > # When linking purgatory.ro with -r unresolved symbols are not checked, > # also link a purgatory.chk binary without -r to check for unresolved > symbols. > PURGATORY_LDFLAGS := -e purgatory_start -z nodefaultlib > > -- > 2.40.1.495.gc816e09b53d-goog > -- Thanks, ~Nick Desaulniers

Re: [PATCH] powerpc/32: Include thread_info.h in head_booke.h

2023-04-07 Thread Nick Desaulniers
; in head_booke.h, so it is possible for THREAD_SHIFT to be undefined. Add > the include to ensure that THREAD_SHIFT is always defined. > > Reported-by: kernel test robot > Link: https://lore.kernel.org/202304050954.yskldczh-...@intel.com/ > Signed-off-by: Nathan Chancellor Than

Re: arch/powerpc/kvm/../kernel/head_booke.h:20:6: warning: "THREAD_SHIFT" is not defined, evaluates to 0

2023-04-07 Thread Nick Desaulniers
honov2009-01-29 28 > > :: The code at line 20 was first introduced by commit > :: e12401222f749c37277a313d631dc024bbfd3b00 powerpc/44x: Support for > 256KB PAGE_SIZE > > :: TO: Yuri Tikhonov > :: CC: Josh Boyer > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests -- Thanks, ~Nick Desaulniers

Re: [PATCH v8 1/3] riscv: Introduce CONFIG_RELOCATABLE

2023-03-22 Thread Nick Desaulniers
t-relocs for KASLR: https://lore.kernel.org/lkml/20230320121006.4863-1-petr.pa...@suse.com/ -- Thanks, ~Nick Desaulniers

Re: [PATCH 1/2] powerpc/64: Set default CPU in Kconfig

2023-02-01 Thread Nick Desaulniers
://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230201/testrun/14479384/suite/build/test/clang-nightly-tqm8xx_defconfig/history/ > > > > The bisection pointed to this commit, > >45f7091aac35 ("powerpc/64: Set default CPU in Kconfig") > > > > -- > > Linaro LKFT > > https://lkft.linaro.org -- Thanks, ~Nick Desaulniers

Re: [PATCH 08/14] powerpc/vdso: Remove an unsupported flag from vgettimeofday-32.o with clang

2023-01-09 Thread Nick Desaulniers
On Mon, Jan 9, 2023 at 2:38 PM Nathan Chancellor wrote: > > On Mon, Jan 09, 2023 at 02:12:55PM -0800, Nick Desaulniers wrote: > > On Wed, Jan 4, 2023 at 11:55 AM Nathan Chancellor wrote: > > > > > > When clang's -Qunused-arguments is dropped f

Re: [PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

2023-01-09 Thread Nick Desaulniers
On Mon, Jan 9, 2023 at 2:29 PM Segher Boessenkool wrote: > > Hi! Happy new year all. HNY Segher! :) > > On Mon, Jan 09, 2023 at 01:58:32PM -0800, Nick Desaulniers wrote: > > On Wed, Jan 4, 2023 at 11:55 AM Nathan Chancellor wrote: > > > > > > When clang&

Re: [PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

2023-01-09 Thread Nick Desaulniers
On Mon, Jan 9, 2023 at 2:15 PM Nathan Chancellor wrote: > > On Mon, Jan 09, 2023 at 01:58:32PM -0800, Nick Desaulniers wrote: > > On Wed, Jan 4, 2023 at 11:55 AM Nathan Chancellor wrote: > > > > > > When clang's -Qunused-arguments is dropped from KBUILD_CP

Re: [PATCH 08/14] powerpc/vdso: Remove an unsupported flag from vgettimeofday-32.o with clang

2023-01-09 Thread Nick Desaulniers
EMOVE_vgettimeofday-32.o += -fno-stack-clash-protection > + endif >CFLAGS_vgettimeofday-64.o += -include $(c-gettimeofday-y) >CFLAGS_vgettimeofday-64.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) >CFLAGS_vgettimeofday-64.o += $(call cc-option, -fno-stack-protector) > > -- > 2.39.0 -- Thanks, ~Nick Desaulniers

Re: [PATCH 07/14] powerpc/vdso: Improve linker flags

2023-01-09 Thread Nick Desaulniers
nd_check = $(VDSOCC) $(c_flags) $(CC64FLAGS) -o $@ > -Wl,-T$(filter %.lds,$^) $(filter %.o,$^) -z noexecstack ; $(cmd_vdso_check) > + cmd_vdso64ld_and_check = $(VDSOCC) $(ldflags-y) $(CC64FLAGS) > $(LD64FLAGS) -o $@ -Wl,-T$(filter %.lds,$^) $(filter %.o,$^) -z noexecstack ; > $(cmd_vdso_check) Let's move `-z noexecstack` up into ldflags-y? (you may add my RB with that modification) > quiet_cmd_vdso64as = VDSO64A $@ >cmd_vdso64as = $(VDSOCC) $(a_flags) $(CC64FLAGS) $(AS64FLAGS) -c -o $@ > $< > > > -- > 2.39.0 -- Thanks, ~Nick Desaulniers

Re: [PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

2023-01-09 Thread Nick Desaulniers
= -D__VDSO32__ -s > +AS32FLAGS := -D__VDSO32__ > > CC64FLAGS := -Wl,-soname=linux-vdso64.so.1 > -AS64FLAGS := -D__VDSO64__ -s > +AS64FLAGS := -D__VDSO64__ > > targets += vdso32.lds > CPPFLAGS_vdso32.lds += -P -C -Upowerpc > > -- > 2.39.0 -- Thanks, ~Nick Desaulniers

Re: [PATCH 05/14] powerpc: Remove linker flag from KBUILD_AFLAGS

2023-01-09 Thread Nick Desaulniers
target=powerpc64-linux-gnu -fno-integrated-as -m64 -### \ > -x assembler-with-cpp -c -o /dev/null /dev/null &| grep gnu-as >"/usr/bin/powerpc64-linux-gnu-as" "-a32" "-mppc" "-many" "-o" "/dev/null" > "/tmp/null-ab

Re: clang kernel PPC32 build failure, undefined reference to `__umoddi3'

2022-08-03 Thread Nick Desaulniers
c: 92 01 00 14 stw r16,20(r1) > 6c0: 92 21 00 1c stw r17,28(r1) > 6c4: 48 00 00 01 bl 6c4 > 6c4: R_PPC_REL24__umoddi3 > > > > I don't understand why calling __umoddi3 when the arguments are > obviously 32 bits are r3 and r5 are zero. > > Christophe -- Thanks, ~Nick Desaulniers

Re: [PATCH] powerpc/dcr: Use cmplwi instead of 3-argument cmpli

2021-10-14 Thread Nick Desaulniers
erates C++ that is used by the assembler, but also the disassembler, the compiler, and even the linker if need be). Link: https://github.com/ClangBuiltLinux/linux/issues/1419 Reviewed-by: Nick Desaulniers > Reported-by: Nick Desaulniers > Signed-off-by: Michael Ellerman > --- >

Re: [PATCH] lkdtm: Fix content of section containing lkdtm_rodata_do_nothing()

2021-10-08 Thread Nick Desaulniers
Disassembly of section .rodata: > > <.lkdtm_rodata_do_nothing>: >0: 4e 80 00 20 blr > > Fixes: e9e08a07385e ("lkdtm: support llvm-objcopy") Thanks for the patch; sorry I broke this. Reviewed-by: Nick Desaulniers > Cc: sta...@vger.kerne

[PATCH] powerpc: clean up UPD_CONSTR

2021-09-14 Thread Nick Desaulniers
UPD_CONSTR was previously a preprocessor define for an old GCC 4.9 inline asm bug with m<> constraints. Fixes: 6563139d90ad ("powerpc: remove GCC version check for UPD_CONSTR") Suggested-by: Nathan Chancellor Suggested-by: Christophe Leroy Suggested-by: Michael Ellerman Sig

Re: [5.15-rc1][PPC][bisected 6d2ef226] mainline build breaks at ./include/linux/compiler_attributes.h:62:5: warning: "__has_attribute"

2021-09-14 Thread Nick Desaulniers
piler_attributes.h: drop __has_attribute() support for > > gcc4 > > Thanks for your report. > > This is known and being addressed. Thanks for the report. Support for GCC 4.X has been dropped. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=76ae847497bc5207c479de5e2ac487270008b19b -- Thanks, ~Nick Desaulniers

[PATCH 3/7] powerpc: replace cc-option-yn uses with cc-option

2021-08-16 Thread Nick Desaulniers
removing cc-option-yn. Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Nick Desaulniers --- arch/powerpc/Makefile | 12 ++-- arch/powerpc/boot/Makefile | 5 + 2 files changed, 7 insertions(+), 10 deletions(-) diff

Re: [PATCH] powerpc/xive: Do not mark xive_request_ipi() as __init

2021-08-16 Thread Nick Desaulniers
cpu_ipi(), which is not > __init, so xive_request_ipi() should not be marked __init. Remove the > attribute so there is no more warning. > > Fixes: cbc06f051c52 ("powerpc/xive: Do not skip CPU-less nodes when creating > the IPIs") > Signed-off-by: Nathan Chancellor Thanks for

Re: [PATCH] ppc: add "-z notext" flag to disable diagnostic

2021-08-13 Thread Nick Desaulniers
ing building, then go digging time permitting. -- Thanks, ~Nick Desaulniers

Re: [PATCH] ppc: add "-z notext" flag to disable diagnostic

2021-08-12 Thread Nick Desaulniers
> > The BFD linker disables this by default (though it's configurable in > current versions). LLD enables this by default. So we add the flag to > keep LLD from emitting the error. > > Signed-off-by: Bill Wendling Link: https://github.com/ClangBuiltLinux/linux/iss

Re: [PATCH 3/3] powerpc: move the install rule to arch/powerpc/Makefile

2021-07-30 Thread Nick Desaulniers
nstall.sh "$(KERNELRELEASE)" vmlinux > System.map "$(INSTALL_PATH)" > - > -PHONY += install > - > # anything not in $(targets) > clean-files += $(image-) $(initrd-) cuImage.* dtbImage.* treeImage.* \ > zImage zImage.initrd zImage.chrp zImage.coff zImage.holly \ > -- > 2.27.0 > -- Thanks, ~Nick Desaulniers

Re: [PATCH 2/3] powerpc: make the install target not depend on any build artifact

2021-07-30 Thread Nick Desaulniers
owerPC installation code in a similar way. > > Signed-off-by: Masahiro Yamada Reviewed-by: Nick Desaulniers > --- > > arch/powerpc/boot/Makefile | 2 +- > arch/powerpc/boot/install.sh | 14 ++ > 2 files changed, 15 insertions(+), 1 deletion(-) > > diff --g

Re: [PATCH 1/3] powerpc: remove unused zInstall target from arch/powerpc/boot/Makefile

2021-07-30 Thread Nick Desaulniers
arch/powerpc/Makefile. > > It has never worked since its addition. Nobody has complained about > it for 7 years, which means this code was unneeded. > > With this removal, the install.sh will be passed in with 4 parameters. > Simplify the shell script. > > Signed-o

Re: [PATCH] powerpc/vdso: Don't use r30 to avoid breaking Go lang

2021-07-29 Thread Nick Desaulniers
r30 is not clobbered by any VDSO code. That > > used to be true > > +# by accident when the VDSO was hand-written asm code, but may not be now > > that the VDSO is > > +# compiler generated. To avoid breaking Go tell GCC not to use r30. Impact > > on code > > +# generation is minimal, it will just use r29 instead. > > +ccflags-y += $(call cc-option, -ffixed-r30) > > + > > asflags-y := -D__VDSO64__ -s > > > > targets += vdso64.lds > > > > The rest looks good. > > > Kind regards, > > Paul -- Thanks, ~Nick Desaulniers

Re: [PATCH] powerpc/barrier: Avoid collision with clang's __lwsync macro

2021-06-01 Thread Nick Desaulniers
le-linux-gnu -mcpu=e500 -m32 for example. Thanks for the patch! Reviewed-by: Nick Desaulniers > This breaks the build because of -Werror in > arch/powerpc, along with thousands of warnings: > > In file included from arch/powerpc/kernel/pmc.c:12: > In file included from include/linux

[PATCH] powerpc: Kconfig: disable CONFIG_COMPAT for clang < 12

2021-05-18 Thread Nick Desaulniers
. Link: https://github.com/ClangBuiltLinux/linux/issues/1160 Link: https://github.com/llvm/llvm-project/commits/2288319733cd5f525bf7e24dece08bfcf9d0ff9e Link: https://groups.google.com/g/clang-built-linux/c/ayNmi3HoNdY/m/XJAGj_G2AgAJ Suggested-by: Nathan Chancellor Signed-off-by: Nick Desaulniers

[PATCH v2] powerpc/powernv/pci: fix header guard

2021-05-18 Thread Nick Desaulniers
.com/ Link: https://lore.kernel.org/lkml/CAOSf1CGoN5R0LUrU=Y=uwho1z_9slgcx8s3sbfjxwjxc5by...@mail.gmail.com/ Signed-off-by: Nick Desaulniers --- arch/powerpc/platforms/powernv/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/powernv/pci.c b/arch/powerpc

Re: [PATCH] powerpc/powernv/pci: remove dead code from !CONFIG_EEH

2021-05-17 Thread Nick Desaulniers
rnel is a good example since that uses > the same RTAS calls, but it has nothing to do with the EEH recovery > machinery enabled by CONFIG_EEH. > > I was looking into that largely because people were considering using > OPAL for microwatt platforms. Breaking the assumption that > powernv==EEH support is one of the few bits of work required to enable > that, but even if you don't go down that road I think everyone would > be better off if you kept a degree of separation between the two. -- Thanks, ~Nick Desaulniers

Re: [PATCH v7] powerpc/irq: Inline call_do_irq() and call_do_softirq()

2021-05-04 Thread Nick Desaulniers
On Fri, Apr 30, 2021 at 2:33 PM Nick Desaulniers wrote: > > On Tue, Apr 27, 2021 at 1:42 PM Nick Desaulniers > wrote: > > > > On Mon, Apr 26, 2021 at 11:39 PM Christophe Leroy > > wrote: > > > > > > As you can see, CLANG doesn't save/restore &#

Re: [PATCH v7] powerpc/irq: Inline call_do_irq() and call_do_softirq()

2021-04-30 Thread Nick Desaulniers
On Tue, Apr 27, 2021 at 1:42 PM Nick Desaulniers wrote: > > On Mon, Apr 26, 2021 at 11:39 PM Christophe Leroy > wrote: > > > > As you can see, CLANG doesn't save/restore 'lr' allthought 'lr' is > > explicitely listed in the > > regi

Re: [PATCH v7] powerpc/irq: Inline call_do_irq() and call_do_softirq()

2021-04-27 Thread Nick Desaulniers
EAD_SIZE - > STACK_FRAME_OVERHEAD), > >> + [callee] "i" (__do_softirq) > >> +: // Clobbers > >> + "lr", "xer", "ctr", "memory", "cr0", "cr1", "cr5", "cr6", > >> + "cr7", "r0", "r3", "r4", "r5", "r6", "r7", "r8", "r9", > "r10", > >> + "r11", "r12" > >> + ); > > -- > You received this message because you are subscribed to the Google Groups > "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clang-built-linux+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/clang-built-linux/de6fc09f-97f5-c934-6393-998ec766b48a%40csgroup.eu. -- Thanks, ~Nick Desaulniers

Re: [PATCH 1/2] powerpc/vdso64: link vdso64 with linker

2021-04-22 Thread Nick Desaulniers
On Wed, Sep 2, 2020 at 11:02 AM Christophe Leroy wrote: > > > > Le 02/09/2020 à 19:41, Nick Desaulniers a écrit : > > On Wed, Sep 2, 2020 at 5:14 AM Michael Ellerman wrote: > >> > >> Nick Desaulniers writes: > >>> Fixes: commit f2af201002a8 ("

[PATCH] powerpc/powernv/pci: remove dead code from !CONFIG_EEH

2021-04-22 Thread Nick Desaulniers
rches Link: https://github.com/ClangBuiltLinux/linux/issues/570 Link: https://lore.kernel.org/lkml/67f6cd269684c9aa8463ff4812c3b4605e6739c3.ca...@perches.com/ Signed-off-by: Nick Desaulniers --- arch/powerpc/platforms/powernv/pci.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/arch/po

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-04 Thread Nick Desaulniers
ux/compiler.h:246: prevent_tail_call_optimization commit a9a3ed1eff36 ("x86: Fix early boot crash on gcc-10, third try") > > Perhaps we can ask the toolchain folks to help add such an attribute. Or > maybe the feature already exists somewhere, but hidden. > > +Cc linux-toolcha...@vger.kernel.org > > > > But I'm also not sure if with all that we'd be guaranteed the code we > > > want, even though in practice it might. > > > > True! I'd just like to be on the least dodgy ground we can be. > > It's been dodgy for a while, and I'd welcome any low-cost fixes to make > it less dodgy in the short-term at least. :-) > > Thanks, > -- Marco -- Thanks, ~Nick Desaulniers

Re: [PATCH 2/3] Revert "lib: Revert use of fallthrough pseudo-keyword in lib/"

2020-11-17 Thread Nick Desaulniers
esting tree, so it can be > build-tested by the 0-day folks. :) SGTM, and thank you. I'm sure you saw the existing warning about indentation. Do we want to modify the revert patch, or put another patch on top? -- Thanks, ~Nick Desaulniers

[PATCH 2/3] Revert "lib: Revert use of fallthrough pseudo-keyword in lib/"

2020-11-16 Thread Nick Desaulniers
This reverts commit 6a9dc5fd6170 ("lib: Revert use of fallthrough pseudo-keyword in lib/") Now that we can build arch/powerpc/boot/ free of -Wimplicit-fallthrough, re-enable these fixes for lib/. Link: https://github.com/ClangBuiltLinux/linux/issues/236 Signed-off-by: Nick Desaulniers

[PATCH 0/3] PPC: Fix -Wimplicit-fallthrough for clang

2020-11-16 Thread Nick Desaulniers
We don't need compiler_types.h for the definition of `fallthrough`, simply compiler_attributes.h. Include that, revert the revert to lib/, and fix the last remaining cases I observed for powernv_defconfig. Nick Desaulniers (3): powerpc: boot: include compiler_attributes.h Revert &quo

Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-22 Thread Nick Desaulniers
el.org/lkml/75393e5ddc272dc7403de74d645e6c6e0f4e70eb.ca...@perches.com/2-convert_section.pl > > Signed-off-by: Joe Perches > --- > > This conversion was previously submitted to -next last month > https://lore.kernel.org/lkml/46f69161e60b802488ba8c8f3f8bbf922aa3b49b.ca...@perches.com/ &

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-05 Thread Nick Desaulniers
, not an error. It should be fixed > > of course, but it is less important; although it may be pointing to a > > deeper problem.) > > > > > > Segher > -- Thanks, ~Nick Desaulniers

Re: error: redefinition of ‘dax_supported’

2020-09-21 Thread Nick Desaulniers
On Mon, Sep 21, 2020 at 11:47 AM Dan Williams wrote: > > On Mon, Sep 21, 2020 at 11:35 AM Nick Desaulniers > wrote: > > > > Hello DAX maintainers, > > I noticed our PPC64LE builds failing last night: > > https://travis-ci.com/github/ClangBuiltLinux/continuous-int

[PATCH 2/2] powerpc/vdso32: link vdso64 with linker

2020-09-01 Thread Nick Desaulniers
was used in the vdso32. Fixes: commit f2af201002a8 ("powerpc/build: vdso linker warning for orphan sections") Link: https://lore.kernel.org/lkml/cakwvodnn3wxydjomvnveyd_njwrku3fabwt_bs92duihhyw...@mail.gmail.com/ Signed-off-by: Nick Desaulniers --- Not sure removing .got is a good

Re: [PATCH v1] powerpc: Make setjmp/longjump signature standard

2020-03-27 Thread Nick Desaulniers
@@ > # Makefile for the linux kernel. > # > > -# Avoid clang warnings around longjmp/setjmp declarations > -CFLAGS_crash.o += -ffreestanding > - > obj-y += core.o crash.o core_$(BITS).o > > obj-$(CONFIG_PPC32)+= relocate_32.o > -- > 2.25.1.696.g5e7596f4ac-goog > -- Thanks, ~Nick Desaulniers

Re: [PATCH v4 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp

2019-10-14 Thread Nick Desaulniers
's fleet, and most calls to memcmp don't care about the position of the mismatch; bcmp is lower overhead (or at least for our libc implementation, not sure about others). -- Thanks, ~Nick Desaulniers

Re: [PATCH] powerpc: fix inline asm constraints for dcbz

2019-08-09 Thread Nick Desaulniers
On Fri, Aug 9, 2019 at 1:13 PM Arnd Bergmann wrote: > > On Fri, Aug 9, 2019 at 10:02 PM Christophe Leroy > wrote: > > > > Arnd Bergmann a écrit : > > > On Fri, Aug 9, 2019 at 8:21 PM 'Nick Desaulniers' via Clang Built > > > Linux wrote:

Re: [PATCH] powerpc: workaround clang codegen bug in dcbz

2019-07-29 Thread Nick Desaulniers
On Mon, Jul 29, 2019 at 1:47 PM Nathan Chancellor wrote: > > On Mon, Jul 29, 2019 at 01:45:35PM -0700, Nick Desaulniers wrote: > > On Mon, Jul 29, 2019 at 1:32 PM Nathan Chancellor > > wrote: > > > > > > On Mon, Jul 29, 2019 at 01:25:41PM -0700, Nick Desauln

Re: [PATCH v2] powerpc: slightly improve cache helpers

2019-07-22 Thread Nick Desaulniers
it looks like clang took that *(u8 *)addr as rvalue, and > stored that in stack, and then used *that* as memory. What's the %y modifier supposed to mean here? addr is in the list of inputs, so what's wrong with using it as an rvalue? > > Maybe clang simply does not not to treat "Z" the same as "m"? (And "Y" > and "Q" and "es" and a whole bunch of "w*", what about those?) -- Thanks, ~Nick Desaulniers

Re: [PATCH] powerpc: vdso: drop unnecessary cc-ldoption

2019-04-30 Thread Nick Desaulniers
On Tue, Apr 23, 2019 at 2:11 PM Nick Desaulniers wrote: > > Towards the goal of removing cc-ldoption, it seems that --hash-style= > was added to binutils 2.17.50.0.2 in 2006. The minimal required version > of binutils for the kernel according to > Documentation/process/chan

Re: [PATCH 12/10] powerpc: unbreak DYNAMIC_DEBUG=y build with clang

2019-04-29 Thread Nick Desaulniers
uiltLinux/linux/issues/456), but unbreak the > build for older versions. > > Fixes: powerpc: select DYNAMIC_DEBUG_RELATIVE_POINTERS for PPC64 > Reported-by: Nathan Chancellor > Reported-by: Arnd Bergmann > Signed-off-by: Rasmus Villemoes Thanks for fixing the build. Reviewed-by:

Re: [PATCH v3] powerpc/math-emu: Update macros from GCC

2018-12-03 Thread Nick Desaulniers
.org/linuxppc-dev/20181102033713.31916-1-j...@jms.id.au/ > v2: > Instead of setting the -fheinous-gnu-extensions for clang, fix the code. > v3: > Sync with GCC version instead of GMP version Thanks for matching these up. Reviewed-by: Nick Desaulniers > --- > arch/powerpc/i

Re: [PATCH v2] raid6/ppc: Fix build for clang

2018-12-03 Thread Nick Desaulniers
On Mon, Dec 3, 2018 at 2:14 PM Joel Stanley wrote: > > On Tue, 4 Dec 2018 at 05:15, Nick Desaulniers wrote: > > > > > +ifdef CONFIG_CC_IS_CLANG > > > > > +# clang ppc port does not yet support -maltivec when -msoft-float is > > > > > +# e

Re: [PATCH v2] raid6/ppc: Fix build for clang

2018-12-03 Thread Nick Desaulniers
On Mon, Dec 3, 2018 at 2:24 AM Joel Stanley wrote: > > On Sat, 3 Nov 2018 at 04:04, Nick Desaulniers wrote: > > > > On Thu, Nov 1, 2018 at 5:45 PM Joel Stanley wrote: > > > > > > We cannot build these files with clang as it does not allow altivec > > &g

Re: [PATCH] powerpc/math-emu: Fix building with clang

2018-11-12 Thread Nick Desaulniers
I can of think that add_ss(), sub_ddmmss(), and umul_ppmm() should be rewritten from the form: asm("..." : "=r" (USItype)(arg) : ...); to the form: USItype temp = (USItype) arg; asm("..." : "=r" (temp) : ...); arg = (typeof(arg)) temp; Rather than the flag being added. -- Thanks, ~Nick Desaulniers

Re: [PATCH v2] powerpc/32: Avoid unsupported flags with clang

2018-11-12 Thread Nick Desaulniers
-$(CONFIG_PPC32) := $(call cc-option, -ffixed-r2) > + > +# Clang doesn't support -mmultiple / -mno-multiple > +# https://bugs.llvm.org/show_bug.cgi?id=39556 > +CFLAGS-$(CONFIG_PPC32) += $(call cc-option, $(MULTIPLEWORD)) > + > CFLAGS-$(CONFIG_PPC32) += $(call cc-option,-mno-readonly-in-sdata) > > ifdef CONFIG_PPC_BOOK3S_64 > -- > 2.19.1 > -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 1/2] Makefile: Export clang toolchain variables

2018-11-12 Thread Nick Desaulniers
`-no-integrated-as` is set? Either way, I think it would be clearer to export this after all the relevant flags are set. > KBUILD_CFLAGS += $(CLANG_FLAGS) > KBUILD_AFLAGS += $(CLANG_FLAGS) > -- > 2.19.1 > -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 2/2] kbuild: consolidate Clang compiler flags

2018-11-09 Thread Nick Desaulniers
FLAGS += -no-integrated-as > +CLANG_FLAGS+= -no-integrated-as > +KBUILD_CFLAGS += $(CLANG_FLAGS) > +KBUILD_AFLAGS += $(CLANG_FLAGS) > endif > > RETPOLINE_CFLAGS_GCC := -mindirect-branch=thunk-extern > -mindirect-branch-register > -- > 2.7.4 > Thanks for this p

Re: [PATCH v2 1/2] kbuild: add -no-integrated-as Clang option unconditionally

2018-11-09 Thread Nick Desaulniers
IX) > -KBUILD_CFLAGS += $(call cc-option, -no-integrated-as) > -KBUILD_AFLAGS += $(call cc-option, -no-integrated-as) > +KBUILD_CFLAGS += -no-integrated-as > +KBUILD_AFLAGS += -no-integrated-as Sorry for the delay in review. Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers

Re: [PATCH 0/2] poewrpc/Boot: Fix cross compiling with clang

2018-11-05 Thread Nick Desaulniers
c/boot: Set target when cross-compiling for clang > > Makefile | 3 +++ > arch/powerpc/boot/Makefile | 7 +++ > 2 files changed, 10 insertions(+) > > -- > 2.19.1 > -- Thanks, ~Nick Desaulniers

Re: [PATCH] powerpc/math-emu: Fix building with clang

2018-11-02 Thread Nick Desaulniers
> index 494df26c5988..b9cb797445ac 100644 > --- a/arch/powerpc/math-emu/Makefile > +++ b/arch/powerpc/math-emu/Makefile > @@ -18,3 +18,7 @@ CFLAGS_fabs.o = -fno-builtin-fabs > CFLAGS_math.o = -fno-builtin-fabs > > ccflags-y = -I. -Iinclude/math-emu -w > + > +ifdef CONFIG_CC_IS_CLANG > +ccflags-y += -fheinous-gnu-extensions > +endif > -- > 2.19.1 > -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 1/5] powerpc/Makefiles: Fix clang/llvm build

2018-09-14 Thread Nick Desaulniers
,-mpower4 > +cpu-as-$(CONFIG_PPC_BOOK3S_64) += $(call > as-option,-Wa$(comma)-mpower8,-Wa$(comma)-mpower4) > cpu-as-$(CONFIG_PPC_E500MC)+= $(call as-option,-Wa$(comma)-me500mc) > > KBUILD_AFLAGS += $(cpu-as-y) > -- > 2.17.1 > -- Thanks, ~Nick Desaulniers