This series reworks how EEH devices are initialised. This mainly affects
pseries since it moves the "early" EEH probe out of shared code and into
pseries platform code. The goal here is to make the platform
dependencies more explicit and to allow PowerNV to implement its own
pci_dev <-> eeh_dev
On Thu, Jan 30, 2020 at 5:32 PM Oliver O'Halloran wrote:
>
> The platform makefile (arch/powerpc/platforms/pseries/Makefile) is only
doh
s/platform/pseries/
> included by the platform makefile (arch/powerpc/platform/Makefile) when
> CONFIG_PPC_PSERIES is selected,
vio.c requires CONFIG_IBMVIO which in turn depends on PPC_PSERIES.
In other words, this ifdef is pointless. At a guess it's a carry-over
from pre-history.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/pseries/vio.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/powerpc
The platform makefile (arch/powerpc/platforms/pseries/Makefile) is only
included by the platform makefile (arch/powerpc/platform/Makefile) when
CONFIG_PPC_PSERIES is selected, so checking for CONFIG_PPC_PSERIES in the
pseries makefile is pointless.
Signed-off-by: Oliver O'Halloran
---
arch
to be specified via an environmental variable
(EEH_MAX_WAIT).
Reported-by: Steve Best
Suggested-by: Douglas Miller
Signed-off-by: Oliver O'Halloran
---
tools/testing/selftests/powerpc/eeh/eeh-functions.sh | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests
On Thu, Jan 16, 2020 at 4:00 PM Daniel Axtens wrote:
>
> Michael Ellerman writes:
>
> > From: Joel Stanley
> >
> > This turns on HARDENED_USERCOPY with HARDENED_USERCOPY_PAGESPAN, and
> > FORTIFY_SOURCE.
> >
> > It also enables SECURITY_LOCKDOWN_LSM with _EARLY and
> >
This is only used in pci-ioda.c so move it there and rename it to match.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 22 +-
arch/powerpc/platforms/powernv/pci.c | 20
arch/powerpc/platforms/powernv/pci.h
pnv_pci_dma_dev_setup() does nothing but call the phb->dma_dev_setup()
callback, if one exists. That callback is only set for normal PCIe PHBs so
we can remove the layer of indirection and use the ioda version in
the pci_controller_ops.
Signed-off-by: Oliver O'Halloran
---
arch/powe
dev_setup().
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 29 +
arch/powerpc/platforms/powernv/pci.c | 14 --
2 files changed, 25 insertions(+), 18 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.
The pnv_pci_dma_dev_setup() only does something when:
1) There PHB contains VFs, or
2) The PHB defines a dma_dev_setup() callback in the pnv_phb structure.
Neither is true for NPU PHBs so there's no reason to set the callback.
Reviewed-by: Alexey Kardashevskiy
Signed-off-by: Oliver O'Halloran
pcibios_bus_add_device() is the only caller of pcibios_setup_device().
Fold them together since there's no real reason to keep them separate.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/kernel/pci-common.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/arch
Pulled out of my big series since these are fairly standalone changes
The series folds some single-use functions together and shovels around
some code so it lives in a more sensible location. No functional
changes.
On Wed, Nov 27, 2019 at 12:07 PM Haren Myneni wrote:
>
> *snip*
>
> @@ -36,7 +62,18 @@ static int init_vas_instance(struct platform_device *pdev)
> return -ENODEV;
> }
>
> - if (pdev->num_resources != 4) {
> + rc = of_property_read_u64(dn, "ibm,vas-port", );
>
On Mon, Dec 2, 2019 at 2:08 PM Jordan Niethe wrote:
>
> Commit a25bd72badfa ("powerpc/mm/radix: Workaround prefetch issue with
> KVM") introduced a number of workarounds as coming out of a guest with
> the mmu enabled would make the cpu would start running in hypervisor
> state with the PID value
On Wed, Nov 27, 2019 at 4:24 PM Alexey Kardashevskiy wrote:
>
>
>
> On 20/11/2019 12:28, Oliver O'Halloran wrote:
> > Signed-off-by: Oliver O'Halloran
> > ---
> > arch/powerpc/platforms/powernv/pci-ioda.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 de
On Wed, Nov 27, 2019 at 8:34 PM Greg Kurz wrote:
>
>
> If everyone is ok with leaking a reference in the NPU case, I guess
> this isn't a problem. But if we move forward with Oliver's patch, a
> pci_dev_put() would be needed for OpenCAPI, correct ?
Yes, but I think that's fair enough. By
On Thu, Nov 21, 2019 at 3:34 PM Alexey Kardashevskiy wrote:
>
>
>
> On 20/11/2019 12:28, Oliver O'Halloran wrote:
> > Move this out of the PHB's dma_dev_setup() callback and into the
> > ppc_md.pcibios_fixup_iov callback. This ensures that the VF PE's
> >
On Thu, Nov 21, 2019 at 6:48 PM Christoph Hellwig wrote:
>
> On Wed, Nov 20, 2019 at 12:28:19PM +1100, Oliver O'Halloran wrote:
> > Move this out of the PHB's dma_dev_setup() callback and into the
> > ppc_md.pcibios_fixup_iov callback. This ensures that the VF PE's
> >
On Mon, Nov 25, 2019 at 2:27 PM Alexey Kardashevskiy wrote:
>
>
>
> On 20/11/2019 12:28, Oliver O'Halloran wrote:
> > Have the PowerNV EEH backend allocate the eeh_dev if needed rather than
> > using
> > the one attached to the pci_dn.
>
> So that pci_dn
On Mon, Nov 25, 2019 at 2:20 PM Alexey Kardashevskiy wrote:
>
>
>
> On 20/11/2019 12:28, Oliver O'Halloran wrote:
> > Use the pnv_eeh_find_edev() helper to look up the eeh_dev for a device
> > rather than doing it via the pci_dn.
>
> This is not what the patc
On Thu, Nov 21, 2019 at 2:38 PM Alexey Kardashevskiy wrote:
>
>
>
> On 20/11/2019 12:28, Oliver O'Halloran wrote:
> > After resetting a VF we call eeh_restore_vf_config() to restore several
> > registers in the VFs config space. For physical functions this
On Thu, Nov 21, 2019 at 3:02 PM Alexey Kardashevskiy wrote:
>
>
>
> On 20/11/2019 12:28, Oliver O'Halloran wrote:
> > These functions are only used from pci-ioda.c. Move them in there and remove
> > the prototypes from the header files.
>
>
> Make them static th
Not-Signed-off-by: Oliver O'Halloran
---
arch/powerpc/kernel/pci_dn.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/powerpc/kernel/pci_dn.c b/arch/powerpc/kernel/pci_dn.c
index f790a8d06f50..0e05c1d7633a 100644
--- a/arch/powerpc/kernel/pci_dn.c
+++ b/arch/powerpc/kernel/pci_dn.c
:toot:
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/pci.c
b/arch/powerpc/platforms/powernv/pci.c
index 0eeea8652426..6383dcfec606 100644
--- a/arch/powerpc/platforms
P8 needs to shove four GPUs into three PEs for $reasons. Remove the
pdn->pe_assignment done there since we just use the pe_rmap[] now.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/a
The only thing we need the pdn for in this function is setting the pe_number
field, which we don't use anymore. Fix the weird refcounting behaviour while
we're here.
Signed-off-by: Oliver O'Halloran
---
Either Fred, or Reza also fixed this in some patch lately and that'll probably
get
merged
Nothing looks at it anymore.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 12
1 file changed, 12 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c
b/arch/powerpc/platforms/powernv/pci-ioda.c
index d3e375d71cdc..45d940730c30
We don't need a pci_dn for the VF any more, so we can skip adding them.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 16
1 file changed, 16 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c
b/arch/powerpc/platforms/powernv
from being called.
In other words, the desired behaviour here appears to be leaking a ref.
Nice!
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/npu-dma.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/npu-dma.c
There's no need to use the pci_dn to find a device_node from a pci_dev.
Just search for the node pointed to by the pci_dev's of_node pointer.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/npu-dma.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
environment the first downstream child will be at devfn 00.0.
In any case it's completely broken when no pci_dn is available. Remove
the PCI_DN checking and scan each of the device number that might be on
the downstream bus.
Cc: Benjamin Herrenschmidt
Signed-off-by: Oliver O'Halloran
---
I'm not sure we
ing a DMA so this gets us a bit closer to the model used
by the HW, which is comprensible by mortals, rather than... whatever
the hell is going on currently.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
d
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/npu-dma.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/npu-dma.c
b/arch/powerpc/platforms/powernv/npu-dma.c
index b95b9e3c4c98..68bfaef44862 100644
--- a/arch
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c
b/arch/powerpc/platforms/powernv/pci-ioda.c
index 4f38652c7cd7..8525642b1256 100644
--- a/arch
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c
b/arch/powerpc/platforms/powernv/pci-ioda.c
index 7e88de18ead6..4f38652c7cd7 100644
--- a/arch
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/pci.c
b/arch/powerpc/platforms/powernv/pci.c
index 5b1f4677cdce..0eeea8652426 100644
--- a/arch/powerpc/platforms
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c
b/arch/powerpc/platforms/powernv/pci-ioda.c
index 98d858999a2d..7e88de18ead6 100644
--- a/arch
Use the helper to look up the pnv_ioda_pe for the device we're configuring DMA
for. In the VF case there's no need set pdn->pe_number since nothing looks at
it any more.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 3 +--
1 file changed, 1 insertion(+)
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c
b/arch/powerpc/platforms/powernv/pci-ioda.c
index 5bd7c1b058da..d4b5ee926222 100644
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 32 +--
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c
b/arch/powerpc/platforms/powernv/pci-ioda.c
index 1c90feed233d..5bd7c1b058da
specific
structure helps to clarify the role of pci_dn and ensures that the platform
specifics stay that way.
This will make the code easier to understand and modify since we don't need
to so much aboute PowerNV changes breaking pseries and EEH, and vis-a-vis.
Signed-off-by: Oliver O'Halloran
---
TODO
-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/arch/powerpc/platforms/powernv/pci.c
b/arch/powerpc/platforms/powernv/pci.c
index 36eea4bb514c..5b1f4677cdce 100644
--- a/arch/powerpc/platforms/powernv/pci.c
+++ b
Remove the use of pci_dn from the low-level config space access functions.
These are used by the eeh's config ops and the bus config ops that we
provide to the PCI core.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/eeh-powernv.c | 14 +++
arch/powerpc/platforms
Despite the name this function is generic PowerNV PCI code rather than anything
EEH specific. Convert to take a phb and bdfn rather than a pci_dn.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci.c | 32 ++--
1 file changed, 21 insertions(+), 11
Squash another usage in preperation for making the config accessors pci_dn.
Signed-off-by: Oliver O'Halloran
---
We might want to move this into eeh-powernv.c
---
arch/powerpc/platforms/powernv/pci.c | 37 +---
1 file changed, 17 insertions(+), 20 deletions(-)
diff
lookup method moves into the pseries platform and PowerNV
can choose the PE based on the bus heirachy instead.
Signed-off-by: Oliver O'Halloran
---
"parent" meaning "parent of the PE that actually contains this edev"
is stupid, but it's stupid consistent with what's there alre
Have the PowerNV EEH backend allocate the eeh_dev if needed rather than using
the one attached to the pci_dn. This gets us most of the way towards decoupling
pci_dn from the PowerNV EEH code.
Signed-off-by: Oliver O'Halloran
---
We should probably be free()ing the eeh_dev somewhere. The pci_dev
Use the pnv_eeh_find_edev() helper to look up the eeh_dev for a device
rather than doing it via the pci_dn.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/eeh-powernv.c | 44 ++--
1 file changed, 31 insertions(+), 13 deletions(-)
diff --git a/arch/powerpc
Most of what we fetch from the pci_dn is also in the pci_dev structure. Convert
the pnv_eeh_probe_pdev() to use the pdev fields rather than the pci_dn so we can
get rid of pci_dn eventually.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/eeh-powernv.c | 26
a problem if an EEH event occured while probing the device,
but I'm pretty sure that's going to be broken anyway.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/eeh-powernv.c | 67 ++--
1 file changed, 4 insertions(+), 63 deletions(-)
diff --git a/arch/powerpc
roller inside the function. This is
hard to read since it requires you to memorise the contents of the
private data fields and kind of error prone since it involves blindly
assigning a void pointer. Add a helper to make it more concise and
explict.
Signed-off-by: Oliver O'Halloran
---
arch/p
"traverse the
pdn tree" method? Probably not.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/eeh-powernv.c | 31
arch/powerpc/platforms/powernv/pci.h | 2 ++
2 files changed, 33 insertions(+)
diff --git a/arch/powerpc/platforms/powernv/eeh
Neaten things up a bit and remove a pci_dn use.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/eeh-powernv.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c
b/arch/powerpc/platforms/powernv/eeh
Use the pnv_eeh_{read|write}_config() functions that take an edev rather
than a pci_dn. This allows us to remove most of the explict uses of pci_dn
in the PowerNV EEH backend and localises them into a few functions which we
can fix later.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc
another pci_dn usage.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/eeh-powernv.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c
b/arch/powerpc/platforms/powernv/eeh-powernv.c
index 5250c4525544
rom using pci_dn on PowerNV and moving the eeh_dev
lookup into probe_pdev() allows the EEH core to be oblivious of how the
mapping is actually done.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/include/asm/eeh.h | 16 +++--
arch/powerpc/kernel/eeh.c|
ions always return NULL so there's
not much point to it.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/include/asm/eeh.h | 3 +-
arch/powerpc/kernel/eeh.c| 6 ++--
arch/powerpc/platforms/powernv/eeh-powernv.c | 29 ++--
arch/powerpc/platf
We use the pci_dn to retrieve the domain, bus, device, and function numbers for
an EEH device. We now have that in the eeh_dev so covert the various printk()s
we have around the place to source that information from the eeh_dev.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/kernel/eeh.c
Remove another pdn usage.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/include/asm/eeh.h | 2 +-
arch/powerpc/kernel/eeh.c| 5 ++---
arch/powerpc/kernel/eeh_pe.c | 6 ++
arch/powerpc/platforms/powernv/eeh-powernv.c | 11
Switch the eeh_ops->{read|write}_config methods to take an eeh_dev structure
rather than a pci_dn structure to specify the target device. This removes a
lot of the uses of pci_dn in both the EEH core and in the platform EEH
support.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/include/
to remove a VF are slightly
different to those which remove a physical PCI device.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/kernel/eeh_driver.c | 44 +++-
1 file changed, 37 insertions(+), 7 deletions(-)
diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch
we have some symmetry between the setup and
teardown paths. Moving the PE assignments to here should also allow us to
converge how PE assignment works on all PHB types so it's always done in
one place.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c |
the fixup and it makes dma_dev_setup a bit simpler.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 35 +++
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c
b/arch/powerpc/platforms/powernv
This is only ever set for IODA PHBs. The only call site is in
pnv_pci_dma_dev_setup(), which is also only used by normal IODA PHBs, so remove
the callback in favour of a direct call.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 4 +---
arch/powerpc/platforms
These functions are only used from pci-ioda.c. Move them in there and remove
the prototypes from the header files.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 43 +++
arch/powerpc/platforms/powernv/pci.c | 43
The pnv_pci_dma_dev_setup() only does something when:
1) There PHB contains VFs, or
2) The PHB defines a dma_dev_setup() callback in the pnv_phb structure.
Neither is true for NPU PHBs, so don't set the callback in the
pci_controller_ops.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc
ed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/pci-ioda.c | 10 ++
arch/powerpc/platforms/powernv/pci.h | 1 +
2 files changed, 11 insertions(+)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c
b/arch/powerpc/platforms/powernv/pci-ioda.c
index fdacf9
ing useful cleanups.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/kernel/eeh.c| 59
arch/powerpc/platforms/powernv/eeh-powernv.c | 39 +++--
arch/powerpc/platforms/pseries/eeh_pseries.c | 26 +
3 files changed, 8 insertions(+), 116 deletion
This series does a few things and probably needs to be split into two or
three smaller ones. I figured I'd post it as-is since I'm sick of sitting
on it and some people wanted people to take a look at it. There's three
parts:
1) Reworking EEH to move the "pseudo-generic" into the platform
On Tue, Nov 19, 2019 at 11:57 PM Frederic Barrat wrote:
>
> > Do the other accessors of ioda.pe_list also need mutex protection?
> > pnv_ioda_setup_bus_PE()
> > pnv_pci_dma_bus_setup()
> > pnv_pci_init_ioda_phb()
> > pnv_pci_ioda_setup_PEs()
>
>
> I think we could also use it there, it wouldn't
es drivers
that is: AER, PME, BW notifications, hotplug, and DPC. However, this is
not a huge disadvantage on PowerNV since these services are either unused
or handled through other means.
Cc: Sergey Miroshnichenko
Fixes: 66725152fb9f ("PCI/hotplug: PowerPC PowerNV PCI hotplug driver")
S
On Mon, Nov 18, 2019 at 12:06 PM Alistair Popple wrote:
>
> On Wednesday, 13 November 2019 4:38:21 AM AEDT Frederic Barrat wrote:
> >
> > However, one question is whether this patch breaks nvlink and if nvlink
> > assumes the devices won’t go away because we explicitly take a reference
> >
On Thu, Nov 14, 2019 at 7:39 AM Tyrel Datwyler wrote:
>
> Nothing but pedantic spelling and grammar nits of the commit log follow.
>
> -Tyrel
Thanks. My speeling is bad even on a good day and it was not a good day.
On Thu, Nov 14, 2019 at 1:31 AM Bjorn Helgaas wrote:
>
> This is fine, but it feels like sort of a blunt instrument. Is there
> any practical way to clear pci_host_bridge.native_pcie_hotplug (and
> native_aer if appropriate) for the PHBs in question? That would also
> prevent pciehp from
On Thu, Nov 14, 2019 at 6:19 PM Madhavan Srinivasan
wrote:
>
> When a root user or a user with CAP_SYS_ADMIN
> privilege use trace_imc performance monitoring
> unit events, to monitor application or KVM threads,
> may result in a checkstop (System crash). Reason
> being frequent switch of the
these problems by setting the "pcie_ports_disabled" flag during
platform initialisation. The flag indicates the platform owns the PCIe
ports which stops the portbus driver being registered.
Cc: Sergey Miroshnichenko
Fixes: 66725152fb9f ("PCI/hotplug: PowerPC PowerNV PCI hotplug driver")
S
eeh_pe_get() to eeh_pe_find()
> because it performs a search.
>
> Signed-off-by: Sam Bobroff
Good idea.
Reviewed-by: Oliver O'Halloran
On Sat, Nov 2, 2019 at 5:46 AM Jeffrin Thalakkottoor
wrote:
>
> hello ,
>
> i found a error message as the output of "sudo dmesg -l err"
> i have attached related to that in this email.
> i think i found this in 5.3.8 kernel
Use "uname -a" to get the current kernel version, architecture.
>
On Sun, Nov 3, 2019 at 11:31 PM Markus Elfring wrote:
>
> From: Markus Elfring
> Date: Sun, 3 Nov 2019 13:23:13 +0100
>
> The field “owner” is set by the core.
> Thus delete an unneeded initialisation.
Acked-by: Oliver O'Halloran
>
> Generated by
to be able to trigger one of these resets directly, so add a way to do
that.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/setup.c | 4
1 file changed, 4 insertions(+)
diff --git a/arch/powerpc/platforms/powernv/setup.c
b/arch/powerpc/platforms/powernv/setup.c
index 8349860
On PowerNV a few different kinds of reboot are supported. We'd like to be
able to exercise these from xmon so allow 'zr' to take an argument, and
pass that to the ppc_md.restart() function.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/xmon/xmon.c | 11 +++
1 file changed, 7
-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/opal.c | 114 +-
1 file changed, 72 insertions(+), 42 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/opal.c
b/arch/powerpc/platforms/powernv/opal.c
index 38e9027..0373da5 100644
--- a/arch/powerpc
Long before we had a generic way for firmware to export memory ranges of
interest we added a special case for the skiboot symbol map. The code is
pretty much identical to the generic export so re-use the code.
Signed-off-by: Oliver O'Halloran
---
v2: Actually compile.
---
arch/powerpc/platforms
be run multiple times on a device, once before the device is added
to the bus and once after.
There's no need to run the setup in the early case any more so just
remove it entirely.
Signed-off-by: Oliver O'Halloran
Tested-by: Alexey Kardashevskiy
Reviewed-by: Alexey Kardashevskiy
---
arch
From: Shawn Anastasio
Move PCI device setup from pcibios_add_device() and pcibios_fixup_bus() to
pcibios_bus_add_device(). This ensures that platform-specific DMA and IOMMU
setup occurs after the device has been registered in sysfs, which is a
requirement for IOMMU group assignment to work
This
gs can be fixed by just deleting the code.
Tested-by: Alexey Kardashevskiy
Reviewed-by: Alexey Kardashevskiy
Signed-off-by: Oliver O'Halloran
---
v2: Re-wrote commit message, got very depressed about the state of things.
The real fix here is to move the IOMMU group setup for both
On Fri, Oct 25, 2019 at 3:51 PM Alastair D'Silva wrote:
>
> From: Alastair D'Silva
>
> Enable OpenCAPI Storage Class Memory driver on bare metal
>
> Signed-off-by: Alastair D'Silva
> ---
> arch/powerpc/configs/powernv_defconfig | 4
> 1 file changed, 4 insertions(+)
>
> diff --git
On Wed, Oct 23, 2019 at 10:21 PM Segher Boessenkool
wrote:
>
> On Wed, Oct 23, 2019 at 12:36:35PM +1100, Oliver O'Halloran wrote:
> > When booting under OF the zImage expects the initrd address and size to be
> > passed to it using registers r3 and r4. SLOF (guest fir
.
Cc: sta...@vger.kernel.org
Cc: Alexey Kardashevskiy
Signed-off-by: Oliver O'Halloran
---
First noticed here:
https://unix.stackexchange.com/questions/547023/linux-kernel-on-ppc64le-vmlinux-equivalent-in-arch-powerpc-boot
---
arch/powerpc/boot/devtree.c | 21 +
arch/powerpc
On Thu, Oct 17, 2019 at 1:01 PM Yi Li wrote:
>
> Hi,
*snip*
> The kernel module can be insert correctly, and we mount a tmpfs, then umount.
> Kernel panic when doing umount:
> "
> [ 148.569777] umount /home/adam/test 0x0
> [ 148.608227] umount2 returned 0
> [ 148.608268] Unable to handle
it to printing one stack trace for each PE freeze. If
the driver is truely stuck the kernel's hung task detector is better suited
to reporting the probelm anyway.
Cc: Sam Bobroff
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/kernel/eeh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Tue, 2019-10-01 at 19:41 -0400, Nayna Jain wrote:
> PowerNV secure variables, which store the keys used for OS kernel
> verification, are managed by the firmware. These secure variables need to
> be accessed by the userspace for addition/deletion of the certificates.
>
> This patch adds the
On Tue, 2019-10-01 at 19:41 -0400, Nayna Jain wrote:
> The X.509 certificates trusted by the platform and required to secure boot
> the OS kernel are wrapped in secure variables, which are controlled by
> OPAL.
>
> This patch adds firmware/kernel interface to read and write OPAL secure
>
On Fri, Oct 4, 2019 at 7:24 PM kbuild test robot wrote:
>
> Hi Oliver,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on powerpc/next]
> [cannot apply to v5.4-rc1 next-20191004]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve
Long before we had a generic way for firmware to export memory ranges of
interest we added a special case for the skiboot symbol map. The code is
pretty much identical to the generic export so re-use the code.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/opal.c | 47
-by: Oliver O'Halloran
---
arch/powerpc/platforms/powernv/opal.c | 114 +-
1 file changed, 72 insertions(+), 42 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/opal.c
b/arch/powerpc/platforms/powernv/opal.c
index 38e9027..0373da5 100644
--- a/arch/powerpc
On Tue, Oct 1, 2019 at 3:09 AM Bjorn Helgaas wrote:
>
> On Mon, Sep 30, 2019 at 12:08:46PM +1000, Oliver O'Halloran wrote:
>
> This is all powerpc, so I assume Michael will handle this. Just
> random things I noticed; ignore if they don't make sense:
>
>
be run multiple times on a device, once before the device is added
to the bus and once after.
There's no need to run the setup in the early case any more so just
remove it entirely.
Signed-off-by: Oliver O'Halloran
---
arch/powerpc/include/asm/pci.h| 1 -
arch/powerpc/kernel/pci-common.c
From: Shawn Anastasio
Move PCI device setup from pcibios_add_device() and pcibios_fixup_bus() to
pcibios_bus_add_device(). This ensures that platform-specific DMA and IOMMU
setup occurs after the device has been registered in sysfs, which is a
requirement for IOMMU group assignment to work
This
t appears to have no basis in
reality so just delete it.
Signed-off-by: Oliver O'Halloran
---
Can't get rid of the fixup entirely since we need it to set the
ioda_pe->pdev back-pointer. I'll look at killing that another time.
---
arch/powerpc/kernel/eeh_driver.c | 6 --
arch/power
301 - 400 of 690 matches
Mail list logo
