lable for
> use. This fix provides the required escalation.
>
> Signed-off-by: Manoj N. Kumar
> Acked-by: Matthew R. Ochs
> Reviewed-by: Brian King
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozla
ing the AFU version
> evaluation is eliminated as it is not needed.
>
> Signed-off-by: Matthew R. Ochs
> Acked-by: Manoj Kumar
> Reviewed-by: Andrew Donnellan
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
eing recovered or returns a failure if the recovery failed. In
> the event that the adapter reset failed, the failure is simply returned
> as the ioctl would be unable to continue.
>
> Reported-by: Brian King
> Signed-off-by: Matthew R. Ochs
> Signed-off-b
g
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
> Reviewed-by: Andrew Donnellan
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
r the life of the adapter. In the future, if the CXL services adopt
> a private member for their context, that could be used to store the
> adapter structure reference and cxlflash could revert to a model that
> does not require an embedded fops.
>
> Signed-off-by: Matthew R. Oc
On 21.10.2015 22:15, Matthew R. Ochs wrote:
> From: Manoj Kumar
>
> The operator used to double the master context response delay
> is incorrect and does not result in delay doubling.
>
> To fix, use a left shift instead of the XOR operator.
>
> Reported-by: Tomas Henzl
bit.
>
> To fix, the AFU RRQ in host memory needs to be cleared after each reset.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
> Reviewed-by: Daniel Axtens
Reviewed-by: Tomas Henzl
Tomas
___
; Fix spelling and grammar issues. Update some comments for clarity and
> consistency. Remove extra lines and a few unneeded variables/statements.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
> Reviewed-by: Andrew Donnella
-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
> Reviewed-by: Daniel Axtens
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
ppropriate to make driver sparse clean.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
> Reviewed-by: Andrew Donnellan
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Li
roperly reflect parameter
> names and return codes.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
> Reviewed-by: Andrew Donnellan
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing l
On 21.10.2015 22:14, Matthew R. Ochs wrote:
> The host reset handler is called with I/O already blocked, thus
> there is no need to explicitly block and unblock I/O in the handler.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
Kumar
> Reviewed-by: Brian King
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
rlier in remove and use cancel_work_sync() instead
> of flush_work() as there is not a need to process any scheduled work when
> shutting down.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
ff-by: Manoj N. Kumar
> Reviewed-by: Brian King
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
an underrun scenario.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
and add a check to prevent an incompatible AFU
> from being used with this driver.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
> Reviewed-by: Daniel Axtens
Reviewed-by: Tomas Henzl
Tomas
_
that despite its void-like behavior, the function was left with a
> return code for right now in case its behavior needs to be altered again
> in the near future based on testing.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
>
add back in the proper evaluation for an unset bit.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https:
o remedy, the host should be rescanned after a link up event.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linux
le waiting for a TMF completion. When a TMF
> times out, report back a failure such that a bigger hammer reset
> can occur.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
Reviewed-by: Tomas Henzl
Tomas
___
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
> Reviewed-by: Andrew Donnellan
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
mour
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
ew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
gned-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
> Reviewed-by: Daniel Axtens
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
ently executing ioctls.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
> Reviewed-by: Daniel Axtens
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
viewed-by: Brian King
> Reviewed-by: Daniel Axtens
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
; Reviewed-by: Daniel Axtens
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
on the
> mode word), the problem is avoided.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
eference per-context
> for each LUN attached to the context.
>
> This resolves a potential Oops in the release handler when a
> dealing with a LUN that has already been removed.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian Kin
ate the timeout to 30 seconds (matches the value used in sd.c)
> and rework the timeout literal to a more appropriate description.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
Reviewed-by: Tomas Henzl
Tomas
t; Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
> Reviewed-by: Andrew Donnellan
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
the subsequent modification of port_sel.
>
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
> Reviewed-by: Brian King
Reviewed-by: Tomas Henzl
Tomas
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On 16.9.2015 23:32, Matthew R. Ochs wrote:
> The adapter state machine is susceptible to missing and/or
> corrupting state updates at runtime. This can lead to a variety
> of unintended issues and is due to the lack of a serialization
> mechanism to protect the adapter state.
>
> Use an adapter-wid
On 16.9.2015 23:31, Matthew R. Ochs wrote:
> The workq can process work in parallel with a remove event, leading
> to a condition where the workq handler can access freed memory.
>
> To remedy, the workq should be terminated prior to freeing memory. Move
> the termination call earlier in remove and
On 16.9.2015 23:28, Matthew R. Ochs wrote:
> Found during code inspection, that the following functions are not
> being used outside of the file where they are defined. Make them static.
>
> int cxlflash_send_cmd(struct afu *, struct afu_cmd *);
> void cxlflash_wait_resp(struct afu *, struct afu_cm
On 16.9.2015 23:27, Matthew R. Ochs wrote:
> When a LUN is removed, the sdev that is associated with the LUN
> remains intact until its reference count drops to 0. In order
> to prevent an sdev from being removed while a context is still
> associated with it, obtain an additional reference per-cont
On 16.9.2015 23:26, Matthew R. Ochs wrote:
> From: Manoj Kumar
>
> The timeout value for read capacity is too small. Certain devices
> may take longer to respond and thus the command may prematurely
> timeout. Additionally the literal used for the timeout is stale.
>
> Update the timeout to 30 sec
On 19.9.2015 01:26, Matthew R. Ochs wrote:
>> On Sep 18, 2015, at 6:59 AM, Tomas Henzl wrote:
>> On 17.9.2015 19:16, Matthew R. Ochs wrote:
>>>> On Sep 17, 2015, at 7:38 AM, Tomas Henzl wrote:
>>>>
>>>> On 16.9.2015 18:53, Matthew R. Ochs wrote:
&
On 17.9.2015 19:16, Matthew R. Ochs wrote:
>> On Sep 17, 2015, at 7:38 AM, Tomas Henzl wrote:
>>
>> On 16.9.2015 18:53, Matthew R. Ochs wrote:
>>> Interrupt processing can run in parallel to a remove operation. This
>>> can lead to a condition where the
On 16.9.2015 18:53, Matthew R. Ochs wrote:
> Interrupt processing can run in parallel to a remove operation. This
> can lead to a condition where the interrupt handler is processing with
> memory that has been freed.
>
> To avoid processing an interrupt while memory may be yanked, check for
>
41 matches
Mail list logo
