Re: [PATCH v6 11/37] cxlflash: Refine host/device attributes

<shane.seym...@hp.com> > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas _

Re: [PATCH v6 15/37] cxlflash: Fix host link up event handling

o remedy, the host should be rescanned after a link up event. > > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> Rev

Re: [PATCH v6 14/37] cxlflash: Fix location of setting resid

an underrun scenario. > > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH v6 22/37] cxlflash: Remove unnecessary scsi_block_requests

y: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 25/37] cxlflash: Fix to prevent EEH recovery failure

thew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > Reviewed-by: Daniel Axtens <d...@axtens.net> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas _

Re: [PATCH v6 18/37] cxlflash: Fix AFU version access/storage and add check

and add a check to prevent an incompatible AFU > from being used with this driver. > > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > R

Re: [PATCH v6 21/37] cxlflash: Correct behavior in device reset handler following EEH

> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 26/37] cxlflash: Correct spelling, grammar, and alignment mistakes

ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 34/37] cxlflash: Fix to escalate to LINK_RESET on login timeout

a LINK_RESET the port will not be available for > use. This fix provides the required escalation. > > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>

Re: [PATCH v6 16/37] cxlflash: Fix async interrupt bypass logic

simply add back in the proper evaluation for an unset bit. > > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> Review

Re: [PATCH v6 19/37] cxlflash: Correct usage of scsi_host_put()

vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 23/37] cxlflash: Fix function prolog parameters and return codes

roperly reflect parameter > names and return codes. > > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > Reviewed-by: Andrew Donnellan <a

Re: [PATCH v6 29/37] cxlflash: Fix to double the delay each time

On 21.10.2015 22:15, Matthew R. Ochs wrote: > From: Manoj Kumar <ma...@linux.vnet.ibm.com> > > The operator used to double the master context response delay > is incorrect and does not result in delay doubling. > > To fix, use a left shift instead of the XOR operator. >

Re: [PATCH v6 32/37] cxlflash: Fix to avoid potential deadlock on EEH

x.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > Reviewed-by: Daniel Axtens <d...@axtens.net> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 12/37] cxlflash: Fix to avoid spamming the kernel log

t.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH v6 17/37] cxlflash: Remove dual port online dependency

...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > Reviewed-by: Daniel Axtens <d...@axtens.net> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 20/37] cxlflash: Fix to prevent workq from accessing freed memory

ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 24/37] cxlflash: Fix MMIO and endianness errors

ppropriate to make driver sparse clean. > > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > Reviewed-by: Andrew Donnellan <a

Re: [PATCH v6 30/37] cxlflash: Fix to avoid corrupting adapter fops

mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> > Reviewed-by: Daniel Axtens <d...@axtens.net> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 33/37] cxlflash: Fix to avoid leaving dangling interrupt resources

ing the AFU version > evaluation is eliminated as it is not needed. > > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Acked-by: Manoj Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> Reviewed-by: To

Re: [PATCH v6 13/37] cxlflash: Fix to avoid stall while waiting on TMF

iting for a TMF completion. When a TMF > times out, report back a failure such that a bigger hammer reset > can occur. > > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk.

Re: [PATCH v6 27/37] cxlflash: Fix to prevent stale AFU RRQ

t; > Reviewed-by: Daniel Axtens <d...@axtens.net> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 31/37] cxlflash: Correct trace string

y: Brian King <brk...@linux.vnet.ibm.com> > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.

Re: [PATCH v5 09/34] cxlflash: Correct naming of limbo state and waitq

y: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > Reviewed-by: Daniel Axtens <d...@axtens.net> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas ___

Re: [PATCH v5 03/34] cxlflash: Fix read capacity timeout

nux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v5 04/34] cxlflash: Fix potential oops following LUN removal

r <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v5 07/34] cxlflash: Fix context encode mask width

f-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > Reviewed-by: Daniel Axtens <d...@axtens.net> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas ___ Linuxppc-dev mailing list

Re: [PATCH v5 08/34] cxlflash: Fix to avoid CXL services during EEH

uting ioctls. > > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > Reviewed-by: Daniel Ax

Re: [PATCH v5 01/34] cxlflash: Fix to avoid invalid port_sel value

he lookup of the > WWID and the subsequent modification of port_sel. > > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@

Re: [PATCH v5 02/34] cxlflash: Replace magic numbers with literals

ral CMD_RETRIES. > > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > Reviewed-by: Andrew Donnellan <andrew.donnel...@au

Re: [PATCH v5 10/34] cxlflash: Make functions static

Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas ___ Linuxppc-dev m

Re: [PATCH v2 03/30] cxlflash: Fix read capacity timeout

On 16.9.2015 23:26, Matthew R. Ochs wrote: > From: Manoj Kumar > > The timeout value for read capacity is too small. Certain devices > may take longer to respond and thus the command may prematurely > timeout. Additionally the literal used for the timeout is stale. > > Update

Re: [PATCH v2 21/30] cxlflash: Fix to prevent workq from accessing freed memory

On 16.9.2015 23:31, Matthew R. Ochs wrote: > The workq can process work in parallel with a remove event, leading > to a condition where the workq handler can access freed memory. > > To remedy, the workq should be terminated prior to freeing memory. Move > the termination call earlier in remove

Re: [PATCH v2 11/30] cxlflash: Make functions static

On 16.9.2015 23:28, Matthew R. Ochs wrote: > Found during code inspection, that the following functions are not > being used outside of the file where they are defined. Make them static. > > int cxlflash_send_cmd(struct afu *, struct afu_cmd *); > void cxlflash_wait_resp(struct afu *, struct

Re: [PATCH v2 29/30] cxlflash: Fix to avoid state change collision

On 16.9.2015 23:32, Matthew R. Ochs wrote: > The adapter state machine is susceptible to missing and/or > corrupting state updates at runtime. This can lead to a variety > of unintended issues and is due to the lack of a serialization > mechanism to protect the adapter state. > > Use an

Re: [PATCH v2 04/30] cxlflash: Fix potential oops following LUN removal

On 16.9.2015 23:27, Matthew R. Ochs wrote: > When a LUN is removed, the sdev that is associated with the LUN > remains intact until its reference count drops to 0. In order > to prevent an sdev from being removed while a context is still > associated with it, obtain an additional reference

Re: [PATCH v2 09/30] cxlflash: Fix to stop interrupt processing on remove

On 19.9.2015 01:26, Matthew R. Ochs wrote: >> On Sep 18, 2015, at 6:59 AM, Tomas Henzl <the...@redhat.com> wrote: >> On 17.9.2015 19:16, Matthew R. Ochs wrote: >>>> On Sep 17, 2015, at 7:38 AM, Tomas Henzl <the...@redhat.com> wrote: >>>>

Re: [PATCH v2 09/30] cxlflash: Fix to stop interrupt processing on remove

On 17.9.2015 19:16, Matthew R. Ochs wrote: >> On Sep 17, 2015, at 7:38 AM, Tomas Henzl <the...@redhat.com> wrote: >> >> On 16.9.2015 18:53, Matthew R. Ochs wrote: >>> Interrupt processing can run in parallel to a remove operation. This >>> can lead

Re: [PATCH v2 09/30] cxlflash: Fix to stop interrupt processing on remove

On 16.9.2015 18:53, Matthew R. Ochs wrote: > Interrupt processing can run in parallel to a remove operation. This > can lead to a condition where the interrupt handler is processing with > memory that has been freed. > > To avoid processing an interrupt while memory may be yanked, check for >