Re: DTS file reference for FSL UPM NAND for MPC832x

2010-01-16 Thread Wolfgang Grandegger
nanda wrote: Hi, Iam looking for any references for the dts (device tree source) file which implements freescale's UPM based NAND driver connected to NAND flash. (it uses the individual gpio connected to R/B pin) The following links might be useful:

Re: [PATCH net-next v4 0/3] can: mscan-mpc5xxx: add support for the Freescale MPC512x

2010-01-08 Thread Wolfgang Grandegger
David Miller wrote: From: Wolfgang Grandegger w...@grandegger.com Date: Thu, 7 Jan 2010 20:43:05 +0100 This patch series adds support for the MPC512x from Freescale to the mpc5xxx_can MSCAN driver. It has been tested on a MPC5121 and MPC5200B board. So are these ready to go or should I

[PATCH net-next v3 0/3] can: mscan-mpc5xxx: add support for the Freescale MPC512x

2010-01-07 Thread Wolfgang Grandegger
() as before. - It has been documented that MPC512x Rev.1 CPUs are not supported. Wolfgang Wolfgang Grandegger (3): can: mscan: fix improper return if dlc 8 in start_xmit function can: mscan-mpc5xxx: add support for the MPC512x processor powerpc/mpc5xxx: add OF platform binding doc for FSL MSCAN

[PATCH net-next v3 3/3] powerpc/mpc5xxx: add OF platform binding doc for FSL MSCAN devices

2010-01-07 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch adds documentation for the MSCAN OF device bindings for the MPC512x and moves the one for the MPC5200 to the new common file Documentation/powerpc/dts-bindings/fsl/can.txt. Signed-off-by: Wolfgang Grandegger w...@denx.de Reviewed-by: Wolfram Sang

[PATCH net-next v3 1/3] can: mscan: fix improper return if dlc 8 in start_xmit function

2010-01-07 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de The start_xmit function of the MSCAN Driver did return improperly if the CAN dlc check failed (skb not freed and invalid return code). This patch adds a proper check of the frame lenght and data size and returns now correctly. Furthermore, a typo has been

[PATCH net-next v4 0/3] can: mscan-mpc5xxx: add support for the Freescale MPC512x

2010-01-07 Thread Wolfgang Grandegger
Wolfgang Grandegger (3): can: mscan: fix improper return if dlc 8 in start_xmit function can: mscan-mpc5xxx: add support for the MPC512x processor powerpc/mpc5xxx: add OF platform binding doc for FSL MSCAN devices Documentation/powerpc/dts-bindings/fsl/can.txt | 53 + Documentation

[PATCH net-next v4 3/3] powerpc/mpc5xxx: add OF platform binding doc for FSL MSCAN devices

2010-01-07 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch adds documentation for the MSCAN OF device bindings for the MPC512x and moves the one for the MPC5200 to the new common file Documentation/powerpc/dts-bindings/fsl/can.txt. Signed-off-by: Wolfgang Grandegger w...@denx.de Reviewed-by: Wolfram Sang

[PATCH net-next v4 1/3] can: mscan: fix improper return if dlc 8 in start_xmit function

2010-01-07 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de The start_xmit function of the MSCAN Driver did return improperly if the CAN dlc check failed (skb not freed and invalid return code). This patch adds a proper check of the frame lenght and data size and returns now correctly. The invalid skb packets

[PATCH net-next v4 2/3] can: mscan-mpc5xxx: add support for the MPC512x processor

2010-01-07 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de The main differences compared to the MSCAN on the MPC5200 are: - More flexibility in choosing the CAN source clock and frequency: Three different clock sources can be selected: ip, ref or sys. For the latter two, a clock divider can be defined as well

Re: [PATCH net-next v2 0/3] can: mscan-mpc5xxx: add support for the Freescale MPC512x

2010-01-06 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: This patch series adds support for the MPC512x from Freescale to the mpc5xxx_can MSCAN driver. Changes since v1: - Various coding style issues, printk formats, variable names and error messagaes and typos fixes or improved - MPC5xxx specific data are now

Re: [PATCH net-next v2 0/3] can: mscan-mpc5xxx: add support for the Freescale MPC512x

2010-01-06 Thread Wolfgang Grandegger
Wolfram Sang wrote: Wolfram, is it OK from your point of view now? I will roll out v3 after some more thorough testing tomorrow. It still works here and, as I see it, all issues were resolved as discussed. OK, fine if I add your acked-by then? Thanks, Wolfgang.

[PATCH net-next v2 3/3] powerpc/mpc5xxx: add OF platform binding doc for FSL MSCAN devices

2010-01-05 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch adds documentation for the MSCAN OF device bindings for the MPC512x and moves the one for the MPC5200 to the new common file Documentation/powerpc/dts-bindings/fsl/can.txt. Signed-off-by: Wolfgang Grandegger w...@denx.de Acked-by: Wolfram Sang

[PATCH net-next v2 2/3] can: mscan-mpc5xxx: add support for the MPC512x processor

2010-01-05 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de The main differences compared to the MSCAN on the MPC5200 are: - More flexibility in choosing the CAN source clock and frequency: Three different clock sources can be selected: ip, ref or sys. For the latter two, a clock divider can be defined as well

[PATCH net-next v2 1/3] can: mscan: fix improper return if dlc 8 in start_xmit function

2010-01-05 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de The start_xmit function of the MSCAN Driver did return improperly if the CAN dlc check failed (skb not freed and invalid return code). This patch adds a proper check of the frame lenght and data size and returns now correctly. Furthermore, a typo has been

[PATCH net-next v2 0/3] can: mscan-mpc5xxx: add support for the Freescale MPC512x

2010-01-05 Thread Wolfgang Grandegger
of_device_id- Wolfgang Grandegger (3): can: mscan: fix improper return if dlc 8 in start_xmit function can: mscan-mpc5xxx: add support for the MPC512x processor powerpc/mpc5xxx: add OF platform binding doc for FSL MSCAN devices Documentation/powerpc/dts-bindings/fsl/can.txt | 53

[PATCH net-next v2 1/3] can: mscan: fix improper return if dlc 8 in start_xmit function

2010-01-05 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de The start_xmit function of the MSCAN Driver did return improperly if the CAN dlc check failed (skb not freed and invalid return code). This patch adds a proper check of the frame lenght and data size and returns now correctly. Furthermore, a typo has been

[PATCH net-next v2 0/3] can: mscan-mpc5xxx: add support for the Freescale MPC512x

2010-01-05 Thread Wolfgang Grandegger
of_device_id-data. - The index of the MPC512x CAN controller is now derived directly from reg property. This allows use of_iomap() as usual. - It has been documented that MPC512x Rev.1 CPUs are not supported. Wolfgang Wolfgang Grandegger (3): can: mscan: fix improper return if dlc 8

[PATCH net-next v2 3/3] powerpc/mpc5xxx: add OF platform binding doc for FSL MSCAN devices

2010-01-05 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch adds documentation for the MSCAN OF device bindings for the MPC512x and moves the one for the MPC5200 to the new common file Documentation/powerpc/dts-bindings/fsl/can.txt. Signed-off-by: Wolfgang Grandegger w...@denx.de Acked-by: Wolfram Sang

[PATCH net-next v2 2/3] can: mscan-mpc5xxx: add support for the MPC512x processor

2010-01-05 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de The main differences compared to the MSCAN on the MPC5200 are: - More flexibility in choosing the CAN source clock and frequency: Three different clock sources can be selected: ip, ref or sys. For the latter two, a clock divider can be defined as well

Re: [PATCH net-next 2/3] can: mscan-mpc5xxx: add support for the MPC521x processor

2010-01-04 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: Wolfram Sang wrote: On Sat, Jan 02, 2010 at 09:17:53AM +0100, Wolfgang Grandegger wrote: From: Wolfgang Grandegger w...@denx.de The main differences compared to the MSCAN on the MPC5200 are: - More flexibility in choosing the CAN source clock and frequency

Re: [PATCH net-next 2/3] can: mscan-mpc5xxx: add support for the MPC521x processor

2010-01-04 Thread Wolfgang Grandegger
Hi Wolfram, Wolfram Sang wrote: Hello Wolfgang, first the good news: Your patches also work with our MPC5121-board. Nice. Just for curiosity, what clock and frequency does it select on your board? It should be listed when the driver is loaded. +#else /* !CONFIG_PPC_MPC5200 */ +static u32

Re: [PATCH net-next 2/3] can: mscan-mpc5xxx: add support for the MPC521x processor

2010-01-04 Thread Wolfgang Grandegger
Wolfram Sang wrote: Nice. Just for curiosity, what clock and frequency does it select on your board? It should be listed when the driver is loaded. Using this simple dts-snipplet ms...@1300 { compatible = fsl,mpc5121-mscan;

[PATCH net-next 3/3] powerpc/mpc5xxx: add OF platform binding doc for FSL MSCAN devices

2010-01-02 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de This patch adds documentation for the MSCAN OF device bindings for the MPC512x and moves the one for the MPC5200 to the new common file Documentation/powerpc/dts-bindings/fsl/can.txt. Signed-off-by: Wolfgang Grandegger w...@denx.de --- Documentation

[PATCH net-next 1/3] can: mscan: fix improper return if dlc 8 in start_xmit function

2010-01-02 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de The start_xmit function of the MSCAN Driver did return improperly if the CAN dlc check failed (skb not freed and invalid return code). This patch adds a proper check of the frame lenght and data size and returns now correctly. Furthermore, a typo has been

[PATCH net-next 2/3] can: mscan-mpc5xxx: add support for the MPC521x processor

2010-01-02 Thread Wolfgang Grandegger
From: Wolfgang Grandegger w...@denx.de The main differences compared to the MSCAN on the MPC5200 are: - More flexibility in choosing the CAN source clock and frequency: Three different clock sources can be selected: ip, ref or sys. For the latter two, a clock divider can be defined as well

[PATCH net-next 0/3] can: mscan-mpc5xxx: add support for the Freescale MPC512x

2010-01-02 Thread Wolfgang Grandegger
This patch series adds support for the MPC512x from Freescale to the mpc5xxx_can MSCAN driver. Wolfgang Wolfgang Grandegger (3): can: mscan: fix improper return if dlc 8 in start_xmit function can: mscan-mpc5xxx: add support for the MPC521x processor powerpc/mpc5xxx: add OF platform

Re: [PATCH net-next 1/3] can: mscan: fix improper return if dlc 8 in start_xmit function

2010-01-02 Thread Wolfgang Grandegger
Wolfram Sang wrote: On Sat, Jan 02, 2010 at 09:17:52AM +0100, Wolfgang Grandegger wrote: From: Wolfgang Grandegger w...@denx.de The start_xmit function of the MSCAN Driver did return improperly if the CAN dlc check failed (skb not freed and invalid return code). This patch adds a proper

Re: [PATCH net-next 2/3] can: mscan-mpc5xxx: add support for the MPC521x processor

2010-01-02 Thread Wolfgang Grandegger
Wolfram Sang wrote: On Sat, Jan 02, 2010 at 09:17:53AM +0100, Wolfgang Grandegger wrote: From: Wolfgang Grandegger w...@denx.de The main differences compared to the MSCAN on the MPC5200 are: - More flexibility in choosing the CAN source clock and frequency: Three different clock sources

Re: I2C bus clock on MPC85XX systems

2009-12-22 Thread Wolfgang Grandegger
Felix Radensky wrote: Hi, Almost all MPC85XX based systems have the compatible=:fsl-i2c in respective i2c device tree nodes. This causes FSL i2c driver to use the following backward compatible values: FSR=0x31 DFSR=0x10. This is regardless of CCB clock frequency and i2c clock prescaler.

Re: I2C bus clock on MPC85XX systems

2009-12-22 Thread Wolfgang Grandegger
Felix Radensky wrote: Hi, Wolfgang Wolfgang Grandegger wrote: Felix Radensky wrote: Hi, Almost all MPC85XX based systems have the compatible=:fsl-i2c in respective i2c device tree nodes. This causes FSL i2c driver to use the following backward compatible values: FSR=0x31 DFSR=0x10

Re: I2C bus clock on MPC85XX systems

2009-12-22 Thread Wolfgang Grandegger
Hi Felix, Felix Radensky wrote: Hi, Wolfgang Wolfgang Grandegger wrote: [snip] The trees provided by Freescale are usually based on older kernel version. Borrow from such trees is OK, but the project developers should use a recent kernel version for development. I was talking about

Re: MPC5200B XLB Configuration Issues, FEC RFIFO Events, ATA Crashes

2009-12-18 Thread Wolfgang Grandegger
Roman Fietze wrote: Hello Wolfram, On Wednesday 09 December 2009 15:57:48 Wolfram Sang wrote: Do you have a way to measure performance penalties? As I said, I do. And here they are. They won't win a price for the most impartial benchmarks ever seen, but thet'll be a good starting

Re: updates to the mscan-driver in net-next

2009-11-17 Thread Wolfgang Grandegger
David Miller wrote: From: Wolfram Sang w.s...@pengutronix.de Date: Mon, 16 Nov 2009 23:57:43 +0100 here are the patches which fix the issues for the mscan mpc52xx_can drivers raised by Wolfgang Grandegger and Grant Likely. They are based on the initial version of the drivers I sent a few

Re: [PATCH] net/can: add driver for mscan family mpc52xx_mscan

2009-11-17 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: Wolfram Sang wrote: Hi Grant, Wolfgang commented on some points already, I will pick up the other remarks, just one question: + clk_src = of_get_property(np, fsl,mscan-clk-src, NULL); + if (clk_src strcmp(clk_src, ip) == 0) Should protect against

Re: [PATCH] net/can: add driver for mscan family mpc52xx_mscan

2009-11-17 Thread Wolfgang Grandegger
Wolfram Sang wrote: Hi Grant, Wolfgang commented on some points already, I will pick up the other remarks, just one question: + clk_src = of_get_property(np, fsl,mscan-clk-src, NULL); + if (clk_src strcmp(clk_src, ip) == 0) Should protect against non-null. strncmp() maybe?

Re: [PATCH] net/can: add driver for mscan family mpc52xx_mscan

2009-11-16 Thread Wolfgang Grandegger
Grant Likely wrote: On Fri, Nov 13, 2009 at 9:14 AM, Wolfram Sang w.s...@pengutronix.de wrote: Taken from socketcan-svn, fixed remaining todos, cleaned up, tested with a phyCORE-MPC5200B-IO and a custom board. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Wolfgang Grandegger w

Re: [PATCH] net/can: add driver for mscan family mpc52xx_mscan

2009-11-16 Thread Wolfgang Grandegger
...@pengutronix.de Cc: Wolfgang Grandegger w...@grandegger.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: David Miller da...@davemloft.net --- This patch is based on net-next as of yesterday. To make the review easier for those who are already familiar with earlier versions of this driver

Re: [PATCH] net/can: add driver for mscan family mpc52xx_mscan

2009-11-16 Thread Wolfgang Grandegger
Hi Wolfram, Wolfram Sang wrote: Hi Wolfgang, On Mon, Nov 16, 2009 at 09:44:05AM +0100, Wolfgang Grandegger wrote: Hi Wolfram, thanks for pushing this driver to mainline. I think you should also add a CC to the Devicetree-discuss ML. thank you very much for your review! I agree

Re: [PATCH] net/can: add driver for mscan family mpc52xx_mscan

2009-11-15 Thread Wolfgang Grandegger
David Miller wrote: From: Wolfram Sang w.s...@pengutronix.de Date: Fri, 13 Nov 2009 17:14:52 +0100 Taken from socketcan-svn, fixed remaining todos, cleaned up, tested with a phyCORE-MPC5200B-IO and a custom board. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Applied. Unfortunately

Re: [PATCH v2] net/fec_mpc52xx: Fix kernel panic on FEC error

2009-10-14 Thread Wolfgang Grandegger
Grant Likely wrote: From: John Bonesio bo...@secretlab.ca The MDIO bus cannot be accessed at interrupt context, but on an FEC error, the fec_mpc52xx driver reset function also tries to reset the PHY. Since the error is detected at IRQ context, and the PHY functions try to sleep, the kernel

Re: [PATCH] i2c-mpc: Do not generate STOP after read.

2009-09-25 Thread Wolfgang Grandegger
the whole transaction ends. Signed-off-by: Joakim Tjernlund joakim.tjernl...@transmode.se Tested-by: Wolfgang Grandegger w...@grandegger.com on a MPC8548 board with an up-to-date kernel. I did not realize any problems. Wolfgang. ___ Linuxppc-dev mailing

Re: [PATCH] mpc5200: support for the MAN mpc5200 based board uc101

2009-09-14 Thread Wolfgang Grandegger
Hello Heiko, Heiko Schocher wrote: Hello Grant, Grant Likely wrote: Thanks for the patch. Comments below. g. On Mon, Sep 14, 2009 at 2:05 AM, Heiko Schocher h...@denx.de wrote: - serial Console on PSC1 - 64MB SDRAM - MTD CFI Flash - Ethernet FEC - I2C with PCF8563 and Temp. Sensor

Re: AW: LITE5200 configuration

2009-08-27 Thread Wolfgang Grandegger
*two* slots. IIRC, there are also early Lite5200B boards using MPC5200 v1.2 chips. Wolfgang (Grandegger) ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

OF modalias

2009-08-19 Thread Wolfgang Grandegger
Hello, I'm confused by the modalias'es created by OF devices, e.g.: # cat /sys/devices/f000.soc5200/ff00.spi/modalias of:NspiTNULLCfsl,mpc5200b-spiCfsl,mpc5200-spi First of all, the string NULL looks like an error. I could then dynamically load a driver module for the SPI using:

Re: Bestcomm trouble with NAPI for MPC5200 FEC

2009-07-10 Thread Wolfgang Grandegger
Grant Likely wrote: On Thu, Jul 9, 2009 at 2:33 PM, Wolfgang Grandeggerw...@grandegger.com wrote: Hello, I'm currently trying to implement NAPI for the FEC on the MPC5200 to solve the well known problem, that network packet storms can cause interrupt flooding, which may totally block the

Re: Bestcomm trouble with NAPI for MPC5200 FEC

2009-07-10 Thread Wolfgang Grandegger
Wolfram Sang wrote: Hello Wolfgang, I'm currently trying to implement NAPI for the FEC on the MPC5200 to solve the well known problem, that network packet storms can cause interrupt flooding, which may totally block the system. The NAPI Just bombard the FEC with network packets. I use

Re: Bestcomm trouble with NAPI for MPC5200 FEC

2009-07-10 Thread Wolfgang Grandegger
Grant Likely wrote: On Thu, Jul 9, 2009 at 2:33 PM, Wolfgang Grandeggerw...@grandegger.com wrote: Hello, I'm currently trying to implement NAPI for the FEC on the MPC5200 to solve the well known problem, that network packet storms can cause interrupt flooding, which may totally block the

Bestcomm trouble with NAPI for MPC5200 FEC

2009-07-09 Thread Wolfgang Grandegger
Hello, I'm currently trying to implement NAPI for the FEC on the MPC5200 to solve the well known problem, that network packet storms can cause interrupt flooding, which may totally block the system. The NAPI implementation, in principle, is straight forward and works well under normal and

Re: [PATCH 2/2] uio: add an of_genirq driver

2009-06-14 Thread Wolfgang Grandegger
Hans J. Koch wrote: On Sun, Jun 14, 2009 at 09:05:33PM +0200, Wolfram Sang wrote: Anyway, 0 is a valid IRQ number, so it cannot be used as no irq. May I point you to this thread? http://lkml.org/lkml/2005/11/21/221 Linus is just plain wrong in this 4 year old mail. See also this related

Re: [PATCH 05/04] *** NOT FOR RELEASE *** HACK *** Work around MII clock issue ***

2009-06-08 Thread Wolfgang Grandegger
Wolfgang Denk wrote: Dear John, in message 4b73d43f0906061708o763409d0u10a344dfc30e3...@mail.gmail.com you wrote: The big question seems to be what the RefMan means when talking about the system clock frequency. Obiously it is NOT the CPU clock as ... But which one is it? My best

Re: [net-next-2.6 PATCH v2] can: SJA1000: generic OF platform bus driver

2009-05-26 Thread Wolfgang Grandegger
David Miller wrote: From: Arnd Bergmann a...@arndb.de Date: Tue, 26 May 2009 10:10:30 +0100 On Monday 25 May 2009, Wolfgang Grandegger wrote: Right, that makes sense. However, most drivers use the field to store the physical address, not the iomap token. Maybe there should be a new field

Re: [net-next-2.6 PATCH v2] can: SJA1000: generic OF platform bus driver

2009-05-25 Thread Wolfgang Grandegger
Arnd Bergmann wrote: On Saturday 23 May 2009, Wolfgang Grandegger wrote: Arnd Bergmann wrote: Minor nitpicking: dev-base_addr should be defined as an __iomem pointer so you can avoid the cast here and in the ioremap/iounmap path. Here the member base_addr of struct net_device is used and it's

Re: [net-next-2.6 PATCH v2] can: SJA1000: generic OF platform bus driver

2009-05-25 Thread Wolfgang Grandegger
Grant Likely wrote: On Sat, May 23, 2009 at 10:44 AM, Wolfgang Grandegger w...@grandegger.com wrote: Wolfgang Grandegger wrote: Grant Likely wrote: +- clock-frequency : CAN system clock frequency in Hz, which is normally + half of the oscillator clock frequency. If not specified

Re: [net-next-2.6 PATCH v2] can: SJA1000: generic OF platform bus driver

2009-05-23 Thread Wolfgang Grandegger
Hi Grant, Grant Likely wrote: Hi Wolfgang, thanks for the quick response. Comments below... On Fri, May 22, 2009 at 8:46 AM, Wolfgang Grandegger w...@grandegger.com wrote: +++ net-next-2.6/Documentation/powerpc/dts-bindings/can/sja1000.txt @@ -0,0 +1,37 @@ +Memory mapped SJA1000 CAN

Re: [net-next-2.6 PATCH v2] can: SJA1000: generic OF platform bus driver

2009-05-23 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: Hi Grant, Grant Likely wrote: Hi Wolfgang, thanks for the quick response. Comments below... On Fri, May 22, 2009 at 8:46 AM, Wolfgang Grandegger w...@grandegger.com wrote: +++ net-next-2.6/Documentation/powerpc/dts-bindings/can/sja1000.txt @@ -0,0 +1,37

Re: [net-next-2.6 PATCH v2] can: SJA1000: generic OF platform bus driver

2009-05-23 Thread Wolfgang Grandegger
Arnd Bergmann wrote: On Friday 22 May 2009, Wolfgang Grandegger wrote: This patch adds a generic driver for SJA1000 chips on the OpenFirmware platform bus found on embedded PowerPC systems. Nice driver! +static u8 sja1000_ofp_read_reg(const struct net_device *dev, int reg

[net-next-2.6 PATCH v2] can: SJA1000: generic OF platform bus driver

2009-05-22 Thread Wolfgang Grandegger
; clock-frequency = 800; cdr-reg = 0x48; ocr-reg = 0x0a; interrupts = 2 0; interrupt-parent = mpic; }; See also Documentation/powerpc/dts-bindings/can/sja1000.txt. Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- Documentation

Re: [net-next-2.6 PATCH] can: SJA1000: generic OF platform bus driver

2009-05-22 Thread Wolfgang Grandegger
David Miller wrote: From: Grant Likely grant.lik...@secretlab.ca Date: Thu, 21 May 2009 22:42:07 -0600 On Wed, May 20, 2009 at 11:06 AM, Wolfgang Grandegger w...@grandegger.com wrote: This patch adds a generic driver for SJA1000 chips on the OpenFirmware platform bus found on embedded

[net-next-2.6 PATCH] can: SJA1000: generic OF platform bus driver

2009-05-20 Thread Wolfgang Grandegger
0x80; clock-frequency = 800; cdr-reg = 0x48; ocr-reg = 0x0a; interrupts = 2 0; interrupt-parent = mpic; }; Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- drivers/net/can/Kconfig |9 + drivers/net/can

Re: [PATCH 08/12] mpc5121: Added I2C support.

2009-05-19 Thread Wolfgang Grandegger
Piotr Zięcik wrote: Monday 18 May 2009 16:29:04 Wolfgang Grandegger napisał(a): I have simple question about bus speed setting support. Existing implementation uses default safe speed if there is no 'clock-frequency' property in i2c node. Comments in code suggest that this behaviour is left

Re: [PATCH 08/12] mpc5121: Added I2C support.

2009-05-07 Thread Wolfgang Grandegger
Grant Likely wrote: On Wed, May 6, 2009 at 4:51 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Wed, May 6, 2009 at 4:19 PM, Wolfgang Denk w...@denx.de wrote: Dear Grant Likely, In message fa686aa40905061401k319313c5q89fd3e245c308...@mail.gmail.com you wrote: On Wed, May 6, 2009 at

Re: [PATCH 09/12] mpc5121ads: Added I2C RTC node to mpc5121ads DTS.

2009-05-07 Thread Wolfgang Grandegger
Wolfgang Denk wrote: From: Piotr Ziecik ko...@semihalf.com Signed-off-by: Piotr Ziecik ko...@semihalf.com Signed-off-by: Wolfgang Denk w...@denx.de Cc: Grant Likely grant.lik...@secretlab.ca Cc: John Rigby jcri...@gmail.com --- arch/powerpc/boot/dts/mpc5121ads.dts |5 + 1 files

Re: FPGA IRQ design question

2009-04-22 Thread Wolfgang Grandegger
Eddie Dawydiuk wrote: Grant, However, if you're writing one-off custom drivers and there is no common coded needed for acking irqs, then I would probably just use the external IRQ. Thanks for the suggestions I think going to just use the external IRQ. As a result I've been reading

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-20 Thread Wolfgang Grandegger
Hi Ben, Wolfgang Grandegger wrote: Wolfgang Grandegger wrote: Kumar Gala wrote: On Apr 8, 2009, at 2:25 AM, Wolfgang Grandegger wrote: So I'm a bit concerned with the output we now get: mpc-i2c fffe03000.i2c: clock 0 Hz (dfsrr=16 fdr=49) why 0? is that right? This is the backward

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-09 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: Kumar Gala wrote: On Apr 8, 2009, at 2:25 AM, Wolfgang Grandegger wrote: So I'm a bit concerned with the output we now get: mpc-i2c fffe03000.i2c: clock 0 Hz (dfsrr=16 fdr=49) why 0? is that right? This is the backward compatibility mode using hard-coded FDR

Re: [PATCH v3 5/5] powerpc/85xx: i2c-mpc: use new I2C bindings for the Socates board

2009-04-08 Thread Wolfgang Grandegger
Grant Likely wrote: On Tue, Apr 7, 2009 at 1:20 AM, Wolfgang Grandegger w...@grandegger.com wrote: Preserve I2C clock settings for the Socrates MPC8544 board. I had thought that the preserve-clocking property was intended for older boards that don't currently have any method of getting

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-08 Thread Wolfgang Grandegger
Kumar Gala wrote: On Apr 8, 2009, at 12:11 AM, Kumar Gala wrote: On Apr 7, 2009, at 3:20 AM, Wolfgang Grandegger wrote: This patch series makes the I2C bus speed configurable by using the I2C node property clock-frequency. If the property is not defined, the old fixed clock settings

Re: [PATCH v3 5/5] powerpc/85xx: i2c-mpc: use new I2C bindings for the Socates board

2009-04-08 Thread Wolfgang Grandegger
Grant Likely wrote: On Wed, Apr 8, 2009 at 12:16 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: On Tue, Apr 7, 2009 at 1:20 AM, Wolfgang Grandegger w...@grandegger.com wrote: Preserve I2C clock settings for the Socrates MPC8544 board. I had thought

Re: [PATCH v3 5/5] powerpc/85xx: i2c-mpc: use new I2C bindings for the Socates board

2009-04-08 Thread Wolfgang Grandegger
Kumar Gala wrote: On Apr 8, 2009, at 1:27 PM, Wolfgang Grandegger wrote: Grant Likely wrote: On Wed, Apr 8, 2009 at 12:16 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: On Tue, Apr 7, 2009 at 1:20 AM, Wolfgang Grandegger w...@grandegger.com wrote: Preserve I2C

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-08 Thread Wolfgang Grandegger
Kumar Gala wrote: On Apr 8, 2009, at 2:25 AM, Wolfgang Grandegger wrote: So I'm a bit concerned with the output we now get: mpc-i2c fffe03000.i2c: clock 0 Hz (dfsrr=16 fdr=49) why 0? is that right? This is the backward compatibility mode using hard-coded FDR values. The output

[PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-07 Thread Wolfgang Grandegger
This patch series makes the I2C bus speed configurable by using the I2C node property clock-frequency. If the property is not defined, the old fixed clock settings will be used for backward compatibility. The property fsl,preserve-clocking allows to inherit the settings from the bootloader.

[PATCH v3 4/5] powerpc: i2c-mpc: document new FSL I2C bindings and cleanup

2009-04-07 Thread Wolfgang Grandegger
This patch documents the new bindings for the MPC I2C bus driver. Furthermore, it removes obsolete FSL device related definitions for I2C. It should go through the appropriate PowerPC maintainer(s) hands. Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- Documentation/powerpc/dts

[PATCH v3 1/5] i2c: i2c-mpc: various coding style fixes

2009-04-07 Thread Wolfgang Grandegger
Fix errors reported by checkpatch (indention, long lines, trailing white space, etc.). Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- drivers/i2c/busses/i2c-mpc.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) Index: linux-2.6-galak

[PATCH v3 2/5] i2c: i2c-mpc: use dev based printout function

2009-04-07 Thread Wolfgang Grandegger
This patch used the dev_dbg, dev_err, etc. functions for debug and error output instead of printk and pr_debug. Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- drivers/i2c/busses/i2c-mpc.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) Index

[PATCH v3 3/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-07 Thread Wolfgang Grandegger
-flags field and the corresponding FSL_I2C_DEV_* definitions have been removed as they are obsolete. Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- drivers/i2c/busses/i2c-mpc.c | 262 +++ 1 file changed, 242 insertions(+), 20 deletions(-) Index

[PATCH v3 5/5] powerpc/85xx: i2c-mpc: use new I2C bindings for the Socates board

2009-04-07 Thread Wolfgang Grandegger
Preserve I2C clock settings for the Socrates MPC8544 board. Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- arch/powerpc/boot/dts/socrates.dts |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: linux-2.6-galak/arch/powerpc/boot/dts/socrates.dts

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-04-02 Thread Wolfgang Grandegger
Hi Kumar, Kumar Gala wrote: On Apr 1, 2009, at 8:10 AM, Wolfgang Grandegger wrote: Grant Likely wrote: On Wed, Apr 1, 2009 at 1:36 AM, Wolfgang Grandegger w...@grandegger.com wrote: Anton Vorontsov wrote: On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote: [...] + soc8

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-02 Thread Wolfgang Grandegger
Grant Likely wrote: On Wed, Apr 1, 2009 at 7:41 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: On Wed, Apr 1, 2009 at 1:51 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: The table definition is more verbose this way, but I think it results

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-04-02 Thread Wolfgang Grandegger
Kumar Gala wrote: On Apr 2, 2009, at 1:38 AM, Wolfgang Grandegger wrote: Socrates is a new board and it has no problem using an up-to-date version of U-Boot. The socrates.dts file in your next tree already has the device_type = soc removed. We need to add fsl,soc to the compatible

Re: [PATCH 6/8] --- arch/powerpc/boot/dts/socrates.dts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)

2009-04-01 Thread Wolfgang Grandegger
Hi David, this patch went out by mistake, sorry. David Gibson wrote: On Tue, Mar 31, 2009 at 02:37:33PM +0200, Wolfgang Grandegger wrote: Index: linux-2.6/arch/powerpc/boot/dts/socrates.dts === --- linux-2.6.orig/arch/powerpc

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-04-01 Thread Wolfgang Grandegger
Anton Vorontsov wrote: On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote: [...] + soc8...@e000 { + #address-cells = 1; + #size-cells = 1; + device_type = soc; Drop device_type here too. Grrr, I just realized that removing the

Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-04-01 Thread Wolfgang Grandegger
David Gibson wrote: On Tue, Mar 31, 2009 at 02:43:39PM +0200, Wolfgang Grandegger wrote: The I2c node property fsl,preserve-clocking allows to overtake the clock settings from the boot loader and avoids the hard-coded setting. Hrm. This is dubious. The device tree should generally describe

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Wolfgang Grandegger
Grant Likely wrote: On Tue, Mar 31, 2009 at 6:37 AM, Wolfgang Grandegger w...@grandegger.com wrote: This patch makes the I2C bus speed configurable by using the I2C node property clock-frequency. If the property is not defined, the old fixed clock settings will be used for backward

Re: [PATCH 6/8] --- arch/powerpc/boot/dts/socrates.dts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)

2009-04-01 Thread Wolfgang Grandegger
David Gibson wrote: On Wed, Apr 01, 2009 at 09:31:34AM +0200, Wolfgang Grandegger wrote: Hi David, this patch went out by mistake, sorry. David Gibson wrote: On Tue, Mar 31, 2009 at 02:37:33PM +0200, Wolfgang Grandegger wrote: Index: linux-2.6/arch/powerpc/boot/dts/socrates.dts

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-04-01 Thread Wolfgang Grandegger
Grant Likely wrote: On Wed, Apr 1, 2009 at 1:36 AM, Wolfgang Grandegger w...@grandegger.com wrote: Anton Vorontsov wrote: On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote: [...] + soc8...@e000 { + #address-cells = 1; + #size-cells = 1

[PATCH v2] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Wolfgang Grandegger
-flags field and the corresponding FSL_I2C_DEV_* definitions have been removed as they are obsolete. Furthermore dev_dbg() and dev_info() are now used to profit from a more comprehensive output. Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- Documentation/powerpc/dts-bindings/fsl

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Wolfgang Grandegger
Grant Likely wrote: On Wed, Apr 1, 2009 at 1:51 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: The table definition is more verbose this way, but I think it results in more understandable and easier to extend code. It also adds lets the compiler do more type

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: Grant Likely wrote: On Wed, Apr 1, 2009 at 1:51 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: The table definition is more verbose this way, but I think it results in more understandable and easier to extend code. It also adds lets

Re: [PATCH v2] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Wolfgang Grandegger
Grant Likely wrote: On Wed, Apr 1, 2009 at 7:44 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Wed, Apr 1, 2009 at 7:13 AM, Wolfgang Grandegger w...@grandegger.com wrote: This patch makes the I2C bus speed configurable by using the I2C node property clock-frequency. If the property

Inconsistent fsl_get_sys_freq() implementation

2009-03-31 Thread Wolfgang Grandegger
Hello, we realized an inconsistent implementation of fsl_get_sys_freq(): http://lxr.linux.no/linux+v2.6.29/arch/powerpc/sysdev/fsl_soc.c#L80 For 826x and 827x boards, the function is available but it cannot be used because the bus-frequency property is not defined for the SOC and U-Boot also

Re: Inconsistent fsl_get_sys_freq() implementation

2009-03-31 Thread Wolfgang Grandegger
Grant Likely wrote: On Tue, Mar 31, 2009 at 1:28 AM, Wolfgang Grandegger w...@grandegger.com wrote: Hello, we realized an inconsistent implementation of fsl_get_sys_freq(): http://lxr.linux.no/linux+v2.6.29/arch/powerpc/sysdev/fsl_soc.c#L80 For 826x and 827x boards, the function

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-31 Thread Wolfgang Grandegger
Grant Likely wrote: I agree 100% with David's comments, and I have some additional ones below. On Thu, Mar 19, 2009 at 9:26 AM, Wolfgang Grandegger w...@grandegger.com wrote: + soc8...@e000 { + #address-cells = 1; + #size-cells = 1

[PATCH 4/8] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfgang Grandegger
The I2c node property fsl,preserve-clocking allows to overtake the clock settings from the boot loader and avoids the hard-coded setting. Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- drivers/i2c/busses/i2c-mpc.c | 24 1 file changed, 16 insertions(+), 8

[PATCH 6/8] --- arch/powerpc/boot/dts/socrates.dts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)

2009-03-31 Thread Wolfgang Grandegger
Index: linux-2.6/arch/powerpc/boot/dts/socrates.dts === --- linux-2.6.orig/arch/powerpc/boot/dts/socrates.dts 2009-03-31 13:24:38.078719288 +0200 +++ linux-2.6/arch/powerpc/boot/dts/socrates.dts2009-03-31

[PATCH 0/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-03-31 Thread Wolfgang Grandegger
Following (most of) Grant's suggestions to my RFC: http://ozlabs.org/pipermail/linuxppc-dev/2009-March/069820.html this new patch series now uses: - the I2c node property fsl,preserve-clocking to overtake the clock settings from the boot loader. The first patch provides this feature and can

[PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-03-31 Thread Wolfgang Grandegger
Divider Register (fdr). Furthermore dev_dbg() and dev_info() are now used to profit from a more comprehensive output. Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- arch/powerpc/platforms/52xx/mpc52xx_common.c | 48 arch/powerpc/sysdev/fsl_soc.c| 90

[PATCH 2/8] [PATCH 01/28] RTC: Add support for RX8025 chip.

2009-03-31 Thread Wolfgang Grandegger
-by: Wolfgang Grandegger w...@grandegger.com Signed-off-by: Sergei Poselenov sposele...@emcraft.com Signed-off-by: Yuri Tikhonov y...@emcraft.com Signed-off-by: Dmitry Rakhchev r...@emcraft.com Signed-off-by: Matthias Fuchs matthias.fu...@esd.eu --- drivers/rtc/Kconfig |9 drivers/rtc/Makefile

[PATCH 7/8] Re: [PATCH 1/2] NAND: Add support for oob size 128

2009-03-31 Thread Wolfgang Grandegger
* Wolfgang Grandegger | 2009-03-25 11:48:37 [+0100]: Signed-off-by: Ilya Yanok ya...@emcraft.com Acked-by: Wolfgang Grandegger w...@grandegger.com You seem to forgot a few bits (subpage_sft max page size). I had this patch in my tree like for ever and forgot post it here. I did however merge

[PATCH 8/8] NAND: Add support for NAND on the Socrates board

2009-03-31 Thread Wolfgang Grandegger
Signed-off-by: Ilya Yanok ya...@emcraft.com Acked-by: Wolfgang Grandegger w...@grandegger.com --- drivers/mtd/nand/Kconfig |6 drivers/mtd/nand/Makefile|1 drivers/mtd/nand/socrates_nand.c | 324 +++ 3 files changed, 331 insertions

[PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfgang Grandegger
The I2c node property fsl,preserve-clocking allows to overtake the clock settings from the boot loader and avoids the hard-coded setting. Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- drivers/i2c/busses/i2c-mpc.c | 24 1 file changed, 16 insertions(+), 8

<    1   2   3   4   >