Re: [PATCH 02/13] powerpc/5200: LocalPlus driver: use SCLPC register structure

2010-01-12 Thread Grant Likely
On Tue, Jan 12, 2010 at 12:06 AM, Roman Fietze wrote: > Hello Grant, > > On Monday 11 January 2010 20:15:58 Grant Likely wrote: > >> No patch description?  Very few patches are sufficiently described by >> the subject line alone.  Tell me what the problem is, what the patch >> changes, and why. >

Re: [PATCH 02/13] powerpc/5200: LocalPlus driver: use SCLPC register structure

2010-01-11 Thread Roman Fietze
Hello Grant, On Monday 11 January 2010 20:15:58 Grant Likely wrote: > No patch description? Very few patches are sufficiently described by > the subject line alone. Tell me what the problem is, what the patch > changes, and why. And a lot of other information. Thank you very much for the effor

Re: [PATCH 02/13] powerpc/5200: LocalPlus driver: use SCLPC register structure

2010-01-11 Thread Grant Likely
On Mon, Jan 11, 2010 at 1:43 PM, Wolfgang Denk wrote: > Dear Grant, > > In message you > wrote: >> >> Please don't.  I know that a lot of other 5200 code uses register map >> structures in this way, but I consider it bad practice.  I coded this > > May I ask _why_ you consider this bad practice?

Re: [PATCH 02/13] powerpc/5200: LocalPlus driver: use SCLPC register structure

2010-01-11 Thread Wolfgang Denk
Dear Grant, In message you wrote: > > Please don't. I know that a lot of other 5200 code uses register map > structures in this way, but I consider it bad practice. I coded this May I ask _why_ you consider this bad practice? Is a structure not the most natural way to encode the specifics o

Re: [PATCH 02/13] powerpc/5200: LocalPlus driver: use SCLPC register structure

2010-01-11 Thread Grant Likely
On Mon, Jan 11, 2010 at 12:42 PM, Scott Wood wrote: > Grant Likely wrote: >> >> Please don't.  I know that a lot of other 5200 code uses register map >> structures in this way, but I consider it bad practice.  I coded this >> driver without a structure for a reason.  The reason I haven't removed >

Re: [PATCH 02/13] powerpc/5200: LocalPlus driver: use SCLPC register structure

2010-01-11 Thread Scott Wood
Grant Likely wrote: Please don't. I know that a lot of other 5200 code uses register map structures in this way, but I consider it bad practice. I coded this driver without a structure for a reason. The reason I haven't removed the other 5200 register map structures is the code impact would be

Re: [PATCH 02/13] powerpc/5200: LocalPlus driver: use SCLPC register structure

2010-01-11 Thread Grant Likely
On Mon, Dec 21, 2009 at 11:59 PM, Roman Fietze wrote: No patch description? Very few patches are sufficiently described by the subject line alone. Tell me what the problem is, what the patch changes, and why. > Signed-off-by: Roman Fietze > --- >  arch/powerpc/include/asm/mpc52xx.h          

[PATCH 02/13] powerpc/5200: LocalPlus driver: use SCLPC register structure

2009-12-21 Thread Roman Fietze
Signed-off-by: Roman Fietze --- arch/powerpc/include/asm/mpc52xx.h| 24 arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c | 79 +++-- 2 files changed, 59 insertions(+), 44 deletions(-) diff --git a/arch/powerpc/include/asm/mpc52xx.h b/arch/powerpc/inclu