Re: [PATCH 1/3] powerpc/32: Fix hugepage allocation on 8xx at hint address

2018-01-17 Thread Christophe LEROY
Le 17/01/2018 à 06:23, Aneesh Kumar K.V a écrit : Christophe LEROY writes: How should I split in separate patches ? Something like ? 1/ Slice support for PPC32 > 2/ Activate slice for 8xx Yes something like that. Will you  be able to avoid that  if (SLICE_NUM_HIGH) from the code? That

Re: [PATCH 1/3] powerpc/32: Fix hugepage allocation on 8xx at hint address

2018-01-16 Thread Aneesh Kumar K.V
Christophe LEROY writes: >> >>> How should I split in separate patches ? Something like ? >>> 1/ Slice support for PPC32 > 2/ Activate slice for 8xx >> >> Yes something like that. Will you  be able to avoid that >>  if (SLICE_NUM_HIGH) from the code? That makes the code ugly. Right now >> i do

Re: [PATCH 1/3] powerpc/32: Fix hugepage allocation on 8xx at hint address

2018-01-16 Thread Christophe LEROY
Le 16/01/2018 à 17:41, Aneesh Kumar K.V a écrit : On 01/16/2018 10:01 PM, Christophe LEROY wrote: diff --git a/arch/powerpc/include/asm/page_64.h b/arch/powerpc/include/asm/page_64.h index 56234c6fcd61..a7baef5bbe5f 100644 --- a/arch/powerpc/include/asm/page_64.h +++ b/arch/powerpc/includ

Re: [PATCH 1/3] powerpc/32: Fix hugepage allocation on 8xx at hint address

2018-01-16 Thread Christophe LEROY
Le 16/01/2018 à 17:43, Aneesh Kumar K.V a écrit : On 01/16/2018 10:01 PM, Christophe LEROY wrote: Le 16/01/2018 à 16:49, Aneesh Kumar K.V a écrit : Christophe Leroy writes: When an app has some regular pages allocated (e.g. see below) and tries to mmap() a huge page at a hint address c

Re: [PATCH 1/3] powerpc/32: Fix hugepage allocation on 8xx at hint address

2018-01-16 Thread Aneesh Kumar K.V
On 01/16/2018 10:01 PM, Christophe LEROY wrote: Le 16/01/2018 à 16:49, Aneesh Kumar K.V a écrit : Christophe Leroy writes: When an app has some regular pages allocated (e.g. see below) and tries to mmap() a huge page at a hint address covered by the same PMD entry, the kernel accepts the

Re: [PATCH 1/3] powerpc/32: Fix hugepage allocation on 8xx at hint address

2018-01-16 Thread Aneesh Kumar K.V
On 01/16/2018 10:01 PM, Christophe LEROY wrote: diff --git a/arch/powerpc/include/asm/page_64.h b/arch/powerpc/include/asm/page_64.h index 56234c6fcd61..a7baef5bbe5f 100644 --- a/arch/powerpc/include/asm/page_64.h +++ b/arch/powerpc/include/asm/page_64.h @@ -91,30 +91,13 @@ extern u64 ppc64_

Re: [PATCH 1/3] powerpc/32: Fix hugepage allocation on 8xx at hint address

2018-01-16 Thread Christophe LEROY
Le 16/01/2018 à 16:49, Aneesh Kumar K.V a écrit : Christophe Leroy writes: When an app has some regular pages allocated (e.g. see below) and tries to mmap() a huge page at a hint address covered by the same PMD entry, the kernel accepts the hint allthough the 8xx cannot handle different page

Re: [PATCH 1/3] powerpc/32: Fix hugepage allocation on 8xx at hint address

2018-01-16 Thread Aneesh Kumar K.V
Christophe Leroy writes: > When an app has some regular pages allocated (e.g. see below) and tries > to mmap() a huge page at a hint address covered by the same PMD entry, > the kernel accepts the hint allthough the 8xx cannot handle different > page sizes in the same PMD entry. So that is a bu

[PATCH 1/3] powerpc/32: Fix hugepage allocation on 8xx at hint address

2018-01-05 Thread Christophe Leroy
When an app has some regular pages allocated (e.g. see below) and tries to mmap() a huge page at a hint address covered by the same PMD entry, the kernel accepts the hint allthough the 8xx cannot handle different page sizes in the same PMD entry. 1000-10001000 r-xp 00:0f 2597 /root/ma