I finally got around to cleaning up the board driver, so the fpga init
function is now moved to the right place. The pika_dtm_start now asks
for the resources itself. This hopefully is the last patch to these
files for a while.
Cheers,
Sean
Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]>
On Thu, 17 Jan 2008 10:36:48 +1100
Stephen Rothwell <[EMAIL PROTECTED]> wrote:
> On Wed, 16 Jan 2008 18:29:45 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
> >
> > Everybody happy with this patch?
>
> I am happy (about this patch at least :-))
Yes, I have this queued up.
josh
On Wed, 16 Jan 2008 18:29:45 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
>
> Everybody happy with this patch?
I am happy (about this patch at least :-))
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpb2vylEkYSL.pgp
Description: PGP sig
Everybody happy with this patch?
Cheers,
Sean
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
This should have all of Stephen Rothwell's recommended changes.
Cheers,
Sean
Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]>
---
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 66a3d8c..b3e4c35 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -469,7 +469,7 @@ c
Hi Sean,
On Sat, 12 Jan 2008 15:42:45 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
>
> +++ b/arch/powerpc/platforms/44x/warp.c
> +static int __init warp_probe(void)
> +{
> + unsigned long root = of_get_flat_dt_root();
> +
> + if (!of_flat_dt_is_compatible(root, "pika,warp"))
> +
Please ignore the last patch. I left in a debug to check
that the non-ad7414 case works.
Cheers,
Sean
Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]>
---
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 66a3d8c..b3e4c35 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kcon
Stefan Roese wrote:
>
> You are accessing the 440EP GPIO controller here right? Then you really
> should
> use big endian access routines. From you code I assume that you have
> connected the LED signals to GPIO00 and GPIO01. I suggest to use code that
> looks like this:
>
> #define LED_GREEN
Stefan Roese wrote:
> On Saturday 12 January 2008, Sean MacLennan wrote:
>
>> Josh Boyer wrote:
>>
+ if (gpio_base == NULL) {
+ printk("ERROR: Unable to remap GPIO base.\n");
+ return;
+ }
+ }
+
+ leds
On Saturday 12 January 2008, Sean MacLennan wrote:
> Josh Boyer wrote:
> >> + if (gpio_base == NULL) {
> >> + printk("ERROR: Unable to remap GPIO base.\n");
> >> + return;
> >> + }
> >> + }
> >> +
> >> + leds = readl(gpio_base + 0x100);
> >
> >
On Fri, Jan 11, 2008 at 09:55:54PM -0500, Sean MacLennan wrote:
> I guess this implies I don't need the GPL blurb. I noticed that the
> blurb I have used mentions GPL2 or later and I know Linus doesn't like GPL3.
You don't need it but people tend to include it by habit.
The two versions are esse
Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]>
---
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 66a3d8c..b3e4c35 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -469,7 +469,7 @@ config MCA
config PCI
bool "PCI support" if 40x || CPM2 || PPC_83xx || PPC_
Olof Johansson wrote:
> On Sat, Jan 12, 2008 at 01:40:05PM +1100, Stephen Rothwell wrote:
>
>> Hi Sean,
>>
>> On Fri, 11 Jan 2008 18:39:15 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
>>
>>> +++ arch/powerpc/platforms/44x/warp-nand.c 2008-01-11 18:04:10.0
>>> -0500
>>> @@ -0,0
Stephen Rothwell wrote:
> Hi Sean,
>
> On Fri, 11 Jan 2008 18:39:15 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
>
>> +++ arch/powerpc/platforms/44x/warp-nand.c 2008-01-11 18:04:10.0
>> -0500
>> @@ -0,0 +1,85 @@
>>
>
> You need a copyright/license notice.
>
> The only other co
On Sat, Jan 12, 2008 at 01:40:05PM +1100, Stephen Rothwell wrote:
> Hi Sean,
>
> On Fri, 11 Jan 2008 18:39:15 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
> >
> > +++ arch/powerpc/platforms/44x/warp-nand.c 2008-01-11 18:04:10.0
> > -0500
> > @@ -0,0 +1,85 @@
>
> You need a copyright/
Hi Sean,
On Fri, 11 Jan 2008 18:39:15 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
>
> +++ arch/powerpc/platforms/44x/warp-nand.c2008-01-11 18:04:10.0
> -0500
> @@ -0,0 +1,85 @@
You need a copyright/license notice.
The only other concern I have left is the extern in the C file, b
Josh Boyer wrote:
>> +if (gpio_base == NULL) {
>> +printk("ERROR: Unable to remap GPIO base.\n");
>> +return;
>> +}
>> +}
>> +
>> +leds = readl(gpio_base + 0x100);
>>
>
> Do you really want readl here? That will byte-swap
On Fri, 11 Jan 2008 02:10:45 -0500
Sean MacLennan <[EMAIL PROTECTED]> wrote:
>
> Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]>
> ---
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 66a3d8c..b3e4c35 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -469,7
Stephen Rothwell wrote:
> I don't where that function is actually defined - I assume it is in one
> of the other recent patch sets.
>
> /me searches ...
> /me reads "ad7414 driver" email ...
> /me notes spaces missing there as well :-)
>
>
I didn't write the ad7414 driver and wanted to change th
Hi Sean,
On Fri, 11 Jan 2008 02:10:45 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
>
> Stephen Rothwell wrote:
> > On Wed, 09 Jan 2008 15:19:13 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
> >
> >> No comments? I really thought I would get raked over the coals for this
> >> one.
> >
> >
Stephen Rothwell wrote:
> On Wed, 09 Jan 2008 15:19:13 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
>
>> I have split up the patches slightly differently based on Josh's comments.
>>
>> The first patch is basically the platform/44x files.
>>
>> Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]
On Wed, 09 Jan 2008 15:19:13 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote:
>
> I have split up the patches slightly differently based on Josh's comments.
>
> The first patch is basically the platform/44x files.
>
> Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]>
> No comments? I really thoug
No comments? I really thought I would get raked over the coals for this one.
Cheers,
Sean
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
I have split up the patches slightly differently based on Josh's comments.
The first patch is basically the platform/44x files.
Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]>
---
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 66a3d8c..b3e4c35 100644
--- a/arch/powerpc/Kconfig
+
24 matches
Mail list logo
