[PATCH 2/4] powerpc: Add ppc_progress() wrapper

2009-01-14 Thread Michael Ellerman
There's quite a lot of code that does: if (ppc_md.progress) ppc_md.progress(...) So move that idiom into a wrapper. Having a wrapper also allows us to have a fallback to printk if no progress routine is specified. Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/machdep.h |

Re: [PATCH 2/4] powerpc: Add ppc_progress() wrapper

2009-01-14 Thread Grant Likely
On Wed, Jan 14, 2009 at 11:43 PM, Michael Ellerman wrote: > There's quite a lot of code that does: > > if (ppc_md.progress) >ppc_md.progress(...) > > So move that idiom into a wrapper. Having a wrapper also allows us > to have a fallback to printk if no progress routine is specified. > > S

Re: [PATCH 2/4] powerpc: Add ppc_progress() wrapper

2009-01-15 Thread Paul Mackerras
Michael Ellerman writes: > There's quite a lot of code that does: > > if (ppc_md.progress) > ppc_md.progress(...) > > So move that idiom into a wrapper. Having a wrapper also allows us > to have a fallback to printk if no progress routine is specified. It certainly used to be the case on

Re: [PATCH 2/4] powerpc: Add ppc_progress() wrapper

2009-01-15 Thread Benjamin Herrenschmidt
> It certainly used to be the case on ppc32 (and may still be) that > ppc_md.progress was called very very early, in some cases before the > MMU was set up, so we don't want to call printk from it. Falling back > to udbg_printf would be more appropriate. > > The idea of ppc_md.progress was that

Re: [PATCH 2/4] powerpc: Add ppc_progress() wrapper

2009-01-15 Thread Michael Ellerman
On Thu, 2009-01-15 at 22:34 +1100, Paul Mackerras wrote: > Michael Ellerman writes: > > > There's quite a lot of code that does: > > > > if (ppc_md.progress) > > ppc_md.progress(...) > > > > So move that idiom into a wrapper. Having a wrapper also allows us > > to have a fallback to printk i