Re: [PATCH 37/61] cpm2: Rework 8272ads initialization, and eliminate init_fcc_ioports().

2007-07-19 Thread Scott Wood
Arnd Bergmann wrote: > On Wednesday 18 July 2007, Scott Wood wrote: > >>+static struct cpm_pin mpc8272ads_pins[] = { >>+ /* SCC1 */ >>+ {3, 30, CPM_PIN_OUTPUT | CPM_PIN_SECONDARY}, >>+ {3, 31, CPM_PIN_INPUT | CPM_PIN_PRIMARY}, >>+ >>+ /* SCC4 */ >>+ {3, 21, CPM_PIN_OU

Re: [PATCH 37/61] cpm2: Rework 8272ads initialization, and eliminate init_fcc_ioports().

2007-07-18 Thread Arnd Bergmann
On Thursday 19 July 2007, Arnd Bergmann wrote: > I guess you considered moving such tables into the device tree at some point, > which doesn't seem that difficult at all to an ignorant reviewer like me. > > What's the reasoning for putting it into the platform code after all? > Ok, I think I fou

Re: [PATCH 37/61] cpm2: Rework 8272ads initialization, and eliminate init_fcc_ioports().

2007-07-18 Thread Arnd Bergmann
On Wednesday 18 July 2007, Scott Wood wrote: > +static struct cpm_pin mpc8272ads_pins[] = { > +   /* SCC1 */ > +   {3, 30, CPM_PIN_OUTPUT | CPM_PIN_SECONDARY}, > +   {3, 31, CPM_PIN_INPUT | CPM_PIN_PRIMARY}, > + > +   /* SCC4 */ > +   {3, 21, CPM_PIN_OUTPUT | CPM_PIN_PRIMARY}, >

[PATCH 37/61] cpm2: Rework 8272ads initialization, and eliminate init_fcc_ioports().

2007-07-17 Thread Scott Wood
The mpc8272ads initialization is reworked to: 1. use cpm2_set_pin() and cpm2_clk_setup() instead of the hardcoded mess, 2. have a sane devtree binding for the BCSR, 3. set the BCSR bits needed for both ethernet ports to work, 4. support the early debug console, and 5. call of_platform_bus_probe(),