Re: [PATCH 5121 pci 1/3] powerpc: 83xx: pci: Remove need for get_immrbase from mpc83xx_add_bridge.

2008-08-13 Thread John Rigby
Grant Likely wrote: On Thu, Aug 07, 2008 at 11:36:25AM -0600, John Rigby wrote: Modify mpc83xx_add_bridge to get config space register base address from the device tree instead of immr + hardcoded offset. 83xx pci nodes have these changes: register properties now contain two address

Re: [PATCH 5121 pci 1/3] powerpc: 83xx: pci: Remove need for get_immrbase from mpc83xx_add_bridge.

2008-08-13 Thread Scott Wood
John Rigby wrote: As I type this I'm coming to like the primary flag more and more. I'm willing to change it to 'fsl,primary-pci-bridge' though I don't really agree with your argument against the generic name. It is in the context of an 'fsl,pci-whatever' node so it does not have to be

Re: [PATCH 5121 pci 1/3] powerpc: 83xx: pci: Remove need for get_immrbase from mpc83xx_add_bridge.

2008-08-13 Thread Grant Likely
On Wed, Aug 13, 2008 at 10:10 AM, Scott Wood [EMAIL PROTECTED] wrote: John Rigby wrote: As I type this I'm coming to like the primary flag more and more. I'm willing to change it to 'fsl,primary-pci-bridge' though I don't really agree with your argument against the generic name. It is in

Re: [PATCH 5121 pci 1/3] powerpc: 83xx: pci: Remove need for get_immrbase from mpc83xx_add_bridge.

2008-08-13 Thread Grant Likely
On Wed, Aug 13, 2008 at 10:06 AM, John Rigby [EMAIL PROTECTED] wrote: On Thu, Aug 07, 2008 at 11:36:25AM -0600, John Rigby wrote: Can you use something like 'fsl,primary-pci-bridge' instead? 'primary' is a little too generic for my taste. Also, the purpose of identifying one of the PCI

Re: [PATCH 5121 pci 1/3] powerpc: 83xx: pci: Remove need for get_immrbase from mpc83xx_add_bridge.

2008-08-13 Thread John Rigby
Grant Likely wrote: On Wed, Aug 13, 2008 at 10:06 AM, John Rigby [EMAIL PROTECTED] wrote: On Thu, Aug 07, 2008 at 11:36:25AM -0600, John Rigby wrote: Can you use something like 'fsl,primary-pci-bridge' instead? 'primary' is a little too generic for my taste. Also, the purpose of

Re: [PATCH 5121 pci 1/3] powerpc: 83xx: pci: Remove need for get_immrbase from mpc83xx_add_bridge.

2008-08-12 Thread Grant Likely
On Thu, Aug 07, 2008 at 11:36:25AM -0600, John Rigby wrote: Modify mpc83xx_add_bridge to get config space register base address from the device tree instead of immr + hardcoded offset. 83xx pci nodes have these changes: register properties now contain two address length tuples: