Re: [patch 04/11] ps3fb: Inline macros that are used only once

2008-01-27 Thread Geert Uytterhoeven
On Sat, 26 Jan 2008, Andrew Morton wrote: On Fri, 25 Jan 2008 16:06:27 +0100 Geert Uytterhoeven [EMAIL PROTECTED] wrote: From: Geert Uytterhoeven [EMAIL PROTECTED] ps3fb: inline the X_OFF(), Y_OFF(), WIDTH(), HEIGHT(), and VP_OFF() macros, as they're used in one place only I think

Re: [patch 04/11] ps3fb: Inline macros that are used only once

2008-01-26 Thread Andrew Morton
On Fri, 25 Jan 2008 16:06:27 +0100 Geert Uytterhoeven [EMAIL PROTECTED] wrote: From: Geert Uytterhoeven [EMAIL PROTECTED] ps3fb: inline the X_OFF(), Y_OFF(), WIDTH(), HEIGHT(), and VP_OFF() macros, as they're used in one place only I think the term open-code would be more suitable here.

[patch 04/11] ps3fb: Inline macros that are used only once

2008-01-25 Thread Geert Uytterhoeven
From: Geert Uytterhoeven [EMAIL PROTECTED] ps3fb: inline the X_OFF(), Y_OFF(), WIDTH(), HEIGHT(), and VP_OFF() macros, as they're used in one place only Signed-off-by: Geert Uytterhoeven [EMAIL PROTECTED] --- drivers/video/ps3fb.c | 12 1 file changed, 4 insertions(+), 8