Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andrew Morton
On Wed, 25 Jul 2007 11:09:21 +1000 Paul Mackerras <[EMAIL PROTECTED]> wrote: > Also, I prefer the style where the ? and : operators have a space > after them but not before them, rather than a space either side. Could I point out that your likes and dislikes are immaterial? The whole point here

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Paul Mackerras
Andy Whitcroft writes: > Ok, this is something we need to decide on. Currently we only ask for > consistent spacing on all the mathematic operators. This is mostly as > we do see a large number of non-spaced uses in defines and the like. > > I am happy to expand these tests so they are always s

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andrew Morton
On Tue, 24 Jul 2007 08:37:09 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Andy Whitcroft wrote: > > Andrew Morton wrote: > > > >>> + start_sector = req->sector*priv->blocking_factor; > >>> + sectors = req->nr_sectors*priv->blocking_factor; > >> s/*/ * /. checkpatch missed this. > > > > Ok, th

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Jeff Garzik
Andreas Schwab wrote: > Jeff Garzik <[EMAIL PROTECTED]> writes: > >> Andy Whitcroft wrote: >>> Andrew Morton wrote: >>> > + start_sector = req->sector*priv->blocking_factor; > + sectors = req->nr_sectors*priv->blocking_factor; s/*/ * /. checkpatch missed this. >>> Ok, this is somethi

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andreas Schwab
Jeff Garzik <[EMAIL PROTECTED]> writes: > Andy Whitcroft wrote: >> Andrew Morton wrote: >> + start_sector = req->sector*priv->blocking_factor; + sectors = req->nr_sectors*priv->blocking_factor; >>> s/*/ * /. checkpatch missed this. >> >> Ok, this is something we need to decide on.

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Jeff Garzik
Andy Whitcroft wrote: > Andrew Morton wrote: > >>> + start_sector = req->sector*priv->blocking_factor; >>> + sectors = req->nr_sectors*priv->blocking_factor; >> s/*/ * /. checkpatch missed this. > > Ok, this is something we need to decide on. Currently we only ask for > consistent spacing o

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andy Whitcroft
Andrew Morton wrote: >> +start_sector = req->sector*priv->blocking_factor; >> +sectors = req->nr_sectors*priv->blocking_factor; > > s/*/ * /. checkpatch missed this. Ok, this is something we need to decide on. Currently we only ask for consistent spacing on all the mathematic operators

[patch 0/4] PS3 storage driver updates (was: Re: [patch 1/3] ps3: Disk Storage Driver)

2007-07-19 Thread Geert Uytterhoeven
Hi Andrew, On Thu, 19 Jul 2007, Andrew Morton wrote: > On Thu, 19 Jul 2007 10:57:53 +0200 (CEST) Geert Uytterhoeven <[EMAIL > PROTECTED]> wrote: > > On Wed, 18 Jul 2007, Andrew Morton wrote: > > > Your patchset significantly hits powerpc, scsi and block. So who gets to > > > merge this?

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-19 Thread Cornelia Huck
On Thu, 19 Jul 2007 14:13:33 +0200 (CEST), Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > Any chance this will change? I already added a mutex to ps3disk to protect > against this. Probably not in the near future. A mutex looks like a good idea though, since one never knows (and the driver core

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-19 Thread Geert Uytterhoeven
On Thu, 19 Jul 2007, Cornelia Huck wrote: > On Thu, 19 Jul 2007 11:36:31 +0200 (CEST), > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > > We have a probe thread that checks for new storage devices and adds them to > > the > > bus with ps3_system_bus_device_register(), which calls device_regist

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-19 Thread Cornelia Huck
On Thu, 19 Jul 2007 11:36:31 +0200 (CEST), Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > We have a probe thread that checks for new storage devices and adds them to > the > bus with ps3_system_bus_device_register(), which calls device_register(). > > I guess the actual bus probe() routine gets

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-19 Thread Geert Uytterhoeven
On Thu, 19 Jul 2007, Cornelia Huck wrote: > On Thu, 19 Jul 2007 10:57:53 +0200 (CEST), > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > > Were .probe()/.remove() made concurrent again? I thought that idea was > > dropped > > because it caused too many problems? > > Well, for a given device, -

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-19 Thread Cornelia Huck
On Thu, 19 Jul 2007 10:57:53 +0200 (CEST), Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > Were .probe()/.remove() made concurrent again? I thought that idea was dropped > because it caused too many problems? Well, for a given device, ->probe()/->remove() are locked by dev->sem, so that there can

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-19 Thread Andrew Morton
On Thu, 19 Jul 2007 10:57:53 +0200 (CEST) Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > Hi Andrew, > > On Wed, 18 Jul 2007, Andrew Morton wrote: > > On Mon, 16 Jul 2007 18:15:40 +0200 > > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > > > > From: Geert Uytterhoeven <[EMAIL PROTECTED]

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-19 Thread Geert Uytterhoeven
Hi Andrew, On Wed, 18 Jul 2007, Andrew Morton wrote: > On Mon, 16 Jul 2007 18:15:40 +0200 > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > > > Add a Disk Storage Driver for the PS3: > > Your patchset significantly hits powerpc, scsi

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-19 Thread Geert Uytterhoeven
On Thu, 19 Jul 2007, Jens Axboe wrote: > On Wed, Jul 18 2007, Andrew Morton wrote: > > On Mon, 16 Jul 2007 18:15:40 +0200 > > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > > > > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > > > > > Add a Disk Storage Driver for the PS3: > > > > Your patch

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-18 Thread Jens Axboe
On Wed, Jul 18 2007, Andrew Morton wrote: > On Mon, 16 Jul 2007 18:15:40 +0200 > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > > > Add a Disk Storage Driver for the PS3: > > Your patchset significantly hits powerpc, scsi and block. So who g

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-18 Thread Andrew Morton
On Mon, 16 Jul 2007 18:15:40 +0200 Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > Add a Disk Storage Driver for the PS3: Your patchset significantly hits powerpc, scsi and block. So who gets to merge this? Jens? James? Paul? Me, I guess ;)

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-18 Thread Geert Uytterhoeven
On Wed, 18 Jul 2007, Jan Engelhardt wrote: > On Jul 16 2007 18:15, Geert Uytterhoeven wrote: > >Add a Disk Storage Driver for the PS3: > > - Implemented as a block device driver with a dynamic major > > - Disk names (and partitions) are of the format ps3d%c(%u) > > - Uses software scatter-gather

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-18 Thread Jan Engelhardt
On Jul 16 2007 18:15, Geert Uytterhoeven wrote: > >Add a Disk Storage Driver for the PS3: > - Implemented as a block device driver with a dynamic major > - Disk names (and partitions) are of the format ps3d%c(%u) > - Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor >

[patch 1/3] ps3: Disk Storage Driver

2007-07-16 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> Add a Disk Storage Driver for the PS3: - Implemented as a block device driver with a dynamic major - Disk names (and partitions) are of the format ps3d%c(%u) - Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor doesn't