Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-03-04 Thread Tasmiya Nalatwad
[revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure Reverting below commit fixes the issue commit 0d60d8df6f493bb46bf5db40d39dd60a1bafdd4e dpll: rely on rcu for netdev_dpll_pin() --- Traces --- ./include/linux/dpll.h: In function ‘netdev_dpll_pin’: ./include/linux/rcupdate.h:439:9

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Tasmiya Nalatwad
Greetings, This is tied to gcc version. Build failure is seen while using gcc-8.5.x On 2/29/24 20:17, Jakub Kicinski wrote: On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote: I do not see other solution than this, otherwise we have to add more pollution to include/linux/netdevice.h Right

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Eric Dumazet
On Thu, Feb 29, 2024 at 3:53 PM Eric Dumazet wrote: > > On Thu, Feb 29, 2024 at 3:47 PM Jakub Kicinski wrote: > > > > On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote: > > > I do not see other solution than this, otherwise we have to add more > > > pollution to include/linux/netdevice.h > >

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Eric Dumazet
On Thu, Feb 29, 2024 at 3:47 PM Jakub Kicinski wrote: > > On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote: > > I do not see other solution than this, otherwise we have to add more > > pollution to include/linux/netdevice.h > > Right :( > > > diff --git a/include/linux/netdevice.h

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Jakub Kicinski
On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote: > I do not see other solution than this, otherwise we have to add more > pollution to include/linux/netdevice.h Right :( > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index >

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Vadim Fedorenko
renko wrote: On 28/02/2024 11:09, Tasmiya Nalatwad wrote: Greetings, [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure Reverting below commit fixes the issue commit 0d60d8df6f493bb46bf5db40d39dd60a1bafdd4e dpll: rely on rcu for netdev_dpll_pin() --- Traces --- ./include/linux

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Tasmiya Nalatwad
On 2/28/24 20:13, Eric Dumazet wrote: On Wed, Feb 28, 2024 at 3:07 PM Vadim Fedorenko wrote: On 28/02/2024 11:09, Tasmiya Nalatwad wrote: Greetings, [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure Reverting below commit fixes the issue commit 0d60d8df6f493bb46bf5

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Eric Dumazet
> smp_store_release(, RCU_INITIALIZER((typeof(p))_r_a_p__v)); \ > ^~~ > net/core/dev.c:9081:2: note: in expansion of macro ‘rcu_assign_pointer’ > rcu_assign_pointer(dev->dpll_pin, dpll_pin); >^~ > > On 2/28/2

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Tasmiya Nalatwad
t;dpll_pin, dpll_pin);   ^~ On 2/28/24 20:13, Eric Dumazet wrote: On Wed, Feb 28, 2024 at 3:07 PM Vadim Fedorenko wrote: On 28/02/2024 11:09, Tasmiya Nalatwad wrote: Greetings, [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure Reverting below commit fix

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-28 Thread Christophe Leroy
Le 28/02/2024 à 15:43, Eric Dumazet a écrit : > On Wed, Feb 28, 2024 at 3:07 PM Vadim Fedorenko > wrote: >> >> On 28/02/2024 11:09, Tasmiya Nalatwad wrote: >>> Greetings, >>> >>> [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure &

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-28 Thread Eric Dumazet
On Wed, Feb 28, 2024 at 3:07 PM Vadim Fedorenko wrote: > > On 28/02/2024 11:09, Tasmiya Nalatwad wrote: > > Greetings, > > > > [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure > > > > Reverting below commit fixes the issue > > > >

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-28 Thread Vadim Fedorenko
On 28/02/2024 11:09, Tasmiya Nalatwad wrote: Greetings, [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure Reverting below commit fixes the issue commit 0d60d8df6f493bb46bf5db40d39dd60a1bafdd4e     dpll: rely on rcu for netdev_dpll_pin() --- Traces --- ./include/linux/dpll.h

[revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-28 Thread Tasmiya Nalatwad
Greetings, [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure Reverting below commit fixes the issue commit 0d60d8df6f493bb46bf5db40d39dd60a1bafdd4e     dpll: rely on rcu for netdev_dpll_pin() --- Traces --- ./include/linux/dpll.h: In function ‘netdev_dpll_pin’: ./include/linux